Re: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2
Hi Greg,
On Sat, Jul 28, 2018 at 4:55 PM Greg KH wrote:
> On Thu, Jul 26, 2018 at 03:01:11PM +0200, Geert Uytterhoeven wrote:
> > On Thu, Jul 26, 2018 at 2:25 PM Chris Brandt
> > wrote:
> > > On Thursday, July 26, 2018, Geert Uytterhoeven wrote:
> > > > Thanks for your series!
> > > >
> > > > Unfortunately Greg has already applied your v1 (and my fix for a
> > > > use-after-free), so either these have to be reverted first, or you have
> > > > to
> > > > rebase against tty-next.
> > >
> > > I assume you would prefer the newer implementation I did.
> > >
> > > In your opinion, which one would be better (revert or rebase)?
> >
> > [looking at the incremental differences]
> >
> > I think the easiest for Greg is to rebase, and send 3 patches:
>
> Greg does not rebase his public trees. Nor should anyone else :)
I know ;-)
FTR, the sentence above was addressed to Chris:
"I think the easiest for Greg(,) is (for you) to rebase (your tree), and send 3
patches".
Which is what Chris did in the mean time.
Apparently I didn't formulate it well. Will try to do better in the future.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
RE: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2
On Saturday, July 28, 2018 1, Greg KH wrote: > > > In your opinion, which one would be better (revert or rebase)? > > > > [looking at the incremental differences] > > > > I think the easiest for Greg is to rebase, and send 3 patches: > > Greg does not rebase his public trees. Nor should anyone else :) > > I can revert patches if you want me to, just let me know what ones. Or > send incremental patches on top of my tree please. But no reverts are > going to be happening. Yesterday I sent a new patch series that will apply on top of the current tty-next and basically reverts what I did and replaces it with a new version that incorporates Geert's suggestions. So no reverts are needed. I assume now I'm just waiting to see if Geert has any feedback on the new series. Chris
Re: [PATCH v2 0/3] serial: sh-sci: Add support for RZ/A2
On Thu, Jul 26, 2018 at 03:01:11PM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Thu, Jul 26, 2018 at 2:25 PM Chris Brandt wrote: > > On Thursday, July 26, 2018, Geert Uytterhoeven wrote: > > > Thanks for your series! > > > > > > Unfortunately Greg has already applied your v1 (and my fix for a > > > use-after-free), so either these have to be reverted first, or you have to > > > rebase against tty-next. > > > > I assume you would prefer the newer implementation I did. > > > > In your opinion, which one would be better (revert or rebase)? > > [looking at the incremental differences] > > I think the easiest for Greg is to rebase, and send 3 patches: Greg does not rebase his public trees. Nor should anyone else :) I can revert patches if you want me to, just let me know what ones. Or send incremental patches on top of my tree please. But no reverts are going to be happening. thanks, greg k-h
