Re: [PATCH] arm64: dts: renesas: r8a77980: add CSI2/VIN support
On Mon, Aug 06, 2018 at 10:55:00PM +0300, Sergei Shtylyov wrote: > Describe the CSI2 and VIN (and their interconnections) in the R8A77980 > device tree. > > Signed-off-by: Sergei Shtylyov > > --- > This patch is against the 'renesas-devel-20180802v2-v4.18-rc7' branch of > Simon Horman's 'renesas.git' repo. > > The R8A77980 CSI2/VIN DT binding updates have been posted earlier today... > > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 374 > ++ > 1 file changed, 374 insertions(+) > > Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > === > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > @@ -579,6 +579,302 @@ > status = "disabled"; > }; > > + vin0: video@e6ef { > + compatible = "renesas,vin-r8a77980"; > + reg = <0 0xe6ef 0 0x1000>; > + interrupts = ; > + clocks = < CPG_MOD 811>; > + power-domains = < R8A77980_PD_ALWAYS_ON>; > + resets = < 811>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <1>; > + > + vin0csi40: endpoint@2 { > + reg = <2>; > + remote-endpoint= <>; > + }; > + }; > + }; > + }; > + > + vin1: video@e6ef1000 { > + compatible = "renesas,vin-r8a77980"; > + reg = <0 0xe6ef1000 0 0x1000>; > + interrupts = ; > + clocks = < CPG_MOD 810>; > + power-domains = < R8A77980_PD_ALWAYS_ON>; > + status = "disabled"; > + resets = < 810>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <1>; > + > + vin1csi40: endpoint@2 { > + reg = <2>; > + remote-endpoint= <>; > + }; > + }; > + }; > + }; > + > + vin2: video@e6ef2000 { > + compatible = "renesas,vin-r8a77980"; > + reg = <0 0xe6ef2000 0 0x1000>; > + interrupts = ; > + clocks = < CPG_MOD 809>; > + power-domains = < R8A77980_PD_ALWAYS_ON>; > + resets = < 809>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <1>; > + > + vin2csi40: endpoint@2 { > + reg = <2>; > + remote-endpoint= <>; > + }; > + }; > + }; > + }; > + > + vin3: video@e6ef3000 { > + compatible = "renesas,vin-r8a77980"; > + reg = <0 0xe6ef3000 0 0x1000>; > + interrupts = ; > + clocks = < CPG_MOD 808>; > + power-domains = < R8A77980_PD_ALWAYS_ON>; > + resets = < 808>; > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reg = <1>; > + > + vin3csi40: endpoint@2 { > + reg = <2>; > +
Re: [PATCH 13/13] sh: lib: convert to SPDX identifiers
Hi Morimoto-san, On Mon, Aug 06, 2018 at 02:26:30AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto > --- > arch/sh/lib/ashiftrt.S | 29 - > arch/sh/lib/ashlsi3.S| 29 - > arch/sh/lib/ashrsi3.S| 29 - > arch/sh/lib/checksum.S | 9 +++-- > arch/sh/lib/io.c | 5 + > arch/sh/lib/libgcc.h | 2 ++ > arch/sh/lib/lshrsi3.S| 29 - > arch/sh/lib/mcount.S | 7 ++- > arch/sh/lib/movmem.S | 29 - > arch/sh/lib/udiv_qrnnd.S | 29 - > arch/sh/lib/udivsi3.S| 29 - > arch/sh/lib/udivsi3_i4i-Os.S | 29 - > arch/sh/lib/udivsi3_i4i.S| 29 - > 13 files changed, 44 insertions(+), 240 deletions(-) > > diff --git a/arch/sh/lib/ashiftrt.S b/arch/sh/lib/ashiftrt.S > index 45ce865..d680b30 100644 > --- a/arch/sh/lib/ashiftrt.S > +++ b/arch/sh/lib/ashiftrt.S > @@ -1,30 +1,9 @@ > -/* Copyright (C) 1994, 1995, 1997, 1998, 1999, 2000, 2001, 2002, 2003, > +/* SPDX-License-Identifier: GPL-2.0+ > + > + Copyright (C) 1994, 1995, 1997, 1998, 1999, 2000, 2001, 2002, 2003, > 2004, 2005, 2006 > Free Software Foundation, Inc. > - > -This file is free software; you can redistribute it and/or modify it > -under the terms of the GNU General Public License as published by the > -Free Software Foundation; either version 2, or (at your option) any > -later version. > - > -In addition to the permissions in the GNU General Public License, the > -Free Software Foundation gives you unlimited permission to link the > -compiled version of this file into combinations with other programs, > -and to distribute those combinations without any restriction coming > -from the use of this file. (The General Public License restrictions > -do apply in other respects; for example, they cover modification of > -the file, and distribution when not linked into a combine > -executable.) Given the above clause I wonder if the SPDX identifier should be: SPDX-License-Identifier: GPL-2.0+ WITH GCC-exception-2.0 ...
Re: [PATCH 12/13] sh: kernel: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:26:16AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 11/13] sh: cpu: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:26:04AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 10/13] sh: shmobile: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:25:35AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 08/13] sh: sh4a: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:24:59AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 09/13] sh: sh5: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:25:17AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 07/13] sh: sh4: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:24:43AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text, > excepting ${LINUX}/arch/sh/kernel/cpu/sh4/softfloat.c > which is not GPL license > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 06/13] sh: sh3: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:24:24AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 06/13] sh: sh3: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:24:24AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 05/13] sh: sh2a: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:24:09AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 04/13] sh: sh2: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:23:56AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 03/13] sh: include: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:23:41AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 02/13] sh: drivers: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:23:25AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > As original license mentioned, it is GPL-2.0 in SPDX. > Then, MODULE_LICENSE() should be "GPL v2" instead of "GPL". > See ${LINUX}/include/linux/module.h > > "GPL" [GNU Public License v2 or later] > "GPL v2"[GNU Public License v2] > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH 01/13] sh: boards: convert to SPDX identifiers
On Mon, Aug 06, 2018 at 02:23:10AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
Re: [PATCH v2 3/5] soc: renesas: rcar-rst: Add support for RZ/G2M
On Thu, Aug 02, 2018 at 03:55:04PM +0100, Biju Das wrote: > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson > Reviewed-by: Geert Uytterhoeven > --- > V1-->V2 > * No change Reviewed-by: Simon Horman
Re: [PATCH v2 2/5] soc: renesas: rcar-sysc: Add r8a774a1 support
On Thu, Aug 02, 2018 at 03:53:19PM +0100, Biju Das wrote: > Add support for RZ/G2M (R8A774A1) SoC power areas to the R-Car SYSC > driver. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman
Re: [PATCH v2 1/5] dt-bindings: power: Add r8a774a1 SYSC power domain definitions
On Thu, Aug 02, 2018 at 03:48:18PM +0100, Biju Das wrote: > This patch adds power domain indices for RZ/G2M. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman
Re: [PATCH v2] arm64: dts: renesas: salvator-xs: enable SATA
On Thu, Aug 02, 2018 at 01:16:07PM +0200, Simon Horman wrote: > On Mon, Jul 30, 2018 at 09:34:56AM +0200, Wolfram Sang wrote: > > Add the nodes to enable SATA. Note that MD12 (SW12-7) must be switched > > off for that to work. > > > > Signed-off-by: Wolfram Sang > > Reviewed-by: Geert Uytterhoeven > > --- > > > > Changes since v1: > > * fixed indentation (Thanks, Geert!) > > * merged two patches into one (Thanks, Simon!) > > * Added Geert's tag > > > > arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 14 ++ > > arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts | 14 ++ > > 2 files changed, 28 insertions(+) > > This looks good to me: > > Reviewed-by: Simon Horman > > But (note to self) depends on: > > [PATCH v2] arm64: dts: r8a77965: Add SATA controller node Both that dependency and that patch applied for v4.20.
Re: [PATCH v2] arm64: dts: r8a77965: Add SATA controller node
On Thu, Aug 02, 2018 at 01:31:52PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Thu, Aug 2, 2018 at 1:13 PM Simon Horman wrote: > > On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote: > > > From: Takeshi Kihara > > > This patch adds SATA controller node for the R8A77965 SoC. > > > > > > Signed-off-by: Takeshi Kihara > > > [wsa: rebased to upstream base] > > > Reviewed-by: Geert Uytterhoeven > > > Signed-off-by: Wolfram Sang > > > --- > > > > > > Changes since v1: > > > * sorted it according to address (Thanks, Geert!) > > > * added Geert's tag > > > > > > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > index 0cd44461a0bd..bf22efb82cbf 100644 > > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > @@ -1507,6 +1507,17 @@ > > > status = "disabled"; > > > }; > > > > > > + sata: sata@ee30 { > > > + compatible = "renesas,sata-r8a77965", > > > + "renesas,rcar-gen3-sata"; > > > + reg = <0 0xee30 0 0x20>; > > > + interrupts = ; > > > + clocks = < CPG_MOD 815>; > > > + power-domains = < R8A77965_PD_ALWAYS_ON>; > > > + resets = < 815>; > > > + status = "disabled"; > > > > Is it intentional that there is no iommus property here? > > Because none of the other device nodes have iommus properties yet? That is my unstated assumption too. I've gone ahead and applied this patch for v4.20.
Re: [V2]Fix RCAR-V3H SoC wrong IPSR9/10 registers
Hi Adnan, On Thu, Aug 9, 2018 at 10:52 AM Adnan Ali wrote: > Please review this V2 patch. This patch belongs to branch from elinux.org for > V3H condor. Still sent as an attachment? And it is still not applicable to upstream, as the bug is not present in upstream. I'm sorry, I can only take patches for upstream. I do not maintain any source tree at elinux.org (which tree? AFAIK there's no git repo at elinux.org?). Thanks for your understanding! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [V2]Fix RCAR-V3H SoC wrong IPSR9/10 registers
Hi Adnan, On Thursday, 9 August 2018 11:10:43 EEST Adnan Ali wrote: > Hi All, > > Please review this V2 patch. This patch belongs to branch from elinux.org > for V3H condor. As requested in a review of v1, could you please send patches inline instead of as attachments ? They can't be reviewed without the reviewer having to manually paste the patch in the e-mail and add quote characters. -- Regards, Laurent Pinchart