Re: [RFT 0/8] arm64: dts: renesas: Ebisu: Add HDMI and CVBS input
Hi Laurent, Niklas, On Sat, Aug 25, 2018 at 08:37:15AM +0200, Niklas Söderlund wrote: > Hi Laurent and Jacopo, > > On 2018-08-25 02:54:44 +0300, Laurent Pinchart wrote: > > Hi Jacopo, > > > > On Monday, 20 August 2018 13:16:34 EEST Jacopo Mondi wrote: > > > Hello renesas list, > > >this series add supports for the HDMI and CVBS input to R-Car E3 > > > R8A77990 > > > Ebisu board. > > > > > > It's an RFT, as I don't have an Ebisu to test with :( > > > > > > The series adds supports for the following items: > > > > > > - PFC: add VIN groups and functions > > > - R-Car VIN and R-Car CSI-2: add support for R8A77990 > > > - R8A77990: Add I2C, VIN and CSI-2 nodes > > > - Ebisu: describe HDMI and CVBS inputs > > > > > > Each patch, when relevant reports difference between the upported BSP > > > patch > > > and the proposed one. > > > > > > I know Laurent should receive an Ebisu sooner or later, maybe we can sync > > > for testing :) > > > > I've given the series a first test, and I think a bit more work is needed > > :-) > > > > [1.455533] adv748x 0-0070: Endpoint /soc/i2c@e650/video-receiver@70/ > > port@7/endpoint on port 7 > > [1.464683] adv748x 0-0070: Endpoint /soc/i2c@e650/video-receiver@70/ > > port@8/endpoint on port 8 > > [1.473728] adv748x 0-0070: Endpoint /soc/i2c@e650/video-receiver@70/ > > port@a/endpoint on port 10 > > [1.484835] adv748x 0-0070: chip found @ 0xe0 revision 2143 > > [1.639470] adv748x 0-0070: No endpoint found for txb > > [1.644653] adv748x 0-0070: Failed to probe TXB > > I fear this is a design choice in the adv748x driver. Currently the > driver requires both of its two CSI-2 transmitters to be connected/used > else probe fails. Furthermore the HDMI capture is always routed to TXA > while the analog capture is always routed to TXB. > > Now that we have a board where only TXA is connected but both HDMI and > analog captures are used maybe it's time to do some more work on v4l2 > and the adv748x driver ;-P What's missing: > > - Probe should be OK with either TXA or TXB connected and not bail if > not both are used. I have three patches for this I hope to share as soon as I'll be able to do some more testing > - The media_device_ops or at least the .link_notify() callback of that > struct must be changed so not one driver in the media graph is > responsible for all links. In this case rcar-vin provides the callback > and rcar-vin should not judge which links between the adv748x > subdevices are OK to enable/disable. Currently the links between the > adv748x subdevices are immutably enabled to avoid this particular > problem. Uh, I didn't get this :/ Care to elaborate more? What I was about to do, instead, given the fixed HDMI->TXA and AFE->TXB routing in the adv748x driver was to insert a .link_validate() callback for both the HDMI and AFE backends, that checks for the availability of the corresponding output endpoint. This seems to me that this makes easy when dynamic routing will be added to do the same on the dynamically configured sink pad. What do you think? Thanks j > > > > > > PS: the list of upported patches will be sent separately. > > > > > > Jacopo Mondi (5): > > > media: dt-bindings: media: rcar-vin: Add R8A77990 support > > > media: rcar-vin: Add support for R-Car R8A77990 > > > dt-bindings: media: rcar-csi2: Add R8A77990 > > > media: rcar-csi2: Add R8A77990 support > > > arm64: dts: renesas: ebisu: Add HDMI and CVBS input > > > > > > Koji Matsuoka (1): > > > arm64: dts: r8a77990: Add VIN and CSI-2 device nodes > > > > > > Takeshi Kihara (2): > > > pinctrl: sh-pfc: r8a77990: Add VIN pins, groups and functions > > > arm64: dts: r8a77990: Add I2C device nodes > > > > > > .../devicetree/bindings/media/rcar_vin.txt | 1 + > > > .../bindings/media/renesas,rcar-csi2.txt | 1 + > > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 > > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 202 + > > > drivers/media/platform/rcar-vin/rcar-core.c| 20 + > > > drivers/media/platform/rcar-vin/rcar-csi2.c| 9 + > > > drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 504 > > > ++ > > > 7 files changed, 823 insertions(+) > > > > -- > > Regards, > > > > Laurent Pinchart > > > > > > > > -- > Regards, > Niklas Söderlund signature.asc Description: PGP signature
TRADING ACCOUNT
Dear sir , I KELLY ALAN purchasing and sales manager of CFM INTERNATIONAL .Our Company specialised in Supplying computer hardware and Electronic .We want to extend our supplier list because of concurrency in prices on the international market. We are seeking a supplier with whom we can to have partnered long-term in order to have competitive prices . we are interested to buy the products you sell and want to place an order with you in big quantities. Can you give us payment facilities ( 14 , 30 or 60 days payment terms ) ? What is the procedure for our account opening and credit line application ? Cordially KELLY ALAN CFM INTERNATIONAL 2 BOULEVARD DU GAL MARTIAL VALIN 75015 PARIS REG N° 302 527 700 VAT N° FR90 302527700 TEL +33171025367 FAX +33177759149 https://www.cfmaeroengines.com
Re: [PATCH v2 4/4] vin-tests: yavta-hdmi: Add VIN4 and parallel link
Hi Niklas, On Fri, Aug 24, 2018 at 06:27:02PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2018-08-24 12:24:22 +0200, Jacopo Mondi wrote: > > Add support for VIN4 to yavta-hdmi and check if format propagation should > > go through 'mc_propagate_parallel()' if the HDMI receiver chip is an > > ADV7612 one. > > > > Signed-off-by: Jacopo Mondi > > --- > > yavta-hdmi | 13 +++-- > > 1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/yavta-hdmi b/yavta-hdmi > > index fdec546..2e3b625 100755 > > --- a/yavta-hdmi > > +++ b/yavta-hdmi > > @@ -33,14 +33,23 @@ case $vc in > > dev=/dev/$vin3 > > csipad=4 > > ;; > > +4) > > +vinname=$vinname4 > > +dev=/dev/$vin4 > > I think you should also add a csipad declaration here as if the script > is used on a board which is not D3 VIN4 would be connected to a CSI-2 > bus. Writing that I realise a new var 'csidev' or something would be > needed here to expand this to cover the full range of VIN0-VIN7. > > > +;; > > *) > > echo "Unkown VC '$vc'" > > exit 1 > > esac > > > > mc_reset > > -mc_set_link "$csi40name" $csipad "$vinname" 1 > > -mc_propagate_format "$hdminame" 1 "$txaname" 0 "$csi40name" $csipad > > "$vinname" > > +if [[ "$hdminame" == "adv7612 0-004c" ]]; then > > > You should use $parallelname here not $hdminame. Furthermore I thin you > should check if the variable is empty or not and not target it for a > specific board. > > A good (or only) example of how I think this should be done can be found > in test-qv4l2.sh. > > if [[ "$csi20name" != "" ]]; then > mc_set_link "$csi20name" 1 "$vinname1" 1 > mc_propagate_cvbs "$vinname1" > qv4l2 -d /dev/$vin1 > fi > > if [[ "$parallelname" != "" ]]; then > mc_reset > mc_set_link "$parallelname" 1 "$vinname0" 1 > mc_propagate_parallel "$vinname0" > qv4l2 -d /dev/$vin0 > fi > This will solve the naming thing in boards.sh I'll try that and have a look at test-qv4l2.sh too! Thanks j > > + mc_set_link "$hdminame" 1 "$vinname" 1 > > + mc_propagate_parallel "$vinname" > > +else > > + mc_set_link "$csi40name" $csipad "$vinname" 1 > > + mc_propagate_format "$hdminame" 1 "$txaname" 0 "$csi40name" $csipad > > "$vinname" > > +fi > > > > out=/tmp/vin-tests > > rm -fr $out > > -- > > 2.7.4 > > > > -- > Regards, > Niklas Söderlund signature.asc Description: PGP signature
Re: [RFT 0/8] arm64: dts: renesas: Ebisu: Add HDMI and CVBS input
Hi Laurent and Jacopo, On 2018-08-25 02:54:44 +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Monday, 20 August 2018 13:16:34 EEST Jacopo Mondi wrote: > > Hello renesas list, > >this series add supports for the HDMI and CVBS input to R-Car E3 R8A77990 > > Ebisu board. > > > > It's an RFT, as I don't have an Ebisu to test with :( > > > > The series adds supports for the following items: > > > > - PFC: add VIN groups and functions > > - R-Car VIN and R-Car CSI-2: add support for R8A77990 > > - R8A77990: Add I2C, VIN and CSI-2 nodes > > - Ebisu: describe HDMI and CVBS inputs > > > > Each patch, when relevant reports difference between the upported BSP patch > > and the proposed one. > > > > I know Laurent should receive an Ebisu sooner or later, maybe we can sync > > for testing :) > > I've given the series a first test, and I think a bit more work is needed :-) > > [1.455533] adv748x 0-0070: Endpoint /soc/i2c@e650/video-receiver@70/ > port@7/endpoint on port 7 > [1.464683] adv748x 0-0070: Endpoint /soc/i2c@e650/video-receiver@70/ > port@8/endpoint on port 8 > [1.473728] adv748x 0-0070: Endpoint /soc/i2c@e650/video-receiver@70/ > port@a/endpoint on port 10 > [1.484835] adv748x 0-0070: chip found @ 0xe0 revision 2143 > [1.639470] adv748x 0-0070: No endpoint found for txb > [1.644653] adv748x 0-0070: Failed to probe TXB I fear this is a design choice in the adv748x driver. Currently the driver requires both of its two CSI-2 transmitters to be connected/used else probe fails. Furthermore the HDMI capture is always routed to TXA while the analog capture is always routed to TXB. Now that we have a board where only TXA is connected but both HDMI and analog captures are used maybe it's time to do some more work on v4l2 and the adv748x driver ;-P What's missing: - Probe should be OK with either TXA or TXB connected and not bail if not both are used. - The media_device_ops or at least the .link_notify() callback of that struct must be changed so not one driver in the media graph is responsible for all links. In this case rcar-vin provides the callback and rcar-vin should not judge which links between the adv748x subdevices are OK to enable/disable. Currently the links between the adv748x subdevices are immutably enabled to avoid this particular problem. > > > PS: the list of upported patches will be sent separately. > > > > Jacopo Mondi (5): > > media: dt-bindings: media: rcar-vin: Add R8A77990 support > > media: rcar-vin: Add support for R-Car R8A77990 > > dt-bindings: media: rcar-csi2: Add R8A77990 > > media: rcar-csi2: Add R8A77990 support > > arm64: dts: renesas: ebisu: Add HDMI and CVBS input > > > > Koji Matsuoka (1): > > arm64: dts: r8a77990: Add VIN and CSI-2 device nodes > > > > Takeshi Kihara (2): > > pinctrl: sh-pfc: r8a77990: Add VIN pins, groups and functions > > arm64: dts: r8a77990: Add I2C device nodes > > > > .../devicetree/bindings/media/rcar_vin.txt | 1 + > > .../bindings/media/renesas,rcar-csi2.txt | 1 + > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 86 > > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 202 + > > drivers/media/platform/rcar-vin/rcar-core.c| 20 + > > drivers/media/platform/rcar-vin/rcar-csi2.c| 9 + > > drivers/pinctrl/sh-pfc/pfc-r8a77990.c | 504 ++ > > 7 files changed, 823 insertions(+) > > -- > Regards, > > Laurent Pinchart > > > -- Regards, Niklas Söderlund
