RE: [PATCH/RFC] iommu/ipmmu-vmsa: R-Car M3-N/V3H/E3 AVB whitelist prototype
Hi Magnus-san, Geert-san, > From: Geert Uytterhoeven, Sent: Sunday, October 28, 2018 10:33 PM > > Hi Magnus, > > Thanks for your patch! > > On Sun, Oct 21, 2018 at 7:56 PM Magnus Damm wrote: > > From: Magnus Damm > > > > For testing purpose enable IPMMU for Ethernet-AVB on R-Car M3-N/V3H/E3. > > > > Not for upstream merge. > > > > Not-Yet-Signed-off-by: Magnus Damm > > --- > > > > Applies on top of renesas-devel-20181019-v4.19-rc8 > > > > drivers/iommu/ipmmu-vmsa.c |4 > > 1 file changed, 4 insertions(+) > > > > --- 0001/drivers/iommu/ipmmu-vmsa.c > > +++ work/drivers/iommu/ipmmu-vmsa.c 2018-10-22 02:46:30.139880557 +0900 > > @@ -756,6 +756,10 @@ static int ipmmu_init_platform_device(st > > > > static bool ipmmu_slave_whitelist(struct device *dev) > > { > > + /* R-Car M3-N/V3H/E3 Ethernet-AVB */ > > + if (!strcmp(dev_name(dev), "e680.ethernet")) > > + return true; > > I'm afraid the whitelisting doesn't work that way: with the above check, it > will > be enabled on all R-Car Gen3 SoCs. I agree with Geert-san. So, how about adding .revision into the soc_rcar_gen3 like a whitelist of SoCs first as following? I believe almost all R-Car Gen3 SoCs can use IPMMU safety, except H3 ES2.0 or older and M3-W ES1.*. --- diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index b98a031..7a528b8 100644 --- a/drivers/iommu/ipmmu-vmsa.c +++ b/drivers/iommu/ipmmu-vmsa.c @@ -758,10 +758,10 @@ static bool ipmmu_slave_whitelist(struct device *dev) } static const struct soc_device_attribute soc_rcar_gen3[] = { - { .soc_id = "r8a7795", }, - { .soc_id = "r8a7796", }, + { .soc_id = "r8a7795", .revision = "ES3.*" }, { .soc_id = "r8a77965", }, { .soc_id = "r8a77970", }, + { .soc_id = "r8a77990", }, { .soc_id = "r8a77995", }, { /* sentinel */ } }; Best regards, Yoshihiro Shimoda > > + > > /* By default, do not allow use of IPMMU */ > > return false; > > } > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
Re: HDMI doesn't work on ULCB board
Hi Morimoto-san, On Monday, 12 November 2018 05:09:13 EET Kuninori Morimoto wrote: > Hi Laurent > > >> I noticed Salvator can't boot if .config has CONFIG_COMMON_CLK_VC5. > >> This means, Salvator and ULCB can't use same binary so far for me > >> (= all modules are =y on .config). > >> I'm using previous attached .config + your patch + CONFIG_COMMON_CLK_VC5 > > (snip) > > > I'm afraid I can't reproduce this. I checked out > > renesas-drivers-2018-10-09- v4.19-rc7, applied the fix I've submitted, > > took your configuration, enabled CONFIG_COMMON_CLK_VC5, and my > > Salvator-XS H3 boots fine. > > I'm deeply sorry, it was my fault. > I'm using ES1.x board, but I used XS dtb I've done worse mistakes, and many times, so I can't blame you :-) I'm glad it works now. -- Regards, Laurent Pinchart
Re: HDMI doesn't work on ULCB board
Hi Laurent > > I noticed Salvator can't boot if .config has CONFIG_COMMON_CLK_VC5. > > This means, Salvator and ULCB can't use same binary so far for me > > (= all modules are =y on .config). > > I'm using previous attached .config + your patch + CONFIG_COMMON_CLK_VC5 (snip) > I'm afraid I can't reproduce this. I checked out renesas-drivers-2018-10-09- > v4.19-rc7, applied the fix I've submitted, took your configuration, enabled > CONFIG_COMMON_CLK_VC5, and my Salvator-XS H3 boots fine. I'm deeply sorry, it was my fault. I'm using ES1.x board, but I used XS dtb Best regards --- Kuninori Morimoto
Re: [PATCH] mfd: bd9571mwv: add volatile register to make DVFS work
On 11/09/2018 12:04 PM, Wolfram Sang wrote: > On Wed, Oct 03, 2018 at 03:58:41PM +0200, Wolfram Sang wrote: >> From: Dien Pham >> >> Because BD9571MWV_DVFS_MONIVDAC is not defined in the volatile table, >> the physical register value is not updated by regmap and DVFS doesn't >> work as expected. Fix it! >> >> Signed-off-by: Dien Pham >> [wsa: rebase, add 'Fixes', reword commit message] >> Signed-off-by: Wolfram Sang >> Fixes: d3ea21272094 ("mfd: Add ROHM BD9571MWV-M MFD PMIC driver") >> --- > > Any blockers for this one? > >> >> Grabbed from the BSP and confirmed by the datasheet. The register is RO >> and reflecting states depending on other registers. >> >> drivers/mfd/bd9571mwv.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c >> index 503979c81dae..fab3cdc27ed6 100644 >> --- a/drivers/mfd/bd9571mwv.c >> +++ b/drivers/mfd/bd9571mwv.c >> @@ -59,6 +59,7 @@ static const struct regmap_access_table >> bd9571mwv_writable_table = { >> }; >> >> static const struct regmap_range bd9571mwv_volatile_yes_ranges[] = { >> +regmap_reg_range(BD9571MWV_DVFS_MONIVDAC, BD9571MWV_DVFS_MONIVDAC), >> regmap_reg_range(BD9571MWV_GPIO_IN, BD9571MWV_GPIO_IN), >> regmap_reg_range(BD9571MWV_GPIO_INT, BD9571MWV_GPIO_INT), >> regmap_reg_range(BD9571MWV_INT_INTREQ, BD9571MWV_INT_INTREQ), >> -- Makes sense, Reviewed-by: Marek Vasut -- Best regards, Marek Vasut
Re: [PATCH 1/2] dt-bindings: dmaengine: usb-dmac: Add binding for r8a77470
On 25-10-18, 15:53, Biju Das wrote: > This patch adds usb high-speed dmac binding for r8a77470 (RZ/G1C) SoC. Applied, thanks -- ~Vinod
Re: [PATCH 4/6] dt-bindings: dmaengine: usb-dmac: Add binding for r8a774a1
On 08-11-18, 14:21, Simon Horman wrote: > On Thu, Nov 08, 2018 at 12:48:46PM +, Fabrizio Castro wrote: > > Dear All, > > > > Who is the best person to take this patch? > > I believe this one is for Vinod. Please resend it, it is not in my queue -- ~Vinod
Re: [PATCH] dmaengine: rcar-dmac: Document R8A774A1 bindings
On 08-11-18, 13:59, Fabrizio Castro wrote: > Thank you Simon for getting back to me. > > Vinod, does this patch look ok to you? This does not appear in my queue, please resend and collect the acks received if any as well Thanks -- ~Vinod