Re: [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
Hi Geert-san,
Thank you for your review.
I will correct the sort order of the audma nodes and a typo of the commit log.
Best regards,
Kaneko
2018-07-18 18:06 GMT+09:00 Geert Uytterhoeven :
> On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko
> wrote:
>> From: Takeshi Kihara
>>
>> This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
>>
>> Based on a similar patch of the R8A7796 device tree
>> by uninori Morimoto .
>
> Kuninori
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Re: [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko wrote:
> From: Takeshi Kihara
>
> This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
>
> Based on a similar patch of the R8A7796 device tree
> by uninori Morimoto .
Kuninori
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
Hi Kaneko-san,
On Tue, Jul 17, 2018 at 9:48 PM Yoshihiro Kaneko wrote:
> From: Takeshi Kihara
>
> This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
>
> Based on a similar patch of the R8A7796 device tree
> by uninori Morimoto .
>
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Yoshihiro Kaneko
Thanks for your patch!
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1386,6 +1386,74 @@
> status = "disabled";
> };
>
> + audma0: dma-controller@ec70 {
> + };
> +
Please respect sort order (by unit address, per device group).
The two audma nodes should be inserted just before usb@ee00.
> ohci0: usb@ee08 {
> compatible = "generic-ohci";
> reg = <0 0xee08 0 0x100>;
With the above fixed:
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH/RFT 1/7] arm64: dts: renesas: r8a77965: Add Audio-DMAC device nodes
From: Takeshi Kihara
This patch adds Audio-DMAC{0,1} device nodes for the R8A77965 SoC.
Based on a similar patch of the R8A7796 device tree
by uninori Morimoto .
Signed-off-by: Takeshi Kihara
Signed-off-by: Yoshihiro Kaneko
---
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 68 +++
1 file changed, 68 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 0cd4446..c0dbabd 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1386,6 +1386,74 @@
status = "disabled";
};
+ audma0: dma-controller@ec70 {
+ compatible = "renesas,dmac-r8a77965",
+"renesas,rcar-dmac";
+ reg = <0 0xec70 0 0x1>;
+ interrupts = ;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3",
+ "ch4", "ch5", "ch6", "ch7",
+ "ch8", "ch9", "ch10", "ch11",
+ "ch12", "ch13", "ch14", "ch15";
+ clocks = < CPG_MOD 502>;
+ clock-names = "fck";
+ power-domains = < R8A77965_PD_ALWAYS_ON>;
+ resets = < 502>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
+ audma1: dma-controller@ec72 {
+ compatible = "renesas,dmac-r8a77965",
+"renesas,rcar-dmac";
+ reg = <0 0xec72 0 0x1>;
+ interrupts = ;
+ interrupt-names = "error",
+ "ch0", "ch1", "ch2", "ch3",
+ "ch4", "ch5", "ch6", "ch7",
+ "ch8", "ch9", "ch10", "ch11",
+ "ch12", "ch13", "ch14", "ch15";
+ clocks = < CPG_MOD 501>;
+ clock-names = "fck";
+ power-domains = < R8A77965_PD_ALWAYS_ON>;
+ resets = < 501>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ };
+
ohci0: usb@ee08 {
compatible = "generic-ohci";
reg = <0 0xee08 0 0x100>;
--
1.9.1
