Re: [PATCH] ARM: Convert to using %pOF instead of full_name

[Paul Walmsley]

On Tue, 18 Jul 2017, Rob Herring wrote:

> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.

Acked-by: Paul Walmsley   # for mach-omap2/omap-hwmod.c

- Paul

Re: [PATCH] ARM: Convert to using %pOF instead of full_name

[Rob Herring]

On Wed, Jul 19, 2017 at 1:22 AM, Uwe Kleine-König
 wrote:
> On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>
> Oh nice. If the commit adding %pOF is already set in stone, i'd suggest
> to mention the commit id here in the commit log.

It is in 4.13, but I'm not really eager to update all 60 patches and
I'd prefer consistency in the commit msg as quite a few have already
been applied.

>> of the full path string for each node.

[...]

>> @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)
>>*/
>>   cell = of_get_property(cpu, "reg", _bytes);
>>   if (!cell || prop_bytes < sizeof(*cell)) {
>> - pr_debug(" * %s missing reg property\n",
>> -  cpu->full_name);
>> + pr_debug(" * %pOF missing reg property\n",
>> +  cpu);
>
> You could join lines here and in the next hunk. And there are two more
> further down.

Okay. I did that generally, but missed a few.

Rob

Re: [PATCH] ARM: Convert to using %pOF instead of full_name

[Gregory CLEMENT]

Hi Rob,
 
 On mar., juil. 18 2017, Rob Herring  wrote:

> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring 
> Cc: Russell King 
> Cc: Kukjin Kim 
> Cc: Krzysztof Kozlowski 
> Cc: Javier Martinez Canillas 
> Cc: Shawn Guo 
> Cc: Sascha Hauer 
> Cc: Fabio Estevam 
> Cc: Jason Cooper 
> Cc: Andrew Lunn 
> Cc: Gregory Clement 
> Cc: Sebastian Hesselbarth 
> Cc: Tony Lindgren 
> Cc: "Benoît Cousson" 
> Cc: Paul Walmsley 
> Cc: Heiko Stuebner 
> Cc: Simon Horman 
> Cc: Magnus Damm 
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-samsung-...@vger.kernel.org
> Cc: linux-o...@vger.kernel.org
> Cc: linux-rockc...@lists.infradead.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
>  arch/arm/kernel/cpuidle.c| 4 ++--
>  arch/arm/kernel/devtree.c| 6 +++---
>  arch/arm/kernel/topology.c   | 4 ++--
>  arch/arm/mach-exynos/suspend.c   | 8 
>  arch/arm/mach-imx/gpc.c  | 4 ++--
>  arch/arm/mach-mvebu/kirkwood.c   | 4 ++--

For the krkwood part
Acked-by: Gregory CLEMENT 

Thanks,

Gregory

>  arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++--
>  arch/arm/mach-omap2/omap_hwmod.c | 4 ++--
>  arch/arm/mach-rockchip/platsmp.c | 4 ++--
>  arch/arm/mach-shmobile/pm-rmobile.c  | 8 
>  10 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c
> index a3308ad1a024..fda5579123a8 100644
> --- a/arch/arm/kernel/cpuidle.c
> +++ b/arch/arm/kernel/cpuidle.c
> @@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node 
> *dn, int cpu)
>
>   ops = arm_cpuidle_get_ops(enable_method);
>   if (!ops) {
> - pr_warn("%s: unsupported enable-method property: %s\n",
> - dn->full_name, enable_method);
> + pr_warn("%pOF: unsupported enable-method property: %s\n",
> + dn, enable_method);
>   return -EOPNOTSUPP;
>   }
>
> diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
> index f676febbb270..28174c9a94ac 100644
> --- a/arch/arm/kernel/devtree.c
> +++ b/arch/arm/kernel/devtree.c
> @@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void)
>   if (of_node_cmp(cpu->type, "cpu"))
>   continue;
>
> - pr_debug(" * %s...\n", cpu->full_name);
> + pr_debug(" * %pOF...\n", cpu);
>   /*
>* A device tree containing CPU nodes with missing "reg"
>* properties is considered invalid to build the
> @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)
>*/
>   cell = of_get_property(cpu, "reg", _bytes);
>   if (!cell || prop_bytes < sizeof(*cell)) {
> - pr_debug(" * %s missing reg property\n",
> -  cpu->full_name);
> + pr_debug(" * %pOF missing reg property\n",
> +  cpu);
>   of_node_put(cpu);
>   return;
>   }
> diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
> index bf949a763dbe..e596c5b8f931 100644
> --- a/arch/arm/kernel/topology.c
> +++ b/arch/arm/kernel/topology.c
> @@ -127,8 +127,8 @@ static void __init parse_dt_topology(void)
>
>   rate = of_get_property(cn, "clock-frequency", );
>   if (!rate || len != 4) {
> - pr_err("%s missing clock-frequency property\n",
> - cn->full_name);
> + pr_err("%pOF missing clock-frequency property\n",
> + cn);
>   continue;
>   }
>
> diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
> index 748cfb8d5212..3c7b66c22697 100644
> --- a/arch/arm/mach-exynos/suspend.c
> +++ b/arch/arm/mach-exynos/suspend.c
> @@ -187,21 +187,21 @@ static int __init exynos_pmu_irq_init(struct 
> device_node *node,
>   struct irq_domain *parent_domain, *domain;
>
>   if (!parent) {
> - pr_err("%s: no parent, giving up\n", node->full_name);
> + pr_err("%pOF: no parent, giving up\n", node);
>   return -ENODEV;
>   }
>
>   parent_domain = irq_find_host(parent);
>   if (!parent_domain) {
> - pr_err("%s: unable to obtain parent domain\n", 

Re: [PATCH] ARM: Convert to using %pOF instead of full_name

[Geert Uytterhoeven]

On Tue, Jul 18, 2017 at 11:42 PM, Rob Herring  wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH] ARM: Convert to using %pOF instead of full_name

[Heiko Stuebner]

Am Dienstag, 18. Juli 2017, 16:42:41 CEST schrieb Rob Herring:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
> 
> Signed-off-by: Rob Herring 

for the Rockchip part
Acked-by: Heiko Stuebner 

> diff --git a/arch/arm/mach-rockchip/platsmp.c 
> b/arch/arm/mach-rockchip/platsmp.c
> index 3abafdbdd7f4..2b5b0e43d657 100644
> --- a/arch/arm/mach-rockchip/platsmp.c
> +++ b/arch/arm/mach-rockchip/platsmp.c
> @@ -182,8 +182,8 @@ static int __init rockchip_smp_prepare_sram(struct 
> device_node *node)
> 
>   ret = of_address_to_resource(node, 0, );
>   if (ret < 0) {
> - pr_err("%s: could not get address for node %s\n",
> -__func__, node->full_name);
> + pr_err("%s: could not get address for node %pOF\n",
> +__func__, node);
>   return ret;
>   }
> 

Re: [PATCH] ARM: Convert to using %pOF instead of full_name

[Uwe Kleine-König]

On Tue, Jul 18, 2017 at 04:42:41PM -0500, Rob Herring wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing

Oh nice. If the commit adding %pOF is already set in stone, i'd suggest
to mention the commit id here in the commit log.

> of the full path string for each node.
> 
> Signed-off-by: Rob Herring 
> Cc: Russell King 
> Cc: Kukjin Kim 
> Cc: Krzysztof Kozlowski 
> Cc: Javier Martinez Canillas 
> Cc: Shawn Guo 
> Cc: Sascha Hauer 
> Cc: Fabio Estevam 
> Cc: Jason Cooper 
> Cc: Andrew Lunn 
> Cc: Gregory Clement 
> Cc: Sebastian Hesselbarth 
> Cc: Tony Lindgren 
> Cc: "Benoît Cousson" 
> Cc: Paul Walmsley 
> Cc: Heiko Stuebner 
> Cc: Simon Horman 
> Cc: Magnus Damm 
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-samsung-...@vger.kernel.org
> Cc: linux-o...@vger.kernel.org
> Cc: linux-rockc...@lists.infradead.org
> Cc: linux-renesas-soc@vger.kernel.org
> ---
>  arch/arm/kernel/cpuidle.c| 4 ++--
>  arch/arm/kernel/devtree.c| 6 +++---
>  arch/arm/kernel/topology.c   | 4 ++--
>  arch/arm/mach-exynos/suspend.c   | 8 
>  arch/arm/mach-imx/gpc.c  | 4 ++--
>  arch/arm/mach-mvebu/kirkwood.c   | 4 ++--
>  arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++--
>  arch/arm/mach-omap2/omap_hwmod.c | 4 ++--
>  arch/arm/mach-rockchip/platsmp.c | 4 ++--
>  arch/arm/mach-shmobile/pm-rmobile.c  | 8 
>  10 files changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c
> index a3308ad1a024..fda5579123a8 100644
> --- a/arch/arm/kernel/cpuidle.c
> +++ b/arch/arm/kernel/cpuidle.c
> @@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node 
> *dn, int cpu)
> 
>   ops = arm_cpuidle_get_ops(enable_method);
>   if (!ops) {
> - pr_warn("%s: unsupported enable-method property: %s\n",
> - dn->full_name, enable_method);
> + pr_warn("%pOF: unsupported enable-method property: %s\n",
> + dn, enable_method);
>   return -EOPNOTSUPP;
>   }
> 
> diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
> index f676febbb270..28174c9a94ac 100644
> --- a/arch/arm/kernel/devtree.c
> +++ b/arch/arm/kernel/devtree.c
> @@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void)
>   if (of_node_cmp(cpu->type, "cpu"))
>   continue;
> 
> - pr_debug(" * %s...\n", cpu->full_name);
> + pr_debug(" * %pOF...\n", cpu);
>   /*
>* A device tree containing CPU nodes with missing "reg"
>* properties is considered invalid to build the
> @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)
>*/
>   cell = of_get_property(cpu, "reg", _bytes);
>   if (!cell || prop_bytes < sizeof(*cell)) {
> - pr_debug(" * %s missing reg property\n",
> -  cpu->full_name);
> + pr_debug(" * %pOF missing reg property\n",
> +  cpu);

You could join lines here and in the next hunk. And there are two more
further down.

>   of_node_put(cpu);
>   return;
>   }
> diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
> index bf949a763dbe..e596c5b8f931 100644
> --- a/arch/arm/kernel/topology.c
> +++ b/arch/arm/kernel/topology.c
> @@ -127,8 +127,8 @@ static void __init parse_dt_topology(void)
> 
>   rate = of_get_property(cn, "clock-frequency", );
>   if (!rate || len != 4) {
> - pr_err("%s missing clock-frequency property\n",
> - cn->full_name);
> + pr_err("%pOF missing clock-frequency property\n",
> + cn);
>   continue;
>   }
> 

Best regards
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |

[PATCH] ARM: Convert to using %pOF instead of full_name

[Rob Herring]

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring 
Cc: Russell King 
Cc: Kukjin Kim 
Cc: Krzysztof Kozlowski 
Cc: Javier Martinez Canillas 
Cc: Shawn Guo 
Cc: Sascha Hauer 
Cc: Fabio Estevam 
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Gregory Clement 
Cc: Sebastian Hesselbarth 
Cc: Tony Lindgren 
Cc: "Benoît Cousson" 
Cc: Paul Walmsley 
Cc: Heiko Stuebner 
Cc: Simon Horman 
Cc: Magnus Damm 
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Cc: linux-o...@vger.kernel.org
Cc: linux-rockc...@lists.infradead.org
Cc: linux-renesas-soc@vger.kernel.org
---
 arch/arm/kernel/cpuidle.c| 4 ++--
 arch/arm/kernel/devtree.c| 6 +++---
 arch/arm/kernel/topology.c   | 4 ++--
 arch/arm/mach-exynos/suspend.c   | 8 
 arch/arm/mach-imx/gpc.c  | 4 ++--
 arch/arm/mach-mvebu/kirkwood.c   | 4 ++--
 arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++--
 arch/arm/mach-omap2/omap_hwmod.c | 4 ++--
 arch/arm/mach-rockchip/platsmp.c | 4 ++--
 arch/arm/mach-shmobile/pm-rmobile.c  | 8 
 10 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c
index a3308ad1a024..fda5579123a8 100644
--- a/arch/arm/kernel/cpuidle.c
+++ b/arch/arm/kernel/cpuidle.c
@@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node 
*dn, int cpu)

ops = arm_cpuidle_get_ops(enable_method);
if (!ops) {
-   pr_warn("%s: unsupported enable-method property: %s\n",
-   dn->full_name, enable_method);
+   pr_warn("%pOF: unsupported enable-method property: %s\n",
+   dn, enable_method);
return -EOPNOTSUPP;
}

diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
index f676febbb270..28174c9a94ac 100644
--- a/arch/arm/kernel/devtree.c
+++ b/arch/arm/kernel/devtree.c
@@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void)
if (of_node_cmp(cpu->type, "cpu"))
continue;

-   pr_debug(" * %s...\n", cpu->full_name);
+   pr_debug(" * %pOF...\n", cpu);
/*
 * A device tree containing CPU nodes with missing "reg"
 * properties is considered invalid to build the
@@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)
 */
cell = of_get_property(cpu, "reg", _bytes);
if (!cell || prop_bytes < sizeof(*cell)) {
-   pr_debug(" * %s missing reg property\n",
-cpu->full_name);
+   pr_debug(" * %pOF missing reg property\n",
+cpu);
of_node_put(cpu);
return;
}
diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
index bf949a763dbe..e596c5b8f931 100644
--- a/arch/arm/kernel/topology.c
+++ b/arch/arm/kernel/topology.c
@@ -127,8 +127,8 @@ static void __init parse_dt_topology(void)

rate = of_get_property(cn, "clock-frequency", );
if (!rate || len != 4) {
-   pr_err("%s missing clock-frequency property\n",
-   cn->full_name);
+   pr_err("%pOF missing clock-frequency property\n",
+   cn);
continue;
}

diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
index 748cfb8d5212..3c7b66c22697 100644
--- a/arch/arm/mach-exynos/suspend.c
+++ b/arch/arm/mach-exynos/suspend.c
@@ -187,21 +187,21 @@ static int __init exynos_pmu_irq_init(struct device_node 
*node,
struct irq_domain *parent_domain, *domain;

if (!parent) {
-   pr_err("%s: no parent, giving up\n", node->full_name);
+   pr_err("%pOF: no parent, giving up\n", node);
return -ENODEV;
}

parent_domain = irq_find_host(parent);
if (!parent_domain) {
-   pr_err("%s: unable to obtain parent domain\n", node->full_name);
+   pr_err("%pOF: unable to obtain parent domain\n", node);
return -ENXIO;
}

pmu_base_addr = of_iomap(node, 0);

if (!pmu_base_addr) {
-   pr_err("%s: failed to find exynos pmu register\n",
-  node->full_name);
+