Re: [PATCH] arm64: dts: r8a7795: Add DRIF support

[Geert Uytterhoeven]

On Fri, Jun 23, 2017 at 11:13 AM, Ramesh Shanmugasundaram
 wrote:
> Adds the DRIF controller nodes for r8a7795.
>
> Signed-off-by: Ramesh Shanmugasundaram 
> 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH] arm64: dts: r8a7795: Add DRIF support

[Simon Horman]

On Fri, Jun 23, 2017 at 10:13:20AM +0100, Ramesh Shanmugasundaram wrote:
> Adds the DRIF controller nodes for r8a7795.
> 
> Signed-off-by: Ramesh Shanmugasundaram 
> 
> ---
> Hi Simon,
> 
>This patch is based on renesas-devel-20170622-v4.12-rc6 tag.
>It is verified on both H3 ES1.1 and ES2.0 SoC revisions.
> 
>The bindings[1] and the driver[2] were pushed into the media_tree.
> 
>[1] 
> https://git.linuxtv.org/media_tree.git/commit/?id=54a707ea011601f06cc5ef7fe6d0daac71ab0622
>[2] 
> https://git.linuxtv.org/media_tree.git/commit/?id=7625ee981af166ddb569e2e6c0006e2af471326f
> 
> Thanks,
> Ramesh.

Thanks for the reminder and sorry for letting this slip through.
I have queued this up for v4.14.

RE: [PATCH] arm64: dts: r8a7795: Add DRIF support

[Ramesh Shanmugasundaram]

Hi Simon,

> Subject: Re: [PATCH] arm64: dts: r8a7795: Add DRIF support
> 
> On Fri, Jun 23, 2017 at 10:13:20AM +0100, Ramesh Shanmugasundaram wrote:
> > Adds the DRIF controller nodes for r8a7795.
> >
> > Signed-off-by: Ramesh Shanmugasundaram
> > <ramesh.shanmugasunda...@bp.renesas.com>
> > ---
> > Hi Simon,
> >
> >This patch is based on renesas-devel-20170622-v4.12-rc6 tag.
> >It is verified on both H3 ES1.1 and ES2.0 SoC revisions.
> >
> >The bindings[1] and the driver[2] were pushed into the media_tree.
> >
> >[1]
> https://git.linuxtv.org/media_tree.git/commit/?id=54a707ea011601f06cc5ef7f
> e6d0daac71ab0622
> >[2]
> > https://git.linuxtv.org/media_tree.git/commit/?id=7625ee981af166ddb569
> > e2e6c0006e2af471326f
> >
> 
> Thanks. Has this been tested not to cause regressions when applied on top
> of renesas-devel-20170622-v4.12-rc6 (without the driver
> changes) ?

Yes, I just tested it without the driver changes on top of 
renesas-devel-20170622-v4.12-rc6 and it works fine on both ES1.1 & 2.0s.

Thanks,
Ramesh

Re: [PATCH] arm64: dts: r8a7795: Add DRIF support

[Simon Horman]

On Fri, Jun 23, 2017 at 10:13:20AM +0100, Ramesh Shanmugasundaram wrote:
> Adds the DRIF controller nodes for r8a7795.
> 
> Signed-off-by: Ramesh Shanmugasundaram 
> 
> ---
> Hi Simon,
> 
>This patch is based on renesas-devel-20170622-v4.12-rc6 tag.
>It is verified on both H3 ES1.1 and ES2.0 SoC revisions.
> 
>The bindings[1] and the driver[2] were pushed into the media_tree.
> 
>[1] 
> https://git.linuxtv.org/media_tree.git/commit/?id=54a707ea011601f06cc5ef7fe6d0daac71ab0622
>[2] 
> https://git.linuxtv.org/media_tree.git/commit/?id=7625ee981af166ddb569e2e6c0006e2af471326f
> 

Thanks. Has this been tested not to cause regressions when
applied on top of renesas-devel-20170622-v4.12-rc6 (without the driver
changes) ?

[PATCH] arm64: dts: r8a7795: Add DRIF support

[Ramesh Shanmugasundaram]

Adds the DRIF controller nodes for r8a7795.

Signed-off-by: Ramesh Shanmugasundaram 
---
Hi Simon,

   This patch is based on renesas-devel-20170622-v4.12-rc6 tag.
   It is verified on both H3 ES1.1 and ES2.0 SoC revisions.

   The bindings[1] and the driver[2] were pushed into the media_tree.

   [1] 
https://git.linuxtv.org/media_tree.git/commit/?id=54a707ea011601f06cc5ef7fe6d0daac71ab0622
   [2] 
https://git.linuxtv.org/media_tree.git/commit/?id=7625ee981af166ddb569e2e6c0006e2af471326f

Thanks,
Ramesh.

 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 120 +++
 1 file changed, 120 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi 
b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index e31c1b660b3f..24283ad057eb 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -691,6 +691,126 @@
};
};
 
+   drif00: rif@e6f4 {
+   compatible = "renesas,r8a7795-drif",
+"renesas,rcar-gen3-drif";
+   reg = <0 0xe6f4 0 0x64>;
+   interrupts = ;
+   clocks = < CPG_MOD 515>;
+   clock-names = "fck";
+   dmas = < 0x20>, < 0x20>;
+   dma-names = "rx", "rx";
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   resets = < 515>;
+   renesas,bonding = <>;
+   status = "disabled";
+   };
+
+   drif01: rif@e6f5 {
+   compatible = "renesas,r8a7795-drif",
+"renesas,rcar-gen3-drif";
+   reg = <0 0xe6f5 0 0x64>;
+   interrupts = ;
+   clocks = < CPG_MOD 514>;
+   clock-names = "fck";
+   dmas = < 0x22>, < 0x22>;
+   dma-names = "rx", "rx";
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   resets = < 514>;
+   renesas,bonding = <>;
+   status = "disabled";
+   };
+
+   drif10: rif@e6f6 {
+   compatible = "renesas,r8a7795-drif",
+"renesas,rcar-gen3-drif";
+   reg = <0 0xe6f6 0 0x64>;
+   interrupts = ;
+   clocks = < CPG_MOD 513>;
+   clock-names = "fck";
+   dmas = < 0x24>, < 0x24>;
+   dma-names = "rx", "rx";
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   resets = < 513>;
+   renesas,bonding = <>;
+   status = "disabled";
+   };
+
+   drif11: rif@e6f7 {
+   compatible = "renesas,r8a7795-drif",
+"renesas,rcar-gen3-drif";
+   reg = <0 0xe6f7 0 0x64>;
+   interrupts = ;
+   clocks = < CPG_MOD 512>;
+   clock-names = "fck";
+   dmas = < 0x26>, < 0x26>;
+   dma-names = "rx", "rx";
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   resets = < 512>;
+   renesas,bonding = <>;
+   status = "disabled";
+   };
+
+   drif20: rif@e6f8 {
+   compatible = "renesas,r8a7795-drif",
+"renesas,rcar-gen3-drif";
+   reg = <0 0xe6f8 0 0x64>;
+   interrupts = ;
+   clocks = < CPG_MOD 511>;
+   clock-names = "fck";
+   dmas = < 0x28>, < 0x28>;
+   dma-names = "rx", "rx";
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   resets = < 511>;
+   renesas,bonding = <>;
+   status = "disabled";
+   };
+
+   drif21: rif@e6f9 {
+   compatible = "renesas,r8a7795-drif",
+"renesas,rcar-gen3-drif";
+   reg = <0 0xe6f9 0 0x64>;
+   interrupts = ;
+   clocks = < CPG_MOD 510>;
+   clock-names = "fck";
+   dmas = < 0x2a>, < 0x2a>;
+   dma-names = "rx", "rx";
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
+   resets = < 510>;
+   renesas,bonding = <>;
+   status = "disabled";
+   };
+
+   drif30: rif@e6fa {
+