Re: [PATCH] arm64: dts: r8a77965: Add Watchdog Timer controller node using RCLK Watchdog Timer
Hi Geert-san, Thanks for your review. I will correct the commit message as per your instructions. Thanks, Kaneko 2018-05-28 22:07 GMT+09:00 Geert Uytterhoeven : > Hi Kaneko-san, > > (after adding more coffee) > > The summary prefix should be "arm64: dts: renesas: r8a77965:" > > On Mon, May 28, 2018 at 11:32 AM, Geert Uytterhoeven > wrote: >> On Wed, May 23, 2018 at 2:36 PM, Yoshihiro Kaneko >> wrote: >>> From: Takeshi Kihara >>> >>> Add a device node for the Watchdog Timer (WDT) controller on the Renesas >>> R-Car M3N (R8A77965) SoC. > > M3-N > >>> Based on a similar patch of the R8A7796 device tree >>> by Geert Uytterhoeven . >>> >>> Signed-off-by: Takeshi Kihara >>> Signed-off-by: Yoshihiro Kaneko >> >> Reviewed-by: Geert Uytterhoeven >> Tested-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds
Re: [PATCH] arm64: dts: r8a77965: Add Watchdog Timer controller node using RCLK Watchdog Timer
Hi Kaneko-san, (after adding more coffee) The summary prefix should be "arm64: dts: renesas: r8a77965:" On Mon, May 28, 2018 at 11:32 AM, Geert Uytterhoevenwrote: > On Wed, May 23, 2018 at 2:36 PM, Yoshihiro Kaneko > wrote: >> From: Takeshi Kihara >> >> Add a device node for the Watchdog Timer (WDT) controller on the Renesas >> R-Car M3N (R8A77965) SoC. M3-N >> Based on a similar patch of the R8A7796 device tree >> by Geert Uytterhoeven . >> >> Signed-off-by: Takeshi Kihara >> Signed-off-by: Yoshihiro Kaneko > > Reviewed-by: Geert Uytterhoeven > Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] arm64: dts: r8a77965: Add Watchdog Timer controller node using RCLK Watchdog Timer
On Wed, May 23, 2018 at 2:36 PM, Yoshihiro Kanekowrote: > From: Takeshi Kihara > > Add a device node for the Watchdog Timer (WDT) controller on the Renesas > R-Car M3N (R8A77965) SoC. > > Based on a similar patch of the R8A7796 device tree > by Geert Uytterhoeven . > > Signed-off-by: Takeshi Kihara > Signed-off-by: Yoshihiro Kaneko Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] arm64: dts: r8a77965: Add Watchdog Timer controller node using RCLK Watchdog Timer
On Wed, May 23, 2018 at 09:36:35PM +0900, Yoshihiro Kaneko wrote: > From: Takeshi Kihara> > Add a device node for the Watchdog Timer (WDT) controller on the Renesas > R-Car M3N (R8A77965) SoC. > > Based on a similar patch of the R8A7796 device tree > by Geert Uytterhoeven . > > Signed-off-by: Takeshi Kihara > Signed-off-by: Yoshihiro Kaneko This looks fine but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman
[PATCH] arm64: dts: r8a77965: Add Watchdog Timer controller node using RCLK Watchdog Timer
From: Takeshi KiharaAdd a device node for the Watchdog Timer (WDT) controller on the Renesas R-Car M3N (R8A77965) SoC. Based on a similar patch of the R8A7796 device tree by Geert Uytterhoeven . Signed-off-by: Takeshi Kihara Signed-off-by: Yoshihiro Kaneko --- This patch is based on the devel branch of Simon Horman's renesas tree. arch/arm64/boot/dts/renesas/r8a77965.dtsi | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index 486aeca..fb7100f 100644 --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi @@ -139,8 +139,13 @@ ranges; wdt0: watchdog@e602 { + compatible = "renesas,r8a77965-wdt", +"renesas,rcar-gen3-wdt"; reg = <0 0xe602 0 0x0c>; - /* placeholder */ + clocks = < CPG_MOD 402>; + power-domains = < R8A77965_PD_ALWAYS_ON>; + resets = < 402>; + status = "disabled"; }; gpio0: gpio@e605 { -- 1.9.1