Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3
Hi Simon, Wolfram, On 2018-12-05 22:36:13 +0100, Niklas Söderlund wrote: > Hi Wolfram, > > On 2018-12-05 21:46:28 +0100, Wolfram Sang wrote: > > On Fri, Nov 02, 2018 at 12:57:19PM +0100, Simon Horman wrote: > > > On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote: > > > > > > > > > This patch have quiet a few dependencies I'm afraid, let me know if > > > > > you > > > > > wish to be notified once they all upstream. I don't think it's a good > > > > > idea to pick this up before all dependencies are resolved. > > > > > > > > Yes, we should do that. Ping Simon once all dependencies are in next. It > > > > is still fine to have this patch here in case people want to test. BTW > > > > did you mention your branch somewhere where you collected all these > > > > patches to make HS400 working/enabled? > > > > > > > > For this patch already: > > > > > > > > Reviewed-by: Wolfram Sang > > > > Tested-by: Wolfram Sang > > > > > > Thanks, I am marking this as deferred. > > > > > > Please repost or ping me once the dependencies are present in > > > an rc release. > > > > Niklas, are we done now, so we can ask Simon to pick up the DTS change? > > > > Almost :-) > > I'm waiting for Geert to take the SD quirk patches before pinging Simon > to take this one. Spoke to him today about that so I hope it will not be > to long. > I just confirmation that the clock patches have been pulled into clk-next so this patch is ready to be consumed by you Simon. Would it be possible to get this in this cycle or is it to late? I know you wished to close your tree for v4.21 at the end of this week which it technically is now ;-) -- Regards, Niklas Söderlund
Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3
On Thu, Nov 01, 2018 at 08:45:29PM +0100, Wolfram Sang wrote: > > > This patch have quiet a few dependencies I'm afraid, let me know if you > > wish to be notified once they all upstream. I don't think it's a good > > idea to pick this up before all dependencies are resolved. > > Yes, we should do that. Ping Simon once all dependencies are in next. It > is still fine to have this patch here in case people want to test. BTW > did you mention your branch somewhere where you collected all these > patches to make HS400 working/enabled? > > For this patch already: > > Reviewed-by: Wolfram Sang > Tested-by: Wolfram Sang Thanks, I am marking this as deferred. Please repost or ping me once the dependencies are present in an rc release.
Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3
And this concludes my first patch review session while being on a ship :) Thanks for this SDHI hackathon guys, and looking forward to seeing you again! signature.asc Description: PGP signature
Re: [PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3
> This patch have quiet a few dependencies I'm afraid, let me know if you > wish to be notified once they all upstream. I don't think it's a good > idea to pick this up before all dependencies are resolved. Yes, we should do that. Ping Simon once all dependencies are in next. It is still fine to have this patch here in case people want to test. BTW did you mention your branch somewhere where you collected all these patches to make HS400 working/enabled? For this patch already: Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang signature.asc Description: PGP signature
[PATCH] arm64: dts: renesas: enable HS400 on R-Car Gen3
From: Niklas Söderlund Successfully tested on H3 ES2.0 and M3-N ES1.0. Transfer rates where >160MB/s for H3 and >200MB/s for M3-N. Signed-off-by: Niklas Söderlund --- arch/arm64/boot/dts/renesas/salvator-common.dtsi | 1 + arch/arm64/boot/dts/renesas/ulcb.dtsi| 1 + 2 files changed, 2 insertions(+) --- Hi Simon, This patch have quiet a few dependencies I'm afraid, let me know if you wish to be notified once they all upstream. I don't think it's a good idea to pick this up before all dependencies are resolved. - [PATCH] mmc: renesas_sdhi: remove workaround for HS400 clock - [PATCH v3 0/3] mmc: tmio: fix reset operation - [PATCH v2 0/3] mmc: renesas_sdhi: extend quirk selection to handle ES revisions - [PATCH 0/2] renesas: rcar-gen3: add HS400 quirk for SD clock diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index d28ae95405f1152b..6bc041cc63bdc81b 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -762,6 +762,7 @@ vqmmc-supply = <_1p8v>; bus-width = <8>; mmc-hs200-1_8v; + mmc-hs400-1_8v; non-removable; fixed-emmc-driver-type = <1>; status = "okay"; diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 7e6078508ba0ba19..88d03177ae2b327c 100644 --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi @@ -430,6 +430,7 @@ vqmmc-supply = <_1p8v>; bus-width = <8>; mmc-hs200-1_8v; + mmc-hs400-1_8v; non-removable; status = "okay"; }; -- 2.19.1