RE: [PATCH] arm64: dts: renesas: r8a77995: add pfc device node

[Yoshihiro Shimoda]

Hi Simon-san,

> -Original Message-
> From: Simon Horman
> Sent: Monday, August 28, 2017 11:05 PM
> 
> On Mon, Aug 28, 2017 at 10:39:47AM +0200, Geert Uytterhoeven wrote:
> > Hi Shimoda-san, Simon,
> >
> > On Wed, Aug 9, 2017 at 2:20 PM, Yoshihiro Shimoda
> >  wrote:
> > > Signed-off-by: Yoshihiro Shimoda 
> > > ---
> > >
> > >  This patch set is based on the renesas-drivers.git /
> > > topic/r8a77995-integration branch and depends on the following patch
> > >  "pinctrl: sh-pfc: r8a77995: Initial R8A77995 PFC support"
> > >
> > >  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 5 +
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi 
> > > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > index 7419688..240b0f8 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > @@ -123,6 +123,11 @@
> > > reg = <0 0xe616 0 0x0200>;
> > > };
> > >
> > > +   pfc: pfc@e606 {
> >
> > Upon second look, this should use the generic "pin-controller@..." node 
> > name.
> > I will fix the example in the bindings.
> >
> > > +   compatible = "renesas,pfc-r8a77995";
> > > +   reg = <0 0xe606 0 0x508>;
> > > +   };
> 
> Shimoda-san, as this patch has been accepted for v4.14 could
> you please send a follow-up patch (for v4.15)?

Sure. I submitted a patch now.

Best regards,
Yoshihiro Shimoda

Re: [PATCH] arm64: dts: renesas: r8a77995: add pfc device node

[Simon Horman]

On Mon, Aug 28, 2017 at 10:39:47AM +0200, Geert Uytterhoeven wrote:
> Hi Shimoda-san, Simon,
> 
> On Wed, Aug 9, 2017 at 2:20 PM, Yoshihiro Shimoda
>  wrote:
> > Signed-off-by: Yoshihiro Shimoda 
> > ---
> >
> >  This patch set is based on the renesas-drivers.git /
> > topic/r8a77995-integration branch and depends on the following patch
> >  "pinctrl: sh-pfc: r8a77995: Initial R8A77995 PFC support"
> >
> >  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 5 +
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi 
> > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > index 7419688..240b0f8 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > @@ -123,6 +123,11 @@
> > reg = <0 0xe616 0 0x0200>;
> > };
> >
> > +   pfc: pfc@e606 {
> 
> Upon second look, this should use the generic "pin-controller@..." node name.
> I will fix the example in the bindings.
> 
> > +   compatible = "renesas,pfc-r8a77995";
> > +   reg = <0 0xe606 0 0x508>;
> > +   };

Shimoda-san, as this patch has been accepted for v4.14 could
you please send a follow-up patch (for v4.15)?

Re: [PATCH] arm64: dts: renesas: r8a77995: add pfc device node

[Geert Uytterhoeven]

Hi Shimoda-san, Simon,

On Wed, Aug 9, 2017 at 2:20 PM, Yoshihiro Shimoda
 wrote:
> Signed-off-by: Yoshihiro Shimoda 
> ---
>
>  This patch set is based on the renesas-drivers.git /
> topic/r8a77995-integration branch and depends on the following patch
>  "pinctrl: sh-pfc: r8a77995: Initial R8A77995 PFC support"
>
>  arch/arm64/boot/dts/renesas/r8a77995.dtsi | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 7419688..240b0f8 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -123,6 +123,11 @@
> reg = <0 0xe616 0 0x0200>;
> };
>
> +   pfc: pfc@e606 {

Upon second look, this should use the generic "pin-controller@..." node name.
I will fix the example in the bindings.

> +   compatible = "renesas,pfc-r8a77995";
> +   reg = <0 0xe606 0 0x508>;
> +   };

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: r8a77995: add pfc device node

[Simon Horman]

On Thu, Aug 10, 2017 at 10:13:19AM +0200, Simon Horman wrote:
> On Wed, Aug 09, 2017 at 09:20:47PM +0900, Yoshihiro Shimoda wrote:
> > Signed-off-by: Yoshihiro Shimoda 
> > ---
> > 
> >  This patch set is based on the renesas-drivers.git /
> > topic/r8a77995-integration branch and depends on the following patch
> >  "pinctrl: sh-pfc: r8a77995: Initial R8A77995 PFC support"
> 
> Thanks Shimoda-san,
> 
> this patch looks fine to me, however, I am marking it as deferred pending
> acceptance of the dependency listed above. Please repost or otherwise
> ping me once Geert has indicated he will accept that patch.

That dependency appears to be satisfied now,
I have applied this patch.

Re: [PATCH] arm64: dts: renesas: r8a77995: add pfc device node

[Geert Uytterhoeven]

On Wed, Aug 9, 2017 at 2:20 PM, Yoshihiro Shimoda
 wrote:
> Signed-off-by: Yoshihiro Shimoda 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH] arm64: dts: renesas: r8a77995: add pfc device node

[Yoshihiro Shimoda]

Signed-off-by: Yoshihiro Shimoda 
---

 This patch set is based on the renesas-drivers.git /
topic/r8a77995-integration branch and depends on the following patch
 "pinctrl: sh-pfc: r8a77995: Initial R8A77995 PFC support"

 arch/arm64/boot/dts/renesas/r8a77995.dtsi | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi 
b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 7419688..240b0f8 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -123,6 +123,11 @@
reg = <0 0xe616 0 0x0200>;
};
 
+   pfc: pfc@e606 {
+   compatible = "renesas,pfc-r8a77995";
+   reg = <0 0xe606 0 0x508>;
+   };
+
prr: chipid@fff00044 {
compatible = "renesas,prr";
reg = <0 0xfff00044 0 4>;
-- 
1.9.1