RE: [PATCH] watchdog: renesas_wdt: Fix typos

[Fabrizio Castro]

> Subject: Re: [PATCH] watchdog: renesas_wdt: Fix typos
>
> On Fri, Nov 02, 2018 at 07:21:11PM +, Fabrizio Castro wrote:
>
> Do not use "," but ";" to separate instructions.

I agree, will send a v2 for this.

Thanks,
Fab

>
> > Signed-off-by: Fabrizio Castro 
>
> Reviewed-by: Guenter Roeck 
>
> > ---
> >  drivers/watchdog/renesas_wdt.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> > index 0d74c3e..b570962 100644
> > --- a/drivers/watchdog/renesas_wdt.c
> > +++ b/drivers/watchdog/renesas_wdt.c
> > @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
> >  goto out_pm_disable;
> >  }
> >
> > -priv->wdev.info = &rwdt_ident,
> > -priv->wdev.ops = &rwdt_ops,
> > +priv->wdev.info = &rwdt_ident;
> > +priv->wdev.ops = &rwdt_ops;
> >  priv->wdev.parent = &pdev->dev;
> >  priv->wdev.min_timeout = 1;
> >  priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
> > --
> > 2.7.4
> >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

Re: [PATCH] watchdog: renesas_wdt: Fix typos

[Geert Uytterhoeven]

On Fri, Nov 2, 2018 at 8:48 PM Guenter Roeck  wrote:
> On Fri, Nov 02, 2018 at 07:21:11PM +, Fabrizio Castro wrote:
>
> Do not use "," but ";" to separate instructions.

+1

Thanks, my eyes had a hard time finding out what had been changed ;-)

> > Signed-off-by: Fabrizio Castro 
>
> Reviewed-by: Guenter Roeck 
>
> > ---
> >  drivers/watchdog/renesas_wdt.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> > index 0d74c3e..b570962 100644
> > --- a/drivers/watchdog/renesas_wdt.c
> > +++ b/drivers/watchdog/renesas_wdt.c
> > @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
> >   goto out_pm_disable;
> >   }
> >
> > - priv->wdev.info = &rwdt_ident,
> > - priv->wdev.ops = &rwdt_ops,
> > + priv->wdev.info = &rwdt_ident;
> > + priv->wdev.ops = &rwdt_ops;
> >   priv->wdev.parent = &pdev->dev;
> >   priv->wdev.min_timeout = 1;
> >   priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH] watchdog: renesas_wdt: Fix typos

[Guenter Roeck]

On Fri, Nov 02, 2018 at 07:21:11PM +, Fabrizio Castro wrote:

Do not use "," but ";" to separate instructions.

> Signed-off-by: Fabrizio Castro 

Reviewed-by: Guenter Roeck 

> ---
>  drivers/watchdog/renesas_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> index 0d74c3e..b570962 100644
> --- a/drivers/watchdog/renesas_wdt.c
> +++ b/drivers/watchdog/renesas_wdt.c
> @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
>   goto out_pm_disable;
>   }
>  
> - priv->wdev.info = &rwdt_ident,
> - priv->wdev.ops = &rwdt_ops,
> + priv->wdev.info = &rwdt_ident;
> + priv->wdev.ops = &rwdt_ops;
>   priv->wdev.parent = &pdev->dev;
>   priv->wdev.min_timeout = 1;
>   priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
> -- 
> 2.7.4
> 

[PATCH] watchdog: renesas_wdt: Fix typos

[Fabrizio Castro]

Signed-off-by: Fabrizio Castro 
---
 drivers/watchdog/renesas_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index 0d74c3e..b570962 100644
--- a/drivers/watchdog/renesas_wdt.c
+++ b/drivers/watchdog/renesas_wdt.c
@@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
goto out_pm_disable;
}
 
-   priv->wdev.info = &rwdt_ident,
-   priv->wdev.ops = &rwdt_ops,
+   priv->wdev.info = &rwdt_ident;
+   priv->wdev.ops = &rwdt_ops;
priv->wdev.parent = &pdev->dev;
priv->wdev.min_timeout = 1;
priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
-- 
2.7.4