RE: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Biju Das]

> -Original Message-
> From: Wolfram Sang [mailto:w...@the-dreams.de]
> Sent: 21 August 2017 09:25
> To: Biju Das <biju@bp.renesas.com>
> Cc: Ulf Hansson <ulf.hans...@linaro.org>; Rob Herring <robh...@kernel.org>;
> Mark Rutland <mark.rutl...@arm.com>; Simon Horman
> <ho...@verge.net.au>; Magnus Damm <magnus.d...@gmail.com>; Chris
> Paterson <chris.paters...@renesas.com>; Wolfram Sang
> <wsa+rene...@sang-engineering.com>; devicet...@vger.kernel.org; linux-
> renesas-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> m...@vger.kernel.org
> Subject: Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
>
>
> >Below is the number clocks for each supported SoC:
> > -   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
> > -  R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
> > +   1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778,
> R8A7779,
> > +  R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795,
> R8A7796
> > 2: R7S72100
>
> Hmm, maybe we should convert this to only listing SoCs with two clocks?
> That will be easier to maintaine since the majority seems to have one.

Ok. I will send v2 with the suggested  changes.





Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Wolfram Sang]

> Below is the number clocks for each supported SoC:
> -1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
> -   R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
> +1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778, R8A7779,
> +   R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
>  2: R7S72100

Hmm, maybe we should convert this to only listing SoCs with two clocks?
That will be easier to maintaine since the majority seems to have one.



signature.asc
Description: PGP signature

Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Rob Herring]

On Mon, Aug 14, 2017 at 12:39:26PM +0100, Biju Das wrote:
> Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
> 
> Signed-off-by: Biju Das <biju@bp.renesas.com>
> ---
> This patch is compiled and tested againt linux next tag
> next-20170811. This patch depend on the driver change
> [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
> https://patchwork.kernel.org/patch/9898611/
> 
> 
>  Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 6 --
>  1 file changed, 4 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <r...@kernel.org>

RE: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Chris Paterson]

Hello Geert,

> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com]
> On Behalf Of Geert Uytterhoeven
> 
> Hi Chris,
> 
> On Mon, Aug 14, 2017 at 5:15 PM, Chris Paterson
>  wrote:
> >> From: geert.uytterhoe...@gmail.com
> >> [mailto:geert.uytterhoe...@gmail.com]
> >> On Behalf Of Geert Uytterhoeven
> >> Sent: 14 August 2017 15:22
> >>
> >> On Mon, Aug 14, 2017 at 1:19 PM, Biju Das 
> wrote:
> >> > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is
> >> > identical to the R-Car Gen2 family.
> >> >
> >> > Signed-off-by: Biju Das 
> >> > ---
> >> > This patch is compiled and tested against mmc/next.
> >> >
> >> >  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> >> >  1 file changed, 2 insertions(+)
> >> >
> >> > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> >> > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> >> > index 718cb8a..f709f7f 100644
> >> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> >> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> >> > @@ -95,6 +95,8 @@
> >> > { .compatible = "renesas,sdhi-r7s72100", .data = 
> >> > _rz_compatible,
> },
> >> > { .compatible = "renesas,sdhi-r8a7778", .data =
> >> _rcar_gen1_compatible, },
> >> > { .compatible = "renesas,sdhi-r8a7779", .data =
> >> > _rcar_gen1_compatible, },
> >> > +   { .compatible = "renesas,sdhi-r8a7743", .data =
> >> _rcar_gen2_compatible, },
> >> > +   { .compatible = "renesas,sdhi-r8a7745", .data =
> >> > + _rcar_gen2_compatible, },
> >> > { .compatible = "renesas,sdhi-r8a7790", .data =
> >> _rcar_gen2_compatible, },
> >> > { .compatible = "renesas,sdhi-r8a7791", .data =
> >> _rcar_gen2_compatible, },
> >> > { .compatible = "renesas,sdhi-r8a7792", .data =
> >> > _rcar_gen2_compatible, },
> >>
> >> I guess we want generic R-Car Gen2/3 compatible values here, too?
> >
> > Yes, but I assume that should be a separate patch submitted instead of this
> one?
> 
> Indeed. That would avoid having to add the SoC-specific compatible values to
> the driver for all RZ/G1 variants.

Okay. I'll send a new patch.

Kind regards, Chris

> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds

Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Geert Uytterhoeven]

Hi Chris,

On Mon, Aug 14, 2017 at 5:15 PM, Chris Paterson
 wrote:
>> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com]
>> On Behalf Of Geert Uytterhoeven
>> Sent: 14 August 2017 15:22
>>
>> On Mon, Aug 14, 2017 at 1:19 PM, Biju Das  wrote:
>> > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is
>> > identical to the R-Car Gen2 family.
>> >
>> > Signed-off-by: Biju Das 
>> > ---
>> > This patch is compiled and tested against mmc/next.
>> >
>> >  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
>> > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
>> > index 718cb8a..f709f7f 100644
>> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
>> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
>> > @@ -95,6 +95,8 @@
>> > { .compatible = "renesas,sdhi-r7s72100", .data = 
>> > _rz_compatible, },
>> > { .compatible = "renesas,sdhi-r8a7778", .data =
>> _rcar_gen1_compatible, },
>> > { .compatible = "renesas,sdhi-r8a7779", .data =
>> > _rcar_gen1_compatible, },
>> > +   { .compatible = "renesas,sdhi-r8a7743", .data =
>> _rcar_gen2_compatible, },
>> > +   { .compatible = "renesas,sdhi-r8a7745", .data =
>> > + _rcar_gen2_compatible, },
>> > { .compatible = "renesas,sdhi-r8a7790", .data =
>> _rcar_gen2_compatible, },
>> > { .compatible = "renesas,sdhi-r8a7791", .data =
>> _rcar_gen2_compatible, },
>> > { .compatible = "renesas,sdhi-r8a7792", .data =
>> > _rcar_gen2_compatible, },
>>
>> I guess we want generic R-Car Gen2/3 compatible values here, too?
>
> Yes, but I assume that should be a separate patch submitted instead of this 
> one?

Indeed. That would avoid having to add the SoC-specific compatible values
to the driver for all RZ/G1 variants.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

RE: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Chris Paterson]

> From: geert.uytterhoe...@gmail.com [mailto:geert.uytterhoe...@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: 14 August 2017 15:22
> 
> On Mon, Aug 14, 2017 at 1:19 PM, Biju Das  wrote:
> > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is
> > identical to the R-Car Gen2 family.
> >
> > Signed-off-by: Biju Das 
> > ---
> > This patch is compiled and tested against mmc/next.
> >
> >  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > index 718cb8a..f709f7f 100644
> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > @@ -95,6 +95,8 @@
> > { .compatible = "renesas,sdhi-r7s72100", .data = _rz_compatible, 
> > },
> > { .compatible = "renesas,sdhi-r8a7778", .data =
> _rcar_gen1_compatible, },
> > { .compatible = "renesas,sdhi-r8a7779", .data =
> > _rcar_gen1_compatible, },
> > +   { .compatible = "renesas,sdhi-r8a7743", .data =
> _rcar_gen2_compatible, },
> > +   { .compatible = "renesas,sdhi-r8a7745", .data =
> > + _rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7790", .data =
> _rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7791", .data =
> _rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7792", .data =
> > _rcar_gen2_compatible, },
> 
> I guess we want generic R-Car Gen2/3 compatible values here, too?

Yes, but I assume that should be a separate patch submitted instead of this one?

Kind regards, Chris


> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds

Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Geert Uytterhoeven]

On Mon, Aug 14, 2017 at 1:19 PM, Biju Das  wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das 
> ---
> This patch is compiled and tested against mmc/next.
>
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c 
> b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 718cb8a..f709f7f 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -95,6 +95,8 @@
> { .compatible = "renesas,sdhi-r7s72100", .data = _rz_compatible, },
> { .compatible = "renesas,sdhi-r8a7778", .data = 
> _rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7779", .data = 
> _rcar_gen1_compatible, },
> +   { .compatible = "renesas,sdhi-r8a7743", .data = 
> _rcar_gen2_compatible, },
> +   { .compatible = "renesas,sdhi-r8a7745", .data = 
> _rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = 
> _rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = 
> _rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7792", .data = 
> _rcar_gen2_compatible, },

I guess we want generic R-Car Gen2/3 compatible values here, too?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Biju Das]

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI
is identical to the R-Car Gen2 family.

Signed-off-by: Biju Das <biju@bp.renesas.com>
---
This patch is compiled and tested againt linux next tag
next-20170811. This patch depend on the driver change
[PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
https://patchwork.kernel.org/patch/9898611/


 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt 
b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
index 4fd8b7a..0d507ec 100644
--- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
@@ -15,6 +15,8 @@ Required properties:
"renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
"renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
"renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+   "renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+   "renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
"renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
"renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
"renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
@@ -34,8 +36,8 @@ Required properties:
  "core" and "cd". If the controller only has 1 clock, naming is not
  required.
  Below is the number clocks for each supported SoC:
-  1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
- R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
+  1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778, R8A7779,
+ R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
   2: R7S72100
 
 Optional properties:
-- 
1.9.1

[PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

[Biju Das]

Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
is identical to the R-Car Gen2 family.

Signed-off-by: Biju Das 
---
This patch is compiled and tested against mmc/next.

 drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c 
b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 718cb8a..f709f7f 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -95,6 +95,8 @@
{ .compatible = "renesas,sdhi-r7s72100", .data = _rz_compatible, },
{ .compatible = "renesas,sdhi-r8a7778", .data = 
_rcar_gen1_compatible, },
{ .compatible = "renesas,sdhi-r8a7779", .data = 
_rcar_gen1_compatible, },
+   { .compatible = "renesas,sdhi-r8a7743", .data = 
_rcar_gen2_compatible, },
+   { .compatible = "renesas,sdhi-r8a7745", .data = 
_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7790", .data = 
_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7791", .data = 
_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7792", .data = 
_rcar_gen2_compatible, },
-- 
1.9.1