Re: [PATCH 0/3] pinctrl: sh-pfc: add r8a7795 support for voltage switching

[Simon Horman]

On Fri, Jun 10, 2016 at 01:21:39PM +0200, Geert Uytterhoeven wrote:
> Hi Wolfram,
> 
> On Fri, Jun 10, 2016 at 1:12 PM, Wolfram Sang  wrote:
> >> BTW, are these a hard dependency for patch 3, or will the missing power
> >> source control just be ignored?
> >
> > Long answer short: It is a hard dependency.
> >
> > It shouldn't be, but fixing this might need patches to pfc, mmc-core,
> > and sdhi driver. Need to think about it. (and even then, patch 3 will be
> > depending on these yet-to-come fixes).
> 
> Thanks, good to know! ;-)
> 
> Simon: So either you can merge sh-pfc-for-v4.8 first (after I have sent the
> pull request, and Linus W. has merged it!), or the DTS update will have to 
> wait
> for v4.9.

I prefer to wait to v4.9 unless there is a good reason no to.

Re: [PATCH 0/3] pinctrl: sh-pfc: add r8a7795 support for voltage switching

[Wolfram Sang]

> BTW, are these a hard dependency for patch 3, or will the missing power
> source control just be ignored?

Long answer short: It is a hard dependency.

It shouldn't be, but fixing this might need patches to pfc, mmc-core,
and sdhi driver. Need to think about it. (and even then, patch 3 will be
depending on these yet-to-come fixes).



signature.asc
Description: PGP signature

Re: [PATCH 0/3] pinctrl: sh-pfc: add r8a7795 support for voltage switching

[Geert Uytterhoeven]

Hi Wolfram,

On Mon, Jun 6, 2016 at 6:08 PM, Wolfram Sang  wrote:
> This series adds support for PFC voltage switching for r8a7795. I decided to
> refactor voltage switching because all Gen2 and Gen3 hardware follow the same
> style to do that. So, we can put generic handling to the core and keep only
> pin-to-bit mapping SoC specific. See patch 1 for details.
>
> Tested on a Lager board (r8a7790/H2) and a Salvator-X (r8a7795/H3) by using
> UHS/non-UHS SD cards. They work fine with SDR50 and the POCCTRL register
> setting was also verified.
>
> Branch is here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git 
> renesas/topic/h3-pfc-set-voltage
>
> Changes since RFC:
> * be precise in encoding which pins can do voltage switching on bank3
> * addded Geert's reviewed tag (thanks!)
>
> Please apply,
>
>Wolfram
>
> Wolfram Sang (3):
>   pinctrl: sh-pfc: refactor voltage setting
>   pinctrl: sh-pfc: r8a7795: add support for voltage switching
>   arm64: dts: r8a7795: salvator: enable UHS for SDHI 0 & 3

Thanks for your series!

I've queued the first two patches in sh-pfc-for-v4.8, and will send a pull
request after next renesas-drivers release.

BTW, are these a hard dependency for patch 3, or will the missing power
source control just be ignored?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 0/3] pinctrl: sh-pfc: add r8a7795 support for voltage switching

[Wolfram Sang]

This series adds support for PFC voltage switching for r8a7795. I decided to
refactor voltage switching because all Gen2 and Gen3 hardware follow the same
style to do that. So, we can put generic handling to the core and keep only
pin-to-bit mapping SoC specific. See patch 1 for details.

Tested on a Lager board (r8a7790/H2) and a Salvator-X (r8a7795/H3) by using
UHS/non-UHS SD cards. They work fine with SDR50 and the POCCTRL register
setting was also verified.

Branch is here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git 
renesas/topic/h3-pfc-set-voltage

Changes since RFC:
* be precise in encoding which pins can do voltage switching on bank3
* addded Geert's reviewed tag (thanks!)

Please apply,

   Wolfram

Wolfram Sang (3):
  pinctrl: sh-pfc: refactor voltage setting
  pinctrl: sh-pfc: r8a7795: add support for voltage switching
  arm64: dts: r8a7795: salvator: enable UHS for SDHI 0 & 3

 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 +++-
 drivers/pinctrl/sh-pfc/pfc-r8a7790.c   | 58 +-
 drivers/pinctrl/sh-pfc/pfc-r8a7795.c   | 28 ++-
 drivers/pinctrl/sh-pfc/pinctrl.c   | 41 +--
 drivers/pinctrl/sh-pfc/sh_pfc.h|  4 +-
 5 files changed, 86 insertions(+), 67 deletions(-)

-- 
2.8.1