Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes
On Thu, May 17, 2018 at 09:52:33AM +0200, Simon Horman wrote:
> On Wed, May 16, 2018 at 07:43:29PM +0200, Geert Uytterhoeven wrote:
> > Hi Uli,
> >
> > On Wed, May 16, 2018 at 3:05 PM, Ulrich Hecht
> > wrote:
> > > From: Hiromitsu Yamasaki
> > >
> > > This patch adds MSIOF device nodes for the R8A77995 SoC.
> > >
> > > Signed-off-by: Hiromitsu Yamasaki
> > > Signed-off-by: Takeshi Kihara
> > > [uli: remove unimplemented ref clock]
> >
> > I think you should remove the clock-names properties, too.
> >
> > > Signed-off-by: Ulrich Hecht
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 66
> > > +++
> > > 1 file changed, 66 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > index 2506f46..2f712ac 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > > @@ -783,6 +783,72 @@
> > > compatible = "renesas,prr";
> > > reg = <0 0xfff00044 0 4>;
> > > };
> > > +
> > > + msiof0: spi@e6e9 {
> > > + compatible = "renesas,msiof-r8a77995",
> > > +"renesas,rcar-gen3-msiof";
> > > + reg = <0 0xe6e9 0 0x0064>;
>
> minor nit: s/0x0064/0x64/
>
> Ulrich, could you consider reposing with the feedback from Geert and the
> minor nit above addressed?
Ulrich, ping for this series.
signature.asc
Description: PGP signature
Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes
> > For the record: can you describe shortly which of these got tested with > > what setup? I don't know the Draak, so I don't know what is exposed. > > MSIOF2 is conveniently hooked up to a 1x4 pin header (CN41), no > weird-ass Samtec connectors required. My testing covered sending some > data using spidev_test and watching the output on an oscilloscope > attached to MSIOF2_TXD (pin 3). Looks plausible. Perfect, thanks! signature.asc Description: PGP signature
Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes
On Thu, May 17, 2018 at 9:56 AM, Wolfram Sang wrote: > On Wed, May 16, 2018 at 03:05:15PM +0200, Ulrich Hecht wrote: >> From: Hiromitsu Yamasaki >> >> This patch adds MSIOF device nodes for the R8A77995 SoC. >> >> Signed-off-by: Hiromitsu Yamasaki >> Signed-off-by: Takeshi Kihara >> [uli: remove unimplemented ref clock] >> Signed-off-by: Ulrich Hecht > > Thanks, Uli! > > For the record: can you describe shortly which of these got tested with > what setup? I don't know the Draak, so I don't know what is exposed. MSIOF2 is conveniently hooked up to a 1x4 pin header (CN41), no weird-ass Samtec connectors required. My testing covered sending some data using spidev_test and watching the output on an oscilloscope attached to MSIOF2_TXD (pin 3). Looks plausible. CU Uli
Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes
On Wed, May 16, 2018 at 03:05:15PM +0200, Ulrich Hecht wrote: > From: Hiromitsu Yamasaki > > This patch adds MSIOF device nodes for the R8A77995 SoC. > > Signed-off-by: Hiromitsu Yamasaki > Signed-off-by: Takeshi Kihara > [uli: remove unimplemented ref clock] > Signed-off-by: Ulrich Hecht Thanks, Uli! For the record: can you describe shortly which of these got tested with what setup? I don't know the Draak, so I don't know what is exposed. signature.asc Description: PGP signature
Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes
On Wed, May 16, 2018 at 07:43:29PM +0200, Geert Uytterhoeven wrote:
> Hi Uli,
>
> On Wed, May 16, 2018 at 3:05 PM, Ulrich Hecht
> wrote:
> > From: Hiromitsu Yamasaki
> >
> > This patch adds MSIOF device nodes for the R8A77995 SoC.
> >
> > Signed-off-by: Hiromitsu Yamasaki
> > Signed-off-by: Takeshi Kihara
> > [uli: remove unimplemented ref clock]
>
> I think you should remove the clock-names properties, too.
>
> > Signed-off-by: Ulrich Hecht
> > ---
> > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 66
> > +++
> > 1 file changed, 66 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > index 2506f46..2f712ac 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > @@ -783,6 +783,72 @@
> > compatible = "renesas,prr";
> > reg = <0 0xfff00044 0 4>;
> > };
> > +
> > + msiof0: spi@e6e9 {
> > + compatible = "renesas,msiof-r8a77995",
> > +"renesas,rcar-gen3-msiof";
> > + reg = <0 0xe6e9 0 0x0064>;
minor nit: s/0x0064/0x64/
Ulrich, could you consider reposing with the feedback from Geert and the
minor nit above addressed?
> > + interrupts = ;
> > + clocks = <&cpg CPG_MOD 211>;
> > + clock-names = "msiof_clk";
> > + dmas = <&dmac1 0x41>, <&dmac1 0x40>,
> > + <&dmac2 0x41>, <&dmac2 0x40>;
> > + dma-names = "tx", "rx", "tx", "rx";
> > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> > + resets = <&cpg 211>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + status = "disabled";
> > + };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
>
Re: [PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes
Hi Uli,
On Wed, May 16, 2018 at 3:05 PM, Ulrich Hecht
wrote:
> From: Hiromitsu Yamasaki
>
> This patch adds MSIOF device nodes for the R8A77995 SoC.
>
> Signed-off-by: Hiromitsu Yamasaki
> Signed-off-by: Takeshi Kihara
> [uli: remove unimplemented ref clock]
I think you should remove the clock-names properties, too.
> Signed-off-by: Ulrich Hecht
> ---
> arch/arm64/boot/dts/renesas/r8a77995.dtsi | 66
> +++
> 1 file changed, 66 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> index 2506f46..2f712ac 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> @@ -783,6 +783,72 @@
> compatible = "renesas,prr";
> reg = <0 0xfff00044 0 4>;
> };
> +
> + msiof0: spi@e6e9 {
> + compatible = "renesas,msiof-r8a77995",
> +"renesas,rcar-gen3-msiof";
> + reg = <0 0xe6e9 0 0x0064>;
> + interrupts = ;
> + clocks = <&cpg CPG_MOD 211>;
> + clock-names = "msiof_clk";
> + dmas = <&dmac1 0x41>, <&dmac1 0x40>,
> + <&dmac2 0x41>, <&dmac2 0x40>;
> + dma-names = "tx", "rx", "tx", "rx";
> + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> + resets = <&cpg 211>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> + };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH 1/2] arm64: dts: r8a77995: Add MSIOF device nodes
From: Hiromitsu Yamasaki
This patch adds MSIOF device nodes for the R8A77995 SoC.
Signed-off-by: Hiromitsu Yamasaki
Signed-off-by: Takeshi Kihara
[uli: remove unimplemented ref clock]
Signed-off-by: Ulrich Hecht
---
arch/arm64/boot/dts/renesas/r8a77995.dtsi | 66 +++
1 file changed, 66 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
index 2506f46..2f712ac 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
@@ -783,6 +783,72 @@
compatible = "renesas,prr";
reg = <0 0xfff00044 0 4>;
};
+
+ msiof0: spi@e6e9 {
+ compatible = "renesas,msiof-r8a77995",
+"renesas,rcar-gen3-msiof";
+ reg = <0 0xe6e9 0 0x0064>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 211>;
+ clock-names = "msiof_clk";
+ dmas = <&dmac1 0x41>, <&dmac1 0x40>,
+ <&dmac2 0x41>, <&dmac2 0x40>;
+ dma-names = "tx", "rx", "tx", "rx";
+ power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+ resets = <&cpg 211>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ msiof1: spi@e6ea {
+ compatible = "renesas,msiof-r8a77995",
+"renesas,rcar-gen3-msiof";
+ reg = <0 0xe6ea 0 0x0064>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 210>;
+ clock-names = "msiof_clk";
+ dmas = <&dmac1 0x43>, <&dmac1 0x42>,
+ <&dmac2 0x43>, <&dmac2 0x42>;
+ dma-names = "tx", "rx", "tx", "rx";
+ power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+ resets = <&cpg 210>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ msiof2: spi@e6c0 {
+ compatible = "renesas,msiof-r8a77995",
+"renesas,rcar-gen3-msiof";
+ reg = <0 0xe6c0 0 0x0064>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 209>;
+ clock-names = "msiof_clk";
+ dmas = <&dmac0 0x45>, <&dmac0 0x44>;
+ dma-names = "tx", "rx";
+ power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+ resets = <&cpg 209>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ msiof3: spi@e6c1 {
+ compatible = "renesas,msiof-r8a77995",
+"renesas,rcar-gen3-msiof";
+ reg = <0 0xe6c1 0 0x0064>;
+ interrupts = ;
+ clocks = <&cpg CPG_MOD 208>;
+ clock-names = "msiof_clk";
+ dmas = <&dmac0 0x47>, <&dmac0 0x46>;
+ dma-names = "tx", "rx";
+ power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
+ resets = <&cpg 208>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
timer {
--
2.7.4
