Re: [PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Hi Ramesh,

On Tue, Jan 17, 2017 at 3:00 PM, Ramesh Shanmugasundaram
 wrote:
>> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
>> @@ -166,6 +166,9 @@
>> <0x0 0xf106 0 0x2>;
>>   interrupts = >   (GIC_CPU_MASK_SIMPLE(4) |
>> IRQ_TYPE_LEVEL_HIGH)>;
>> + clocks = < CPG_MOD 408>;
>> + clock-names = "clk";
>
> Should the module clock be named "fck"?

Not according to
Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt.

P.S. If you use "git blame", you may think I'm cheating, but naming was
 ased on the actual Technical Reference Manuals ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

RE: [PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain

[Ramesh Shanmugasundaram]

Hi Geert,

> Subject: [PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock
> domain
> 
> Link the ARM GIC to the INTC-AP module clock, and add it to the SYSC
> "always-on" PM Domain, so it can be power managed using that clock.
> 
> Note that currently the GIC-400 driver doesn't support module clocks nor
> Runtime PM, so this must be handled as a critical clock.
> 
> Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>
> ---
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> index 026a16ac41b422a1..0627df2a0b810c86 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> @@ -166,6 +166,9 @@
> <0x0 0xf106 0 0x2>;
>   interrupts =(GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_HIGH)>;
> + clocks = < CPG_MOD 408>;
> + clock-names = "clk";

Should the module clock be named "fck"?

Thanks,
Ramesh

[PATCH 3/4] arm64: dts: r8a7795: Link ARM GIC to clock and clock domain

[Geert Uytterhoeven]

Link the ARM GIC to the INTC-AP module clock, and add it to the SYSC
"always-on" PM Domain, so it can be power managed using that clock.

Note that currently the GIC-400 driver doesn't support module clocks nor
Runtime PM, so this must be handled as a critical clock.

Signed-off-by: Geert Uytterhoeven 
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi 
b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 026a16ac41b422a1..0627df2a0b810c86 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -166,6 +166,9 @@
  <0x0 0xf106 0 0x2>;
interrupts = ;
+   clocks = < CPG_MOD 408>;
+   clock-names = "clk";
+   power-domains = < R8A7795_PD_ALWAYS_ON>;
};
 
wdt0: watchdog@e602 {
-- 
1.9.1