Re: [PATCH 4/4] arm64: dts: r8a7795: salvator: add serial console pins

[Geert Uytterhoeven]

Hi Ulrich,

On Tue, Jun 28, 2016 at 11:34 AM, Ulrich Hecht
 wrote:
> Adds pin control for SCIF2.
>
> Signed-off-by: Ulrich Hecht 
> ---
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 9 +
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts 
> b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> index 9c52613..10fceaf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -31,11 +31,20 @@
> };
>  };
>
> + {
> +   scif2_pins: scif2 {
> +   groups = "scif2_data_a";
> +   function = "scif2";
> +   };

Given the driver configures the SCIF to use scif_clk for 115200 bps, I think
you should add support for the scif_clk pins, too. Currently it relies on the
boot loader having configured pinctrl for scif_clk.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 4/4] arm64: dts: r8a7795: salvator: add serial console pins

[Ulrich Hecht]

That should have said r8a7796, of course... :(

CU
Uli

On Tue, Jun 28, 2016 at 11:34 AM, Ulrich Hecht
 wrote:
> Adds pin control for SCIF2.
>
> Signed-off-by: Ulrich Hecht 
> ---
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 9 +
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts 
> b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> index 9c52613..10fceaf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
> @@ -31,11 +31,20 @@
> };
>  };
>
> + {
> +   scif2_pins: scif2 {
> +   groups = "scif2_data_a";
> +   function = "scif2";
> +   };
> +};
> +
>  _clk {
> clock-frequency = <1666>;
>  };
>
>   {
> +   pinctrl-0 = <_pins>;
> +   pinctrl-names = "default";
> status = "okay";
>  };
>
> --
> 2.7.4
>

[PATCH 4/4] arm64: dts: r8a7795: salvator: add serial console pins

[Ulrich Hecht]

Adds pin control for SCIF2.

Signed-off-by: Ulrich Hecht 
---
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts | 9 +
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts 
b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
index 9c52613..10fceaf 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts
@@ -31,11 +31,20 @@
};
 };
 
+ {
+   scif2_pins: scif2 {
+   groups = "scif2_data_a";
+   function = "scif2";
+   };
+};
+
 _clk {
clock-frequency = <1666>;
 };
 
  {
+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
status = "okay";
 };
 
-- 
2.7.4