Re: [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms

[Laurent Pinchart]

Hi Ulrich,

Thank you for the patch.

On Thursday, 15 March 2018 16:45:37 EET Ulrich Hecht wrote:
> Add is_i915_device() requirement to tests using Intel-specific APIs.
> 
> Signed-off-by: Ulrich Hecht 

Reviewed-by: Laurent Pinchart 

> ---
>  tests/kms_addfb_basic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 7d8852f..cf9ba37 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -104,6 +104,7 @@ static void invalid_tests(int fd)
>   }
> 
>   igt_subtest("clobberred-modifier") {
> + igt_require(is_i915_device(fd));
>   f.flags = 0;
>   f.modifier[0] = 0;
>   gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);
> @@ -318,6 +319,7 @@ static void size_tests(int fd)
>   }
> 
>   igt_subtest("bo-too-small-due-to-tiling") {
> + igt_require(is_i915_device(fd));
>   gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
>   igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
>  errno == EINVAL);
> @@ -369,6 +371,7 @@ static void addfb25_tests(int fd)
> 
>   igt_subtest_group {
>   igt_fixture {
> + igt_require(is_i915_device(fd));
>   gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
>   igt_require_fb_modifiers(fd);
>   }


-- 
Regards,

Laurent Pinchart

Re: [Intel-gfx] [PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms

[Daniel Vetter]

On Thu, Mar 15, 2018 at 03:45:37PM +0100, Ulrich Hecht wrote:
> Add is_i915_device() requirement to tests using Intel-specific APIs.
> 
> Signed-off-by: Ulrich Hecht 

Reviewed-by: Daniel Vetter 

> ---
>  tests/kms_addfb_basic.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 7d8852f..cf9ba37 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -104,6 +104,7 @@ static void invalid_tests(int fd)
>   }
>  
>   igt_subtest("clobberred-modifier") {
> + igt_require(is_i915_device(fd));
>   f.flags = 0;
>   f.modifier[0] = 0;
>   gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);
> @@ -318,6 +319,7 @@ static void size_tests(int fd)
>   }
>  
>   igt_subtest("bo-too-small-due-to-tiling") {
> + igt_require(is_i915_device(fd));
>   gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
>   igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
>  errno == EINVAL);
> @@ -369,6 +371,7 @@ static void addfb25_tests(int fd)
>  
>   igt_subtest_group {
>   igt_fixture {
> + igt_require(is_i915_device(fd));
>   gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
>   igt_require_fb_modifiers(fd);
>   }
> -- 
> 2.7.4
> 
> ___
> Intel-gfx mailing list
> intel-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[PATCH igt 1/8] tests/kms_addfb_basic: skip i915-specific tests on other platforms

[Ulrich Hecht]

Add is_i915_device() requirement to tests using Intel-specific APIs.

Signed-off-by: Ulrich Hecht 
---
 tests/kms_addfb_basic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 7d8852f..cf9ba37 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -104,6 +104,7 @@ static void invalid_tests(int fd)
}
 
igt_subtest("clobberred-modifier") {
+   igt_require(is_i915_device(fd));
f.flags = 0;
f.modifier[0] = 0;
gem_set_tiling(fd, gem_bo, I915_TILING_X, 512*4);
@@ -318,6 +319,7 @@ static void size_tests(int fd)
}
 
igt_subtest("bo-too-small-due-to-tiling") {
+   igt_require(is_i915_device(fd));
gem_set_tiling(fd, gem_bo_small, I915_TILING_X, 1024*4);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
   errno == EINVAL);
@@ -369,6 +371,7 @@ static void addfb25_tests(int fd)
 
igt_subtest_group {
igt_fixture {
+   igt_require(is_i915_device(fd));
gem_set_tiling(fd, gem_bo, I915_TILING_X, 1024*4);
igt_require_fb_modifiers(fd);
}
-- 
2.7.4