Re: [PATCH v2] arm64: dts: r8a77965: Add SATA controller node

2018-08-09 Thread Simon Horman 
On Thu, Aug 02, 2018 at 01:31:52PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Thu, Aug 2, 2018 at 1:13 PM Simon Horman  wrote:
> > On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote:
> > > From: Takeshi Kihara 
> > > This patch adds SATA controller node for the R8A77965 SoC.
> > >
> > > Signed-off-by: Takeshi Kihara 
> > > [wsa: rebased to upstream base]
> > > Reviewed-by: Geert Uytterhoeven 
> > > Signed-off-by: Wolfram Sang 
> > > ---
> > >
> > > Changes since v1:
> > >   * sorted it according to address (Thanks, Geert!)
> > >   * added Geert's tag
> > >
> > >  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> > > b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > > index 0cd44461a0bd..bf22efb82cbf 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > > @@ -1507,6 +1507,17 @@
> > >   status = "disabled";
> > >   };
> > >
> > > + sata: sata@ee30 {
> > > + compatible = "renesas,sata-r8a77965",
> > > +  "renesas,rcar-gen3-sata";
> > > + reg = <0 0xee30 0 0x20>;
> > > + interrupts = ;
> > > + clocks = < CPG_MOD 815>;
> > > + power-domains = < R8A77965_PD_ALWAYS_ON>;
> > > + resets = < 815>;
> > > + status = "disabled";
> >
> > Is it intentional that there is no iommus property here?
> 
> Because none of the other device nodes have iommus properties yet?

That is my unstated assumption too.

I've gone ahead and applied this patch for v4.20.

Re: [PATCH v2] arm64: dts: r8a77965: Add SATA controller node

2018-08-02 Thread Geert Uytterhoeven 
Hi Simon,

On Thu, Aug 2, 2018 at 1:13 PM Simon Horman  wrote:
> On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote:
> > From: Takeshi Kihara 
> > This patch adds SATA controller node for the R8A77965 SoC.
> >
> > Signed-off-by: Takeshi Kihara 
> > [wsa: rebased to upstream base]
> > Reviewed-by: Geert Uytterhoeven 
> > Signed-off-by: Wolfram Sang 
> > ---
> >
> > Changes since v1:
> >   * sorted it according to address (Thanks, Geert!)
> >   * added Geert's tag
> >
> >  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> > b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > index 0cd44461a0bd..bf22efb82cbf 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> > @@ -1507,6 +1507,17 @@
> >   status = "disabled";
> >   };
> >
> > + sata: sata@ee30 {
> > + compatible = "renesas,sata-r8a77965",
> > +  "renesas,rcar-gen3-sata";
> > + reg = <0 0xee30 0 0x20>;
> > + interrupts = ;
> > + clocks = < CPG_MOD 815>;
> > + power-domains = < R8A77965_PD_ALWAYS_ON>;
> > + resets = < 815>;
> > + status = "disabled";
>
> Is it intentional that there is no iommus property here?

Because none of the other device nodes have iommus properties yet?

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH v2] arm64: dts: r8a77965: Add SATA controller node

2018-08-02 Thread Simon Horman 
On Mon, Jul 30, 2018 at 09:33:38AM +0200, Wolfram Sang wrote:
> From: Takeshi Kihara 
> 
> This patch adds SATA controller node for the R8A77965 SoC.
> 
> Signed-off-by: Takeshi Kihara 
> [wsa: rebased to upstream base]
> Reviewed-by: Geert Uytterhoeven 
> Signed-off-by: Wolfram Sang 
> ---
> 
> Changes since v1:
>   * sorted it according to address (Thanks, Geert!)
>   * added Geert's tag
> 
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> index 0cd44461a0bd..bf22efb82cbf 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1507,6 +1507,17 @@
>   status = "disabled";
>   };
>  
> + sata: sata@ee30 {
> + compatible = "renesas,sata-r8a77965",
> +  "renesas,rcar-gen3-sata";
> + reg = <0 0xee30 0 0x20>;
> + interrupts = ;
> + clocks = < CPG_MOD 815>;
> + power-domains = < R8A77965_PD_ALWAYS_ON>;
> + resets = < 815>;
> + status = "disabled";

Is it intentional that there is no iommus property here?

> + };
> +
>   gic: interrupt-controller@f101 {
>   compatible = "arm,gic-400";
>   #interrupt-cells = <3>;
> -- 
> 2.11.0
>

[PATCH v2] arm64: dts: r8a77965: Add SATA controller node

2018-07-30 Thread Wolfram Sang 
From: Takeshi Kihara 

This patch adds SATA controller node for the R8A77965 SoC.

Signed-off-by: Takeshi Kihara 
[wsa: rebased to upstream base]
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Wolfram Sang 
---

Changes since v1:
* sorted it according to address (Thanks, Geert!)
* added Geert's tag

 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 0cd44461a0bd..bf22efb82cbf 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1507,6 +1507,17 @@
status = "disabled";
};
 
+   sata: sata@ee30 {
+   compatible = "renesas,sata-r8a77965",
+"renesas,rcar-gen3-sata";
+   reg = <0 0xee30 0 0x20>;
+   interrupts = ;
+   clocks = < CPG_MOD 815>;
+   power-domains = < R8A77965_PD_ALWAYS_ON>;
+   resets = < 815>;
+   status = "disabled";
+   };
+
gic: interrupt-controller@f101 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;
-- 
2.11.0