Re: [PATCH v5 4/6] pinctrl: sh-pfc: r8a7792: Fix VIN versioned groups

[Geert Uytterhoeven]

Hi Jacopo,

On Thu, Nov 8, 2018 at 5:07 PM Jacopo Mondi  wrote:
> Versioned VIN groups can appear on different sets of pins. Use of the
> VIN_DATA_PIN_GROUP macro fix naming of said groups through an optional
> 'version' argument.

I more liked the description from the previous version, which you retained
in PATCH 6/6, so I used that ;-)

> Use the 'version' argument for said macro to fix naming of versioned
> groups for R-Car V2H R8A7792 SoC.
>
> Fixes: 7dd74bb1f058 ("pinctrl: sh-pfc: r8a7792: Add VIN pin groups")
> Reviewed-by: Simon Horman 
> Reviewed-by: Geert Uytterhoeven 
> Signed-off-by: Jacopo Mondi 

Queuing in sh-pfc-for-v4.21.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH v5 4/6] pinctrl: sh-pfc: r8a7792: Fix VIN versioned groups

[Jacopo Mondi]

Versioned VIN groups can appear on different sets of pins. Use of the
VIN_DATA_PIN_GROUP macro fix naming of said groups through an optional
'version' argument.

Use the 'version' argument for said macro to fix naming of versioned
groups for R-Car V2H R8A7792 SoC.

Fixes: 7dd74bb1f058 ("pinctrl: sh-pfc: r8a7792: Add VIN pin groups")
Reviewed-by: Simon Horman 
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Jacopo Mondi 

---
v4 -> v5:
- Broke out r8a7792 from single patch

---
 drivers/pinctrl/sh-pfc/pfc-r8a7792.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7792.c 
b/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
index e977121b433b..a623459b234e 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
@@ -1744,10 +1744,10 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
VIN_DATA_PIN_GROUP(vin1_data, 12),
VIN_DATA_PIN_GROUP(vin1_data, 10),
VIN_DATA_PIN_GROUP(vin1_data, 8),
-   VIN_DATA_PIN_GROUP(vin1_data_b, 24),
-   VIN_DATA_PIN_GROUP(vin1_data_b, 20),
+   VIN_DATA_PIN_GROUP(vin1_data, 24, _b),
+   VIN_DATA_PIN_GROUP(vin1_data, 20, _b),
SH_PFC_PIN_GROUP(vin1_data18_b),
-   VIN_DATA_PIN_GROUP(vin1_data_b, 16),
+   VIN_DATA_PIN_GROUP(vin1_data, 16, _b),
SH_PFC_PIN_GROUP(vin1_sync),
SH_PFC_PIN_GROUP(vin1_field),
SH_PFC_PIN_GROUP(vin1_clkenb),
--
2.7.4