Re: [PATCH v5 5/6] pinctrl: sh-pfc: r8a7795: Fix VIN versioned groups

[Geert Uytterhoeven]

Hi Jacopo,

On Thu, Nov 8, 2018 at 5:07 PM Jacopo Mondi  wrote:
> Versioned VIN groups can appear on different sets of pins. Use of the
> VIN_DATA_PIN_GROUP macro fix naming of said groups through an optional
> 'version' argument.

I more liked the description from the previous version, which you retained
for PATCH 6/6, so I used that ;-)

> Use the 'version' argument for said macro to fix naming of versioned
> groups for R-Car H3 R8A7795 SoC.
>
> Fixes: 9942a5b52990 ("pinctrl: sh-pfc: r8a7795: Deduplicate VIN4 pin 
> definitions")
> Reviewed-by: Simon Horman 
> Reviewed-by: Geert Uytterhoeven 
> Signed-off-by: Jacopo Mondi 

Queueing in sh-pfc-for-v4.21.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH v5 5/6] pinctrl: sh-pfc: r8a7795: Fix VIN versioned groups

[Jacopo Mondi]

Versioned VIN groups can appear on different sets of pins. Use of the
VIN_DATA_PIN_GROUP macro fix naming of said groups through an optional
'version' argument.

Use the 'version' argument for said macro to fix naming of versioned
groups for R-Car H3 R8A7795 SoC.

Fixes: 9942a5b52990 ("pinctrl: sh-pfc: r8a7795: Deduplicate VIN4 pin 
definitions")
Reviewed-by: Simon Horman 
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Jacopo Mondi 

---
v4 -> v5:
- Broke out r8a7795 from single patch

---
 drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c 
b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
index 0af737d11403..20fac0fde91a 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795.c
@@ -4474,20 +4474,20 @@ static const struct sh_pfc_pin_group pinmux_groups[] = {
SH_PFC_PIN_GROUP(usb2),
SH_PFC_PIN_GROUP(usb2_ch3),
SH_PFC_PIN_GROUP(usb30),
-   VIN_DATA_PIN_GROUP(vin4_data_a, 8),
-   VIN_DATA_PIN_GROUP(vin4_data_a, 10),
-   VIN_DATA_PIN_GROUP(vin4_data_a, 12),
-   VIN_DATA_PIN_GROUP(vin4_data_a, 16),
+   VIN_DATA_PIN_GROUP(vin4_data, 8, _a),
+   VIN_DATA_PIN_GROUP(vin4_data, 10, _a),
+   VIN_DATA_PIN_GROUP(vin4_data, 12, _a),
+   VIN_DATA_PIN_GROUP(vin4_data, 16, _a),
SH_PFC_PIN_GROUP(vin4_data18_a),
-   VIN_DATA_PIN_GROUP(vin4_data_a, 20),
-   VIN_DATA_PIN_GROUP(vin4_data_a, 24),
-   VIN_DATA_PIN_GROUP(vin4_data_b, 8),
-   VIN_DATA_PIN_GROUP(vin4_data_b, 10),
-   VIN_DATA_PIN_GROUP(vin4_data_b, 12),
-   VIN_DATA_PIN_GROUP(vin4_data_b, 16),
+   VIN_DATA_PIN_GROUP(vin4_data, 20, _a),
+   VIN_DATA_PIN_GROUP(vin4_data, 24, _a),
+   VIN_DATA_PIN_GROUP(vin4_data, 8, _b),
+   VIN_DATA_PIN_GROUP(vin4_data, 10, _b),
+   VIN_DATA_PIN_GROUP(vin4_data, 12, _b),
+   VIN_DATA_PIN_GROUP(vin4_data, 16, _b),
SH_PFC_PIN_GROUP(vin4_data18_b),
-   VIN_DATA_PIN_GROUP(vin4_data_b, 20),
-   VIN_DATA_PIN_GROUP(vin4_data_b, 24),
+   VIN_DATA_PIN_GROUP(vin4_data, 20, _b),
+   VIN_DATA_PIN_GROUP(vin4_data, 24, _b),
SH_PFC_PIN_GROUP(vin4_sync),
SH_PFC_PIN_GROUP(vin4_field),
SH_PFC_PIN_GROUP(vin4_clkenb),
--
2.7.4