Re: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling
Hi, On Tuesday 23 February 2016 11:54 AM, Yoshihiro Shimoda wrote: > Hi Kishon, > > Would you review this patch? merged it now. Thanks for reminding. -Kishon > > I checked the latest linux-phy.git / next branch today, > this patch can be applied on the top of branch. > > commit 6b825eb7323a634cdd1014a4aa9a8ff07cf8040c > Author: Heiko Stuebner <he...@sntech.de> > Date: Mon Feb 22 12:55:01 2016 +0100 > > phy: rockchip-usb: add handler for usb-uart functionality > > Best regards, > Yoshihiro Shimoda > >> -Original Message- >> From: Yoshihiro Shimoda >> Sent: Tuesday, February 02, 2016 5:29 PM >> To: kis...@ti.com >> Cc: pawel.m...@arm.com; mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk; >> ga...@codeaurora.org; >> linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; >> linux...@vger.kernel.org; 'Rob Herring' <r...@kernel.org>; >> linux-renesas-soc@vger.kernel.org >> Subject: RE: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling >> >> Hi Kishon, >> >> Would you review this patch? >> I checked the latest linux-phy.git / next branch today, and it is the same >> as the following. >> >>>> This patch is based on the linux-phy / next branch. >>>> (commit id = 9955a7835bf376e12482583958b2661f501b868b) >> >> Best regards, >> Yoshihiro Shimoda >> >>> From: Rob Herring [mailto:r...@kernel.org] >>> Sent: Sunday, January 10, 2016 7:33 AM >>> To: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> >>> Cc: kis...@ti.com; pawel.m...@arm.com; mark.rutl...@arm.com; >>> ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; >>> linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; >>> linux...@vger.kernel.org >>> Subject: Re: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling >>> >>> On Thu, Jan 07, 2016 at 06:16:44PM +0900, Yoshihiro Shimoda wrote: >>>> Since the related driver (CPG/MSSR driver) only manages the first module >>>> clock, this driver should not handle the HSUSB registers. So, this patch >>>> removes the HSUSB registers handling. >>>> >>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> >>>> --- >>>> This patch is based on the linux-phy / next branch. >>>> (commit id = 9955a7835bf376e12482583958b2661f501b868b) >>>> >>>> .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 15 ++-- >>> >>> Acked-by: Rob Herring <r...@kernel.org> >>> >>>> drivers/phy/phy-rcar-gen3-usb2.c | 83 >>>> +++--- >>>> 2 files changed, 15 insertions(+), 83 deletions(-) >>> >
RE: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling
Hi Kishon, Would you review this patch? I checked the latest linux-phy.git / next branch today, this patch can be applied on the top of branch. commit 6b825eb7323a634cdd1014a4aa9a8ff07cf8040c Author: Heiko Stuebner <he...@sntech.de> Date: Mon Feb 22 12:55:01 2016 +0100 phy: rockchip-usb: add handler for usb-uart functionality Best regards, Yoshihiro Shimoda > -Original Message- > From: Yoshihiro Shimoda > Sent: Tuesday, February 02, 2016 5:29 PM > To: kis...@ti.com > Cc: pawel.m...@arm.com; mark.rutl...@arm.com; ijc+devicet...@hellion.org.uk; > ga...@codeaurora.org; > linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; > linux...@vger.kernel.org; 'Rob Herring' <r...@kernel.org>; > linux-renesas-soc@vger.kernel.org > Subject: RE: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling > > Hi Kishon, > > Would you review this patch? > I checked the latest linux-phy.git / next branch today, and it is the same as > the following. > > > > This patch is based on the linux-phy / next branch. > > > (commit id = 9955a7835bf376e12482583958b2661f501b868b) > > Best regards, > Yoshihiro Shimoda > > > From: Rob Herring [mailto:r...@kernel.org] > > Sent: Sunday, January 10, 2016 7:33 AM > > To: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > > Cc: kis...@ti.com; pawel.m...@arm.com; mark.rutl...@arm.com; > > ijc+devicet...@hellion.org.uk; ga...@codeaurora.org; > > linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; > > linux...@vger.kernel.org > > Subject: Re: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling > > > > On Thu, Jan 07, 2016 at 06:16:44PM +0900, Yoshihiro Shimoda wrote: > > > Since the related driver (CPG/MSSR driver) only manages the first module > > > clock, this driver should not handle the HSUSB registers. So, this patch > > > removes the HSUSB registers handling. > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > > > --- > > > This patch is based on the linux-phy / next branch. > > > (commit id = 9955a7835bf376e12482583958b2661f501b868b) > > > > > > .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 15 ++-- > > > > Acked-by: Rob Herring <r...@kernel.org> > > > > > drivers/phy/phy-rcar-gen3-usb2.c | 83 > > > +++--- > > > 2 files changed, 15 insertions(+), 83 deletions(-) > >
Re: [PATCH] phy: rcar-gen3-usb2: remove HSUSB registers handling
Hi Shimoda-san, [dropping most CCs to avoid delaying your patch] On Thu, Jan 7, 2016 at 10:16 AM, Yoshihiro Shimodawrote: > Since the related driver (CPG/MSSR driver) only manages the first module > clock, this driver should not handle the HSUSB registers. So, this patch > removes the HSUSB registers handling. > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > Example (R-Car H3): > > usb-phy@ee080200 { > compatible = "renesas,usb2-phy-r8a7795"; > - reg = <0 0xee080200 0 0x700>, <0 0xe6590100 0 0x100>; > - reg-names = "usb2_host", "hsusb"; > + reg = <0 0xee080200 0 0x700>; > interrupts = ; > - clocks = <_clks R8A7795_CLK_EHCI0>, > -<_clks R8A7795_CLK_HSUSB>; > + clocks = <_clks R8A7795_CLK_EHCI0>; > }; > > usb-phy@ee0a0200 { > compatible = "renesas,usb2-phy-r8a7795"; > reg = <0 0xee0a0200 0 0x700>; > - reg-names = "usb2_host"; > clocks = <_clks R8A7795_CLK_EHCI0>; > }; BTW, I think the examples should be updated to use the CPG/MSSR DT bindings. That can/should be done in a separate patch, of course. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds