Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions
On Mon, Nov 5, 2018 at 10:40 PM Marek Vasut wrote:
> From: Takeshi Kihara
>
> This patch adds SDHI{0,1,3} pins, groups and functions to the R8A77990
> SoC.
>
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Marek Vasut
Reviewed-by: Geert Uytterhoeven
i.e. will queue in sh-pfc-for-v4.21.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions
On 11/06/2018 12:14 PM, Wolfram Sang wrote:
>
>> static const struct {
>> -struct sh_pfc_pin_group common[123];
>> +struct sh_pfc_pin_group common[140];
>> struct sh_pfc_pin_group automotive[0];
>> } pinmux_groups = {
>
> ...
>
>> static const struct {
>> -struct sh_pfc_function common[29];
>> +struct sh_pfc_function common[32];
>> struct sh_pfc_function automotive[0];
>> } pinmux_functions = {
>
>
> It is Geert's call, but maybe those are a seperate patch?
These must be part of this patch, since adding
+ SH_PFC_PIN_GROUP(sdhi0_data1),
entries grows the size of the array. If you were to split this patch,
the PFC driver would break, as the size of the array won't match the
size of the content.
--
Best regards,
Marek Vasut
Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions
> static const struct {
> - struct sh_pfc_pin_group common[123];
> + struct sh_pfc_pin_group common[140];
> struct sh_pfc_pin_group automotive[0];
> } pinmux_groups = {
...
> static const struct {
> - struct sh_pfc_function common[29];
> + struct sh_pfc_function common[32];
> struct sh_pfc_function automotive[0];
> } pinmux_functions = {
It is Geert's call, but maybe those are a seperate patch?
signature.asc
Description: PGP signature
RE: [PATCH 1/2] pinctrl: sh-pfc: r8a77990: Add SDHI pins, groups and functions
Hello Marek-san,
> From: Marek Vasut, Sent: Tuesday, November 6, 2018 6:40 AM
>
> From: Takeshi Kihara
>
> This patch adds SDHI{0,1,3} pins, groups and functions to the R8A77990
> SoC.
>
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Marek Vasut
> Cc: Geert Uytterhoeven
> Cc: Simon Horman
> Cc: Wolfram Sang
> Cc: Yoshihiro Shimoda
> Cc: linux-renesas-soc@vger.kernel.org
> ---
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda
Best regards,
Yoshihiro Shimoda
