Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

2018-04-30 Thread Simon Horman 
On Thu, Apr 26, 2018 at 12:29:47PM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Monday, 23 April 2018 14:07:14 EEST Simon Horman wrote:
> > On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote:
> > > The r8a7790 has three FDP1 instances.
> > > 
> > > Signed-off-by: Laurent Pinchart
> > > 
> > 
> > Hi Laurent,
> > 
> > could you rearrange these nodes so they preserve the sorting
> > of sub-nodes of the soc node by bus address. The other patches
> > in the series seem fine in this regards and I have applied them.
> 
> I would have if you hadn't merged the patch already :-) Would you like me to 
> submit a follow-up patch ?

Sorry about that. Yes, please submit a follow-up patch.

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

2018-04-26 Thread Laurent Pinchart 
Hi Simon,

On Monday, 23 April 2018 14:07:14 EEST Simon Horman wrote:
> On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote:
> > The r8a7790 has three FDP1 instances.
> > 
> > Signed-off-by: Laurent Pinchart
> > 
> 
> Hi Laurent,
> 
> could you rearrange these nodes so they preserve the sorting
> of sub-nodes of the soc node by bus address. The other patches
> in the series seem fine in this regards and I have applied them.

I would have if you hadn't merged the patch already :-) Would you like me to 
submit a follow-up patch ?

-- 
Regards,

Laurent Pinchart

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

2018-04-26 Thread Simon Horman 
On Tue, Apr 24, 2018 at 05:01:29PM +0200, Geert Uytterhoeven wrote:
> On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
>  wrote:
> > The r8a7790 has three FDP1 instances.
> >
> > Signed-off-by: Laurent Pinchart 
> 
> Reviewed-by: Geert Uytterhoeven 

Thanks, applied.

> 
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -1606,6 +1606,33 @@
> > resets = < 128>;
> > };
> >
> > +   fdp1@fe94 {
> 
> Just wondering: should we go for "display-processor@foo"?
> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds
>

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

2018-04-24 Thread Geert Uytterhoeven 
On Sun, Apr 22, 2018 at 12:35 PM, Laurent Pinchart
 wrote:
> The r8a7790 has three FDP1 instances.
>
> Signed-off-by: Laurent Pinchart 

Reviewed-by: Geert Uytterhoeven 

> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1606,6 +1606,33 @@
> resets = < 128>;
> };
>
> +   fdp1@fe94 {

Just wondering: should we go for "display-processor@foo"?

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/4] ARM: dts: renesas: r8a7790: Add FDP1 instances

2018-04-23 Thread Simon Horman 
On Sun, Apr 22, 2018 at 01:35:25PM +0300, Laurent Pinchart wrote:
> The r8a7790 has three FDP1 instances.
> 
> Signed-off-by: Laurent Pinchart 

Hi Laurent,

could you rearrange these nodes so they preserve the sorting
of sub-nodes of the soc node by bus address. The other patches
in the series seem fine in this regards and I have applied them.