Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

[Sergei Shtylyov]

Hello!

On 08/14/2017 05:15 PM, Geert Uytterhoeven wrote:


From: Wolfram Sang [mailto:w...@the-dreams.de]
Sent: 10 August 2017 12:24



+i2c6: i2c@e60b {


I'd use iic0 as the label.


Sergei: I assume you meant "iic3"? ;-)


   After having a look at the manual, yes. :-)

[...]


Gr{oetje,eeting}s,

 Geert


MBR, Sergei

Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

[Geert Uytterhoeven]

On Thu, Aug 10, 2017 at 3:49 PM, Chris Paterson
 wrote:
>> From: Wolfram Sang [mailto:w...@the-dreams.de]
>> Sent: 10 August 2017 12:24
>>
>>
>> > > >+i2c6: i2c@e60b {
>> > >
>> > >I'd use iic0 as the label.

Sergei: I assume you meant "iic3"? ;-)

>> >
>> > I have no preference here other than that we try to be consistent in
>> > DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
>>
>> Back then, for M2-W, I decided to go with the schematics/datasheets.
>> And those mentioned i2c6 rather than iic0. For that reason, the comment
>
> The M2 schematics still use i2c6, and for consistency I'd vote to use the 
> same with RZ/G1M.
>
>>
>> "/* The memory map in the User's Manual maps the cores to bus numbers */"
>>
>> exists in r8a7791.dtsi. Dunno the manual of this SoC here.
>
> The manual for r8a7743 uses the same terminology as the r8a7791 manuals.

The pinctrl section does, indeed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

[Simon Horman]

On Thu, Aug 10, 2017 at 01:49:05PM +, Chris Paterson wrote:
> Hello,
> 
> > From: Wolfram Sang [mailto:w...@the-dreams.de]
> > Sent: 10 August 2017 12:24
> > 
> > 
> > > > >+  i2c6: i2c@e60b {
> > > >
> > > >I'd use iic0 as the label.
> > >
> > > I have no preference here other than that we try to be consistent in
> > > DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
> > 
> > Back then, for M2-W, I decided to go with the schematics/datasheets.
> > And those mentioned i2c6 rather than iic0. For that reason, the comment
> 
> The M2 schematics still use i2c6, and for consistency I'd vote to use the 
> same with RZ/G1M.

+1

> > "/* The memory map in the User's Manual maps the cores to bus numbers */"
> > 
> > exists in r8a7791.dtsi. Dunno the manual of this SoC here.
> 
> The manual for r8a7743 uses the same terminology as the r8a7791 manuals.

RE: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

[Chris Paterson]

Hello,

> From: Wolfram Sang [mailto:w...@the-dreams.de]
> Sent: 10 August 2017 12:24
> 
> 
> > > >+i2c6: i2c@e60b {
> > >
> > >I'd use iic0 as the label.
> >
> > I have no preference here other than that we try to be consistent in
> > DT for different R-Car SoCs. Wolfram, do you have an opinion on this?
> 
> Back then, for M2-W, I decided to go with the schematics/datasheets.
> And those mentioned i2c6 rather than iic0. For that reason, the comment

The M2 schematics still use i2c6, and for consistency I'd vote to use the same 
with RZ/G1M.

> 
> "/* The memory map in the User's Manual maps the cores to bus numbers */"
> 
> exists in r8a7791.dtsi. Dunno the manual of this SoC here.

The manual for r8a7743 uses the same terminology as the r8a7791 manuals.

Kind regards, Chris

Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

[Simon Horman]

On Wed, Aug 09, 2017 at 12:17:06PM +0300, Sergei Shtylyov wrote:
> On 8/8/2017 3:46 PM, Biju Das wrote:
> 
> >Signed-off-by: Biju Das 
> >---
> >This patch has been tested against Linux-next tag 20170727 and renesas-dev 
> >branch.
> >This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html
> >
> >  arch/arm/boot/dts/r8a7743.dtsi | 55 
> > ++
> >  1 file changed, 55 insertions(+)
> >
> >diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> >index 14222c72..5c2b140 100644
> >--- a/arch/arm/boot/dts/r8a7743.dtsi
> >+++ b/arch/arm/boot/dts/r8a7743.dtsi
> [...]
> >@@ -436,6 +439,58 @@
> > status = "disabled";
> > };
> >+i2c6: i2c@e60b {
> 
>I'd use iic0 as the label.

I have no preference here other than that we try to be consistent
in DT for different R-Car SoCs. Wolfram, do you have an opinion on this?

> 
> >+/* doesn't need pinmux */
> >+#address-cells = <1>;
> >+#size-cells = <0>;
> >+compatible = "renesas,iic-r8a7743",
> >+ "renesas,rcar-gen2-iic",
> >+ "renesas,rmobile-iic";
> >+reg = <0 0xe60b 0 0x425>;
> >+interrupts = ;
> >+clocks = < CPG_MOD 926>;
> >+dmas = < 0x77>, < 0x78>,
> >+   < 0x77>, < 0x78>;
> >+dma-names = "tx", "rx", "tx", "rx";
> >+power-domains = < R8A7743_PD_ALWAYS_ON>;
> >+resets = < CPG_MOD 926>;
> 
>CPG_MOD not needed here, it's not a "clocks" prop.
> 
> [...]
> 
> MBR, Sergei
> 

RE: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

[Biju Das]

> -Original Message-
> From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
> Sent: 09 August 2017 10:17
> To: Biju Das <biju@bp.renesas.com>; Rob Herring <robh...@kernel.org>;
> Mark Rutland <mark.rutl...@arm.com>
> Cc: Simon Horman <ho...@verge.net.au>; Wolfram Sang <wsa@the-
> dreams.de>; Magnus Damm <magnus.d...@gmail.com>; Russell King
> <li...@armlinux.org.uk>; Chris Paterson <chris.paters...@renesas.com>;
> devicet...@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org
> Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi
>
> On 8/8/2017 3:46 PM, Biju Das wrote:
>
> > Signed-off-by: Biju Das <biju@bp.renesas.com>
> > ---
> > This patch has been tested against Linux-next tag 20170727 and renesas-dev
> branch.
> > This patch depends on
> > https://www.spinics.net/lists/arm-kernel/msg599220.html
> >
> >   arch/arm/boot/dts/r8a7743.dtsi | 55
> ++
> >   1 file changed, 55 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7743.dtsi
> > b/arch/arm/boot/dts/r8a7743.dtsi index 14222c72..5c2b140 100644
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> [...]
> > @@ -436,6 +439,58 @@
> >   status = "disabled";
> >   };
> >
> > +i2c6: i2c@e60b {
>
> I'd use iic0 as the label.
>
> > +/* doesn't need pinmux */
> > +#address-cells = <1>;
> > +#size-cells = <0>;
> > +compatible = "renesas,iic-r8a7743",
> > + "renesas,rcar-gen2-iic",
> > + "renesas,rmobile-iic";
> > +reg = <0 0xe60b 0 0x425>;
> > +interrupts = ;
> > +clocks = < CPG_MOD 926>;
> > +dmas = < 0x77>, < 0x78>,
> > +   < 0x77>, < 0x78>;
> > +dma-names = "tx", "rx", "tx", "rx";
> > +power-domains = < R8A7743_PD_ALWAYS_ON>;
> > +resets = < CPG_MOD 926>;
>
> CPG_MOD not needed here, it's not a "clocks" prop.
Thanks Sergie,  I will correct this.
[>]
> [...]
>
> MBR, Sergei



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.

Re: [PATCH 2/2] ARM: dts: r8a7743: Add IIC cores to dtsi

[Sergei Shtylyov]

On 8/8/2017 3:46 PM, Biju Das wrote:


Signed-off-by: Biju Das 
---
This patch has been tested against Linux-next tag 20170727 and renesas-dev 
branch.
This patch depends on https://www.spinics.net/lists/arm-kernel/msg599220.html

  arch/arm/boot/dts/r8a7743.dtsi | 55 ++
  1 file changed, 55 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 14222c72..5c2b140 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi

[...]

@@ -436,6 +439,58 @@
status = "disabled";
};
  
+		i2c6: i2c@e60b {


   I'd use iic0 as the label.


+   /* doesn't need pinmux */
+   #address-cells = <1>;
+   #size-cells = <0>;
+   compatible = "renesas,iic-r8a7743",
+"renesas,rcar-gen2-iic",
+"renesas,rmobile-iic";
+   reg = <0 0xe60b 0 0x425>;
+   interrupts = ;
+   clocks = < CPG_MOD 926>;
+   dmas = < 0x77>, < 0x78>,
+  < 0x77>, < 0x78>;
+   dma-names = "tx", "rx", "tx", "rx";
+   power-domains = < R8A7743_PD_ALWAYS_ON>;
+   resets = < CPG_MOD 926>;


   CPG_MOD not needed here, it's not a "clocks" prop.

[...]

MBR, Sergei