Re: [PATCH 2/3] arm64: dts: renesas: r8a7796: move nodes which have no reg property out of bus

2017-12-18 Thread Simon Horman 
On Wed, Dec 13, 2017 at 09:34:15AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Wed, Dec 13, 2017 at 9:25 AM, Simon Horman  wrote:
> > For now I've applied the following:
> >
> > From: Simon Horman 
> > Date: Tue, 12 Dec 2017 09:24:35 +0100
> > Subject: [PATCH] arm64: dts: renesas: r8a7796: move nodes which have no reg
> >  property out of bus
> >
> > Move pmu_a5[73], timer and thermal-zones nodes from soc node to root node.
> > The nodes that have been moved do not have any register properties and thus
> > shouldn't be placed on the bus.
> 
> > index c1b0d0344329..e82b4db1ad1a 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -154,6 +154,23 @@
> > clock-frequency = <0>;
> > };
> >
> > +   pmu_a57 {
> > +   compatible = "arm,cortex-a57-pmu";
> > +   interrupts-extended = < GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > +   interrupt-affinity = <_0>,
> > +<_1>;
> 
> Merge?

Sure, sorry for missing that.

> 
> > +   };
> > +
> > +   pmu_a53 {
> > +   compatible = "arm,cortex-a53-pmu";
> > +   interrupts-extended = < GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> > +   interrupt-affinity = <_0>, <_1>, <_2>, <_3>;
> 
> Thanks!
> 
> > +   };
> 
> > @@ -2027,4 +1968,56 @@
> > resets = < 822>;
> > };
> > };
> > +
> > +   timer {
> > +   compatible = "arm,armv8-timer";
> > +   interrupts-extended = < GIC_PPI 13 
> > (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
> > + < GIC_PPI 14 
> > (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
> > + < GIC_PPI 11 
> > (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
> > + < GIC_PPI 10 
> > (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>;
> 
> Much better!
> 
> Or even
> 
> > +   interrupts-extended =
> > +   < GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(6) | 
> > IRQ_TYPE_LEVEL_LOW)>,
> > +   < GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(6) | 
> > IRQ_TYPE_LEVEL_LOW)>,
> > +   < GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(6) | 
> > IRQ_TYPE_LEVEL_LOW)>,
> > +   < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(6) | 
> > IRQ_TYPE_LEVEL_LOW)>;
> 
> I don't care that much, it extends beyond 80 characters anyway.

As its over 80 characters anyway lets go with my version.

Re: [PATCH 2/3] arm64: dts: renesas: r8a7796: move nodes which have no reg property out of bus

2017-12-13 Thread Geert Uytterhoeven 
Hi Simon,

On Wed, Dec 13, 2017 at 9:25 AM, Simon Horman  wrote:
> For now I've applied the following:
>
> From: Simon Horman 
> Date: Tue, 12 Dec 2017 09:24:35 +0100
> Subject: [PATCH] arm64: dts: renesas: r8a7796: move nodes which have no reg
>  property out of bus
>
> Move pmu_a5[73], timer and thermal-zones nodes from soc node to root node.
> The nodes that have been moved do not have any register properties and thus
> shouldn't be placed on the bus.

> index c1b0d0344329..e82b4db1ad1a 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -154,6 +154,23 @@
> clock-frequency = <0>;
> };
>
> +   pmu_a57 {
> +   compatible = "arm,cortex-a57-pmu";
> +   interrupts-extended = < GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> +   interrupt-affinity = <_0>,
> +<_1>;

Merge?

> +   };
> +
> +   pmu_a53 {
> +   compatible = "arm,cortex-a53-pmu";
> +   interrupts-extended = < GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> +   interrupt-affinity = <_0>, <_1>, <_2>, <_3>;

Thanks!

> +   };

> @@ -2027,4 +1968,56 @@
> resets = < 822>;
> };
> };
> +
> +   timer {
> +   compatible = "arm,armv8-timer";
> +   interrupts-extended = < GIC_PPI 13 
> (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
> + < GIC_PPI 14 
> (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
> + < GIC_PPI 11 
> (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>,
> + < GIC_PPI 10 
> (GIC_CPU_MASK_SIMPLE(6) | IRQ_TYPE_LEVEL_LOW)>;

Much better!

Or even

> +   interrupts-extended =
> +   < GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(6) | 
> IRQ_TYPE_LEVEL_LOW)>,
> +   < GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(6) | 
> IRQ_TYPE_LEVEL_LOW)>,
> +   < GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(6) | 
> IRQ_TYPE_LEVEL_LOW)>,
> +   < GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(6) | 
> IRQ_TYPE_LEVEL_LOW)>;

I don't care that much, it extends beyond 80 characters anyway.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 2/3] arm64: dts: renesas: r8a7796: move nodes which have no reg property out of bus

2017-12-13 Thread Simon Horman 
On Tue, Dec 12, 2017 at 10:44:53AM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
> 
> On Tue, Dec 12, 2017 at 9:24 AM, Simon Horman
>  wrote:
> > Move pmu_a5[73], timer and thermal-zones nodes from soc node to root node.
> > The nodes that have been moved do not have any register properties and thus
> > shouldn't be placed on the bus.
> 
> [...]
> 
> > Signed-off-by: Simon Horman 
> 
> Reviewed-by: Geert Uytterhoeven 
> but a few minor comments below...
> 
> > --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> > @@ -154,6 +154,26 @@
> > clock-frequency = <0>;
> > };
> >
> > +   pmu_a57 {
> > +   compatible = "arm,cortex-a57-pmu";
> > +   interrupts-extended = < GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> > +   interrupt-affinity = <_0>,
> > +<_1>;
> > +   };
> > +
> > +   pmu_a53 {
> > +   compatible = "arm,cortex-a53-pmu";
> > +   interrupts-extended = < GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
> > + < GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> > +   interrupt-affinity = <_0>,
> > +<_1>,
> > +<_2>,
> > +<_3>;
> 
> Merge these 4 into a single line?
> 
> > @@ -2027,4 +1971,64 @@
> > resets = < 822>;
> > };
> > };
> > +
> > +   timer {
> > +   compatible = "arm,armv8-timer";
> > +   interrupts-extended = < GIC_PPI 13
> > +  (GIC_CPU_MASK_SIMPLE(6) |
> > +   IRQ_TYPE_LEVEL_LOW)>,
> > + < GIC_PPI 14
> > +  (GIC_CPU_MASK_SIMPLE(6) |
> > +   IRQ_TYPE_LEVEL_LOW)>,
> > + < GIC_PPI 11
> > +  (GIC_CPU_MASK_SIMPLE(6) |
> > +   IRQ_TYPE_LEVEL_LOW)>,
> > + < GIC_PPI 10
> > +  (GIC_CPU_MASK_SIMPLE(6) |
> > +   IRQ_TYPE_LEVEL_LOW)>;
> 
> I think you can do a better job here, by trying not to break entries across
> multiple lines ;-)
> 
> (Oops, we already have it this way in r8a7795.dtsi)

That can be fixed.

For now I've applied the following:

From: Simon Horman 
Date: Tue, 12 Dec 2017 09:24:35 +0100
Subject: [PATCH] arm64: dts: renesas: r8a7796: move nodes which have no reg
 property out of bus

Move pmu_a5[73], timer and thermal-zones nodes from soc node to root node.
The nodes that have been moved do not have any register properties and thus
shouldn't be placed on the bus.

This problem is flagged by the compiler as follows:
$ make
...
  DTC arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb
...
arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (simple_bus_reg): 
Node /soc/timer missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (simple_bus_reg): 
Node /soc/pmu_a57 missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (simple_bus_reg): 
Node /soc/pmu_a53 missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dtb: Warning (simple_bus_reg): 
Node /soc/thermal-zones missing or empty reg/ranges property
...
  DTC arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dtb
...
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dtb: Warning (simple_bus_reg): Node 
/soc/timer missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dtb: Warning (simple_bus_reg): Node 
/soc/pmu_a57 missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dtb: Warning (simple_bus_reg): Node 
/soc/pmu_a53 missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb.dtb: Warning (simple_bus_reg): Node 
/soc/thermal-zones missing or empty reg/ranges property
...
  DTC arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb
...
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb: Warning (simple_bus_reg): 
Node /soc/timer missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb: Warning (simple_bus_reg): 
Node /soc/pmu_a57 missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb: Warning (simple_bus_reg): 
Node /soc/pmu_a53 missing or empty reg/ranges property
arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dtb:

Re: [PATCH 2/3] arm64: dts: renesas: r8a7796: move nodes which have no reg property out of bus

2017-12-12 Thread Geert Uytterhoeven 
Hi Simon,

On Tue, Dec 12, 2017 at 9:24 AM, Simon Horman
 wrote:
> Move pmu_a5[73], timer and thermal-zones nodes from soc node to root node.
> The nodes that have been moved do not have any register properties and thus
> shouldn't be placed on the bus.

[...]

> Signed-off-by: Simon Horman 

Reviewed-by: Geert Uytterhoeven 
but a few minor comments below...

> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -154,6 +154,26 @@
> clock-frequency = <0>;
> };
>
> +   pmu_a57 {
> +   compatible = "arm,cortex-a57-pmu";
> +   interrupts-extended = < GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> +   interrupt-affinity = <_0>,
> +<_1>;
> +   };
> +
> +   pmu_a53 {
> +   compatible = "arm,cortex-a53-pmu";
> +   interrupts-extended = < GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 85 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>,
> + < GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
> +   interrupt-affinity = <_0>,
> +<_1>,
> +<_2>,
> +<_3>;

Merge these 4 into a single line?

> @@ -2027,4 +1971,64 @@
> resets = < 822>;
> };
> };
> +
> +   timer {
> +   compatible = "arm,armv8-timer";
> +   interrupts-extended = < GIC_PPI 13
> +  (GIC_CPU_MASK_SIMPLE(6) |
> +   IRQ_TYPE_LEVEL_LOW)>,
> + < GIC_PPI 14
> +  (GIC_CPU_MASK_SIMPLE(6) |
> +   IRQ_TYPE_LEVEL_LOW)>,
> + < GIC_PPI 11
> +  (GIC_CPU_MASK_SIMPLE(6) |
> +   IRQ_TYPE_LEVEL_LOW)>,
> + < GIC_PPI 10
> +  (GIC_CPU_MASK_SIMPLE(6) |
> +   IRQ_TYPE_LEVEL_LOW)>;

I think you can do a better job here, by trying not to break entries across
multiple lines ;-)

(Oops, we already have it this way in r8a7795.dtsi)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds