RE: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
Olof Johansson wrote: On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: Changes since v4: - Rebased to linux-3.8-rc1. Changes since v3: - Includes changes suggested by Tomasz Figa tomasz.f...@gmail.com This patch series migrates the Samsung Exynos4 SoC clock code to adopt the common clock framework. The use of Samsung specific clock structures has been removed and all board support code has been updated. imx-style of clock registration and lookup has been adopted for device tree based exynos4 platforms. I'd prefer to see if exynos4 and 5 were kept common here, and both transitioned at the same time. Especially since there are no legacy boards for exynos5, it would mean you could have a very clean transition there. What's the plan to follow up with 5? Yeah, I'm working on EXYNOS5250 common clk stuff and Thomas is working on EXYNOS5440. So I think, we can move on exynos4 and 5 both common clk at the same time. Note, EXYNOS5 common clk stuff will be submitted in the beginning of Jan. What are the plans to remove legacy board files on exynos4 at this time and switch them to DT-only? You could do it gradually like Stephen Warren did on Tegra, with hooks that call out to some of the legacy code, but configure the board through device tree and do away with the classic machine descriptors, etc. I had a plan to remove non-DT support on EXYNOS4 for v3.10, but if possible, I will try to do it for v3.9. If any updates, let you know. Thanks. Happy New Year! - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: dts: add board dts file for EXYNOS4412 based Origen board
Thomas Abraham wrote:
Add a minimal board dts file for EXYNOS4412 based Insignal Origen board.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/exynos4412-origen.dts | 45
+++
2 files changed, 46 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos4412-origen.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e44da40..c84f9f7 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -43,6 +43,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-
origen.dtb \
exynos4210-smdkv310.dtb \
exynos4210-trats.dtb \
exynos4412-smdk4412.dtb \
+ exynos4412-origen.dtb \
exynos5250-smdk5250.dtb \
exynos5250-snow.dtb \
exynos5440-ssdk5440.dtb
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
b/arch/arm/boot/dts/exynos4412-origen.dts
new file mode 100644
index 000..df880c4
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -0,0 +1,45 @@
+/*
+ * Insignal's Exynos4412 based Origen board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * Device tree source file for Insignal's Origen board which is based on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ exynos4412.dtsi
+
+/ {
+ model = Insignal Origen evaluation board based on Exynos4412;
+ compatible = insignal,origen4412, samsung,exynos4412;
+
+ memory {
+ reg = 0x4000 0x4000;
+ };
+
+ chosen {
+ bootargs =console=ttySAC2,115200;
+ };
+
+ serial@1380 {
+ status = okay;
+ };
+
+ serial@1381 {
+ status = okay;
+ };
+
+ serial@1382 {
+ status = okay;
+ };
+
+ serial@1383 {
+ status = okay;
+ };
+};
--
1.7.5.4
Looks OK to me, applied.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: dts: add board dts file for EXYNOS4412 based Origen board
Kukjin Kim wrote:
Thomas Abraham wrote:
Add a minimal board dts file for EXYNOS4412 based Insignal Origen board.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
---
arch/arm/boot/dts/Makefile |1 +
arch/arm/boot/dts/exynos4412-origen.dts | 45
+++
2 files changed, 46 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos4412-origen.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e44da40..c84f9f7 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -43,6 +43,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-
origen.dtb \
exynos4210-smdkv310.dtb \
exynos4210-trats.dtb \
exynos4412-smdk4412.dtb \
+ exynos4412-origen.dtb \
exynos5250-smdk5250.dtb \
exynos5250-snow.dtb \
exynos5440-ssdk5440.dtb
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
b/arch/arm/boot/dts/exynos4412-origen.dts
new file mode 100644
index 000..df880c4
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -0,0 +1,45 @@
+/*
+ * Insignal's Exynos4412 based Origen board device tree source
+ *
+ * Copyright (c) 2012-2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * Device tree source file for Insignal's Origen board which is based
on
+ * Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ exynos4412.dtsi
+
+/ {
+ model = Insignal Origen evaluation board based on Exynos4412;
+ compatible = insignal,origen4412, samsung,exynos4412;
+
+ memory {
+ reg = 0x4000 0x4000;
+ };
+
+ chosen {
+ bootargs =console=ttySAC2,115200;
+ };
+
+ serial@1380 {
+ status = okay;
+ };
+
+ serial@1381 {
+ status = okay;
+ };
+
+ serial@1382 {
+ status = okay;
+ };
+
+ serial@1383 {
+ status = okay;
+ };
+};
--
1.7.5.4
Looks OK to me, applied.
Ah, one more.
BTW, I think, need to sort out the memory configuration and bootargs
And compatible name? origen4412 is right? Probably, origen-quad?
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH RESEND] ARM: dts: Add EHCI device tree node for Exynos4
This patch adds EHCI device node on device tree for Exynos4 and defines its
default platform data, s5p_usb_phy_init and s5p_usb_phy_exit, so that those
function can be called from the driver.
Signed-off-by: Dongjin Kim tobet...@gmail.com
---
arch/arm/boot/dts/exynos4.dtsi |7 +++
arch/arm/mach-exynos/mach-exynos4-dt.c |9 +
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 92bca86..df1a9f0 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -140,6 +140,13 @@
status = disabled;
};
+ ehci@1258 {
+ compatible = samsung,exynos-ehci;
+ reg = 0x1258 0x100;
+ interrupts = 0 70 0;
+ status = disabled;
+ };
+
serial@1380 {
compatible = samsung,exynos4210-uart;
reg = 0x1380 0x100;
diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c
b/arch/arm/mach-exynos/mach-exynos4-dt.c
index 92757ff..c8a23f0 100644
--- a/arch/arm/mach-exynos/mach-exynos4-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos4-dt.c
@@ -13,6 +13,7 @@
#include linux/of_platform.h
#include linux/serial_core.h
+#include linux/platform_data/usb-ehci-s5p.h
#include asm/mach/arch.h
#include asm/hardware/gic.h
@@ -20,9 +21,15 @@
#include plat/cpu.h
#include plat/regs-serial.h
+#include plat/usb-phy.h
#include common.h
+static struct s5p_ehci_platdata s5p_ehci_platdata = {
+ .phy_init = s5p_usb_phy_init,
+ .phy_exit = s5p_usb_phy_exit,
+};
+
/*
* The following lookup table is used to override device names when devices
* are registered from device tree. This is temporarily added to enable
@@ -80,6 +87,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[]
__initconst = {
OF_DEV_AUXDATA(arm,pl330, EXYNOS4_PA_MDMA1, dma-pl330.2, NULL),
OF_DEV_AUXDATA(samsung,exynos4210-tmu, EXYNOS4_PA_TMU,
exynos-tmu, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-ehci, EXYNOS4_PA_EHCI,
+ s5p-ehci, s5p_ehci_platdata),
{},
};
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] Add missing fixed regulators on Origen board
On 12/30/2012 11:55 AM, Olof Johansson wrote: Hi, On Fri, Dec 28, 2012 at 12:34 AM, Tushar Behera tushar.beh...@linaro.org wrote: This patchset adds vmmc and hdmi-en regulators for Origen board. Tushar Behera (2): ARM: EXYNOS: Add vmmc regulator for Origen board ARM: EXYNOS: Add hdmi-en regulator for Origen board The vmmc one seems to already be there in the dts file for origen. It looks like the HDMI one is still needed though. DT enablement patches for HDMI driver were posted sometime back, but they have not yet been merged in trunk. So HDMI regulator entry for DT will be added after that. Please move to using DT board files instead of expanding the legacy board files. Sure, the focus would be on adding DT support. Legacy board support for Origen is pretty much complete with support for various multimedia drivers, so it provides a good environment for testing different features. It would be good to get these patches in for enabling HDMI support, which otherwise would be broken if REGULATOR_DUMMY is not defined. -Olof -- Tushar Behera -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH RESEND] ARM: dts: Add EHCI device tree node for Exynos4
On 12/31/2012 08:15 AM, Dongjin Kim wrote:
This patch adds EHCI device node on device tree for Exynos4 and defines its
default platform data, s5p_usb_phy_init and s5p_usb_phy_exit, so that those
function can be called from the driver.
Signed-off-by: Dongjin Kim tobet...@gmail.com
---
arch/arm/boot/dts/exynos4.dtsi |7 +++
arch/arm/mach-exynos/mach-exynos4-dt.c |9 +
2 files changed, 16 insertions(+)
[ ... ]
+static struct s5p_ehci_platdata s5p_ehci_platdata = {
+ .phy_init = s5p_usb_phy_init,
+ .phy_exit = s5p_usb_phy_exit,
+};
+
Going by the recent development on Samsung USBPHY driver, we won't need
these hooks once that patch gets accepted. [1]
Patch for adding EHCI support for EXYNOS5-DT can be found here.[2]
[1] https://patchwork.kernel.org/patch/1794651/
[2] https://patchwork.kernel.org/patch/1875491/
/*
* The following lookup table is used to override device names when devices
* are registered from device tree. This is temporarily added to enable
@@ -80,6 +87,8 @@ static const struct of_dev_auxdata exynos4_auxdata_lookup[]
__initconst = {
OF_DEV_AUXDATA(arm,pl330, EXYNOS4_PA_MDMA1, dma-pl330.2, NULL),
OF_DEV_AUXDATA(samsung,exynos4210-tmu, EXYNOS4_PA_TMU,
exynos-tmu, NULL),
+ OF_DEV_AUXDATA(samsung,exynos-ehci, EXYNOS4_PA_EHCI,
+ s5p-ehci, s5p_ehci_platdata),
{},
};
--
Tushar Behera
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/5] ARM: Exynos: Enable device tree support for MCT controller
On 29 December 2012 21:24, Olof Johansson o...@lixom.net wrote: On Sat, Dec 29, 2012 at 12:50:33PM -0800, Thomas Abraham wrote: Changes since v2: - Rebased to linux 3.8-rc1 Changes since v1: - Includes changes suggested by Sylwester Nawrocki sylvester.nawro...@gmail.com This patch series adds device tree support for Exynos4/5 MCT controller. This patch series has been tested on Exynos4210 based Origen board, Exynos4412 based Origen board and Exynos5250 based SMDK board. Hi, Nice cleanups -- no specific comments on those at this time. But this is a good time to move the MCT driver out of arch/arm and into drivers/clocksource. Can you please do that in this series as well, please? Hi Olof, Ok. I will move the MCT diver to drivers/clocksource and repost this series. Thanks for your suggestion. Regards, Thomas. Thanks, -Olof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework
On 29 December 2012 21:29, Olof Johansson o...@lixom.net wrote: On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: Changes since v4: - Rebased to linux-3.8-rc1. Changes since v3: - Includes changes suggested by Tomasz Figa tomasz.f...@gmail.com This patch series migrates the Samsung Exynos4 SoC clock code to adopt the common clock framework. The use of Samsung specific clock structures has been removed and all board support code has been updated. imx-style of clock registration and lookup has been adopted for device tree based exynos4 platforms. I'd prefer to see if exynos4 and 5 were kept common here, and both transitioned at the same time. Especially since there are no legacy boards for exynos5, it would mean you could have a very clean transition there. What's the plan to follow up with 5? Ok. I have been looking into Exynos4 since Mr. Kim was already onto Exynos5 common clock. Sure, we could do a cleaner Exynos4/5 common clock series for v3.9. That would let both exynos4/5 to be built together which otherwise this patch series would not allow. What are the plans to remove legacy board files on exynos4 at this time and switch them to DT-only? You could do it gradually like Stephen Warren did on Tegra, with hooks that call out to some of the legacy code, but configure the board through device tree and do away with the classic machine descriptors, etc. I did try this sometime back for exynos4210 based origen board. But did not make much progress since certain portions require the older samsung gpiolib support and exynos4210 mainline device tree support has migrated to newer pinctrl framework. There is some work here to do and I will work with Mr. Kim on this. Thanks, Thomas. -Olof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
