Re: [PATCH 1/7] ARM: EXYNOS: initial board support for exynos5260 SoC
Hi Tomasz, Sorry for responding late. On 10 December 2013 21:27, Tomasz Figa t.f...@samsung.com wrote: Hi Pankaj, Rahul, Arun, In addition to issues already pointed by Sachin, please also see my comments inline. On Friday 06 of December 2013 21:26:25 Rahul Sharma wrote: From: Pankaj Dubey pankaj.du...@samsung.com This patch add basic arch side support for exynos5260 SoC. Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com --- arch/arm/mach-exynos/Kconfig |9 + arch/arm/mach-exynos/common.c| 19 ++- arch/arm/mach-exynos/cpuidle.c |2 +- arch/arm/mach-exynos/include/mach/map.h |1 + arch/arm/mach-exynos/include/mach/regs-pmu.h |4 arch/arm/mach-exynos/mach-exynos5-dt.c |1 + arch/arm/plat-samsung/include/plat/cpu.h |8 arch/arm/plat-samsung/include/plat/map-s5p.h |1 + 8 files changed, 43 insertions(+), 2 deletions(-) [snip] diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index ddbfe87..405c11a 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -120,7 +120,7 @@ static int exynos4_enter_core0_aftr(struct cpuidle_device *dev, cpu_suspend(0, idle_finisher); #ifdef CONFIG_SMP - if (!soc_is_exynos5250()) + if (!soc_is_exynos5250() || soc_is_exynos5260()) The added OR condition doesn't affect the if condition in any way, because when running on Exynos5260, soc_is_exynos5250() will return false and make the whole condition evaluate to true. Shouldn't it be if (!soc_is_exynos5250() !soc_is_exynos5260()) if Exynos5260 doesn't need scu_enable(), or left as is if it needs? Actually we don't need to call scu_enable() for 5260. Hence leaving it as it is. scu_enable(S5P_VA_SCU); #endif cpu_pm_exit(); diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index 7b046b5..bd6fa02 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -29,6 +29,7 @@ #define EXYNOS4210_PA_SYSRAM_NS 0x0203F000 #define EXYNOS4x12_PA_SYSRAM_NS 0x0204F000 #define EXYNOS5250_PA_SYSRAM_NS 0x0204F000 +#define EXYNOS5260_PA_SYSRAM_NS 0x02073000 #define EXYNOS_PA_CHIPID 0x1000 diff --git a/arch/arm/mach-exynos/include/mach/regs-pmu.h b/arch/arm/mach-exynos/include/mach/regs-pmu.h index 2cdb63e..09ae29a 100644 --- a/arch/arm/mach-exynos/include/mach/regs-pmu.h +++ b/arch/arm/mach-exynos/include/mach/regs-pmu.h @@ -234,6 +234,10 @@ #define EXYNOS5_SYS_WDTRESET (1 20) +#define EXYNOS5260_A7_WDTRST (1 24) +#define EXYNOS5260_A15_WDTRST(1 23) +#define EXYNOS5260_SYS_WDTRESET (EXYNOS5260_A7_WDTRST || EXYNOS5260_A15_WDTRST) + Are these definitions needed? I don't see any user in this patch. Removed these definitions. Regards, Rahul Sharma. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] pinctrl: exynos: add exynos5260 SoC specific data
Hi Sachin,
On 9 December 2013 10:21, Sachin Kamat sachin.ka...@linaro.org wrote:
Hi Rahul, Young-Gun,
On 6 December 2013 21:26, Rahul Sharma rahul.sha...@samsung.com wrote:
From: Young-Gun Jang yg1004.j...@samsung.com
Add Samsung Exynos5260 SoC specific data to enable pinctrl
support for all platforms based on EXYNOS5260.
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
Signed-off-by: Rahul Sharma rahul.sha...@samsung.com
Signed-off-by: Arun Kumar K arun...@samsung.com
Author's (Young-Gun Jang) signed-off by is missing here.
done.
[snip]
+
+/* pin banks of exynos5260 pin-controller 2 */
+static struct samsung_pin_bank exynos5260_pin_banks2[] = {
+ EXYNOS_PIN_BANK_EINTG(7, 0x000, gpz0, 0x00),
+ EXYNOS_PIN_BANK_EINTG(4, 0x020, gpz1, 0x04),
+};
+
+/*
+ * Samsung pinctrl driver data for Exynos5260 SoC. Exynos5420 SoC includes
s/5420/5260 ?
done.
Regards,
Rahul Sharma.
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] ARM: SAMSUNG: Remove hardware.h inclusion
The contents of this header file are not referenced anywhere in the included .c files except in devs.c. Remove its inclusion. For devs.c, explicitly include sizes.h header for SZ_* macros. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/plat-samsung/clock.c|1 - arch/arm/plat-samsung/devs.c |2 +- arch/arm/plat-samsung/init.c |2 -- arch/arm/plat-samsung/pm.c |1 - arch/arm/plat-samsung/s5p-dev-uart.c |1 - 5 files changed, 1 insertion(+), 6 deletions(-) diff --git a/arch/arm/plat-samsung/clock.c b/arch/arm/plat-samsung/clock.c index 494deadb4602..179bdc17b667 100644 --- a/arch/arm/plat-samsung/clock.c +++ b/arch/arm/plat-samsung/clock.c @@ -42,7 +42,6 @@ #include linux/debugfs.h #endif -#include mach/hardware.h #include asm/irq.h #include plat/cpu-freq.h diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c index 78460f836e89..7a29f1256439 100644 --- a/arch/arm/plat-samsung/devs.c +++ b/arch/arm/plat-samsung/devs.c @@ -30,6 +30,7 @@ #include linux/mtd/partitions.h #include linux/mmc/host.h #include linux/ioport.h +#include linux/sizes.h #include linux/platform_data/s3c-hsudc.h #include linux/platform_data/s3c-hsotg.h #include linux/platform_data/dma-s3c24xx.h @@ -41,7 +42,6 @@ #include asm/mach/map.h #include asm/mach/irq.h -#include mach/hardware.h #include mach/dma.h #include mach/irqs.h #include mach/map.h diff --git a/arch/arm/plat-samsung/init.c b/arch/arm/plat-samsung/init.c index e63e3cea9dac..9183ded63552 100644 --- a/arch/arm/plat-samsung/init.c +++ b/arch/arm/plat-samsung/init.c @@ -23,8 +23,6 @@ #include linux/platform_device.h #include linux/of.h -#include mach/hardware.h - #include asm/mach/arch.h #include asm/mach/map.h diff --git a/arch/arm/plat-samsung/pm.c b/arch/arm/plat-samsung/pm.c index 72e8e8f234f4..0f70339d60da 100644 --- a/arch/arm/plat-samsung/pm.c +++ b/arch/arm/plat-samsung/pm.c @@ -25,7 +25,6 @@ #include plat/regs-serial.h #ifdef CONFIG_SAMSUNG_ATAGS -#include mach/hardware.h #include mach/map.h #ifndef CONFIG_ARCH_EXYNOS #include mach/regs-clock.h diff --git a/arch/arm/plat-samsung/s5p-dev-uart.c b/arch/arm/plat-samsung/s5p-dev-uart.c index cafa3deddcc1..8c4487af98c8 100644 --- a/arch/arm/plat-samsung/s5p-dev-uart.c +++ b/arch/arm/plat-samsung/s5p-dev-uart.c @@ -18,7 +18,6 @@ #include asm/mach/arch.h #include asm/mach/irq.h -#include mach/hardware.h #include mach/map.h #include plat/devs.h -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] ARM: S3C24XX: Remove invalid code from hardware.h
Remove the code that is not referenced anywhere. While at it also remove incorrect file path. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-s3c24xx/include/mach/hardware.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/arch/arm/mach-s3c24xx/include/mach/hardware.h b/arch/arm/mach-s3c24xx/include/mach/hardware.h index a6cc14a092fc..dedd3837c193 100644 --- a/arch/arm/mach-s3c24xx/include/mach/hardware.h +++ b/arch/arm/mach-s3c24xx/include/mach/hardware.h @@ -1,5 +1,4 @@ -/* arch/arm/mach-s3c2410/include/mach/hardware.h - * +/* * Copyright (c) 2003 Simtec Electronics * Ben Dooks b...@simtec.co.uk * @@ -17,20 +16,9 @@ extern unsigned int s3c2410_modify_misccr(unsigned int clr, unsigned int chg); -#ifdef CONFIG_CPU_S3C2440 - -extern int s3c2440_set_dsc(unsigned int pin, unsigned int value); - -#endif /* CONFIG_CPU_S3C2440 */ - #endif /* __ASSEMBLY__ */ #include asm/sizes.h #include mach/map.h -/* machine specific hardware definitions should go after this */ - -/* currently here until moved into config (todo) */ -#define CONFIG_NO_MULTIWORD_IO - #endif /* __ASM_ARCH_HARDWARE_H */ -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/3] ARM: EXYNOS: Remove hardware.h file
This is a dummy placeholder file. Delete it. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/include/mach/hardware.h | 18 -- arch/arm/mach-exynos/platsmp.c |2 -- 2 files changed, 20 deletions(-) delete mode 100644 arch/arm/mach-exynos/include/mach/hardware.h diff --git a/arch/arm/mach-exynos/include/mach/hardware.h b/arch/arm/mach-exynos/include/mach/hardware.h deleted file mode 100644 index 5109eb232f23.. --- a/arch/arm/mach-exynos/include/mach/hardware.h +++ /dev/null @@ -1,18 +0,0 @@ -/* linux/arch/arm/mach-exynos4/include/mach/hardware.h - * - * Copyright (c) 2010-2011 Samsung Electronics Co., Ltd. - * http://www.samsung.com - * - * EXYNOS4 - Hardware support - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. -*/ - -#ifndef __ASM_ARCH_HARDWARE_H -#define __ASM_ARCH_HARDWARE_H __FILE__ - -/* currently nothing here, placeholder */ - -#endif /* __ASM_ARCH_HARDWARE_H */ diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index b681f899511d..7197d9ab9fcc 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -26,8 +26,6 @@ #include asm/smp_scu.h #include asm/firmware.h -#include mach/hardware.h - #include plat/cpu.h #include common.h -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board
On 21 December 2013 02:40, Tomasz Figa tomasz.f...@gmail.com wrote:
On Thursday 19 of December 2013 10:05:52 Sachin Kamat wrote:
Hi Tomasz,
On 18 December 2013 20:46, Tomasz Figa t.f...@samsung.com wrote:
Hi Sachin,
On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:
Added regulator entries to Exynos5420 SMDK board.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Changes since v1:
Changed node name
---
arch/arm/boot/dts/exynos5420-smdk5420.dts | 216
+
1 file changed, 216 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts
b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index fb5a1e25c632..62e1ebe4e989 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -120,4 +120,220 @@
reg = 0x50;
};
};
+
+ hsi2c_4: i2c@12CA {
+ status = okay;
+
+ s2mps11_pmic@66 {
Just pmic@66 is enough.
Please see my comment below.
+ compatible = samsung,s2mps11-pmic;
+ reg = 0x66;
+ s2mps11,buck2-ramp-delay = 12;
+ s2mps11,buck34-ramp-delay = 12;
+ s2mps11,buck16-ramp-delay = 12;
+ s2mps11,buck6-ramp-enable = 1;
+ s2mps11,buck2-ramp-enable = 1;
+ s2mps11,buck3-ramp-enable = 1;
+ s2mps11,buck4-ramp-enable = 1;
+
+ s2mps11_osc: clocks {
+ #clock-cells = 1;
+ clock-output-names = s2mps11_ap,
+ s2mps11_cp, s2mps11_bt;
+ };
+
+ regulators {
+ ldo1_reg: LDO1 {
+ regulator-name = vdd_ldo1;
Is this the name as written on the PCB or board schematics?
+ the same for all regulators below.
Yes, the schematic refers to these just as above (with no specific names).
Unless you have strong objections or a re-spin of this patch becomes
necessary, I
wouldn't want to change the name you pointed above. :)
OK.
Reviewed-by: Tomasz Figa t.f...@samsung.com
Ping Kukjin.
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM: dts: Re-organize RTC status for 5420
On 21 December 2013 02:42, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Sachin, On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote: Some boards might not have RTC xtal, so RTC shouldn't really be enabled by default. Enable it in the required board files. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/boot/dts/exynos5420-arndale-octa.dts |4 arch/arm/boot/dts/exynos5420-smdk5420.dts |4 arch/arm/boot/dts/exynos5420.dtsi |2 +- 3 files changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Tomasz Figa t.f...@samsung.com Ping Kukjin. Also the other patch for 5250. -- With warm regards, Sachin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Boot hang on Origen with (!SMP CPU_IDLE)
Hi, We are getting boot-time system hang on Exynos4210-based Origen board if the kernel (right now testing v3.13-rc6) is built using exynos_defconfig, disabling SMP support and enabling CPU_IDLE support. The boot log can be found here[1]. Git bisect points to following commit. commit 87107d89052bcec1fe91b309631de4ed294a5171 Author: Arnd Bergmann a...@arndb.de Date: Wed Jun 19 01:36:52 2013 +0900 ARM: EXYNOS: Remove legacy L2X0 initialization Since Exynos is now supporting only DT-based boot, the old L2X0 initialization code is not needed anymore, so exynos4_l2x0_cache_init() can be greatly simplified. Signed-off-by: Arnd Bergmann a...@arndb.de Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Reverting the changes, the kernel boots up. Any idea what else we might be missing? [1] http://pastebin.com/0mP6ML4y -- Tushar Behera -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Boot hang on Origen with (!SMP CPU_IDLE)
On Friday 03 January 2014, Tushar Behera wrote: Hi, We are getting boot-time system hang on Exynos4210-based Origen board if the kernel (right now testing v3.13-rc6) is built using exynos_defconfig, disabling SMP support and enabling CPU_IDLE support. The boot log can be found here[1]. Git bisect points to following commit. commit 87107d89052bcec1fe91b309631de4ed294a5171 Author: Arnd Bergmann a...@arndb.de Date: Wed Jun 19 01:36:52 2013 +0900 ARM: EXYNOS: Remove legacy L2X0 initialization Since Exynos is now supporting only DT-based boot, the old L2X0 initialization code is not needed anymore, so exynos4_l2x0_cache_init() can be greatly simplified. Signed-off-by: Arnd Bergmann a...@arndb.de Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Reverting the changes, the kernel boots up. Any idea what else we might be missing? [1] http://pastebin.com/0mP6ML4y Hmm, the boot log contains no message about the l2 cache controller getting initialized, which means that l2x0_of_init probably failed before calling l2x0_init. It also seems that the dts files distributed with the kernel are lacking nodes for the l2x0 device, which is indeed a perfectly good explanation although it doesn't explain at all why it ever worked on any system with my patch. Can you check if there is a correct cache controller node in your device tree, and whether it works when you add one? If so, we should probably add a couple of stable backport patches to the dts files. It would also be a good time to get rid of the L2_AUX_VAL and L2_AUX_MASK defines and just read the respective settings from DT. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Boot hang on Origen with (!SMP CPU_IDLE)
On Friday 03 of January 2014 14:37:10 Arnd Bergmann wrote: On Friday 03 January 2014, Tushar Behera wrote: Hi, We are getting boot-time system hang on Exynos4210-based Origen board if the kernel (right now testing v3.13-rc6) is built using exynos_defconfig, disabling SMP support and enabling CPU_IDLE support. The boot log can be found here[1]. Git bisect points to following commit. commit 87107d89052bcec1fe91b309631de4ed294a5171 Author: Arnd Bergmann a...@arndb.de Date: Wed Jun 19 01:36:52 2013 +0900 ARM: EXYNOS: Remove legacy L2X0 initialization Since Exynos is now supporting only DT-based boot, the old L2X0 initialization code is not needed anymore, so exynos4_l2x0_cache_init() can be greatly simplified. Signed-off-by: Arnd Bergmann a...@arndb.de Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Reverting the changes, the kernel boots up. Any idea what else we might be missing? [1] http://pastebin.com/0mP6ML4y Hmm, the boot log contains no message about the l2 cache controller getting initialized, which means that l2x0_of_init probably failed before calling l2x0_init. It also seems that the dts files distributed with the kernel are lacking nodes for the l2x0 device, which is indeed a perfectly good explanation although it doesn't explain at all why it ever worked on any system with my patch. Can you check if there is a correct cache controller node in your device tree, and whether it works when you add one? If so, we should probably add a couple of stable backport patches to the dts files. It would also be a good time to get rid of the L2_AUX_VAL and L2_AUX_MASK defines and just read the respective settings from DT. Tushar, do you maybe also have CONFIG_CACHE_L2X0 enabled? Generally I can see two different issues here: 1) Broken handling of L2 cache in plat-samsung/sleep.S. It assumes that whenever CONFIG_CACHE_L2X0 is enabled, L2 cache is enabled too. This needs to go away. On normal resume from sleep, there is no need to do anything with L2X0 at such early stage. This reinitialization can be safely done later, by calling generic outer_resume(). The problem shows up when you look at AFTR and LPA idle modes. They keep L2 cache contents, but L2X0 registers must be restored to let the cache operate normally. This must happen early enough to keep cache data consistent. Still, the code doing this must consider whether the cache was enabled before entering AFTR/LPA and whether secure firmware is used (see below), so this is a bit tricky. 2) There is no L2 cache controller node in Exynos4*.dtsi. It should be added, but L2 cache can't be enabled on all boards yet, since on boards where secure firmware is enabled, special configuration involving SMC calls is required. Patches for this are queued on my work queue, but it's quite tricky due to 1), which needs to consider whether secure firmware is enabled or not. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] i2c: s3c2410 : Add polling mode support
Hi, On Mon, Nov 11, 2013 at 04:50:20PM +0530, Yuvaraj Kumar C D wrote: From: Vasanth Ananthan vasanthanant...@gmail.com This patch adds polling mode support for i2c-s3c2410 driver.The SATA PHY controller's CMU and TRSV block's are of I2C register map in exynos5250.These blocks can be configured using i2c. But i2c controller instance on which these block's sits lacks an interrupt line.Also the current i2c-s3c2410 driver is only interrupt driven, thus a polling mode support is required in the driver for supporting this controller. This patch adds this support to the driver. Changes from V1: 1.Changed the is_ack() to have even period b/w polls and used usleep_range() instead of udelay(). Mileages vary, but I'd like to see revision changes after the ---. ret = devm_request_irq(pdev-dev, i2c-irq, s3c24xx_i2c_irq, 0, -dev_name(pdev-dev), i2c); + dev_name(pdev-dev), i2c); Unrelated change. Rest looks good, so I'll fix up the things for you and apply to for-next, thanks! signature.asc Description: Digital signature
Re: [PATCH v4] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series
On Tue, Nov 26, 2013 at 09:52:46AM +0530, Naveen Krishna Chatradhi wrote: For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based on a fixed 66 MHz peripheral clock, and therefore is completely independent of the cpu frequency. Thus, registering for a CPU freq notifier is very wasteful. This patch modifes the code such that, i2c bus registers to cpu_freq_transition only if CONFIG_CPU_FREQ_S3C24XX is enabled. This change should save a bunch of cpufreq transitions calls which does not apply to exynos SoCs. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Doug Anderson diand...@chromium.org Applied to for-next, thanks! signature.asc Description: Digital signature
USB broken on Exynos 5250 with 3.13-rc6 kernel
I build 3.13-rc6 for exynso-5250. After installing the kernel and rebooting my machine, everything worked (lpae out of the box, even) except for usb; I rebuilt the kernel a couple of times, poking at USB config options, but was completely unable to get USB to work. -- John Dulaney, RHCE IRC: handsome_pirate jdulaney.wordpress.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] mtd: s3c2410: Merge plat/regs-nand.h into s3c2410.c
Sachin Kamat wrote: plat/regs-nand.h is used only by S3C2410 nand driver. Since there are no other users, merge this file into the driver code to remove platform dependency. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- The earlier version of this patch was titled mtd: s3c2410: Move plat/regs-nand.h to drivers/mtd. Please ignore that. --- arch/arm/plat-samsung/include/plat/regs-nand.h | 123 --- - drivers/mtd/nand/s3c2410.c | 104 +++- 2 files changed, 103 insertions(+), 124 deletions(-) delete mode 100644 arch/arm/plat-samsung/include/plat/regs-nand.h Moving looks good, but if some of them are not used, we don't need to keep them while moving. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: SAMSUNG: Remove unused HDMI code
Sachin Kamat wrote: There seems to be no users of this code in the tree for now. Hence remove it. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- S5P_DEV_I2C_HDMIPHY config entry is not selected by any machine. Please check if this code is required for S5PV210 HDMI support. Untested on that platform. As I know, this can be used until moving DT for all S5P SoCs, so I'll drop this one. In my opinion, maybe we could cleanup whole S5P_DEV_XXX after moving DT for all S5P SoCs. Anyway thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
Sachin Kamat wrote: plat/regs-ata.h is used only by Samsung PATA driver. Move this file to the drivers folder to remove platform dependency required for multiplatform support. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/ata/pata_samsung_cf.c |2 +- .../regs-ata.h = drivers/ata/pata_samsung_cf.h|9 - 2 files changed, 5 insertions(+), 6 deletions(-) rename arch/arm/plat-samsung/include/plat/regs-ata.h = drivers/ata/pata_samsung_cf.h (91%) I don't know we need to create header file into drivers/ata/ because the header will be used for only pata_samsung_cf.c. But it's up to Tejun who is a maintainer of SERIAL ATA ;-) Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [GIT PULL 2nd 3/5] Samsung defconfig update for v3.14
Olof Johansson wrote: On Tue, Dec 31, 2013 at 8:17 AM, Mark Brown broo...@kernel.org wrote: On Sat, Dec 28, 2013 at 07:48:26PM -0800, Olof Johansson wrote: On Sat, Dec 28, 2013 at 7:44 PM, Olof Johansson o...@lixom.net wrote: The regulator driver causes build breaks. Really, nobody checks these things before sending patches or merge requests? Having exynos_defconfig broken in arm-soc isn't an alternative. So I dropped this branch again. If the regulator driver gets fixed in -rc then we can probably merge it before the merge window, otherwise we'll have to merge the defconfig change after the regulator fix goes in for the 3.14 merge window. Ah, I guess the fix went in after -rc4, which is the latest -rc that we have in for-next today. I'll bring for-next forward and merge this in. Still, it's odd that you were able to test your branch before sending it in. The build breakage was only introduced in -rc4 - a MFD/RTC change went in via Andrew's tree so it got no exposure in -next before it showed up in Linus' tree which wasn't good. The fix was in by -rc5, looking at the date on the pull request I expect that any testing against -next (as opposed to arm-soc) would've been OK and since the branch is based on -rc1 it'd have tested out by itself as well. Ah, yeah, that explains it. Thanks for the clarification. Sorry for late response and Mark, thanks for your response ;-) Olof, I have not seen regarding problem in my tree before my pull-request so I didn't know but I will look at -next and arm-soc more closely. Thanks. Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [GIT PULL 2nd 5/5] Samsung SoC update for v3.14
Sachin Kamat wrote: Hi Olof, On 29 December 2013 04:47, Olof Johansson o...@lixom.net wrote: On Sun, Dec 22, 2013 at 03:23:57AM +0900, Kukjin Kim wrote: The following changes since commit 538cfbb4c40ab59688236484138133b8e3e89220: ARM: dts: Add initial support for Arndale Octa board (2013-12-16 05:05:43 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-soc-2 for you to fetch changes up to 7a28f198735d040f4d318511827d913d4b53f355: ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board (2013-12-19 05:34:26 +0900) Samsung SoC 2nd update for v3.14 - add exynos4412-tiny4412 board dt for FriendlyARM's TINY4412 board Alex Ling (1): ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/exynos4412-tiny4412.dts | 93 +++ 2 files changed, 94 insertions(+) create mode 100644 arch/arm/boot/dts/exynos4412-tiny4412.dts Hi, This is really just a DT patch, and given that I didn't take the base patch it makes sense to take this in a DT branch instead. Please resend on top of dt-2. The Arndale octa support patch (ARM: dts: Add initial support for Arndale Octa board) is also just a DT patch and does not add any new platform support. It is based on the existing 5420 SoC platform. Please consider pulling in that too. Sachin, in my understanding, adding 'Arndale Octa DT' is a support for new hardware platform, so I've applied it into -soc branch. The -soc branch is for new platform support including new SoC, new hardware, so if arm-soc maintainers don't want to pull 'new platform' before supporting multiplatform for exynos, we need to hold on at this moment. But I think, we could support multiplatform for exynos soon ;-) Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [GIT PULL 2nd 5/5] Samsung SoC update for v3.14
Olof Johansson wrote: On Sun, Dec 22, 2013 at 03:23:57AM +0900, Kukjin Kim wrote: The following changes since commit 538cfbb4c40ab59688236484138133b8e3e89220: ARM: dts: Add initial support for Arndale Octa board (2013-12-16 05:05:43 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-soc-2 for you to fetch changes up to 7a28f198735d040f4d318511827d913d4b53f355: ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board (2013-12-19 05:34:26 +0900) Samsung SoC 2nd update for v3.14 - add exynos4412-tiny4412 board dt for FriendlyARM's TINY4412 board Alex Ling (1): ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/exynos4412-tiny4412.dts | 93 +++ 2 files changed, 94 insertions(+) create mode 100644 arch/arm/boot/dts/exynos4412-tiny4412.dts Hi, This is really just a DT patch, and given that I didn't take the base patch it makes sense to take this in a DT branch instead. Please resend on top of dt-2. Olof, you mean adding new DT is OK? Sounds good, let me send a new pull-request for exynos4412-tiny4412 and exynos5420-arndale-octa tonight, I replied with different opinion on other Sachin's email though ;-) Sachin, you don't need to concern about that :-) Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 03/11] ARM: EXYNOS: local regs-pmu.h header file
Olof Johansson wrote:
Hi,
Hi,
On Tue, Dec 17, 2013 at 3:52 AM, kg...@kernel.org wrote:
From: Kukjin Kim kgene@samsung.com
This moves regs-pmu.h file into mach-exynos directory.
Signed-off-by: Kukjin Kim kgene@samsung.com
---
arch/arm/mach-exynos/common.c |3 ++-
arch/arm/mach-exynos/cpuidle.c |2 +-
arch/arm/mach-exynos/hotplug.c |2 +-
arch/arm/mach-exynos/mach-exynos5-dt.c |2 +-
arch/arm/mach-exynos/platsmp.c |2 +-
arch/arm/mach-exynos/pm.c |2 +-
arch/arm/mach-exynos/pm_domains.c |3 ++-
arch/arm/mach-exynos/pmu.c |2 +-
arch/arm/mach-exynos/{include/mach = }/regs-pmu.h |0
9 files changed, 10 insertions(+), 8 deletions(-)
rename arch/arm/mach-exynos/{include/mach = }/regs-pmu.h (100%)
This looks OK, but when you committed, you did the move of the include
file in another commit (e44de221d3ddb99387b04cfd49483bcd05daa6fb).
That means that between that commit and this patch, there's build
breakage. Please try to avoid that in the future since if something
needs to be bisected near here it can cause problems.
Yeah, you're right. Sorry and I'll try to avoid that per your suggestion.
Thanks,
Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [GIT PULL 2nd 2/5] Samsung cleanup for v3.14
Olof Johansson wrote: On Sun, Dec 22, 2013 at 03:23:30AM +0900, Kukjin Kim wrote: The following changes since commit 7c394e7be4d267c02eaaac8fa197a7c1b023c99b: ARM: EXYNOS: Constify clksrc immutable register restore tables (2013-12-12 07:09:33 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-cleanup-2 for you to fetch changes up to 1fd3cbccaf47aefbe3bfb026d310cd2f5d0685c6: ARM: EXYNOS: Kill exynos_pm_late_initcall() (2013-12-21 06:40:44 +0900) Samsung cleanup 2nd for v3.14 - remove mach/regs-clock.h for exynos - remove mach/regs-irq.h for exynos - local mach/regs-pmu.h into mach-exynos - select PM_GENERIC_DOMAINS for ARCH_EXYNOS4 instead of each SOC_EXYNOS4XXX in Kconfig - call pm_genpd_poweroff_unused() instead of via exynos_pm_late_initcall() because no need to handle whether CONFIG_PM_GENERIC_DOMAINS is enalbed Great! Merged into next/cleanup. See a separate comment on one of the patches when they were posted regarding bisectability though. Sure, thanks. Happy new year ;-) - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ata: pata_samsung_cf: Move plat/regs-ata.h to drivers/ata
Tejun Heo wrote: On Tue, Dec 31, 2013 at 10:59:13AM +0530, Sachin Kamat wrote: plat/regs-ata.h is used only by Samsung PATA driver. Move this file to the drivers folder to remove platform dependency required for multiplatform support. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Applied to libata/for-3.14. As this is only used by pata_samsung_cf.c, can you please follow up with a patch to roll pata_samsung_cf.h into .c? There's no point in creating separate header files for stuff which isn't shared among multiple files. Oops, I read this just now ;-) Tejun, if you've applied this in your tree already, I'm OK so please kindly ignore my previous reply. Sachin, when you move the definitions into the .c file per Tejun's suggestion, please cleanup useless definitions. Thanks and happy new year. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [GIT PULL 2nd 5/5] Samsung SoC update for v3.14
On Fri, Jan 3, 2014 at 6:17 PM, Kukjin Kim kgene@samsung.com wrote: Olof Johansson wrote: On Sun, Dec 22, 2013 at 03:23:57AM +0900, Kukjin Kim wrote: The following changes since commit 538cfbb4c40ab59688236484138133b8e3e89220: ARM: dts: Add initial support for Arndale Octa board (2013-12-16 05:05:43 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-soc-2 for you to fetch changes up to 7a28f198735d040f4d318511827d913d4b53f355: ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board (2013-12-19 05:34:26 +0900) Samsung SoC 2nd update for v3.14 - add exynos4412-tiny4412 board dt for FriendlyARM's TINY4412 board Alex Ling (1): ARM: dts: add board dts file for EXYNOS4412 based TINY4412 board arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/exynos4412-tiny4412.dts | 93 +++ 2 files changed, 94 insertions(+) create mode 100644 arch/arm/boot/dts/exynos4412-tiny4412.dts Hi, This is really just a DT patch, and given that I didn't take the base patch it makes sense to take this in a DT branch instead. Please resend on top of dt-2. Olof, you mean adding new DT is OK? Sounds good, let me send a new pull-request for exynos4412-tiny4412 and exynos5420-arndale-octa tonight, I replied with different opinion on other Sachin's email though ;-) Sachin, you don't need to concern about that :-) Yes, I'm ok with adding DT (if the DT is usable and bootable without code changes). Don't submit the DT if the required code changes are not yet in though. -Olof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/9] ARM: SAMSUNG: Remove platform dependency from samsung.S
Tushar Behera wrote: On 31 December 2013 21:08, Mark Brown broo...@kernel.org wrote: On Mon, Dec 30, 2013 at 03:30:32PM +0530, Tushar Behera wrote: From: Sachin Kamat sachin.ka...@linaro.org regs-serial.h only includes linux/serial_s3c.h. Include this header directly in samsung.S to remove unnecessary platform dependency. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- If you're forwarding on a patch from someone else you need to add your Signed-off-by to it - that's important for the whole goal of tracking licensing. Yeah, true. I forgot about that. Signed-off-by: Tushar Behera tushar.beh...@linaro.org Kukjin, While applying this series, can you please add my Signed-off-by? Tushar, The 'Signed-off-by' is different with others ack, review or whatever. In my understanding it's a legal issue so you need to repost. BTW, I think this series looks good to me but we don't need separated #1 to #8 patches because it's samething, so please squash them. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V4 1/6] clk: exynos-audss: convert to platform device
Tomasz Figa wrote: Hi Kukjin, Mike, On Monday 02 of December 2013 07:43:42 Kukjin Kim wrote: On 11/28/13 03:41, Mike Turquette wrote: Quoting Padma Venkat (2013-11-25 22:29:44) Hi Mike and Kukjin, On Tue, Oct 8, 2013 at 10:23 PM, Andrew Bresticker abres...@chromium.org wrote: Hi Mike and Kukjin, Any decisions regarding this patchset? I believe all comments have been addressed. Thanks, Andrew Any decisions on this patchset. These can be applied directly on linux-samsung tree. For all of the clk parts: Acked-by: Mike Turquettemturque...@linaro.org I'm happy to take them in as part of a pull request. OK, Mike, I will take this series into samsung tree and let me send a pull request for your clk tree to avoid useless merge conflicts. - some persons in Cc Hmm, I can't find this series in any tree, so I guess it has been lost in action. Oops, sorry about that :-( Should I take it through samsung-clk tree with your acks? Tomasz, yes please take this series with my ack. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] Samsung 3rd DT updates for v3.14
Hi Arnd, Olof and Kevin, Here is 3rd Exynos DT updates for v3.14, actually it's including new dt files for exynos4412-tiny4412 and exynos5420-arndale-octa boards. They have been included in previous pull-request but it has not been pulled because of multiplatform. However Olof agreed just adding DT like this is OK so I'm re-sending this pull-request after re-sort them out. Just note this branch is based on tags/samsung-dt-2 already pulled into arm-soc per Olof's suggestion. If any problems, please kindly let me know. Thanks, Kukjin --- The following changes since commit a22d060e3299ce672258d00070fa0ed398c035c5: ARM: dts: Rename Exynos5250 ChromeOS common file to have exynos prefix (2013-12-21 10:09:25 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-dt-3 for you to fetch changes up to b67a55125f1413902f7db6d167a8d9e4154386bf: ARM: dts: add support for EXYNOS4412 based TINY4412 board (2014-01-04 16:12:04 +0900) Samsung DT 3rd updates for v3.14 - add exynos4412-tiny4412 board dt for FriendlyARM's TINY4412 board including initial support UART, SD card and LEDs - add exynos5420-arndale-octa board dt for Arndale Octa board Alex Ling (1): ARM: dts: add support for EXYNOS4412 based TINY4412 board Sachin Kamat (1): ARM: dts: Add initial support for Arndale Octa board arch/arm/boot/dts/Makefile| 2 + arch/arm/boot/dts/exynos4412-tiny4412.dts | 93 +++ arch/arm/boot/dts/exynos5420-arndale-octa.dts | 66 +++ 3 files changed, 161 insertions(+) create mode 100644 arch/arm/boot/dts/exynos4412-tiny4412.dts create mode 100644 arch/arm/boot/dts/exynos5420-arndale-octa.dts -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
