Re: [PATCH V12 1/3] ARM: dts: Add pmu sysreg node to exynos5250 and exynos5420 dtsi files
On 1/10/14, Wim Van Sebroeck w...@iguana.be wrote: Hi Leela, This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to handle PMU register accesses in a centralized way using syscon driver Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com Reviewed-by: Doug Anderson diand...@chromium.org Tested-by: Doug Anderson diand...@chromium.org --- ... diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index b1fa334..cd47db0 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -402,4 +402,9 @@ clock-names = gscl; samsung,power-domain = gsc_pd; }; I can't add this patch since there is no gscl in the current linux-tree. Is this depending on another patch or are we going to fix this in another way? Hi Kgene, Driver changes has been merged to Wim's tree, so can you please pick this patch into your tree. Best Wishes, Leela krishna. Kind regards, Wim. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V12 3/3] ARM: dts: update watchdog device nodes for Exynos5250 and Exynos5420
On 12/7/13, Guenter Roeck li...@roeck-us.net wrote: On Fri, Dec 06, 2013 at 11:17:48AM +0530, Leela Krishna Amudala wrote: In Exynos5 series SoCs, PMU has registers to enable/disable mask/unmask watchdog timer which is not the case with s3c series SoCs so, there is a need to have different compatible names for watchdog to handle these pmu registers access. Hence this patch removes watchdog node from Exynos5.dtsi common file and make it separate by updating existing node in Exynos5250 and adding new node to Exynos5420. This patch also makes the watchdog node enabled by default Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com Reviewed-by: Doug Anderson diand...@chromium.org Tested-by: Doug Anderson diand...@chromium.org Acked-by: Guenter Roeck li...@roeck-us.net Hi Kgene, Driver changes has been merged to Wim's tree, so can you please pick this patch into your tree. Best Wishes, Leela krishna. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 4/7] ARM: dts: Exynos: add cpu nodes, opp and cpu clock frequency table
Hi Thomas, From: Thomas Abraham thomas...@samsung.com For all Exynos based platforms, add CPU nodes, operating points and cpu clock frequency table for migrating from Exynos specific cpufreq driver to using generic cpufreq-cpu0 driver. Signed-off-by: Thomas Abraham thomas...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts |6 +++ arch/arm/boot/dts/exynos4210-trats.dts |6 +++ arch/arm/boot/dts/exynos4210-universal_c210.dts |6 +++ arch/arm/boot/dts/exynos4210.dtsi | 35 ++ arch/arm/boot/dts/exynos4212.dtsi | 17 + arch/arm/boot/dts/exynos4412-odroidx.dts| 6 +++ arch/arm/boot/dts/exynos4412-origen.dts |6 +++ arch/arm/boot/dts/exynos4412-trats2.dts |6 +++ arch/arm/boot/dts/exynos4412.dtsi | 30 arch/arm/boot/dts/exynos4x12.dtsi | 35 ++ arch/arm/boot/dts/exynos5250-arndale.dts |6 +++ arch/arm/boot/dts/exynos5250-cros-common.dtsi |6 +++ arch/arm/boot/dts/exynos5250-smdk5250.dts |6 +++ arch/arm/boot/dts/exynos5250.dtsi | 43 ++- 14 files changed, 213 insertions(+), 1 deletions(-) diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts index 2aa13cb..dd17e93 100644 --- a/arch/arm/boot/dts/exynos4210-origen.dts +++ b/arch/arm/boot/dts/exynos4210-origen.dts @@ -32,6 +32,12 @@ bootargs =root=/dev/ram0 rw ramdisk=8192 initrd=0x4100,8M console=ttySAC2,115200 init=/linuxrc; }; + cpus { + cpu@0 { + cpu0-supply = buck1_reg; + }; + }; + regulators { compatible = simple-bus; #address-cells = 1; diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index 63cc571..25487d7 100644 --- a/arch/arm/boot/dts/exynos4210-trats.dts +++ b/arch/arm/boot/dts/exynos4210-trats.dts @@ -30,6 +30,12 @@ bootargs = console=ttySAC2,115200N8 root=/dev/mmcblk0p5 rootwait earlyprintk panic=5; }; + cpus { + cpu: cpu@0 { + cpu0-supply = varm_breg; + }; + }; + regulators { compatible = simple-bus; diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm/boot/dts/exynos4210-universal_c210.dts index d2e3f5f..74d5a70 100644 --- a/arch/arm/boot/dts/exynos4210-universal_c210.dts +++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts @@ -28,6 +28,12 @@ bootargs = console=ttySAC2,115200N8 root=/dev/mmcblk0p5 rw rootwait earlyprintk panic=5 maxcpus=1; }; + cpus { + cpu: cpu@0 { + cpu0-supply = vdd_arm_reg; + }; + }; + mct@1005 { compatible = none; }; diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index 48ecd7a..40cd663 100644 --- a/arch/arm/boot/dts/exynos4210.dtsi +++ b/arch/arm/boot/dts/exynos4210.dtsi @@ -36,6 +36,34 @@ reg = 0x10023CA0 0x20; }; + cpus { + #address-cells = 1; + #size-cells = 0; + cpu@0 { + device_type = cpu; + compatible = arm,cortex-a9; + reg = 0; + clocks = clock 12; + clock-names = cpu; + + operating-points = + 20 95 + 40 975000 + 50 975000 + 80 1075000 + 100 115 + 120 125 Please be consistent with operating-points definition. Here you use increasing order, when below you use decreasing one. + ; + safe-opp = 80 1075000; + }; + + cpu@1 { + device_type = cpu; + compatible = arm,cortex-a9; + reg = 1; + }; + }; + gic: interrupt-controller@1049 { cpu-offset = 0x8000; }; @@ -73,6 +101,13 @@ compatible = samsung,exynos4210-clock; reg = 0x1003 0x2; #clock-cells = 1; + + arm-frequency-table = 120 120 0 3 7 3 4 1 7 0 5 0 0, + 100 100 0 3 7 3 4 1 7 0 4 0 0, +80 80 0 3 7 3 3 1 7 0 3 0 0, +50 50 0 3 7 3 3 1 7 0 3 0 0, +40 40 0 3 7 3 3 1 7 0 3 0 0, +20 20 0 1 3 1 1 1 0 0 3 0 0; }; pmu { diff --git
Re: [PATCH v2 6/7] ARM: Exynos: switch to using generic cpufreq-cpu0 driver
Hi Thomas, From: Thomas Abraham thomas...@samsung.com Remove the platform device instantiation for Exynos specific cpufreq driver and add the platform device for cpufreq-cpu0 driver. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Thomas Abraham thomas...@samsung.com --- arch/arm/mach-exynos/common.c |5 - arch/arm/mach-exynos/common.h |1 - arch/arm/mach-exynos/mach-exynos4-dt.c |2 +- arch/arm/mach-exynos/mach-exynos5-dt.c |2 +- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index f18be40..72ae5d3 100644 --- a/arch/arm/mach-exynos/common.c +++ b/arch/arm/mach-exynos/common.c @@ -303,11 +303,6 @@ void __init exynos_cpuidle_init(void) platform_device_register(exynos_cpuidle); } -void __init exynos_cpufreq_init(void) -{ - platform_device_register_simple(exynos-cpufreq, -1, NULL, 0); -} - void __init exynos_init_late(void) { if (of_machine_is_compatible(samsung,exynos5440)) diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h index f76967b..0c31b34 100644 --- a/arch/arm/mach-exynos/common.h +++ b/arch/arm/mach-exynos/common.h @@ -22,7 +22,6 @@ void exynos_init_io(void); void exynos4_restart(enum reboot_mode mode, const char *cmd); void exynos5_restart(enum reboot_mode mode, const char *cmd); void exynos_cpuidle_init(void); -void exynos_cpufreq_init(void); void exynos_init_late(void); void exynos_firmware_init(void); diff --git a/arch/arm/mach-exynos/mach-exynos4-dt.c b/arch/arm/mach-exynos/mach-exynos4-dt.c index d3e54b7..9a25320 100644 --- a/arch/arm/mach-exynos/mach-exynos4-dt.c +++ b/arch/arm/mach-exynos/mach-exynos4-dt.c @@ -22,8 +22,8 @@ static void __init exynos4_dt_machine_init(void) { exynos_cpuidle_init(); - exynos_cpufreq_init(); + platform_device_register_simple(cpufreq-cpu0, -1, NULL, 0); of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c index 37ea261..9dc3710 100644 --- a/arch/arm/mach-exynos/mach-exynos5-dt.c +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c @@ -44,8 +44,8 @@ static void __init exynos5_dt_machine_init(void) } exynos_cpuidle_init(); - exynos_cpufreq_init(); + platform_device_register_simple(cpufreq-cpu0, -1, NULL, 0); of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } Reviewed-by: Lukasz Majewski l.majew...@samsung.com -- Best regards, Lukasz Majewski Samsung RD Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html