Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support
Andreas, On Thu, Jul 31, 2014 at 7:52 PM, Andreas Färber afaer...@suse.de wrote: Am 31.07.2014 12:23, schrieb Thierry Reding: On Thu, Jul 31, 2014 at 10:57:55AM +0200, Andreas Färber wrote: Am 31.07.2014 10:38, schrieb Ajay kumar: With just the spring-bridge.v6 branch of your own tree, I am able to see bootup logo on Skate(a variant of spring which also contains ps8622). I have tried both exynos_defconfig and multi_v7_defconfig. I enable DRM, EXYNOS DRM, BRIDGE CHIPS, IOMMU, EXYNOS IOMMU in configs. [...] If you have something like simplefb enabled in addition to a DRM driver, then perhaps the DRM driver isn't properly taking over the framebuffer console. So, with simplefb reverted in U-Boot and ... * with just the v6 applied (...~2), I get only a black screen from Linux, no penguins, but the backlight seems on. System comes up okay, ssh available, and nothing stands out in dmesg. * with the two iommu patches on top, something breaks badly, no backlight, no USB/network, system inaccessible. I.e. U-Boot had no noticeable impact on these symptoms. * with the iommu patches, but dp-controller, ps8622, panel commented out, I do get backlight but USB/network not working, system inaccessible. With simplefb support in U-Boot and with just v6 applied, but dp-controller, ps8622, panel commented out, things work as well as before, i.e. this series has no bad side effects. Note that I never claimed Ajay's series were broken, just reported that things regressed for me from v4, which may well be DT-related. The iommu patches interfere with my USB somehow (none or not all devices powered; with v4, plugging my wifi dongle led to oops but ethernet dongle worked, so not entirely new symptom), which is bad since my rootfs is on USB. The internal SDIO-connected Wifi is not enabled yet, so USB based network is my only alternative to a working display once we reach userspace. Well, there are 2 variants here: 1) Bootloader 2) config Type of the bootloader should not matter unless its switching on FET1 and FET6 of tps65090 for you. But, config can be different! I have attached a config i used to get display with your latest spring-bridge.v6. Uncomment the DT nodes for DP and bridge chip and you should be able to get display and also the login. I think that you have not selected all the configs needed for IOMMU to work properly. When I deselected few IOMMU configs, I could see system crashing when FIMD + DP path was being initialized. May be, that is why your USB stops working. Even I have root file system on USB drive. Just give a try with this config and let me know your observation. If you still observe the same behavior, may be I need to flash new bootloader onto my board and try. :( Ajay # # Automatically generated file; DO NOT EDIT. # Linux/arm 3.16.0-rc6 Kernel Configuration # CONFIG_ARM=y CONFIG_ARM_HAS_SG_CHAIN=y CONFIG_NEED_SG_DMA_LENGTH=y CONFIG_ARM_DMA_USE_IOMMU=y CONFIG_ARM_DMA_IOMMU_ALIGNMENT=8 CONFIG_MIGHT_HAVE_PCI=y CONFIG_SYS_SUPPORTS_APM_EMULATION=y CONFIG_HAVE_PROC_CPU=y CONFIG_NO_IOPORT_MAP=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_TRACE_IRQFLAGS_SUPPORT=y CONFIG_RWSEM_XCHGADD_ALGORITHM=y CONFIG_ARCH_HAS_BANDGAP=y CONFIG_GENERIC_HWEIGHT=y CONFIG_GENERIC_CALIBRATE_DELAY=y CONFIG_NEED_DMA_MAP_STATE=y CONFIG_ARCH_SUPPORTS_UPROBES=y CONFIG_VECTORS_BASE=0x CONFIG_ARM_PATCH_PHYS_VIRT=y CONFIG_GENERIC_BUG=y CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config CONFIG_IRQ_WORK=y CONFIG_BUILDTIME_EXTABLE_SORT=y # # General setup # CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_CROSS_COMPILE= # CONFIG_COMPILE_TEST is not set CONFIG_LOCALVERSION= CONFIG_LOCALVERSION_AUTO=y CONFIG_HAVE_KERNEL_GZIP=y CONFIG_HAVE_KERNEL_LZMA=y CONFIG_HAVE_KERNEL_XZ=y CONFIG_HAVE_KERNEL_LZO=y CONFIG_HAVE_KERNEL_LZ4=y CONFIG_KERNEL_GZIP=y # CONFIG_KERNEL_LZMA is not set # CONFIG_KERNEL_XZ is not set # CONFIG_KERNEL_LZO is not set # CONFIG_KERNEL_LZ4 is not set CONFIG_DEFAULT_HOSTNAME=(none) CONFIG_SWAP=y CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y # CONFIG_POSIX_MQUEUE is not set CONFIG_CROSS_MEMORY_ATTACH=y # CONFIG_FHANDLE is not set CONFIG_USELIB=y # CONFIG_AUDIT is not set CONFIG_HAVE_ARCH_AUDITSYSCALL=y # # IRQ subsystem # CONFIG_GENERIC_IRQ_PROBE=y CONFIG_GENERIC_IRQ_SHOW=y CONFIG_HARDIRQS_SW_RESEND=y CONFIG_GENERIC_IRQ_CHIP=y CONFIG_IRQ_DOMAIN=y CONFIG_IRQ_FORCED_THREADING=y CONFIG_SPARSE_IRQ=y CONFIG_KTIME_SCALAR=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BUILD=y CONFIG_ARCH_HAS_TICK_BROADCAST=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y # # Timers subsystem # CONFIG_TICK_ONESHOT=y CONFIG_NO_HZ_COMMON=y # CONFIG_HZ_PERIODIC is not set CONFIG_NO_HZ_IDLE=y # CONFIG_NO_HZ_FULL is not set CONFIG_NO_HZ=y CONFIG_HIGH_RES_TIMERS=y # # CPU/Task time and stats accounting # CONFIG_TICK_CPU_ACCOUNTING=y # CONFIG_VIRT_CPU_ACCOUNTING_GEN is not set # CONFIG_IRQ_TIME_ACCOUNTING is not set # CONFIG_BSD_PROCESS_ACCT is not set # CONFIG_TASKSTATS is not set # # RCU
[FIX][RESEND PATCH v3] ARM: EXYNOS: Fix suspend/resume sequences
From: Tomasz Figa t.f...@samsung.com
Due to recent consolidation of Exynos suspend and cpuidle code, some
parts of suspend and resume sequences are executed two times, once from
exynos_pm_syscore_ops and then from exynos_cpu_pm_notifier() and thus it
breaks suspend, at least on Exynos4-based boards. In addition, simple
core power down from a cpuidle driver could, in case of CPU 0 could
result in calling functions that are specific to suspend and deeper idle
states.
This patch fixes the issue by moving those operations outside the CPU PM
notifier into suspend and AFTR code paths. This leads to a bit of code
duplication, but allows additional code simplification, so in the end
more code is removed than added.
Fixes: 85f9f90808b4 (ARM: EXYNOS: Use the cpu_pm notifier for pm)
Cc: Kukjin Kim kgene@samsung.com
Cc: Arnd Bergmann a...@arndb.de
Cc: Olof Johansson o...@lixom.net
Cc: a...@kernel.org
Signed-off-by: Tomasz Figa t.f...@samsung.com
---
arch/arm/mach-exynos/pm.c| 164 ++-
drivers/cpuidle/cpuidle-exynos.c | 25 +-
2 files changed, 80 insertions(+), 109 deletions(-)
This is resend of a regression fix sent more than two weeks ago (July, 15;
[1]), without any response from respective maintainers. It fixes
a significant regression breaking suspend/resume on Exynos4-based systems.
I know we already have -rc7, but this patch in its first iteration was
sent more than a month ago (June, 24; [2]) and it changed only for
convenience of authors of further patches, to either avoid conflicts ([3])
or reduce the need of changes to support more functionality later (as
discussed in [4]). However it should have had priority over clean-up or
functional patches, which was apparently not the case.
[1] https://lkml.org/lkml/2014/7/15/319
[2] https://lkml.org/lkml/2014/6/24/290
[3] https://lkml.org/lkml/2014/6/24/351
[4] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29085/focus=33975
diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
index 202ca73e49c4..e3b04b45f39b 100644
--- a/arch/arm/mach-exynos/pm.c
+++ b/arch/arm/mach-exynos/pm.c
@@ -176,26 +176,6 @@ int exynos_cluster_power_state(int cluster)
#define S5P_CHECK_AFTR 0xFCBA0D10
#define S5P_CHECK_SLEEP 0x0BAD
-/* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */
-static void exynos_set_wakeupmask(long mask)
-{
- __raw_writel(mask, S5P_WAKEUP_MASK);
-}
-
-static void exynos_cpu_set_boot_vector(long flags)
-{
- __raw_writel(virt_to_phys(exynos_cpu_resume), EXYNOS_BOOT_VECTOR_ADDR);
- __raw_writel(flags, EXYNOS_BOOT_VECTOR_FLAG);
-}
-
-void exynos_enter_aftr(void)
-{
- exynos_set_wakeupmask(0xff3e);
- exynos_cpu_set_boot_vector(S5P_CHECK_AFTR);
- /* Set value of power down register for aftr mode */
- exynos_sys_powerdown_conf(SYS_AFTR);
-}
-
/* For Cortex-A9 Diagnostic and Power control register */
static unsigned int save_arm_register[2];
@@ -235,6 +215,82 @@ static void exynos_cpu_restore_register(void)
: cc);
}
+static void exynos_pm_central_suspend(void)
+{
+ unsigned long tmp;
+
+ /* Setting Central Sequence Register for power down mode */
+ tmp = __raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
+ tmp = ~S5P_CENTRAL_LOWPWR_CFG;
+ __raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
+}
+
+static int exynos_pm_central_resume(void)
+{
+ unsigned long tmp;
+
+ /*
+* If PMU failed while entering sleep mode, WFI will be
+* ignored by PMU and then exiting cpu_do_idle().
+* S5P_CENTRAL_LOWPWR_CFG bit will not be set automatically
+* in this situation.
+*/
+ tmp = __raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
+ if (!(tmp S5P_CENTRAL_LOWPWR_CFG)) {
+ tmp |= S5P_CENTRAL_LOWPWR_CFG;
+ __raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
+ /* clear the wakeup state register */
+ __raw_writel(0x0, S5P_WAKEUP_STAT);
+ /* No need to perform below restore code */
+ return -1;
+ }
+
+ return 0;
+}
+
+/* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */
+static void exynos_set_wakeupmask(long mask)
+{
+ __raw_writel(mask, S5P_WAKEUP_MASK);
+}
+
+static void exynos_cpu_set_boot_vector(long flags)
+{
+ __raw_writel(virt_to_phys(exynos_cpu_resume), EXYNOS_BOOT_VECTOR_ADDR);
+ __raw_writel(flags, EXYNOS_BOOT_VECTOR_FLAG);
+}
+
+static int exynos_aftr_finisher(unsigned long flags)
+{
+ exynos_set_wakeupmask(0xff3e);
+ exynos_cpu_set_boot_vector(S5P_CHECK_AFTR);
+ /* Set value of power down register for aftr mode */
+ exynos_sys_powerdown_conf(SYS_AFTR);
+ cpu_do_idle();
+
+ return 0;
+}
+
+void exynos_enter_aftr(void)
+{
+ cpu_pm_enter();
+
+ exynos_pm_central_suspend();
+ if (read_cpuid_part_number() == ARM_CPU_PART_CORTEX_A9)
+
Re: [PATCHv9 1/5] mmc: dw_mmc: Slot quirk disable-wp is deprecated.
Am Freitag, 1. August 2014, 13:26:43 schrieb Jaehoon Chung: Hi, All. It seems too late that this patch-set is merged into linux-3.16. Also there are some conflicts in device-tree. (I will remove the conflicts) So if everybody is ok, I will rebase on linux-next after released linux-3.16. At that time, i will send this patch-set to stable kernel, too. how about? And I want to know who can apply this patch-set(#3~#5). I guess each SoC maintainer could take the changes to their work-area, once the core changes have landed in the mmc tree. So I would take the Rockchip patch, Kukjin the Exynos one and Dinh the socfpga patch. Heiko Best Regards, Jaehoon Chung On 08/01/2014 03:36 AM, Kukjin Kim wrote: On 08/01/14 01:02, Doug Anderson wrote: Jaehoon On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chungjh80.ch...@samsung.com wrote: Slot quirks disable-wp is deprecated. Instead, use the host quirk disable-wp. (Because the slot-node is removed in dt-file.) Signed-off-by: Jaehoon Chungjh80.ch...@samsung.com Tested-by: Sachin Kamatsachin.ka...@samsung.com Acked-by: Seungwon Jeontgih@samsung.com --- drivers/mmc/host/dw_mmc.c | 11 +-- include/linux/mmc/dw_mmc.h |2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) Thanks for taking my suggestion and making it backward compatible. This looks great to me. It tested this in both the backward compatible way (with the warning) and the non-backward compatible way. I think we should land and patch #2 ASAP and then we can land the rest of the series as SoC maintainers see fit. Yes, right if we don't want to see useless merge conflicts... When I sent ack on exynos stuff, there was no conflict with my tree but happens it now. - Kukjin Reviewed-by: Doug Andersondiand...@chromium.org Tested-by: Doug Andersondiand...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 06/15] drm/exynos: dpi: Add support for panel prepare and unprepare routines
On Thu, Jul 31, 2014 at 11:12:05PM +0530, Ajay Kumar wrote: Modify exynos_dpi driver to support the new panel calls: prepare and unprepare. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dpi.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Looks good to me. Inki, can I have your Acked-by to take this through the panel tree? Thierry pgpeW2tiZINOo.pgp Description: PGP signature
Re: [PATCH 07/15] drm/exynos: dsi: Add support for panel prepare and unprepare routines
On Thu, Jul 31, 2014 at 11:12:06PM +0530, Ajay Kumar wrote: Modify exynos_dsi driver to support the new panel calls: prepare and unprepare. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) And this one as well. Thierry pgp0M4Bxenabd.pgp Description: PGP signature
Re: [PATCH 15/15] drm/exynos: dp: Modify driver to support drm_panel
On Thu, Jul 31, 2014 at 11:12:14PM +0530, Ajay Kumar wrote: Add drm_panel controls to support powerup/down of the eDP panel, if one is present at the sink side. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/Kconfig |1 + drivers/gpu/drm/exynos/exynos_dp_core.c | 88 --- drivers/gpu/drm/exynos/exynos_dp_core.h |3 +- 3 files changed, 71 insertions(+), 21 deletions(-) Inki, I'll need an Acked-by from you on this one as well. It has a build time dependency on earlier patches in this series, so taking it through the panel tree along with the rest is probably easiest. Thierry pgpEZ7NTHmxHr.pgp Description: PGP signature
Re: [PATCH 14/15] drm/exynos: Move DP setup into commit()
On Thu, Jul 31, 2014 at 11:12:13PM +0530, Ajay Kumar wrote:
Add commit callback for exynos_dp, and move the DP link training,
video configuration code from the hotplug handler into commit().
Signed-off-by: Sean Paul seanp...@chromium.org
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
This is not related to the other patches in the series, so it can be
applied independently.
Sean, this looks like a back-/forward-port of the patch you linked to in
reply to an earlier version of the series, does this still correspond to
what you think it should be doing? (hence not trimming the quote)
Thierry
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 31c3de9..347dec9 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -875,10 +875,18 @@ static irqreturn_t exynos_dp_irq_handler(int irq, void
*arg)
static void exynos_dp_hotplug(struct work_struct *work)
{
struct exynos_dp_device *dp;
- int ret;
dp = container_of(work, struct exynos_dp_device, hotplug_work);
+ if (dp-drm_dev)
+ drm_helper_hpd_irq_event(dp-drm_dev);
+}
+
+static void exynos_dp_commit(struct exynos_drm_display *display)
+{
+ struct exynos_dp_device *dp = display-ctx;
+ int ret;
+
ret = exynos_dp_detect_hpd(dp);
if (ret) {
/* Cable has been disconnected, we're done */
@@ -1050,8 +1058,10 @@ static void exynos_dp_phy_exit(struct exynos_dp_device
*dp)
}
}
-static void exynos_dp_poweron(struct exynos_dp_device *dp)
+static void exynos_dp_poweron(struct exynos_drm_display *display)
{
+ struct exynos_dp_device *dp = display-ctx;
+
if (dp-dpms_mode == DRM_MODE_DPMS_ON)
return;
@@ -1059,10 +1069,13 @@ static void exynos_dp_poweron(struct exynos_dp_device
*dp)
exynos_dp_phy_init(dp);
exynos_dp_init_dp(dp);
enable_irq(dp-irq);
+ exynos_dp_commit(display);
}
-static void exynos_dp_poweroff(struct exynos_dp_device *dp)
+static void exynos_dp_poweroff(struct exynos_drm_display *display)
{
+ struct exynos_dp_device *dp = display-ctx;
+
if (dp-dpms_mode != DRM_MODE_DPMS_ON)
return;
@@ -1078,12 +1091,12 @@ static void exynos_dp_dpms(struct exynos_drm_display
*display, int mode)
switch (mode) {
case DRM_MODE_DPMS_ON:
- exynos_dp_poweron(dp);
+ exynos_dp_poweron(display);
break;
case DRM_MODE_DPMS_STANDBY:
case DRM_MODE_DPMS_SUSPEND:
case DRM_MODE_DPMS_OFF:
- exynos_dp_poweroff(dp);
+ exynos_dp_poweroff(display);
break;
default:
break;
@@ -1094,6 +1107,7 @@ static void exynos_dp_dpms(struct exynos_drm_display
*display, int mode)
static struct exynos_drm_display_ops exynos_dp_display_ops = {
.create_connector = exynos_dp_create_connector,
.dpms = exynos_dp_dpms,
+ .commit = exynos_dp_commit,
};
static struct exynos_drm_display exynos_dp_display = {
--
1.7.9.5
pgpT97LcF4iWp.pgp
Description: PGP signature
Re: [PATCH 06/15] drm/exynos: dpi: Add support for panel prepare and unprepare routines
On 2014년 08월 01일 18:04, Thierry Reding wrote: On Thu, Jul 31, 2014 at 11:12:05PM +0530, Ajay Kumar wrote: Modify exynos_dpi driver to support the new panel calls: prepare and unprepare. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dpi.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Looks good to me. Inki, can I have your Acked-by to take this through the panel tree? Of course. Acked-by: Inki Dae inki@samsung.com Thanks, Inki Dae Thierry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 15/15] drm/exynos: dp: Modify driver to support drm_panel
On 2014년 08월 01일 18:09, Thierry Reding wrote: On Thu, Jul 31, 2014 at 11:12:14PM +0530, Ajay Kumar wrote: Add drm_panel controls to support powerup/down of the eDP panel, if one is present at the sink side. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/Kconfig |1 + drivers/gpu/drm/exynos/exynos_dp_core.c | 88 --- drivers/gpu/drm/exynos/exynos_dp_core.h |3 +- 3 files changed, 71 insertions(+), 21 deletions(-) Inki, I'll need an Acked-by from you on this one as well. It has a build time dependency on earlier patches in this series, so taking it through the panel tree along with the rest is probably easiest. Acked-by: Inki Dae inki@samsung.com Thanks, Inki Dae Thierry -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 14/15] drm/exynos: Move DP setup into commit()
On Fri, Aug 1, 2014 at 2:48 PM, Thierry Reding thierry.red...@gmail.com wrote:
On Thu, Jul 31, 2014 at 11:12:13PM +0530, Ajay Kumar wrote:
Add commit callback for exynos_dp, and move the DP link training,
video configuration code from the hotplug handler into commit().
Signed-off-by: Sean Paul seanp...@chromium.org
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
drivers/gpu/drm/exynos/exynos_dp_core.c | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
This is not related to the other patches in the series, so it can be
applied independently.
This patch should go in this series only.
[PATCH 15/15] has dependency on this because it modifies exynos_dp_commit().
Sean, this looks like a back-/forward-port of the patch you linked to in
reply to an earlier version of the series, does this still correspond to
what you think it should be doing? (hence not trimming the quote)
Sean said one of his test app fails since exynos_dp_commit was missing
in previous version of this patch.
Now, I have added exynos_dp_commit as he suggested, and the side effect
because of this addition (video reconfiguration glitch) is taken care by the
panel calls in the next patch [PATCH 15/15].
Ajay
diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
b/drivers/gpu/drm/exynos/exynos_dp_core.c
index 31c3de9..347dec9 100644
--- a/drivers/gpu/drm/exynos/exynos_dp_core.c
+++ b/drivers/gpu/drm/exynos/exynos_dp_core.c
@@ -875,10 +875,18 @@ static irqreturn_t exynos_dp_irq_handler(int irq, void
*arg)
static void exynos_dp_hotplug(struct work_struct *work)
{
struct exynos_dp_device *dp;
- int ret;
dp = container_of(work, struct exynos_dp_device, hotplug_work);
+ if (dp-drm_dev)
+ drm_helper_hpd_irq_event(dp-drm_dev);
+}
+
+static void exynos_dp_commit(struct exynos_drm_display *display)
+{
+ struct exynos_dp_device *dp = display-ctx;
+ int ret;
+
ret = exynos_dp_detect_hpd(dp);
if (ret) {
/* Cable has been disconnected, we're done */
@@ -1050,8 +1058,10 @@ static void exynos_dp_phy_exit(struct
exynos_dp_device *dp)
}
}
-static void exynos_dp_poweron(struct exynos_dp_device *dp)
+static void exynos_dp_poweron(struct exynos_drm_display *display)
{
+ struct exynos_dp_device *dp = display-ctx;
+
if (dp-dpms_mode == DRM_MODE_DPMS_ON)
return;
@@ -1059,10 +1069,13 @@ static void exynos_dp_poweron(struct
exynos_dp_device *dp)
exynos_dp_phy_init(dp);
exynos_dp_init_dp(dp);
enable_irq(dp-irq);
+ exynos_dp_commit(display);
}
-static void exynos_dp_poweroff(struct exynos_dp_device *dp)
+static void exynos_dp_poweroff(struct exynos_drm_display *display)
{
+ struct exynos_dp_device *dp = display-ctx;
+
if (dp-dpms_mode != DRM_MODE_DPMS_ON)
return;
@@ -1078,12 +1091,12 @@ static void exynos_dp_dpms(struct exynos_drm_display
*display, int mode)
switch (mode) {
case DRM_MODE_DPMS_ON:
- exynos_dp_poweron(dp);
+ exynos_dp_poweron(display);
break;
case DRM_MODE_DPMS_STANDBY:
case DRM_MODE_DPMS_SUSPEND:
case DRM_MODE_DPMS_OFF:
- exynos_dp_poweroff(dp);
+ exynos_dp_poweroff(display);
break;
default:
break;
@@ -1094,6 +1107,7 @@ static void exynos_dp_dpms(struct exynos_drm_display
*display, int mode)
static struct exynos_drm_display_ops exynos_dp_display_ops = {
.create_connector = exynos_dp_create_connector,
.dpms = exynos_dp_dpms,
+ .commit = exynos_dp_commit,
};
static struct exynos_drm_display exynos_dp_display = {
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
On 1 August 2014 00:04, Thomas Abraham ta.oma...@gmail.com wrote: You had acked the cpufreq related changes in v7 of this series. But there were some changes in v8 and so I have not included your Ack for v8 and v9. Could you please have one more look at the patches 4/6 [1] and 5/6 [2] of this v9 series and let me know if it looks okay. [1] http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34865.html [2] http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg34864.html Looks fine.. Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 06/15] drm/exynos: dpi: Add support for panel prepare and unprepare routines
On Fri, Aug 01, 2014 at 06:24:42PM +0900, Inki Dae wrote: On 2014년 08월 01일 18:04, Thierry Reding wrote: On Thu, Jul 31, 2014 at 11:12:05PM +0530, Ajay Kumar wrote: Modify exynos_dpi driver to support the new panel calls: prepare and unprepare. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dpi.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Looks good to me. Inki, can I have your Acked-by to take this through the panel tree? Of course. Acked-by: Inki Dae inki@samsung.com I'll take it that this Acked-by applies also to patch 07/15? Thierry pgpo_jrz_IT3K.pgp Description: PGP signature
Re: [PATCH 14/15] drm/exynos: Move DP setup into commit()
On Fri, Aug 01, 2014 at 03:11:37PM +0530, Ajay kumar wrote: On Fri, Aug 1, 2014 at 2:48 PM, Thierry Reding thierry.red...@gmail.com wrote: On Thu, Jul 31, 2014 at 11:12:13PM +0530, Ajay Kumar wrote: Add commit callback for exynos_dp, and move the DP link training, video configuration code from the hotplug handler into commit(). Signed-off-by: Sean Paul seanp...@chromium.org Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_dp_core.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) This is not related to the other patches in the series, so it can be applied independently. This patch should go in this series only. [PATCH 15/15] has dependency on this because it modifies exynos_dp_commit(). Okay, I'll apply it to the panel tree. Inki, can I assume your Acked-by from patch 06/15 applies to this one as well? Thierry pgpiPukLIYlvH.pgp Description: PGP signature
Re: [PATCH 00/15] drm/panel: Add prepare and unprepare routines
On Thu, Jul 31, 2014 at 11:11:59PM +0530, Ajay Kumar wrote: This series is based on exynos-drm-next branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git This is originally a part of the bridge chip series: http://www.spinics.net/lists/linux-samsung-soc/msg34826.html But, since we can handle panel and bridge chips seperately, I thought of seperating them. This patchset basically extends the drm panel framework to accomodate wider range of panels with strict timing sequence for enabling panel power, backlight enable, etc. I have tested this patchset on exynos5800-peach-pi board. Thierry: As discussed, I have seperated patches such that they won't break the compilation in between. Also, I have incorporated all the comments given by you for panel patches. I assume you have already taken [PATCH 01/15] and hence it can be dropped from this patchset. Ajay Kumar (15): [PATCH 01/15] drm/panel: add prepare and unprepare routines [PATCH 02/15] drm/panel: Add get_modes helper [PATCH 03/15] drm/panel: ld9040: Add dummy prepare and unprepare routines [PATCH 04/15] drm/panel: s6e8aa0: Add dummy prepare and unprepare routines [PATCH 05/15] drm/panel: simple: Add dummy prepare and unprepare routines [PATCH 06/15] drm/exynos: dpi: Add support for panel prepare and unprepare routines [PATCH 07/15] drm/exynos: dsi: Add support for panel prepare and unprepare routines [PATCH 08/15] drm/tegra: Add support for panel prepare and unprepare routines [PATCH 09/15] drm/panel: ld9040: Add proper definition for prepare and unprepare [PATCH 10/15] drm/panel: s6e8aa0: Add proper definition for prepare and unprepare [PATCH 11/15] drm/panel: simple: Add proper definition for prepare and unprepare [PATCH 12/15] drm/panel: simple: Support usage of delays in panel functions [PATCH 13/15] drm/panel: simple: Add support for auo_b133htn01 panel [PATCH 14/15] drm/exynos: Move DP setup into commit() [PATCH 15/15] drm/exynos: dp: Modify driver to support drm_panel I already had patches 01/15 and 02/15, but I've applied the rest of the series. I went out on a limb and applied Inki's Acked-by to all Exynos- related patches, assuming that was the intention. Thierry pgpEgL1ITV3bo.pgp Description: PGP signature
Re: [FIX][RESEND PATCH v3] ARM: EXYNOS: Fix suspend/resume sequences
Hi,
On Friday, August 01, 2014 10:51:37 AM Tomasz Figa wrote:
From: Tomasz Figa t.f...@samsung.com
Due to recent consolidation of Exynos suspend and cpuidle code, some
parts of suspend and resume sequences are executed two times, once from
exynos_pm_syscore_ops and then from exynos_cpu_pm_notifier() and thus it
breaks suspend, at least on Exynos4-based boards. In addition, simple
core power down from a cpuidle driver could, in case of CPU 0 could
result in calling functions that are specific to suspend and deeper idle
states.
This patch fixes the issue by moving those operations outside the CPU PM
notifier into suspend and AFTR code paths. This leads to a bit of code
duplication, but allows additional code simplification, so in the end
more code is removed than added.
Fixes: 85f9f90808b4 (ARM: EXYNOS: Use the cpu_pm notifier for pm)
Cc: Kukjin Kim kgene@samsung.com
Cc: Arnd Bergmann a...@arndb.de
Cc: Olof Johansson o...@lixom.net
Cc: a...@kernel.org
Signed-off-by: Tomasz Figa t.f...@samsung.com
---
arch/arm/mach-exynos/pm.c| 164
++-
drivers/cpuidle/cpuidle-exynos.c | 25 +-
2 files changed, 80 insertions(+), 109 deletions(-)
This is resend of a regression fix sent more than two weeks ago (July, 15;
[1]), without any response from respective maintainers. It fixes
a significant regression breaking suspend/resume on Exynos4-based systems.
I know we already have -rc7, but this patch in its first iteration was
sent more than a month ago (June, 24; [2]) and it changed only for
convenience of authors of further patches, to either avoid conflicts ([3])
or reduce the need of changes to support more functionality later (as
discussed in [4]). However it should have had priority over clean-up or
functional patches, which was apparently not the case.
This is not quite right, your initial version needed to be changed also
because of potential problems (https://lkml.org/lkml/2014/7/15/206).
However the current version (from two weeks ago) is fine and IMO still
should be merged as a _regression_ fix for v3.16 (despite not being
a tiny patch).
Also FWIW:
Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung RD Institute Poland
Samsung Electronics
[1] https://lkml.org/lkml/2014/7/15/319
[2] https://lkml.org/lkml/2014/6/24/290
[3] https://lkml.org/lkml/2014/6/24/351
[4] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29085/focus=33975
diff --git a/arch/arm/mach-exynos/pm.c b/arch/arm/mach-exynos/pm.c
index 202ca73e49c4..e3b04b45f39b 100644
--- a/arch/arm/mach-exynos/pm.c
+++ b/arch/arm/mach-exynos/pm.c
@@ -176,26 +176,6 @@ int exynos_cluster_power_state(int cluster)
#define S5P_CHECK_AFTR 0xFCBA0D10
#define S5P_CHECK_SLEEP 0x0BAD
-/* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */
-static void exynos_set_wakeupmask(long mask)
-{
- __raw_writel(mask, S5P_WAKEUP_MASK);
-}
-
-static void exynos_cpu_set_boot_vector(long flags)
-{
- __raw_writel(virt_to_phys(exynos_cpu_resume), EXYNOS_BOOT_VECTOR_ADDR);
- __raw_writel(flags, EXYNOS_BOOT_VECTOR_FLAG);
-}
-
-void exynos_enter_aftr(void)
-{
- exynos_set_wakeupmask(0xff3e);
- exynos_cpu_set_boot_vector(S5P_CHECK_AFTR);
- /* Set value of power down register for aftr mode */
- exynos_sys_powerdown_conf(SYS_AFTR);
-}
-
/* For Cortex-A9 Diagnostic and Power control register */
static unsigned int save_arm_register[2];
@@ -235,6 +215,82 @@ static void exynos_cpu_restore_register(void)
: cc);
}
+static void exynos_pm_central_suspend(void)
+{
+ unsigned long tmp;
+
+ /* Setting Central Sequence Register for power down mode */
+ tmp = __raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
+ tmp = ~S5P_CENTRAL_LOWPWR_CFG;
+ __raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
+}
+
+static int exynos_pm_central_resume(void)
+{
+ unsigned long tmp;
+
+ /*
+ * If PMU failed while entering sleep mode, WFI will be
+ * ignored by PMU and then exiting cpu_do_idle().
+ * S5P_CENTRAL_LOWPWR_CFG bit will not be set automatically
+ * in this situation.
+ */
+ tmp = __raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
+ if (!(tmp S5P_CENTRAL_LOWPWR_CFG)) {
+ tmp |= S5P_CENTRAL_LOWPWR_CFG;
+ __raw_writel(tmp, S5P_CENTRAL_SEQ_CONFIGURATION);
+ /* clear the wakeup state register */
+ __raw_writel(0x0, S5P_WAKEUP_STAT);
+ /* No need to perform below restore code */
+ return -1;
+ }
+
+ return 0;
+}
+
+/* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */
+static void exynos_set_wakeupmask(long mask)
+{
+ __raw_writel(mask, S5P_WAKEUP_MASK);
+}
+
+static void exynos_cpu_set_boot_vector(long flags)
+{
+ __raw_writel(virt_to_phys(exynos_cpu_resume),
Re: [PATCH v5 06/10] ARM: dts: Clean up exynos5250-smdk5250
Am 01.08.2014 06:54, schrieb Andreas Färber:
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index ff1c09607631..30482fc523f9 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -215,7 +215,7 @@
clock-names = fimg2d;
};
- codec@1100 {
+ codec: codec@1100 {
compatible = samsung,mfc-v6;
reg = 0x1100 0x1;
interrupts = 0 96 0;
I notice that Ajay's iommu patch uses mfc here, so let's use it here,
too. Affects patches 7 and 10.
Andreas
@@ -258,7 +258,7 @@
clock-names = uart, clk_uart_baud0;
};
- sata@122F {
+ sata: sata@122F {
compatible = snps,dwc-ahci;
samsung,sata-freq = 66;
reg = 0x122F 0x1ff;
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support
Hi Ajay, Am 01.08.2014 09:02, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 7:52 PM, Andreas Färber afaer...@suse.de wrote: So, with simplefb reverted in U-Boot and ... * with just the v6 applied (...~2), I get only a black screen from Linux, no penguins, but the backlight seems on. System comes up okay, ssh available, and nothing stands out in dmesg. * with the two iommu patches on top, something breaks badly, no backlight, no USB/network, system inaccessible. I.e. U-Boot had no noticeable impact on these symptoms. * with the iommu patches, but dp-controller, ps8622, panel commented out, I do get backlight but USB/network not working, system inaccessible. With simplefb support in U-Boot and with just v6 applied, but dp-controller, ps8622, panel commented out, things work as well as before, i.e. this series has no bad side effects. Note that I never claimed Ajay's series were broken, just reported that things regressed for me from v4, which may well be DT-related. The iommu patches interfere with my USB somehow (none or not all devices powered; with v4, plugging my wifi dongle led to oops but ethernet dongle worked, so not entirely new symptom), which is bad since my rootfs is on USB. The internal SDIO-connected Wifi is not enabled yet, so USB based network is my only alternative to a working display once we reach userspace. Well, there are 2 variants here: 1) Bootloader 2) config Type of the bootloader should not matter unless its switching on FET1 and FET6 of tps65090 for you. But, config can be different! I have attached a config i used to get display with your latest spring-bridge.v6. Uncomment the DT nodes for DP and bridge chip and you should be able to get display and also the login. I think that you have not selected all the configs needed for IOMMU to work properly. When I deselected few IOMMU configs, I could see system crashing when FIMD + DP path was being initialized. May be, that is why your USB stops working. Even I have root file system on USB drive. Find attached a diff between our configs. The following stand out: * I have LPAE enabled * you don't have DMA enabled * I have CMA enabled (like in the new defconfigs) * I have the arch timer disabled (which you suggested earlier for delay) * I have more devices enabled (SPI, PWM, cpufreq, watchdog, ...) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg --- .config 2014-08-01 14:03:18.255022463 +0200 +++ ../config-ajay.txt 2014-08-01 13:19:01.875021197 +0200 @@ -34,7 +34,7 @@ CONFIG_CROSS_COMPILE= # CONFIG_COMPILE_TEST is not set CONFIG_LOCALVERSION= -# CONFIG_LOCALVERSION_AUTO is not set +CONFIG_LOCALVERSION_AUTO=y CONFIG_HAVE_KERNEL_GZIP=y CONFIG_HAVE_KERNEL_LZMA=y CONFIG_HAVE_KERNEL_XZ=y @@ -51,7 +51,7 @@ CONFIG_SYSVIPC_SYSCTL=y # CONFIG_POSIX_MQUEUE is not set CONFIG_CROSS_MEMORY_ATTACH=y -CONFIG_FHANDLE=y +# CONFIG_FHANDLE is not set CONFIG_USELIB=y # CONFIG_AUDIT is not set CONFIG_HAVE_ARCH_AUDITSYSCALL=y @@ -106,19 +106,10 @@ # CONFIG_TREE_RCU_TRACE is not set # CONFIG_RCU_BOOST is not set # CONFIG_RCU_NOCB_CPU is not set -CONFIG_IKCONFIG=y -CONFIG_IKCONFIG_PROC=y +# CONFIG_IKCONFIG is not set CONFIG_LOG_BUF_SHIFT=17 CONFIG_GENERIC_SCHED_CLOCK=y -CONFIG_CGROUPS=y -# CONFIG_CGROUP_DEBUG is not set -# CONFIG_CGROUP_FREEZER is not set -# CONFIG_CGROUP_DEVICE is not set -# CONFIG_CPUSETS is not set -# CONFIG_CGROUP_CPUACCT is not set -# CONFIG_RESOURCE_COUNTERS is not set -# CONFIG_CGROUP_SCHED is not set -# CONFIG_BLK_CGROUP is not set +# CONFIG_CGROUPS is not set # CONFIG_CHECKPOINT_RESTORE is not set CONFIG_NAMESPACES=y CONFIG_UTS_NS=y @@ -204,7 +195,6 @@ CONFIG_HAVE_CONTEXT_TRACKING=y CONFIG_HAVE_VIRT_CPU_ACCOUNTING_GEN=y CONFIG_HAVE_IRQ_TIME_ACCOUNTING=y -CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=y CONFIG_HAVE_MOD_ARCH_SPECIFIC=y CONFIG_MODULES_USE_ELF_REL=y CONFIG_CLONE_BACKWARDS=y @@ -228,7 +218,7 @@ CONFIG_STOP_MACHINE=y CONFIG_BLOCK=y CONFIG_LBDAF=y -CONFIG_BLK_DEV_BSG=y +# CONFIG_BLK_DEV_BSG is not set # CONFIG_BLK_DEV_BSGLIB is not set # CONFIG_BLK_DEV_INTEGRITY is not set # CONFIG_BLK_CMDLINE_PARSER is not set @@ -267,7 +257,6 @@ CONFIG_DEFAULT_CFQ=y # CONFIG_DEFAULT_NOOP is not set CONFIG_DEFAULT_IOSCHED=cfq -CONFIG_PREEMPT_NOTIFIERS=y CONFIG_UNINLINE_SPIN_UNLOCK=y CONFIG_ARCH_SUPPORTS_ATOMIC_RMW=y CONFIG_RWSEM_SPIN_ON_OWNER=y @@ -323,7 +312,6 @@ # CONFIG_ARCH_MULTI_CPU_AUTO is not set # CONFIG_ARCH_VIRT is not set # CONFIG_ARCH_MVEBU is not set -# CONFIG_ARCH_AXXIA is not set # CONFIG_ARCH_BCM is not set # CONFIG_ARCH_BERLIN is not set # CONFIG_ARCH_HIGHBANK is not set @@ -358,10 +346,11 @@ CONFIG_SOC_EXYNOS4212=y CONFIG_SOC_EXYNOS4412=y CONFIG_SOC_EXYNOS5250=y -# CONFIG_SOC_EXYNOS5260 is not set -# CONFIG_SOC_EXYNOS5410 is not set -# CONFIG_SOC_EXYNOS5420 is not set -# CONFIG_SOC_EXYNOS5440 is not set +CONFIG_SOC_EXYNOS5260=y
Re: [PATCH v2 0/9] thermal: exynos: various cleanups
Bartlomiej, On Thu, Jul 31, 2014 at 1:37 PM, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Hi, On Tuesday, July 29, 2014 08:58:48 AM Eduardo Valentin wrote: On Mon, Jul 28, 2014 at 08:30:53PM +0530, amit daniel kachhap wrote: Hi Eduardo, Hello Amit, Please reject this entire series as this is not re-based recently. Actually two point trimming which this series seeks to remove is used by exynos3250 and is in Rui's tree (https://git.kernel.org/cgit/linux/kernel/git/rzhang/linux.git/commit/?h=nextid=1fe56dc16a3dab400206443f70ae158c8f595c42). Yeah, that was my original concern when I first looked this series. However, as I saw a couple of your acks I thought you would be in sync with Bartlomiej. I agree with Bartlomiej that we need to keep the kernel code in very good shape, but if we are removing features for the sake of reducing LOCs and we end up dropping support to known chips, I definitely won't agree. There is no intention to drop support for known chips. Two months after initial posting of my patchset support for the new Exynos3250 SoC was posted and it happens to use the two point trimming calibration code (that was introduced back in September 2011 but never used previously). If we had removed it earlier it would have to be readded partially but we are talking about less than 100 lines of rather straightforward code (also the calibration code in question is not perfect anyway and would profit from some cleaning but I left it as it is for now). Can you guys please reach a common agreement on these cleanups? Bartlomiej, best thing to do is to sync your work on top of Rui's tree. Done, I posted v3 of patchset today: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg35013.html I hope that it is acceptable for Amit now (Amit, please take a look at patches when you find some time, thanks!). Thanks for updating the series. Amit, can you please test the series on socs you have available? I would prefer to merge this one now if we have a proper tested-by. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics For now I am dropping this series from my -next branch. :-( Thanks, Amit D On Mon, Jul 28, 2014 at 8:07 PM, Eduardo Valentin edubez...@gmail.com wrote: On Tue, Jun 17, 2014 at 07:27:16PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, This patch series contains various cleanups for EXYNOS thermal driver. Overall it decreases driver's LOC by 12%. It is based on next-20140617 kernel. It should not cause any functionality changes. Changes since v1: - synced patches against next-20140617 - merged patch thermal: exynos: remove unused defines into thermal: exynos: remove unused struct exynos_tmu_registers entries one (per request from Eduardo) - improved patch descriptions for patches #1-5 - fixed documentation for pdata-gain and pdata-reference_voltage - added Reviewed-by from Amit to patches #6, #7 and #10 - added missing Acked-by from Kyungmin Park Pulled the series. Thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (9): thermal: exynos: remove unused struct exynos_tmu_registers entries thermal: exynos: remove dead code for HW_MODE calibration thermal: exynos: remove dead code for TYPE_TWO_POINT_TRIMMING calibration thermal: exynos: remove redundant pdata checks from exynos_tmu_initialize() thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize() thermal: exynos: simplify temp_to_code() and code_to_temp() thermal: exynos: cache non_hw_trigger_levels in pdata thermal: exynos: remove redundant pdata checks from exynos_tmu_control() thermal: exynos: remove identical values from exynos*_tmu_registers structures drivers/thermal/samsung/exynos_thermal_common.h | 1 - drivers/thermal/samsung/exynos_tmu.c| 181 drivers/thermal/samsung/exynos_tmu.h| 90 +--- drivers/thermal/samsung/exynos_tmu_data.c | 64 + drivers/thermal/samsung/exynos_tmu_data.h | 33 + 5 files changed, 41 insertions(+), 328 deletions(-) -- 1.8.2.3 -- Eduardo Bezerra Valentin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [FIX][RESEND PATCH v3] ARM: EXYNOS: Fix suspend/resume sequences
Bartlomiej Zolnierkiewicz wrote: Hi, Hi, On Friday, August 01, 2014 10:51:37 AM Tomasz Figa wrote: From: Tomasz Figa t.f...@samsung.com Due to recent consolidation of Exynos suspend and cpuidle code, some parts of suspend and resume sequences are executed two times, once from exynos_pm_syscore_ops and then from exynos_cpu_pm_notifier() and thus it breaks suspend, at least on Exynos4-based boards. In addition, simple core power down from a cpuidle driver could, in case of CPU 0 could result in calling functions that are specific to suspend and deeper idle states. This patch fixes the issue by moving those operations outside the CPU PM notifier into suspend and AFTR code paths. This leads to a bit of code duplication, but allows additional code simplification, so in the end more code is removed than added. Fixes: 85f9f90808b4 (ARM: EXYNOS: Use the cpu_pm notifier for pm) Cc: Kukjin Kim kgene@samsung.com Cc: Arnd Bergmann a...@arndb.de Cc: Olof Johansson o...@lixom.net Cc: a...@kernel.org Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mach-exynos/pm.c| 164 ++- drivers/cpuidle/cpuidle-exynos.c | 25 +- 2 files changed, 80 insertions(+), 109 deletions(-) This is resend of a regression fix sent more than two weeks ago (July, 15; [1]), without any response from respective maintainers. It fixes a significant regression breaking suspend/resume on Exynos4-based systems. I know we already have -rc7, but this patch in its first iteration was sent more than a month ago (June, 24; [2]) and it changed only for convenience of authors of further patches, to either avoid conflicts ([3]) or reduce the need of changes to support more functionality later (as discussed in [4]). However it should have had priority over clean-up or functional patches, which was apparently not the case. This is not quite right, your initial version needed to be changed also because of potential problems (https://lkml.org/lkml/2014/7/15/206). Yeah...hmm...maybe it should be updated in 3.17... However the current version (from two weeks ago) is fine and IMO still should be merged as a _regression_ fix for v3.16 (despite not being a tiny patch). Agreed. OK. Also FWIW: Reviewed-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kukjin Kim kgene@samsung.com @Olof, It's true this is a regression for v3.16 and I couldn't take this before because of some dependencies...so I'd like to ask you to take for v3.16 even though it's late and big... Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support
Ajay, Am 01.08.2014 09:02, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 7:52 PM, Andreas Färber afaer...@suse.de wrote: Am 31.07.2014 12:23, schrieb Thierry Reding: On Thu, Jul 31, 2014 at 10:57:55AM +0200, Andreas Färber wrote: Am 31.07.2014 10:38, schrieb Ajay kumar: With just the spring-bridge.v6 branch of your own tree, I am able to see bootup logo on Skate(a variant of spring which also contains ps8622). I have tried both exynos_defconfig and multi_v7_defconfig. I enable DRM, EXYNOS DRM, BRIDGE CHIPS, IOMMU, EXYNOS IOMMU in configs. [...] If you have something like simplefb enabled in addition to a DRM driver, then perhaps the DRM driver isn't properly taking over the framebuffer console. So, with simplefb reverted in U-Boot and ... * with just the v6 applied (...~2), I get only a black screen from Linux, no penguins, but the backlight seems on. System comes up okay, ssh available, and nothing stands out in dmesg. * with the two iommu patches on top, something breaks badly, no backlight, no USB/network, system inaccessible. I.e. U-Boot had no noticeable impact on these symptoms. * with the iommu patches, but dp-controller, ps8622, panel commented out, I do get backlight but USB/network not working, system inaccessible. With simplefb support in U-Boot and with just v6 applied, but dp-controller, ps8622, panel commented out, things work as well as before, i.e. this series has no bad side effects. Note that I never claimed Ajay's series were broken, just reported that things regressed for me from v4, which may well be DT-related. The iommu patches interfere with my USB somehow (none or not all devices powered; with v4, plugging my wifi dongle led to oops but ethernet dongle worked, so not entirely new symptom), which is bad since my rootfs is on USB. The internal SDIO-connected Wifi is not enabled yet, so USB based network is my only alternative to a working display once we reach userspace. Well, there are 2 variants here: 1) Bootloader 2) config Unfortunately your config doesn't work for me either, on my latest spring-bridge.v6 branch. Type of the bootloader should not matter unless its switching on FET1 and FET6 of tps65090 for you. It does switch them on, if I'm reading correctly: https://github.com/afaerber/u-boot/blob/spring/board/samsung/smdk5250/smdk5250.c#L599 https://github.com/afaerber/u-boot/blob/spring/board/samsung/smdk5250/smdk5250.c#L907 Another observation I made is that sometimes in my testing (didn't spot a pattern yet) after reboot or power-off/power-on the initial white screen with the warning did not come up (no backlight), but Ctrl+U worked fine and chain-loaded nv u-boot came up on screen okay. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] i2c: Kconfig: Enable HSI2C for Exynos5 platform
On Fri, Jul 25, 2014 at 05:06:32PM +0530, Sachin Kamat wrote: On Wed, Jul 16, 2014 at 11:10 PM, Wolfram Sang w...@the-dreams.de wrote: On Wed, Jun 25, 2014 at 10:55:31AM -0700, Doug Anderson wrote: Sachin, On Wed, Jun 25, 2014 at 3:02 AM, Sachin Kamat sachin.ka...@samsung.com wrote: All Exynos5 platforms have HSI2C controllers and are needed by various IPs connected to the boards based on these SoCs. Thus select this by default for Exynos5 platforms. Signed-off-by: Sachin Kamat sachin.ka...@samsung.com Cc: Doug Anderson diand...@chromium.org --- drivers/i2c/busses/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 9f7d5859cf65..c7918cffe790 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -465,9 +465,9 @@ config I2C_EG20T config I2C_EXYNOS5 tristate Exynos5 high-speed I2C driver depends on ARCH_EXYNOS5 OF + default y help - Say Y here to include support for high-speed I2C controller in the - Exynos5 based Samsung SoCs. + High-speed I2C controller on Exynos5 based Samsung SoCs. config I2C_GPIO tristate GPIO-based bitbanging I2C -- 1.7.9.5 This seems reasonable to me and I will also take the blame for suggesting this. It's hard to imagine running a real exynos5 system without I2C. One could argue that on an exynos5250 the high speed I2C controller is not mandatory (since all the ports can be muxed to use the old controller) but on newer exynos5 products you're expected to have the main PMIC on one of the i2c ports. An exynos system without access to its PMIC will just sorta limp by. ...but I've added Arnd to this thread as he expressed some reservations about this type of thing, so we'll see what he says. Ping. Arnd? I have no strong opinion and would take this patch... Wolfram, How do you want to proceed with this? Giving Arnd a last chance to speak, otherwise I'll take it. signature.asc Description: Digital signature
Re: [PATCH v5 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow
Hi, On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote: The pinctrl properties should be on the device directly and not on the slot sub-node. Reported-by: Doug Anderson diand...@chromium.org Cc: Jaehoon Chung jh80.ch...@samsung.com Reviewed-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Andreas Färber afaer...@suse.de Let's land this one before Jaehoon's, since it was a hidden functionality change in his patch. It will be an easy conflict to resolve when his patch is applied. Reviewed-by: Doug Anderson diand...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2] ARM: dts: Add DT changes for display on peach_pi
Add DT nodes for panel-simple auo,b133htn01 panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add panel phandle needed by dp to enable display on peach_pi.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
Changes since V1:
Remove simple-panel compatible string and use only auo,b133htn01.
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..f8c2e61 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -28,11 +28,13 @@
i2c20 = /spi@12d4/cros-ec@0/i2c-tunnel;
};
- backlight {
+ backlight: backlight {
compatible = pwm-backlight;
pwms = pwm 0 100 0;
brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
default-brightness-level = 7;
+ enable-gpios = gpx2 2 0;
+ power-supply = tps65090_fet1;
pinctrl-0 = pwm0_out;
pinctrl-names = default;
};
@@ -98,6 +100,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
+ compatible = auo,b133htn01;
+ power-supply = tps65090_fet6;
+ backlight = backlight;
+ };
};
dp {
@@ -111,22 +119,7 @@
samsung,link-rate = 0x0a;
samsung,lane-count = 2;
samsung,hpd-gpio = gpx2 6 0;
-
- display-timings {
- native-mode = timing1;
-
- timing1: timing@1 {
- clock-frequency = 15066;
- hactive = 1920;
- vactive = 1080;
- hfront-porch = 60;
- hback-porch = 172;
- hsync-len = 80;
- vback-porch = 25;
- vfront-porch = 10;
- vsync-len = 10;
- };
- };
+ panel = panel;
};
fimd {
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: dts: Add DT changes for display on peach_pi
+Kukjin
On Fri, Aug 1, 2014 at 9:54 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
Add DT nodes for panel-simple auo,b133htn01 panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add panel phandle needed by dp to enable display on peach_pi.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
Changes since V1:
Remove simple-panel compatible string and use only auo,b133htn01.
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..f8c2e61 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -28,11 +28,13 @@
i2c20 = /spi@12d4/cros-ec@0/i2c-tunnel;
};
- backlight {
+ backlight: backlight {
compatible = pwm-backlight;
pwms = pwm 0 100 0;
brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
default-brightness-level = 7;
+ enable-gpios = gpx2 2 0;
+ power-supply = tps65090_fet1;
pinctrl-0 = pwm0_out;
pinctrl-names = default;
};
@@ -98,6 +100,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
+ compatible = auo,b133htn01;
+ power-supply = tps65090_fet6;
+ backlight = backlight;
+ };
};
dp {
@@ -111,22 +119,7 @@
samsung,link-rate = 0x0a;
samsung,lane-count = 2;
samsung,hpd-gpio = gpx2 6 0;
-
- display-timings {
- native-mode = timing1;
-
- timing1: timing@1 {
- clock-frequency = 15066;
- hactive = 1920;
- vactive = 1080;
- hfront-porch = 60;
- hback-porch = 172;
- hsync-len = 80;
- vback-porch = 25;
- vfront-porch = 10;
- vsync-len = 10;
- };
- };
+ panel = panel;
};
fimd {
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow
Andreas, On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote: exynos5250-cros-common.dtsi was meant for sharing common pieces across ChromeOS devices. This turned out premature, as several devices ended up in the common file that are not common after all. Since the remaining common ChromeOS pieces are fairly minor, exynos5250-cros-common.dtsi was requested to be merged into the Snow device tree, sharing only the keyboard controller for now. This may be re-evaluated as both mature. Suggested-by: Doug Anderson diand...@chromium.org Reviewed-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Andreas Färber afaer...@suse.de --- v4 - v5: * Extended commit message (Tomasz Figa) v3 - v4: Unchanged v2 - v3: * Renamed subject to match Kukjin's style * Rebased onto MMC pinctrl bug fix (Doug Anderson) v2: New (Doug Anderson) arch/arm/boot/dts/exynos5250-cros-common.dtsi | 164 -- arch/arm/boot/dts/exynos5250-snow.dts | 164 +++--- 2 files changed, 145 insertions(+), 183 deletions(-) Reviewed-by: Doug Anderson diand...@chromium.org I'd suggest that this land sooner rather than later to avoid future conflicts. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: dts: Add DT changes for display on peach_pi
Hi,
Am 01.08.2014 18:24, schrieb Ajay Kumar:
Add DT nodes for panel-simple auo,b133htn01 panel.
Add backlight enable pin and backlight power supply for pwm-backlight.
Also add panel phandle needed by dp to enable display on peach_pi.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
Changes since V1:
Remove simple-panel compatible string and use only auo,b133htn01.
arch/arm/boot/dts/exynos5800-peach-pi.dts | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts
b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index f3ee48b..f8c2e61 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -28,11 +28,13 @@
i2c20 = /spi@12d4/cros-ec@0/i2c-tunnel;
};
- backlight {
+ backlight: backlight {
compatible = pwm-backlight;
pwms = pwm 0 100 0;
brightness-levels = 0 100 500 1000 1500 2000 2500 2800;
default-brightness-level = 7;
+ enable-gpios = gpx2 2 0;
For Spring I was asked to use GPIO_ACTIVE_* - here that would mean
s/0/GPIO_ACTIVE_HIGH/ IIUC and if necessary
#include dt-bindings/gpio/gpio.h before the .dtsi #include.
A modified version of your patch for Snow, rebased onto my cleanups, can
be found on my spring-next branch.
+ power-supply = tps65090_fet1;
pinctrl-0 = pwm0_out;
pinctrl-names = default;
};
@@ -98,6 +100,12 @@
regulator-boot-on;
regulator-always-on;
};
+
+ panel: panel-simple {
Nit: panel-simple seems backwards in English language, and given that
simple-panel would be referring to the implementation, I used just
panel for Spring.
+ compatible = auo,b133htn01;
FWIW this depends on auo,b133htn01 getting added to Documentation and
panel-simple, which I think hasn't happened yet?
https://patchwork.kernel.org/patch/4625321/
+ power-supply = tps65090_fet6;
+ backlight = backlight;
+ };
};
dp {
@@ -111,22 +119,7 @@
samsung,link-rate = 0x0a;
samsung,lane-count = 2;
samsung,hpd-gpio = gpx2 6 0;
-
- display-timings {
- native-mode = timing1;
-
- timing1: timing@1 {
- clock-frequency = 15066;
- hactive = 1920;
- vactive = 1080;
- hfront-porch = 60;
- hback-porch = 172;
- hsync-len = 80;
- vback-porch = 25;
- vfront-porch = 10;
- vsync-len = 10;
- };
- };
+ panel = panel;
};
fimd {
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] dma: pl08x: Use correct specifier for size_t values
From: Mark Brown broo...@linaro.org
When printing size_t values we should use the %zd or %zx format specifier
in order to ensure the value is displayed correctly and avoid warnings from
sparse.
Signed-off-by: Mark Brown broo...@linaro.org
---
drivers/dma/amba-pl08x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 8114731..8ff32b1 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -1040,7 +1040,7 @@ static int pl08x_fill_llis_for_desc(struct
pl08x_driver_data *pl08x,
if (early_bytes) {
dev_vdbg(pl08x-adev-dev,
- %s byte width LLIs (remain 0x%08x)\n,
+ %s byte width LLIs (remain 0x%08zx)\n,
__func__, bd.remainder);
prep_byte_width_lli(pl08x, bd, cctl, early_bytes,
num_llis++, total_bytes);
@@ -1662,7 +1662,7 @@ static struct dma_async_tx_descriptor
*pl08x_prep_dma_cyclic(
dma_addr_t slave_addr;
dev_dbg(pl08x-adev-dev,
- %s prepare cyclic transaction of %d/%d bytes %s %s\n,
+ %s prepare cyclic transaction of %zd/%zd bytes %s %s\n,
__func__, period_len, buf_len,
direction == DMA_MEM_TO_DEV ? to : from,
plchan-name);
--
2.0.0
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/7] i2c: i2c-cros-ec-tunnel: Set retries to 3
On Mon, Jul 28, 2014 at 02:19:22PM +0200, Javier Martinez Canillas wrote:
From: Derek Basehore dbaseh...@chromium.org
Since the i2c bus can get wedged on the EC sometimes, set the number of
retries
to 3. Since we un-wedge the bus immediately after the wedge happens, this is
the
correct fix since only one transfer will fail.
Signed-off-by: Derek Basehore dbaseh...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
---
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
index 05e033c..a4411da 100644
--- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
+++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
@@ -16,6 +16,8 @@
#include linux/platform_device.h
#include linux/slab.h
+#define I2C_MAX_RETRIES 3
I think a define for this is overkill, yet I don't really mind.
Acked-by: Wolfram Sang w...@the-dreams.de
I assume this goes via MFD, let me know if I should take it.
+
/**
* struct ec_i2c_device - Driver data for I2C tunnel
*
@@ -290,6 +292,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
bus-adap.algo_data = bus;
bus-adap.dev.parent = pdev-dev;
bus-adap.dev.of_node = np;
+ bus-adap.retries = I2C_MAX_RETRIES;
err = i2c_add_adapter(bus-adap);
if (err) {
--
2.0.0.rc2
signature.asc
Description: Digital signature
Re: [PATCH 2/7] i2c: i2c-cros-ec-tunnel: Set retries to 3
Hello Wolfram, On 08/01/2014 07:59 PM, Wolfram Sang wrote: +#define I2C_MAX_RETRIES 3 I think a define for this is overkill, yet I don't really mind. Acked-by: Wolfram Sang w...@the-dreams.de Thanks a lot. I assume this goes via MFD, let me know if I should take it. Yes, if possible I prefer if all the series are picked by Lee Jones to avoid any dependencies. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 03/10] ARM: dts: Clean up exynos5250-snow
Andreas,
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
Use the new style of referencing inherited nodes and use symbolic names.
Reorder one pinctrl node in GPIO order.
Goal is the alignment of all exynos5250 based device trees for comparison.
Suggested-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v4 - v5:
* Introduced labels to consistently use new referencing style (Tomasz)
* Use IRQ_TYPE_* constants
* Use some more GPIO_ACTIVE_*
v3 - v4: Unchanged
v3: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-snow.dts | 291
+-
arch/arm/boot/dts/exynos5250.dtsi | 20 +--
As much as possible it's nice to touch the main exynos dtsi file and
specific board files in different patches. Among other things it
makes backporting the patch and resolving merge conflicts easier (if
someone doesn't care about snow they could just pick up the main dtsi,
for instance).
I'm not a total stickler and I'd love to see this land quickly to
avoid conflicts, though...
+sd3_clk {
+ samsung,pin-drv = 0;
+};
+
+sd3_cmd {
+ samsung,pin-pud = 3;
+ samsung,pin-drv = 0;
+};
+
+sd3_bus4 {
Itty bitty bitty nit that bus sorts alphabetically above clk. ;)
Maybe Kukjin would be willing to sort these when he applies?
Thank you for all your hard work on this one. Things look MUCH MUCH
nicer! I did a pretty thorough review of your changes and it all
looks good.
Reviewed-by: Doug Anderson diand...@chromium.org
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 04/10] ARM: dts: Fill in bootargs for exynos5250-snow
Hi,
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
exynos5250-cros-common.dtsi had an empty /chosen node.
Fill in exemplary boot arguments.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5: New
Cleanup for /chosen node moved into -snow.dts.
arch/arm/boot/dts/exynos5250-snow.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index 7680d5e03fb3..c4b0c73c736d 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -27,6 +27,7 @@
};
chosen {
+ bootargs = console=tty1;
As mentioned earlier, I don't think this is a particularly useful
change. Just this boot argument is not enough to boot with anyway, so
listing it doesn't really help anyone. In theory you could make some
assertion about what the most popular boot device and filesystem is,
but it seems unlikely to cover the majority of the cases.
I won't NAK this change myself, but I certainly won't push for it.
-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow
Andreas,
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
Spring uses a different GPIO, so this is not a generic SoC piece.
Suggested-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5: New (Tomasz Figa)
Frees dp_hpd for Spring.
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 ---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +
arch/arm/boot/dts/exynos5250-snow.dts | 7 +++
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index 886cfca044ac..ed0e5230514b 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -581,13 +581,6 @@
samsung,pin-pud = 0;
samsung,pin-drv = 0;
};
-
- dp_hpd: dp_hpd {
- samsung,pins = gpx0-7;
- samsung,pin-function = 3;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
};
pinctrl@1340 {
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index aaa055ac0fe3..5d30fe1dcda4 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -414,3 +414,12 @@
};
};
};
+
+pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+};
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index c4b0c73c736d..a9a2f2743794 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -547,6 +547,13 @@
};
pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs.
Pin function 3 is special function. This pin _is_ the hot plug detect
pin for display port. When it's set as special function 3 it goes
straight into the hot plug logic of the display port controller.
Spring may have had its reasons to detect hot plug events on a GPIO
instead of using this pin, but that doesn't make this pin any less the
hot plug pin.
-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 06/10] ARM: dts: Clean up exynos5250-smdk5250
Andreas, On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote: Use the new style for referencing inherited nodes and use symbolic names. Goal is the alignment of all exynos5250 based device trees for comparison. Signed-off-by: Andreas Färber afaer...@suse.de --- v5: New Follow-up after adding dp_hpd pinctrl node new-style. Since I NAKed that one, are you going to drop this patch? It's probably still a useful thing to do. It sounds like you might be spinning? ...if so I'll review it in the next cycle... Note: same feedback as before about splitting changes to exynos5250.dtsi and actual board files... -Doug -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 03/10] ARM: dts: Clean up exynos5250-snow
Am 01.08.2014 22:24, schrieb Doug Anderson:
Andreas,
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
Use the new style of referencing inherited nodes and use symbolic names.
Reorder one pinctrl node in GPIO order.
Goal is the alignment of all exynos5250 based device trees for comparison.
Suggested-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v4 - v5:
* Introduced labels to consistently use new referencing style (Tomasz)
* Use IRQ_TYPE_* constants
* Use some more GPIO_ACTIVE_*
v3 - v4: Unchanged
v3: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-snow.dts | 291
+-
arch/arm/boot/dts/exynos5250.dtsi | 20 +--
As much as possible it's nice to touch the main exynos dtsi file and
specific board files in different patches. Among other things it
makes backporting the patch and resolving merge conflicts easier (if
someone doesn't care about snow they could just pick up the main dtsi,
for instance).
I'm not a total stickler and I'd love to see this land quickly to
avoid conflicts, though...
+sd3_clk {
+ samsung,pin-drv = 0;
+};
+
+sd3_cmd {
+ samsung,pin-pud = 3;
+ samsung,pin-drv = 0;
+};
+
+sd3_bus4 {
Itty bitty bitty nit that bus sorts alphabetically above clk. ;)
True. I guess I just reused the original order from within pinctrl.
Maybe Kukjin would be willing to sort these when he applies?
Thank you for all your hard work on this one. Things look MUCH MUCH
nicer! I did a pretty thorough review of your changes and it all
looks good.
Reviewed-by: Doug Anderson diand...@chromium.org
I need to respin anyway for a .dtsi label, so I can factor this out
while at it.
Patches 1-2 could meanwhile already be applied by Kukjin.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow
Doug,
Am 01.08.2014 22:33, schrieb Doug Anderson:
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
Spring uses a different GPIO, so this is not a generic SoC piece.
Suggested-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5: New (Tomasz Figa)
Frees dp_hpd for Spring.
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 ---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +
arch/arm/boot/dts/exynos5250-snow.dts | 7 +++
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index 886cfca044ac..ed0e5230514b 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -581,13 +581,6 @@
samsung,pin-pud = 0;
samsung,pin-drv = 0;
};
-
- dp_hpd: dp_hpd {
- samsung,pins = gpx0-7;
- samsung,pin-function = 3;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
};
pinctrl@1340 {
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index aaa055ac0fe3..5d30fe1dcda4 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -414,3 +414,12 @@
};
};
};
+
+pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+};
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index c4b0c73c736d..a9a2f2743794 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -547,6 +547,13 @@
};
pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs.
Pin function 3 is special function. This pin _is_ the hot plug detect
pin for display port. When it's set as special function 3 it goes
straight into the hot plug logic of the display port controller.
Spring may have had its reasons to detect hot plug events on a GPIO
instead of using this pin, but that doesn't make this pin any less the
hot plug pin.
Please advise how to handle it then: Should there be two different
pinctrl entries (if so, how should it be named?), or should spring
override the generic entry? As I reported, 3.8 has only one dp-hpd
pinctrl entry, so I dropped the dp-hpd-gpio naming.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow
On 01.08.2014 22:54, Andreas Färber wrote:
Doug,
Am 01.08.2014 22:33, schrieb Doug Anderson:
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
Spring uses a different GPIO, so this is not a generic SoC piece.
Suggested-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5: New (Tomasz Figa)
Frees dp_hpd for Spring.
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 ---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +
arch/arm/boot/dts/exynos5250-snow.dts | 7 +++
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
index 886cfca044ac..ed0e5230514b 100644
--- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
@@ -581,13 +581,6 @@
samsung,pin-pud = 0;
samsung,pin-drv = 0;
};
-
- dp_hpd: dp_hpd {
- samsung,pins = gpx0-7;
- samsung,pin-function = 3;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
};
pinctrl@1340 {
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index aaa055ac0fe3..5d30fe1dcda4 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -414,3 +414,12 @@
};
};
};
+
+pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+};
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index c4b0c73c736d..a9a2f2743794 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -547,6 +547,13 @@
};
pinctrl_0 {
+ dp_hpd: dp_hpd {
+ samsung,pins = gpx0-7;
+ samsung,pin-function = 3;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+
NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs.
Pin function 3 is special function. This pin _is_ the hot plug detect
pin for display port. When it's set as special function 3 it goes
straight into the hot plug logic of the display port controller.
Spring may have had its reasons to detect hot plug events on a GPIO
instead of using this pin, but that doesn't make this pin any less the
hot plug pin.
Please advise how to handle it then: Should there be two different
pinctrl entries (if so, how should it be named?),
IMHO this is the right way. Just name the GPIO variant dp_hpd_gpio.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 07/10] ARM: dts: Clean up exynos5250-arndale
Just wanted to report one issue unrelated to your changes I spotted
while reviewing this patch. See below.
On 01.08.2014 06:54, Andreas Färber wrote:
Use the new style of referencing inherited nodes, use symbolic names,
tidy indentation and reorder includes.
Goal is the alignment of all exynos5250 based device trees for comparison.
[snip]
- fimd: fimd@1440 {
- status = okay;
- display-timings {
- native-mode = timing0;
- timing0: timing@0 {
- /* 2560x1600 DP panel */
- clock-frequency = 5;
This apparently makes little sense as I doubt anybody would be willing
to run a DP panel with refresh rate of 0,012 Hz...
Anyway, your patch just moves it, so this is just an unrelated report.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 00/10] ARM: dts: exynos: Prepare Spring
Hi Andreas, On 01.08.2014 06:54, Andreas Färber wrote: Hello, Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 based attempts by Stephan and me that broke for 3.16, I've prepared a device tree for the HP Chromebook 11 aka Google Spring. v5 cleans up a regulator and the USB3503 hub and touches more exynos5250 files. Not yet enabled are trackpad, Wifi and sound. My rebasing branch for testing is here: https://github.com/afaerber/linux/commits/spring-next Regards, Andreas v1 - v2: * Dropped 3 documentation patches from series: 2 picked up, https://patchwork.kernel.org/patch/4397271/ https://patchwork.kernel.org/patch/4397291/ 1 already sent separately as v2, pending. https://patchwork.kernel.org/patch/4424881/ * Minimized and beautified Spring device tree and to some degree Snow as well. See individual patches. v2 - v3: * Rebased: Two -cros-common cleanup patches were already applied * Lots of small cleanups for both Snow and Spring * Enabled I2S in Spring for symmetry * Added lid-switch and gpio-keys pinctrls to Spring v3 - v4: * Fixed pin-function 1 - 0 for dp-hpd pinctrl, style cleanup v4 - v5: * Dropped regulator and fixed USB3503 for Spring * More cleanups, including SMDK5250 and Arndale Andreas Färber (10): ARM: dts: Fix MMC pinctrl for exynos5250-snow ARM: dts: Fold exynos5250-cros-common into exynos5250-snow ARM: dts: Clean up exynos5250-snow ARM: dts: Fill in bootargs for exynos5250-snow ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow ARM: dts: Clean up exynos5250-smdk5250 ARM: dts: Clean up exynos5250-arndale ARM: dts: Fix apparent GPIO typo in exynos5250-arndale ARM: dts: Simplify USB3503 on exynos5250-arndale ARM: dts: Add exynos5250-spring device tree arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/exynos5250-arndale.dts | 927 +- arch/arm/boot/dts/exynos5250-cros-common.dtsi | 164 - arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 - arch/arm/boot/dts/exynos5250-smdk5250.dts | 641 +- arch/arm/boot/dts/exynos5250-snow.dts | 441 +++- arch/arm/boot/dts/exynos5250-spring.dts | 536 +++ arch/arm/boot/dts/exynos5250.dtsi | 24 +- 8 files changed, 1624 insertions(+), 1117 deletions(-) delete mode 100644 arch/arm/boot/dts/exynos5250-cros-common.dtsi create mode 100644 arch/arm/boot/dts/exynos5250-spring.dts I have looked through all the patches and they look good to me, so, for the whole series: Reviewed-by: Tomasz Figa t.f...@samsung.com There is one unrelated issue I reported in my reply to patch 7/10, but it is more of a bug report, not a comment to your patch. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 04/10] ARM: dts: Fill in bootargs for exynos5250-snow
Hi Doug,
Am 01.08.2014 22:28, schrieb Doug Anderson:
On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber afaer...@suse.de wrote:
exynos5250-cros-common.dtsi had an empty /chosen node.
Fill in exemplary boot arguments.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5: New
Cleanup for /chosen node moved into -snow.dts.
arch/arm/boot/dts/exynos5250-snow.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index 7680d5e03fb3..c4b0c73c736d 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -27,6 +27,7 @@
};
chosen {
+ bootargs = console=tty1;
As mentioned earlier, I don't think this is a particularly useful
change. Just this boot argument is not enough to boot with anyway, so
listing it doesn't really help anyone. In theory you could make some
assertion about what the most popular boot device and filesystem is,
but it seems unlikely to cover the majority of the cases.
I won't NAK this change myself, but I certainly won't push for it.
This patch should be entirely optional.
I believe you said it wasn't necessary because the bootloader supplies
it. My point is that someone needs to know what to put into the bootargs
(setenv / boot.scr / uEnv.txt) - knowing whether it's ttySAC3 vs.
ttySAC2 vs. ttyS0 etc. has been pretty handy for me. In this case, Snow
and Spring use an identical console, so not sure if it might be tty2 or
something elsewhere?
My question of what to use for linux,stdout-path (which was elsewhere
mentioned as successor to bootargs in that regard) remained unanswered.
Should it point to the dp-controller node or what?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 02/10] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow
exynos5250-cros-common.dtsi was meant for sharing common pieces across
ChromeOS devices. This turned out premature, as several devices ended up
in the common file that are not common after all. Since the remaining
common ChromeOS pieces are fairly minor, exynos5250-cros-common.dtsi
was requested to be merged into the Snow device tree, sharing only the
keyboard controller for now. This may be re-evaluated as both mature.
Suggested-by: Doug Anderson diand...@chromium.org
Reviewed-by: Tomasz Figa t.f...@samsung.com
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6: Unchanged
v4 - v5:
* Extended commit message (Tomasz Figa)
v3 - v4: Unchanged
v2 - v3:
* Renamed subject to match Kukjin's style
* Rebased onto MMC pinctrl bug fix (Doug Anderson)
v2: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-cros-common.dtsi | 164 --
arch/arm/boot/dts/exynos5250-snow.dts | 164 +++---
2 files changed, 145 insertions(+), 183 deletions(-)
delete mode 100644 arch/arm/boot/dts/exynos5250-cros-common.dtsi
diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
deleted file mode 100644
index e603e9c70142..
--- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
+++ /dev/null
@@ -1,164 +0,0 @@
-/*
- * Common device tree include for all Exynos 5250 boards based off of Daisy.
- *
- * Copyright (c) 2012 Google, Inc
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
-*/
-
-/ {
- aliases {
- };
-
- memory {
- reg = 0x4000 0x8000;
- };
-
- chosen {
- };
-
- pinctrl@1140 {
- /*
-* Disabled pullups since external part has its own pullups and
-* double-pulling gets us out of spec in some cases.
-*/
- i2c2_bus: i2c2-bus {
- samsung,pin-pud = 0;
- };
- };
-
- i2c@12C6 {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 378000;
- };
-
- i2c@12C7 {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 378000;
- };
-
- i2c@12C8 {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 66000;
-
- hdmiddc@50 {
- compatible = samsung,exynos4210-hdmiddc;
- reg = 0x50;
- };
- };
-
- i2c@12C9 {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 66000;
- };
-
- i2c@12CA {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 66000;
- };
-
- i2c@12CB {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 66000;
- };
-
- i2c@12CD {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 66000;
- };
-
- i2c@12CE {
- status = okay;
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 378000;
-
- hdmiphy: hdmiphy@38 {
- compatible = samsung,exynos4212-hdmiphy;
- reg = 0x38;
- };
- };
-
- mmc@1220 {
- num-slots = 1;
- supports-highspeed;
- broken-cd;
- card-detect-delay = 200;
- samsung,dw-mshc-ciu-div = 3;
- samsung,dw-mshc-sdr-timing = 2 3;
- samsung,dw-mshc-ddr-timing = 1 2;
- pinctrl-names = default;
- pinctrl-0 = sd0_clk sd0_cmd sd0_cd sd0_bus4 sd0_bus8;
-
- slot@0 {
- reg = 0;
- bus-width = 8;
- };
- };
-
- mmc@1222 {
- num-slots = 1;
- supports-highspeed;
- card-detect-delay = 200;
- samsung,dw-mshc-ciu-div = 3;
- samsung,dw-mshc-sdr-timing = 2 3;
- samsung,dw-mshc-ddr-timing = 1 2;
- pinctrl-names = default;
- pinctrl-0 = sd2_clk sd2_cmd sd2_cd sd2_bus4;
-
- slot@0 {
- reg = 0;
- bus-width = 4;
- wp-gpios = gpc2 1 0;
- };
- };
-
- mmc@1223 {
- num-slots = 1;
- supports-highspeed;
- broken-cd;
-
[PATCH v6 00/10] ARM: dts: exynos: Prepare Spring
Hello, Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 based attempts by Stephan and me that broke for 3.16, I've prepared a device tree for the HP Chromebook 11 aka Google Spring. v6 renames a node and reverts dp_hpd. Not yet enabled are trackpad, Wifi and sound. My rebasing branch for testing is here: https://github.com/afaerber/linux/commits/spring-next Regards, Andreas v1 - v2: * Dropped 3 documentation patches from series: 2 picked up, https://patchwork.kernel.org/patch/4397271/ https://patchwork.kernel.org/patch/4397291/ 1 already sent separately as v2, pending. https://patchwork.kernel.org/patch/4424881/ * Minimized and beautified Spring device tree and to some degree Snow as well. See individual patches. v2 - v3: * Rebased: Two -cros-common cleanup patches were already applied * Lots of small cleanups for both Snow and Spring * Enabled I2S in Spring for symmetry * Added lid-switch and gpio-keys pinctrls to Spring v3 - v4: * Fixed pin-function 1 - 0 for dp-hpd pinctrl, style cleanup v4 - v5: * Dropped regulator and fixed USB3503 for Spring * More cleanups, including SMDK5250 and Arndale v5 - v6: * Renamed mfc node label for alignment with iommu patches around * Reverted dp-hpd to v4 Andreas Färber (10): ARM: dts: Fix MMC pinctrl for exynos5250-snow ARM: dts: Fold exynos5250-cros-common into exynos5250-snow ARM: dts: Prepare node labels for exynos5250 ARM: dts: Clean up exynos5250-snow ARM: dts: Fill in bootargs for exynos5250-snow ARM: dts: Clean up exynos5250-smdk5250 ARM: dts: Clean up exynos5250-arndale ARM: dts: Fix apparent GPIO typo in exynos5250-arndale ARM: dts: Simplify USB3503 on exynos5250-arndale ARM: dts: Add exynos5250-spring device tree arch/arm/boot/dts/Makefile| 1 + arch/arm/boot/dts/exynos5250-arndale.dts | 927 +- arch/arm/boot/dts/exynos5250-cros-common.dtsi | 164 - arch/arm/boot/dts/exynos5250-smdk5250.dts | 632 +- arch/arm/boot/dts/exynos5250-snow.dts | 434 +++- arch/arm/boot/dts/exynos5250-spring.dts | 536 +++ arch/arm/boot/dts/exynos5250.dtsi | 24 +- 7 files changed, 1608 insertions(+), 1110 deletions(-) delete mode 100644 arch/arm/boot/dts/exynos5250-cros-common.dtsi create mode 100644 arch/arm/boot/dts/exynos5250-spring.dts -- 1.9.3 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 09/10] ARM: dts: Simplify USB3503 on exynos5250-arndale
There's no need for a simple-bus, place the smsc,usb3503a directly into
the root node. That's what we're going to do on exynos5250-spring.
Reported-by: Tomasz Figa t.f...@samsung.com
Reviewed-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6: Unchanged
v5: New
Aligns with Spring's new USB3503 node.
arch/arm/boot/dts/exynos5250-arndale.dts | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch/arm/boot/dts/exynos5250-arndale.dts
index cc8b9ffeecc1..b231bcff7403 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -108,18 +108,12 @@
};
};
- usb_hub_bus {
- compatible = simple-bus;
- #address-cells = 1;
- #size-cells = 0;
+ // SMSC USB3503 connected in hardware only mode as a PHY
+ usb_hub: usb-hub {
+ compatible = smsc,usb3503a;
- // SMSC USB3503 connected in hardware only mode as a PHY
- usb_hub: usb_hub {
- compatible = smsc,usb3503a;
-
- reset-gpios = gpx3 5 GPIO_ACTIVE_LOW;
- connect-gpios = gpd1 7 GPIO_ACTIVE_LOW;
- };
+ reset-gpios = gpx3 5 GPIO_ACTIVE_LOW;
+ connect-gpios = gpd1 7 GPIO_ACTIVE_LOW;
};
};
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree
Adds initial support for the HP Chromebook 11.
Cc: Vincent Palatin vpala...@chromium.org
Cc: Doug Anderson diand...@chromium.org
Cc: Stephan van Schaik step...@synkhronix.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Updated for mfc node label
* Reverted to dp-hpd-gpio node in pinctrl_0 (Doug Anderson)
* Fixed alphabetical order of sd1_* nodes (Doug Anderson)
v4 - v5:
* Dropped bogus USB3 regulator (Vincent Palatin, Tomasz Figa)
* Fixed USB3503 reset GPIO (Tomasz Figa)
* Introduced labels to use new referencing style consistently (Tomasz Figa)
* Don't override dp_hpd, moved to pinctrl_0 instead (Tomasz Figa)
* mmc_1: Added comment from Snow's mmc_3 (Tomasz Figa / Doug Anderson)
* Override /codec samsung,mfc-{l,r} properties for alignment with Arndale
* Use more GPIO_ACTIVE_* constants
* Use IRQ_TYPE_* constants
* Dropped s5m_ prefix for s5m8767 LDO regulator labels (max77686 is gone)
* Labeled also all s5m8767 BUCK regulators
v3 - v4:
* Fixed samsung,pin-function 1 - 0 for dp-hpd-gpio
* Replaced dp-hpd-gpio with existing dp_hpd, overriding it
v2 - v3:
* Use GPIO_ACTIVE_{LOW,HIGH} (Doug Anderson)
* Use symbolic KEY_POWER instead of comment
* Moved hsic_reset to new USB3503 node's reset-gpios (Vincent Palatin)
* Use dp_hpd_gpio for dp-controller (Doug Anderson, Ajay Kumar)
* Override sd1_{clk,cmd,cd,bus4} pinctrl similar to Snow (Doug Anderson)
* Added ec_irq pinctrl for cros_ec (Doug Anderson)
* Reordered nodes to minimize diff against Snow (Doug Anderson)
* Dropped obsolete mmc_2 override (Doug Anderson)
* Added lid-switch node (Doug Anderson)
* Added gpio-keys pinctrl (Doug Anderson)
* Added bootargs to avoid empty /chosen node and to document console setting
* Renamed s5m8767_pmic node to avoid underscore
* Use new style for overriding inherited pinctrl nodes, too
* Enable i2s0 node
v1 - v2:
* Use label-based overriding/extension of nodes. (Doug Anderson)
* Dropped tps65090 for now, until we know where to place it.
* Dropped non-Spring nodes from -cros-common.dtsi rather than disabling them.
* Enabled a missing MMC node for access to internal storage.
* Dropped display-timings from dp-controller node. (Ajay Kumar)
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/exynos5250-spring.dts | 536
2 files changed, 537 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5250-spring.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 80a781f76e88..dec4c292f63d 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -76,6 +76,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
exynos5250-arndale.dtb \
exynos5250-smdk5250.dtb \
exynos5250-snow.dtb \
+ exynos5250-spring.dtb \
exynos5260-xyref5260.dtb \
exynos5410-smdk5410.dtb \
exynos5420-arndale-octa.dtb \
diff --git a/arch/arm/boot/dts/exynos5250-spring.dts
b/arch/arm/boot/dts/exynos5250-spring.dts
new file mode 100644
index ..f5566f84d885
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -0,0 +1,536 @@
+/*
+ * Google Spring board device tree source
+ *
+ * Copyright (c) 2013 Google, Inc
+ * Copyright (c) 2014 SUSE LINUX Products GmbH
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+/dts-v1/;
+#include dt-bindings/gpio/gpio.h
+#include dt-bindings/interrupt-controller/irq.h
+#include dt-bindings/input/input.h
+#include exynos5250.dtsi
+
+/ {
+ model = Google Spring;
+ compatible = google,spring, samsung,exynos5250, samsung,exynos5;
+
+ memory {
+ reg = 0x4000 0x8000;
+ };
+
+ chosen {
+ bootargs = console=tty1;
+ };
+
+ gpio-keys {
+ compatible = gpio-keys;
+ pinctrl-names = default;
+ pinctrl-0 = power_key_irq, lid_irq;
+
+ power {
+ label = Power;
+ gpios = gpx1 3 GPIO_ACTIVE_LOW;
+ linux,code = KEY_POWER;
+ gpio-key,wakeup;
+ };
+
+ lid-switch {
+ label = Lid;
+ gpios = gpx3 5 GPIO_ACTIVE_LOW;
+ linux,input-type = 5; /* EV_SW */
+ linux,code = 0; /* SW_LID */
+ debounce-interval = 1;
+ gpio-key,wakeup;
+ };
+ };
+
+ usb-hub {
+ compatible = smsc,usb3503a;
+ reset-gpios = gpe1 0 GPIO_ACTIVE_LOW;
+ };
+
+ fixed-rate-clocks {
+ xxti {
+ compatible = samsung,clock-xxti;
+ clock-frequency = 2400;
+ };
+ };
+};
+
+dp {
+ status =
[PATCH v6 08/10] ARM: dts: Fix apparent GPIO typo in exynos5250-arndale
The GPIO flag 2 has no constant assigned, so this was probably active-low.
Reviewed-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6: Unchanged
v5: New
Spotted during cleanup.
arch/arm/boot/dts/exynos5250-arndale.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch/arm/boot/dts/exynos5250-arndale.dts
index aac41c394d43..cc8b9ffeecc1 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -159,7 +159,7 @@
};
hdmi {
- hpd-gpio = gpx3 7 2;
+ hpd-gpio = gpx3 7 GPIO_ACTIVE_LOW;
vdd_osc-supply = ldo10_reg;
vdd_pll-supply = ldo8_reg;
vdd-supply = ldo8_reg;
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale
Use the new style of referencing inherited nodes, use symbolic names,
tidy indentation and reorder includes.
Goal is the alignment of all exynos5250 based device trees for comparison.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Updated for mfc node label
v5: New
Aligns with SMDK.
arch/arm/boot/dts/exynos5250-arndale.dts | 929 ---
1 file changed, 466 insertions(+), 463 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
b/arch/arm/boot/dts/exynos5250-arndale.dts
index d0de1f50d15b..aac41c394d43 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -7,12 +7,13 @@
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
-*/
+ */
/dts-v1/;
-#include exynos5250.dtsi
+#include dt-bindings/gpio/gpio.h
#include dt-bindings/interrupt-controller/irq.h
#include dt-bindings/input/input.h
+#include exynos5250.dtsi
/ {
model = Insignal Arndale evaluation board based on EXYNOS5250;
@@ -26,473 +27,52 @@
bootargs = console=ttySAC2,115200;
};
- rtc@101E {
- status = okay;
- };
-
- codec@1100 {
- samsung,mfc-r = 0x4300 0x80;
- samsung,mfc-l = 0x5100 0x80;
- };
-
- i2c@12C6 {
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 2;
- samsung,i2c-slave-addr = 0x66;
- status = okay;
-
- s5m8767_pmic@66 {
- compatible = samsung,s5m8767-pmic;
- reg = 0x66;
- interrupt-parent = gpx3;
- interrupts = 2 IRQ_TYPE_LEVEL_LOW;
-
- vinb1-supply = main_dc_reg;
- vinb2-supply = main_dc_reg;
- vinb3-supply = main_dc_reg;
- vinb4-supply = main_dc_reg;
- vinb5-supply = main_dc_reg;
- vinb6-supply = main_dc_reg;
- vinb7-supply = main_dc_reg;
- vinb8-supply = main_dc_reg;
- vinb9-supply = main_dc_reg;
-
- vinl1-supply = buck7_reg;
- vinl2-supply = buck7_reg;
- vinl3-supply = buck7_reg;
- vinl4-supply = main_dc_reg;
- vinl5-supply = main_dc_reg;
- vinl6-supply = main_dc_reg;
- vinl7-supply = main_dc_reg;
- vinl8-supply = buck8_reg;
- vinl9-supply = buck8_reg;
-
- s5m8767,pmic-buck2-dvs-voltage = 130;
- s5m8767,pmic-buck3-dvs-voltage = 110;
- s5m8767,pmic-buck4-dvs-voltage = 120;
- s5m8767,pmic-buck-dvs-gpios = gpd1 0 0,
- gpd1 1 0,
- gpd1 2 0;
- s5m8767,pmic-buck-ds-gpios = gpx2 3 0,
- gpx2 4 0,
- gpx2 5 0;
- regulators {
- ldo1_reg: LDO1 {
- regulator-name = VDD_ALIVE_1.0V;
- regulator-min-microvolt = 110;
- regulator-max-microvolt = 110;
- regulator-always-on;
- regulator-boot-on;
- op_mode = 1;
- };
-
- ldo2_reg: LDO2 {
- regulator-name = VDD_28IO_DP_1.35V;
- regulator-min-microvolt = 120;
- regulator-max-microvolt = 120;
- regulator-always-on;
- regulator-boot-on;
- op_mode = 1;
- };
-
- ldo3_reg: LDO3 {
- regulator-name = VDD_COMMON1_1.8V;
- regulator-min-microvolt = 180;
- regulator-max-microvolt = 180;
- regulator-always-on;
- regulator-boot-on;
- op_mode = 1;
- };
-
- ldo4_reg: LDO4 {
- regulator-name =
[PATCH v6 06/10] ARM: dts: Clean up exynos5250-smdk5250
Use the new style for referencing inherited nodes and use symbolic names.
Goal is the alignment of all exynos5250 based device trees for comparison.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Renamed node label codec - mfc for alignment with add System MMU nodes
* Rebased for leaving dp_hpd in .dtsi
v5: New
Follow-up after adding dp_hpd pinctrl node new-style.
arch/arm/boot/dts/exynos5250-smdk5250.dts | 632 +++---
1 file changed, 318 insertions(+), 314 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index aaa055ac0fe3..6bcd64ff2ded 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -7,9 +7,11 @@
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
-*/
+ */
/dts-v1/;
+#include dt-bindings/gpio/gpio.h
+#include dt-bindings/interrupt-controller/irq.h
#include exynos5250.dtsi
/ {
@@ -27,165 +29,6 @@
bootargs = root=/dev/ram0 rw ramdisk=8192 initrd=0x4100,8M
console=ttySAC2,115200 init=/linuxrc;
};
- rtc@101E {
- status = okay;
- };
-
- i2c@12C6 {
- samsung,i2c-sda-delay = 100;
- samsung,i2c-max-bus-freq = 2;
- status = okay;
-
- eeprom@50 {
- compatible = samsung,s524ad0xd1;
- reg = 0x50;
- };
-
- max77686@09 {
- compatible = maxim,max77686;
- reg = 0x09;
- interrupt-parent = gpx3;
- interrupts = 2 0;
-
- voltage-regulators {
- ldo1_reg: LDO1 {
- regulator-name = P1.0V_LDO_OUT1;
- regulator-min-microvolt = 100;
- regulator-max-microvolt = 100;
- regulator-always-on;
- };
-
- ldo2_reg: LDO2 {
- regulator-name = P1.2V_LDO_OUT2;
- regulator-min-microvolt = 120;
- regulator-max-microvolt = 120;
- regulator-always-on;
- };
-
- ldo3_reg: LDO3 {
- regulator-name = P1.8V_LDO_OUT3;
- regulator-min-microvolt = 180;
- regulator-max-microvolt = 180;
- regulator-always-on;
- };
-
- ldo4_reg: LDO4 {
- regulator-name = P2.8V_LDO_OUT4;
- regulator-min-microvolt = 280;
- regulator-max-microvolt = 280;
- };
-
- ldo5_reg: LDO5 {
- regulator-name = P1.8V_LDO_OUT5;
- regulator-min-microvolt = 180;
- regulator-max-microvolt = 180;
- };
-
- ldo6_reg: LDO6 {
- regulator-name = P1.1V_LDO_OUT6;
- regulator-min-microvolt = 110;
- regulator-max-microvolt = 110;
- regulator-always-on;
- };
-
- ldo7_reg: LDO7 {
- regulator-name = P1.1V_LDO_OUT7;
- regulator-min-microvolt = 110;
- regulator-max-microvolt = 110;
- regulator-always-on;
- };
-
- ldo8_reg: LDO8 {
- regulator-name = P1.0V_LDO_OUT8;
- regulator-min-microvolt = 100;
- regulator-max-microvolt = 100;
- };
-
- ldo10_reg: LDO10 {
- regulator-name = P1.8V_LDO_OUT10;
- regulator-min-microvolt = 180;
- regulator-max-microvolt = 180;
- };
-
-
[PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow
exynos5250-cros-common.dtsi had an empty /chosen node.
Fill in exemplary boot arguments.
Reviewed-by: Tomasz Figa t.f...@samsung.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6: Unchanged
v5: New
Cleanup for /chosen node moved into -snow.dts.
arch/arm/boot/dts/exynos5250-snow.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index 40cad43f8a11..8d8e62de86c7 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -27,6 +27,7 @@
};
chosen {
+ bootargs = console=tty1;
};
gpio-keys {
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow
Use the new style of referencing inherited nodes and use symbolic names.
Reorder one pinctrl node in GPIO order.
Goal is the alignment of all exynos5250 based device trees for comparison.
Suggested-by: Doug Anderson diand...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Split off label additions (Doug Anderson)
* Fixed alphabetical order of sd3_* nodes (Doug Anderson)
v4 - v5:
* Introduced labels to consistently use new referencing style (Tomasz Figa)
* Use IRQ_TYPE_* constants
* Use some more GPIO_ACTIVE_*
v3 - v4: Unchanged
v3: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-snow.dts | 291 +-
1 file changed, 145 insertions(+), 146 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index 1c36cd72905f..40cad43f8a11 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -6,9 +6,12 @@
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
-*/
+ */
/dts-v1/;
+#include dt-bindings/gpio/gpio.h
+#include dt-bindings/interrupt-controller/irq.h
+#include dt-bindings/input/input.h
#include exynos5250.dtsi
/ {
@@ -26,89 +29,19 @@
chosen {
};
- rtc@101E {
- status = okay;
- };
-
- pinctrl@1140 {
- ec_irq: ec-irq {
- samsung,pins = gpx1-6;
- samsung,pin-function = 0;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
-
- sd3_clk: sd3-clk {
- samsung,pin-drv = 0;
- };
-
- sd3_cmd: sd3-cmd {
- samsung,pin-pud = 3;
- samsung,pin-drv = 0;
- };
-
- sd3_bus4: sd3-bus-width4 {
- samsung,pin-drv = 0;
- };
-
- max98095_en: max98095-en {
- samsung,pins = gpx1-7;
- samsung,pin-function = 0;
- samsung,pin-pud = 3;
- samsung,pin-drv = 0;
- };
-
- tps65090_irq: tps65090-irq {
- samsung,pins = gpx2-6;
- samsung,pin-function = 0;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
-
- usb3_vbus_en: usb3-vbus-en {
- samsung,pins = gpx2-7;
- samsung,pin-function = 1;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
-
- hdmi_hpd_irq: hdmi-hpd-irq {
- samsung,pins = gpx3-7;
- samsung,pin-function = 0;
- samsung,pin-pud = 1;
- samsung,pin-drv = 0;
- };
- };
-
- pinctrl@1340 {
- arb_their_claim: arb-their-claim {
- samsung,pins = gpe0-4;
- samsung,pin-function = 0;
- samsung,pin-pud = 3;
- samsung,pin-drv = 0;
- };
-
- arb_our_claim: arb-our-claim {
- samsung,pins = gpf0-3;
- samsung,pin-function = 1;
- samsung,pin-pud = 0;
- samsung,pin-drv = 0;
- };
- };
-
gpio-keys {
compatible = gpio-keys;
power {
label = Power;
- gpios = gpx1 3 1;
- linux,code = 116; /* KEY_POWER */
+ gpios = gpx1 3 GPIO_ACTIVE_LOW;
+ linux,code = KEY_POWER;
gpio-key,wakeup;
};
lid-switch {
label = Lid;
- gpios = gpx3 5 1;
+ gpios = gpx3 5 GPIO_ACTIVE_LOW;
linux,input-type = 5; /* EV_SW */
linux,code = 0; /* SW_LID */
debounce-interval = 1;
@@ -129,8 +62,8 @@
i2c-parent = {/i2c@12CA};
- our-claim-gpio = gpf0 3 1;
- their-claim-gpios = gpe0 4 1;
+ our-claim-gpio = gpf0 3 GPIO_ACTIVE_LOW;
+ their-claim-gpios = gpe0 4 GPIO_ACTIVE_LOW;
slew-delay-us = 10;
wait-retry-us = 3000;
wait-free-us = 5;
@@ -153,7 +86,7 @@
cros_ec: embedded-controller {
compatible = google,cros-ec-i2c;
reg = 0x1e;
-
[PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250
Allows them to be extended by reference.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
arch/arm/boot/dts/exynos5250.dtsi | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 834fb5a5306f..cf94aeaeaa84 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -215,7 +215,7 @@
clock-names = fimg2d;
};
- codec@1100 {
+ mfc: codec@1100 {
compatible = samsung,mfc-v6;
reg = 0x1100 0x1;
interrupts = 0 96 0;
@@ -224,7 +224,7 @@
clock-names = mfc;
};
- rtc@101E {
+ rtc: rtc@101E {
clocks = clock CLK_RTC;
clock-names = rtc;
status = disabled;
@@ -238,27 +238,27 @@
clock-names = tmu_apbif;
};
- serial@12C0 {
+ uart0: serial@12C0 {
clocks = clock CLK_UART0, clock CLK_SCLK_UART0;
clock-names = uart, clk_uart_baud0;
};
- serial@12C1 {
+ uart1: serial@12C1 {
clocks = clock CLK_UART1, clock CLK_SCLK_UART1;
clock-names = uart, clk_uart_baud0;
};
- serial@12C2 {
+ uart2: serial@12C2 {
clocks = clock CLK_UART2, clock CLK_SCLK_UART2;
clock-names = uart, clk_uart_baud0;
};
- serial@12C3 {
+ uart3: serial@12C3 {
clocks = clock CLK_UART3, clock CLK_SCLK_UART3;
clock-names = uart, clk_uart_baud0;
};
- sata@122F {
+ sata: sata@122F {
compatible = snps,dwc-ahci;
samsung,sata-freq = 66;
reg = 0x122F 0x1ff;
@@ -570,7 +570,7 @@
#phy-cells = 1;
};
- usb@1211 {
+ ehci: usb@1211 {
compatible = samsung,exynos4210-ehci;
reg = 0x1211 0x100;
interrupts = 0 71 0;
@@ -585,7 +585,7 @@
};
};
- usb@1212 {
+ ohci: usb@1212 {
compatible = samsung,exynos4210-ohci;
reg = 0x1212 0x100;
interrupts = 0 71 0;
@@ -722,7 +722,7 @@
clock-names = gscl;
};
- hdmi {
+ hdmi: hdmi {
compatible = samsung,exynos4212-hdmi;
reg = 0x1453 0x7;
interrupts = 0 95 0;
@@ -748,14 +748,14 @@
#phy-cells = 0;
};
- dp-controller@145B {
+ dp: dp-controller@145B {
clocks = clock CLK_DP;
clock-names = dp;
phys = dp_phy;
phy-names = dp;
};
- fimd@1440 {
+ fimd: fimd@1440 {
clocks = clock CLK_SCLK_FIMD1, clock CLK_FIMD1;
clock-names = sclk_fimd, fimd;
};
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 01/10] ARM: dts: Fix MMC pinctrl for exynos5250-snow
The pinctrl properties should be on the device directly and not on the
slot sub-node.
Reported-by: Doug Anderson diand...@chromium.org
Cc: Jaehoon Chung jh80.ch...@samsung.com
Reviewed-by: Tomasz Figa t.f...@samsung.com
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v3 - v4 - v5 - v6: Unchanged
v3: New (Doug Anderson)
Redundant with Jaehoon Chung's general slot@0 deprecation,
in case that hits the tree earlier.
arch/arm/boot/dts/exynos5250-snow.dts | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts/exynos5250-snow.dts
index f2b8c4116541..eb437f6afec1 100644
--- a/arch/arm/boot/dts/exynos5250-snow.dts
+++ b/arch/arm/boot/dts/exynos5250-snow.dts
@@ -240,10 +240,8 @@
*/
mmc@1223 {
status = okay;
- slot@0 {
- pinctrl-names = default;
- pinctrl-0 = sd3_clk sd3_cmd sd3_bus4;
- };
+ pinctrl-names = default;
+ pinctrl-0 = sd3_clk sd3_cmd sd3_bus4;
};
i2c@12CD {
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 05/10] ARM: dts: Fill in bootargs for exynos5250-snow
Hello Andreas,
Sorry for missing your v5.
On 08/02/2014 02:52 AM, Andreas Färber wrote:
chosen {
+ bootargs = console=tty1;
};
While I agree with you that having a chosen node with a default bootargs is
better than having an empty one, I second Doug that this bootargs is not very
useful.
If you want to add a bootargs in the DTS I think that it should be a complete
kernel command line that allows to boot a system. I would at least add a root
parameter and possibly another console for the serial port. So if
CMDLINE_FROM_BOOTLOADER is not set then the DT can be used to specify the
bootargs instead of using whatever was set in CONFIG_CMDLINE which probably
won't be relevant for every system on a multi-platform kernel.
But I think that is safe to rely on the bootloader to set the bootargs and after
all having a hardcoded bootargs in the DTS is not much better than having a
hardcoded CONFIG_CMDLINE since as Doug said it is hard to make assumptions about
what would be the most common options.
Personally I would just drop this change and as I said before remove the empty
chosen node on a follow up patch but I don't have a strong opinion either.
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring
Hello Andreas On 08/02/2014 02:52 AM, Andreas Färber wrote: Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 based attempts by Stephan and me that broke for 3.16, I've prepared a device tree for the HP Chromebook 11 aka Google Spring. v6 renames a node and reverts dp_hpd. Not yet enabled are trackpad, Wifi and sound. My rebasing branch for testing is here: https://github.com/afaerber/linux/commits/spring-next Regards, Andreas I made a comment on patch 05/10 but the rest of the series looks good to me. So for the remaining patches: Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk NOTE: I thought that Tomasz Figa gave you his Reviewed-by on v5 for the whole series as well but I didn't see his tag on the v6 patches. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v9 3/6] ARM: dts: Exynos: add CPU OPP and regulator supply property
Hello Thomas, On 07/30/2014 10:07 AM, Thomas Abraham wrote: For Exynos 4210/5250/5420 based platforms, add CPU operating points and CPU regulator supply properties for migrating from Exynos specific cpufreq driver to using generic cpufreq drivers. Cc: Kukjin Kim kgene@samsung.com Cc: Doug Anderson diand...@chromium.org Cc: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Andreas Faerber afaer...@suse.de Cc: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Thomas Abraham thomas...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts |4 +++ arch/arm/boot/dts/exynos4210-trats.dts |4 +++ arch/arm/boot/dts/exynos4210-universal_c210.dts |4 +++ arch/arm/boot/dts/exynos4210.dtsi | 14 - arch/arm/boot/dts/exynos5250-arndale.dts|4 +++ arch/arm/boot/dts/exynos5250-smdk5250.dts |4 +++ arch/arm/boot/dts/exynos5250-snow.dts |4 +++ arch/arm/boot/dts/exynos5250.dtsi | 25 ++- arch/arm/boot/dts/exynos5420.dtsi | 38 +++ 9 files changed, 99 insertions(+), 2 deletions(-) Tested the series on a Exynos5420 based Peach Pit Chromebook by doing the following for CPU0-3: 1) Verified that the big.LITTLE CPUFreq (arm-big-little) driver was reported as used in /sys/devices/system/cpu/cpu*/cpufreq/scaling_driver. 2) Set all available governors (conservative, ondemand, userspace, powersave and performance). 3) Confirmed that cpuinfo_cur_freq and scaling_cur_freq values were fixed or changing according to the selected governor policy. 4) Verified that the statistics in /sys/devices/system/cpu/cpu*/cpufreq/stats/* were filled. Everything is working correctly so please feel free to add for the whole series: Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250
Andreas, On Fri, Aug 1, 2014 at 5:52 PM, Andreas Färber afaer...@suse.de wrote: Allows them to be extended by reference. Signed-off-by: Andreas Färber afaer...@suse.de --- v6: Split off from Snow/SMDK cleanups (Doug Anderson) arch/arm/boot/dts/exynos5250.dtsi | 24 1 file changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Doug Anderson diand...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree
Tomasz,
On Thu, Jul 31, 2014 at 12:40 PM, Tomasz Figa tomasz.f...@gmail.com wrote:
Andreas,
On 31.07.2014 21:20, Andreas Färber wrote:
Am 31.07.2014 21:05, schrieb Tomasz Figa:
On 31.07.2014 18:08, Andreas Färber wrote:
Adds initial support for the HP Chromebook 11.
[snip]
+ gpio-keys {
+ compatible = gpio-keys;
+ pinctrl-names = default;
+ pinctrl-0 = power_key_irq, lid_irq;
+
+ power {
+ label = Power;
+ gpios = gpx1 3 GPIO_ACTIVE_LOW;
+ linux,code = KEY_POWER;
I assume the key is debounced in hardware, so there is no need for
debounce-interval here. Is this correct?
You're asking the wrong person... This is copied from
-cros-common/-snow. Downstream 3.8 does not have a debounce-interval
property.
Doug, Vincent?
Not something I've looked at, but it's never been a problem...
+sd1_clk {
+ samsung,pin-drv = 0;
+};
+
+sd1_cmd {
+ samsung,pin-pud = 3;
+ samsung,pin-drv = 0;
+};
+
+sd1_cd {
+ samsung,pin-drv = 0;
+};
+
+sd1_bus4 {
+ samsung,pin-drv = 0;
+};
Here generic settings are being overridden, so it might be a good idea
to explain why, like with i2c pull-up above.
Snow does not have an explanation either, so please suggest what comment
you'd like to see. Consider me just a user with no specs. :)
Doug, Vincent, someone else?
The comment is just in a different place--it's in the dw_mmc node.
Probably belongs here, though:
/*
* Wifi is a SiP, so can keep drive strengths low
* to reduce EMI.
*/
I guess the cmd line isn't documented. There is no external pull on
the command line and on most boards there is one. Our hardware guys
thought we didn't need it and apparently we don't...
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
