Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support
Hi, On 16 February 2015 at 01:19, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Olof, On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: Hello, The mainline ChromeOS Embedded Controller (EC) driver is still missing some features that are present in the downstream ChromiumOS tree. These are: - Low Pin Count (LPC) interface - User-space device interface - Access to vboot context stored on a block device - Access to vboot context stored on EC's nvram - Power Delivery Device - Support for multiple EC in a system This is a fifth version of a series that adds support for the first two of the missing features: the EC LPC and EC character device interfaces that are used by user-space to access the ChromeOS EC. The support patches were taken from the downstream ChromiumOS 3.14 tree with the fixes and cleanups squashed to have a minimal patch-set. Any comments on this series? The last version was posted a couple of weeks ago but the series have been in the list for months. Lee has already acked the mfd changes so you can merge all through your chrome-platform tree if you want. It wold be great if this series get in to have the EC user-space interface supported and to minimize the delta with the Chromemium OS kernel since it still has other features that needs to be upstreamed like multiple EC in a system and access to vboot context stored in block device or EC's nvram. Are you sure Olof is the right maintainer for this going to mainline? I do feel for you trying to get all this in and have seen your many attempts. It has been in U-Boot for 18 months...I hope you get there in the end. Regards, Simon -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/9] ARM: samsung: randconfig build fixes
Arnd Bergmann wrote: This is a set of mostly trivial build fixes for bugs I have encountered in random configurations. I'm sending them separate from the other platforms since we have a lot of them for the various samsung platforms here. Kukjin, please pick them up into a fixes branch for 3.20 or send an Ack so we can apply them directly. Sure, I will create a branch for them in this week. IMO, would be better if I could make a non-critical fixes branch for v3.20 in Samsung tree for further other Samsung stuff for v3.20 ;) Let me know if anything looks wrong with some of the patches. OK, if anything I'll let you know. Thanks for your pointing out. Happy new year again! (Actually it's the Lunar New Year holidays now) - Kukjin Arnd Bergmann (9): ARM: s3c64xx: add I2C dependencies where needed ARM: s3c64xx: fix building without CONFIG_PM_SLEEP ARM: s3c64xx: fix __initdata section mismatch ARM: s3c24xx: use SAMSUNG_WAKEMASK for s3c2416 ARM: s3c24xx: fix building without PM_SLEEP ARM: s3c24xx: fix header file inclusions ARM: s3c24xx: avoid a Kconfig warning ARM: EXYNOS: suspend requires regulator access ARM: EXYNOS: make exynos 4210 cpuidle build without SMP arch/arm/mach-exynos/Kconfig | 1 + arch/arm/mach-exynos/pm.c| 19 +++ arch/arm/mach-s3c24xx/Kconfig| 19 ++- arch/arm/mach-s3c24xx/Makefile | 3 ++- arch/arm/mach-s3c24xx/include/mach/pm-core.h | 24 ++-- arch/arm/mach-s3c24xx/pm-s3c2416.c | 3 ++- arch/arm/mach-s3c24xx/pm.c | 6 -- arch/arm/mach-s3c24xx/s3c2410.c | 2 +- arch/arm/mach-s3c24xx/s3c2412.c | 2 +- arch/arm/mach-s3c24xx/s3c2416.c | 2 +- arch/arm/mach-s3c24xx/s3c2440.c | 4 ++-- arch/arm/mach-s3c24xx/s3c2442.c | 4 ++-- arch/arm/mach-s3c24xx/s3c244x.c | 7 ++- arch/arm/mach-s3c64xx/Kconfig| 4 +++- arch/arm/mach-s3c64xx/Makefile | 3 ++- arch/arm/mach-s3c64xx/mach-smdk6410.c| 2 +- arch/arm/mach-s3c64xx/pm.c | 2 ++ arch/arm/plat-samsung/include/plat/pm.h | 14 +++--- arch/arm/plat-samsung/pm-debug.c | 1 + arch/arm/plat-samsung/pm.c | 20 20 files changed, 85 insertions(+), 57 deletions(-) -- -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Revert drm/exynos: IOMMU support should not be selectable by user
This reverts commit 8dcc14f82f06fce997e35f4c77ced9d4ed192f31. This patch causes this error on Arndale: [1.643800] kernel BUG at drivers/iommu/exynos-iommu.c:481! [1.649355] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM [1.655170] Modules linked in: [1.658203] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.19.0-07543-g3ec3f38 #1904 [1.665683] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [1.671750] task: ee0f4000 ti: ee0f2000 task.ti: ee0f2000 [1.677138] PC is at __exynos_sysmmu_enable+0x190/0x19c [1.682341] LR is at exynos_iommu_attach_device+0x54/0xc0 I am afraid I am not very familiar with either IOMMU or DRM, so apologies if I am missing anything and fixing the underlying problem in exynos-iommu.c is beyond my knowledge. That said this appears to be related to the the fact archdata.iommu is never set to anything in drivers/iommu/exynos-iommu.c. It looks to me like the exynos-iommu driver is broken as nothing initialises the exynos_iommu_owner structure, this doesn't look to be the result of recent changes either so I assume it has been broken for some time. If I had to guess I would suggest this driver works in some out of tree implementation, but not in mainline. Simplest solution seems to be to revert this patch such that the IOMMU driver is not built in on Arndale until it is fixed. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/gpu/drm/exynos/Kconfig |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index a5e7461..3fe02ca 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -12,9 +12,10 @@ config DRM_EXYNOS If M is selected the module will be called exynosdrm. config DRM_EXYNOS_IOMMU - bool + bool EXYNOS DRM IOMMU Support depends on DRM_EXYNOS EXYNOS_IOMMU ARM_DMA_USE_IOMMU - default y + help + Choose this option if you want to use IOMMU feature for DRM. config DRM_EXYNOS_FIMD bool Exynos DRM FIMD -- 1.7.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] drm/exynos: Check for NULL dereference of crtc
The commit drm/exynos: remove exynos_plane_dpms (d9ea6256) removed the use of the enabled flag, which means that the code may attempt to call win_enable on a NULL crtc. This results in the following oops on Arndale: [1.673479] Unable to handle kernel NULL pointer dereference at virtual address 0368 [1.681500] pgd = c0004000 [1.684154] [0368] *pgd= [1.687713] Internal error: Oops: 5 [#1] PREEMPT SMP ARM [1.693012] Modules linked in: [1.696045] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.19.0-07545-g57485fa #1907 [1.703524] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) () [2.014803] [c02f9cfc] (exynos_plane_destroy) from [c02e61b4] (drm_mode_config_cleanup+0x168/0x20c) [2.024178] [c02e61b4] (drm_mode_config_cleanup) from [c02f66fc] (exynos_drm_load+0xac/0x12c) This patch adds in a check to ensure exynos_crtc is not NULL before it is dereferenced. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com --- drivers/gpu/drm/exynos/exynos_drm_plane.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c index 2dfb847..78fc0a1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c @@ -176,7 +176,7 @@ static int exynos_disable_plane(struct drm_plane *plane) struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane); struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(plane-crtc); - if (exynos_crtc-ops-win_disable) + if (exynos_crtc exynos_crtc-ops-win_disable) exynos_crtc-ops-win_disable(exynos_crtc, exynos_plane-zpos); -- 1.7.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: exynos4412: misc issues on Hardkernel Odroid boards
2015-02-14 19:14 GMT+01:00 Tobias Jakobi tjak...@math.uni-bielefeld.de: Hello! Marek Szyprowski wrote: 4) Spinlock BUGs triggered by the sdhci subsystem (so for the people using the system with a SD card). This is also a known problem, I think first mentioned here: http://www.spinics.net/lists/linux-mmc/msg27277.html Currently fixing this with this patch: https://github.com/tobiasjakobi/linux-odroid/commit/abc749843dd7022d01322dca3db0181211a30cd8 The fix for this issue has been queued to mmc-next: https://git.linaro.org/people/ulf.hansson/mmc.git/commit/017210d1c0dc2e2d3b142985cb31d90b98dc0f0f This fix doesn't work for me. I have it applied, but encountered this just now: [ 33.159544] BUG: scheduling while atomic: mmcqd/0/789/0x0002 [ 33.159558] Modules linked in: bridge stp llc bnep btrfs xor xor_neon zlib_inflate zlib_deflate raid6_pq ecb btusb bluetooth usb_storage [ 33.159625] Preemption disabled at:[c037de64] sdhci_do_set_ios+0x24/0x6a0 Looking at the backtrace this seems very likely however I have troubles reproducing this. Any special tree or config is required (except MMC_CLKGATE and DEBUG_ATOMIC_SLEEP)? Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Revert drm/exynos: IOMMU support should not be selectable by user
On Tue, Feb 17, 2015 at 09:18:28PM +0100, Javier Martinez Canillas wrote: Hello Charles, On Tue, Feb 17, 2015 at 5:58 PM, Charles Keepax ckee...@opensource.wolfsonmicro.com wrote: This reverts commit 8dcc14f82f06fce997e35f4c77ced9d4ed192f31. This patch causes this error on Arndale: IMHO the commit you are referring is correct so it should not be reverted but I also had the same error on different boards (Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi). So I posted a patch [0] today to disable Exnos IOMMU support in exynos_defconfig until these issues gets fixed. Best regards, Javier [0]: https://lkml.org/lkml/2015/2/17/163 I agree your patch is the better fix. Thanks, Charles -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support
Enabling Exynos DRM IOMMU support for Exynos is currently broken and causes a BUG on exynos-iommu driver. This was not an issue since the options was disabled in exynos_defconfig but after commit 8dcc14f82f06 (drm/exynos: IOMMU support should not be selectable by user), it is selected if EXYNOS_IOMMU is enabled which is in exynos_defconfig. So a kernel built using exynos_defconfig after the mentioned commit fails to boot [0]. Disable IOMMU support in Exynos defconfig until things get sorted out. [0]: [1.242183] [ cut here ] [1.246191] kernel BUG at drivers/iommu/exynos-iommu.c:481! [1.251747] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM [1.257561] Modules linked in: [1.260603] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.19.0-07478-g796e1c55717e #490 [1.268412] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [1.274489] task: ee06c000 ti: ee05a000 task.ti: ee05a000 [1.279874] PC is at __exynos_sysmmu_enable+0x184/0x190 [1.285080] LR is at exynos_iommu_attach_device+0x44/0xb0 [1.290461] pc : [c0254a14]lr : [c0254a64]psr: 6193 [1.290461] sp : ee05bcf8 ip : fp : ed84aa40 [1.301916] r10: ed84a890 r9 : a113 r8 : 6db3 [1.307125] r7 : ed84aa40 r6 : r5 : r4 : ee174e10 [1.313635] r3 : 6db3 r2 : ed84aa40 r1 : 6db3 r0 : ee174e10 [1.320147] Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel [1.327524] Control: 10c5387d Table: 4000406a DAC: 0015 [1.333252] Process swapper/0 (pid: 1, stack limit = 0xee05a210) [1.339241] Stack: (0xee05bcf8 to 0xee05c000) [1.343581] bce0: 6db3 ee174e10 [1.351741] bd00: ed84a880 ed84aa40 ee174e10 a113 ed84a890 c0254a64 [1.359900] bd20: 6db3 ee174e10 ed84adc0 0005 0034 0001 c0692c1c [1.368059] bd40: 0097 c02526c8 ee29f050 c0017210 ee29f050 ee174e10 edab6810 c0282558 [1.376219] bd60: edab6a10 ee1cb000 0005 c0283520 ee29f240 c028f210 edab6810 ee2ef280 [1.384378] bd80: edb24680 ed84a680 ee1cb000 c02883f8 edab6810 ee1cb000 ee1cb000 [1.392537] bda0: ed84a680 ee2ef450 c027e968 ee1cb000 c0268fd4 [1.400696] bdc0: edab6800 c06b0de4 ee1cb000 c026a8bc ee2ef0c0 c028f210 0002 ee2ef460 [1.408855] bde0: ee2ef460 0002 ee2ef280 c0288728 c04af5d0 edab6810 ee2ef280 [1.417014] be00: c06b1348 c0288918 c06b0f00 c06b0f00 edab6810 0001 c06b0da0 c027eaf4 [1.425173] be20: c070334c edaee190 edab6810 ffed c06b0da0 c028da1c [1.42] be40: edab6810 c070334c c028c5f8 edab6810 c06b0da0 edab6844 [1.441492] be60: eda3c740 c028c7a4 c06b0da0 c028c718 c028af74 ee005274 ee3b7b40 [1.449652] be80: c06b0da0 ee3b7680 c06b1540 c028bde4 c05b6990 c06b0da0 c0703324 c06b0da0 [1.457811] bea0: c0703324 c069ab18 c028cdc4 c0703324 c027ebd8 [1.465970] bec0: c05b6990 c00c4574 [1.474129] bee0: c069ab18 c027eb1c c069ab18 c069ab18 c0008944 [1.482288] bf00: 0036 c04770e8 ee049800 c06eace0 ee06c000 6113 c069eab0 [1.490447] bf20: c069eab0 6113 ef7fcabc ef7fcaae c061c594 c0038640 [1.498607] bf40: c05cb1d0 c061bc24 0006 0006 c069ea50 c06724d4 0006 c06724b4 [1.506766] bf60: c06c7600 c0647588 c0692c1c 0097 c0647d40 0006 0006 [1.514925] bf80: c0647588 c003d2d8 c046921c [1.523084] bfa0: c0469224 c000e680 [1.531243] bfc0: [1.539402] bfe0: 0013 [1.547567] [c0254a14] (__exynos_sysmmu_enable) from [c0254a64] (exynos_iommu_attach_device+0x44/0xb0) [1.557199] [c0254a64] (exynos_iommu_attach_device) from [c02526c8] (iommu_attach_device+0x18/0x24) [1.566576] [c02526c8] (iommu_attach_device) from [c0017210] (arm_iommu_attach_device+0x18/0x50) [1.575690] [c0017210] (arm_iommu_attach_device) from [c0282558] (drm_iommu_attach_device+0x50/0xb4) [1.585150] [c0282558] (drm_iommu_attach_device) from [c0283520] (fimd_bind+0x94/0x1b8) [1.593483] [c0283520] (fimd_bind) from [c02883f8] (component_bind_all+0xb4/0x214) [1.601380] [c02883f8] (component_bind_all) from [c027e968] (exynos_drm_load+0x9c/0x13c) [1.609802] [c027e968] (exynos_drm_load) from [c0268fd4] (drm_dev_register+0xa0/0xf4) [1.617960] [c0268fd4] (drm_dev_register) from [c026a8bc] (drm_platform_init+0x44/0xcc) [1.626293] [c026a8bc] (drm_platform_init) from [c0288728] (try_to_bring_up_master.part.3+0xc8/0x104) [
Re: [PATCH v12 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
Hello! Lukasz Majewski wrote: Hi Krzysztof, Thomas, 2015-01-08 22:17 GMT+01:00 Kevin Hilman khil...@kernel.org: Hi Thomas, Do you plan to continue with this work? It would be very helpful. +1 from me. I also wonder if Exynos 4412 could be re-added (without the boost if these bindings are not ready)? I would prefer to have all platforms converted at once, since it might happen that some parts of the work would get lost. Joining in as well! Reviving this patch series would be very much appreciated, especially if it moves again into the direction of storing most information into the DT (so that one can easily modify it in the board dts). With best wishes, Tobias -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Revert drm/exynos: IOMMU support should not be selectable by user
Hello Charles, On Tue, Feb 17, 2015 at 5:58 PM, Charles Keepax ckee...@opensource.wolfsonmicro.com wrote: This reverts commit 8dcc14f82f06fce997e35f4c77ced9d4ed192f31. This patch causes this error on Arndale: IMHO the commit you are referring is correct so it should not be reverted but I also had the same error on different boards (Exynos5250 Snow, Exynos5420 Peach Pit and Exynos5800 Peach Pi). So I posted a patch [0] today to disable Exnos IOMMU support in exynos_defconfig until these issues gets fixed. Best regards, Javier [0]: https://lkml.org/lkml/2015/2/17/163 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency
On 02/16/15 05:36, Krzysztof Kozlowski wrote: During CPU shutdown the exynos_cpu_power_down() is called after disabling cache coherency and it uses LDREX and STREX instructions (by calling of_machine_is_compatible() - kobject_get() - kref_get()). The LDREX and STREX should not be used after disabling the cache coherency so just use soc_is_exynos(). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Fixes: adc548d77c22 (ARM: EXYNOS: Use MCPM call-backs to support S2R on exynos5420) Cc: sta...@vger.kernel.org Reported-by: Stephen Boyd sb...@codeaurora.org --- Looks good to me. Reviewed-by: Stephen Boyd sb...@codeaurora.org -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
drm/exynos: DRM_EXYNOS7DECON?
Your commit 96976c3d9aff (drm/exynos: Add DECON driver) is included in today's linux-next (ie, next-20150217). I noticed because a script I use to check linux-next spotted a problem with it. It added an (optional) dependency on DRM_EXYNOS7DECON instead of DRM_EXYNOS7_DECON (see drivers/gpu/drm/exynos/Kconfig). Is the trivial patch to correct this typo queued somewhere? (This assumes an optional dependency on DRM_EXYNOS7_DECON is actually needed for DRM_EXYNOS_DP, of course.) Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: drm/exynos: DRM_EXYNOS7DECON?
On 2015년 02월 17일 18:04, Paul Bolle wrote: Your commit 96976c3d9aff (drm/exynos: Add DECON driver) is included in today's linux-next (ie, next-20150217). I noticed because a script I use to check linux-next spotted a problem with it. It added an (optional) dependency on DRM_EXYNOS7DECON instead of DRM_EXYNOS7_DECON (see drivers/gpu/drm/exynos/Kconfig). Is the trivial patch to correct this typo queued somewhere? (This assumes an optional dependency on DRM_EXYNOS7_DECON is actually needed for DRM_EXYNOS_DP, of course.) Ah, right. It's my mistake. That is just typo so it should be DRM_EXYNOS7_DECON instead of DRM_EXYNOS7DECON. It would be fixed at RC1. Thanks for report, Inki Dae Paul Bolle -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support
On wto, 2015-02-17 at 12:38 +0100, Javier Martinez Canillas wrote: Enabling Exynos DRM IOMMU support for Exynos is currently broken and causes a BUG on exynos-iommu driver. This was not an issue since the options was disabled in exynos_defconfig but after commit 8dcc14f82f06 (drm/exynos: IOMMU support should not be selectable by user), it is selected if EXYNOS_IOMMU is enabled which is in exynos_defconfig. So a kernel built using exynos_defconfig after the mentioned commit fails to boot [0]. Disable IOMMU support in Exynos defconfig until things get sorted out. On which board you got this error? Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support
Hello, On 2015-02-17 12:38, Javier Martinez Canillas wrote: Enabling Exynos DRM IOMMU support for Exynos is currently broken and causes a BUG on exynos-iommu driver. This was not an issue since the options was disabled in exynos_defconfig but after commit 8dcc14f82f06 (drm/exynos: IOMMU support should not be selectable by user), it is selected if EXYNOS_IOMMU is enabled which is in exynos_defconfig. So a kernel built using exynos_defconfig after the mentioned commit fails to boot [0]. Disable IOMMU support in Exynos defconfig until things get sorted out. [0]: [1.242183] [ cut here ] [1.246191] kernel BUG at drivers/iommu/exynos-iommu.c:481! [1.251747] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM [1.257561] Modules linked in: [1.260603] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 3.19.0-07478-g796e1c55717e #490 [1.268412] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [1.274489] task: ee06c000 ti: ee05a000 task.ti: ee05a000 [1.279874] PC is at __exynos_sysmmu_enable+0x184/0x190 [1.285080] LR is at exynos_iommu_attach_device+0x44/0xb0 [1.290461] pc : [c0254a14]lr : [c0254a64]psr: 6193 [1.290461] sp : ee05bcf8 ip : fp : ed84aa40 [1.301916] r10: ed84a890 r9 : a113 r8 : 6db3 [1.307125] r7 : ed84aa40 r6 : r5 : r4 : ee174e10 [1.313635] r3 : 6db3 r2 : ed84aa40 r1 : 6db3 r0 : ee174e10 [1.320147] Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel [1.327524] Control: 10c5387d Table: 4000406a DAC: 0015 [1.333252] Process swapper/0 (pid: 1, stack limit = 0xee05a210) [1.339241] Stack: (0xee05bcf8 to 0xee05c000) [1.343581] bce0: 6db3 ee174e10 [1.351741] bd00: ed84a880 ed84aa40 ee174e10 a113 ed84a890 c0254a64 [1.359900] bd20: 6db3 ee174e10 ed84adc0 0005 0034 0001 c0692c1c [1.368059] bd40: 0097 c02526c8 ee29f050 c0017210 ee29f050 ee174e10 edab6810 c0282558 [1.376219] bd60: edab6a10 ee1cb000 0005 c0283520 ee29f240 c028f210 edab6810 ee2ef280 [1.384378] bd80: edb24680 ed84a680 ee1cb000 c02883f8 edab6810 ee1cb000 ee1cb000 [1.392537] bda0: ed84a680 ee2ef450 c027e968 ee1cb000 c0268fd4 [1.400696] bdc0: edab6800 c06b0de4 ee1cb000 c026a8bc ee2ef0c0 c028f210 0002 ee2ef460 [1.408855] bde0: ee2ef460 0002 ee2ef280 c0288728 c04af5d0 edab6810 ee2ef280 [1.417014] be00: c06b1348 c0288918 c06b0f00 c06b0f00 edab6810 0001 c06b0da0 c027eaf4 [1.425173] be20: c070334c edaee190 edab6810 ffed c06b0da0 c028da1c [1.42] be40: edab6810 c070334c c028c5f8 edab6810 c06b0da0 edab6844 [1.441492] be60: eda3c740 c028c7a4 c06b0da0 c028c718 c028af74 ee005274 ee3b7b40 [1.449652] be80: c06b0da0 ee3b7680 c06b1540 c028bde4 c05b6990 c06b0da0 c0703324 c06b0da0 [1.457811] bea0: c0703324 c069ab18 c028cdc4 c0703324 c027ebd8 [1.465970] bec0: c05b6990 c00c4574 [1.474129] bee0: c069ab18 c027eb1c c069ab18 c069ab18 c0008944 [1.482288] bf00: 0036 c04770e8 ee049800 c06eace0 ee06c000 6113 c069eab0 [1.490447] bf20: c069eab0 6113 ef7fcabc ef7fcaae c061c594 c0038640 [1.498607] bf40: c05cb1d0 c061bc24 0006 0006 c069ea50 c06724d4 0006 c06724b4 [1.506766] bf60: c06c7600 c0647588 c0692c1c 0097 c0647d40 0006 0006 [1.514925] bf80: c0647588 c003d2d8 c046921c [1.523084] bfa0: c0469224 c000e680 [1.531243] bfc0: [1.539402] bfe0: 0013 [1.547567] [c0254a14] (__exynos_sysmmu_enable) from [c0254a64] (exynos_iommu_attach_device+0x44/0xb0) [1.557199] [c0254a64] (exynos_iommu_attach_device) from [c02526c8] (iommu_attach_device+0x18/0x24) [1.566576] [c02526c8] (iommu_attach_device) from [c0017210] (arm_iommu_attach_device+0x18/0x50) [1.575690] [c0017210] (arm_iommu_attach_device) from [c0282558] (drm_iommu_attach_device+0x50/0xb4) [1.585150] [c0282558] (drm_iommu_attach_device) from [c0283520] (fimd_bind+0x94/0x1b8) [1.593483] [c0283520] (fimd_bind) from [c02883f8] (component_bind_all+0xb4/0x214) [1.601380] [c02883f8] (component_bind_all) from [c027e968] (exynos_drm_load+0x9c/0x13c) [1.609802] [c027e968] (exynos_drm_load) from [c0268fd4] (drm_dev_register+0xa0/0xf4) [1.617960] [c0268fd4] (drm_dev_register) from [c026a8bc] (drm_platform_init+0x44/0xcc) [1.626293] [c026a8bc] (drm_platform_init) from
Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support
Hello Krzysztof, On 02/17/2015 01:20 PM, Krzysztof Kozlowski wrote: On wto, 2015-02-17 at 12:38 +0100, Javier Martinez Canillas wrote: Enabling Exynos DRM IOMMU support for Exynos is currently broken and causes a BUG on exynos-iommu driver. This was not an issue since the options was disabled in exynos_defconfig but after commit 8dcc14f82f06 (drm/exynos: IOMMU support should not be selectable by user), it is selected if EXYNOS_IOMMU is enabled which is in exynos_defconfig. So a kernel built using exynos_defconfig after the mentioned commit fails to boot [0]. Disable IOMMU support in Exynos defconfig until things get sorted out. On which board you got this error? Sorry, I should had mention it in the commit message. I get that error with at least Exynos5800 Peach Pi, Exynos5420 Peach Pit and Exynos5250 Snow Chromebooks with today's next (next-20150217). The problem is that the Exynos IOMMU driver does not set a struct exynos_iommu_owner in dev.archdata.iommu but __exynos_sysmmu_enable() has a BUG_ON(!has_sysmmu(dev)). Marek's series [1] solves this issue by filling sysmmu devices from DT but causes boot failures on the Exynos Chromebooks because the display is left enabled by the bootloader [2]. So I think that this option should be disabled until is known to not cause issues on any platform. Best regards, Krzysztof [1]: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/319244.html [2]: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/319293.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support
On wto, 2015-02-17 at 13:56 +0100, Javier Martinez Canillas wrote: Hello Krzysztof, On 02/17/2015 01:20 PM, Krzysztof Kozlowski wrote: On wto, 2015-02-17 at 12:38 +0100, Javier Martinez Canillas wrote: Enabling Exynos DRM IOMMU support for Exynos is currently broken and causes a BUG on exynos-iommu driver. This was not an issue since the options was disabled in exynos_defconfig but after commit 8dcc14f82f06 (drm/exynos: IOMMU support should not be selectable by user), it is selected if EXYNOS_IOMMU is enabled which is in exynos_defconfig. So a kernel built using exynos_defconfig after the mentioned commit fails to boot [0]. Disable IOMMU support in Exynos defconfig until things get sorted out. On which board you got this error? Sorry, I should had mention it in the commit message. I get that error with at least Exynos5800 Peach Pi, Exynos5420 Peach Pit and Exynos5250 Snow Chromebooks with today's next (next-20150217). The problem is that the Exynos IOMMU driver does not set a struct exynos_iommu_owner in dev.archdata.iommu but __exynos_sysmmu_enable() has a BUG_ON(!has_sysmmu(dev)). Marek's series [1] solves this issue by filling sysmmu devices from DT but causes boot failures on the Exynos Chromebooks because the display is left enabled by the bootloader [2]. So I think that this option should be disabled until is known to not cause issues on any platform. Sure, I am completely fine with that change. I just wanted to know the hardware. Anyway Marek already acked this I won't duplicate the effort :). Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
