RE: [PATCH] ARM: Exynos5420: dt: Fixed the checkpatch.pl WARNING misspelled
Anand Moon wrote: Changes fixes the misspelled of #interrups-cell. arch/arm/boot/dts/exynos5420.dtsi:224: WARNING: 'interrups' may be misspelled - perhaps 'interrupts'? Tested on OdroidXU3 board. Signed-off-by: Anand Moon linux.am...@gmail.com --- arch/arm/boot/dts/exynos5420.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index c0e98cf..a78ac1f 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -221,7 +221,7 @@ compatible = samsung,exynos4210-mct; reg = 0x101C 0x800; interrupt-controller; - #interrups-cells = 1; + #interrupt-cells = 1; Oops, what's happened :( I'm seeing the typo in exynos5250.dtsi as well... arch/arm/boot/dts/exynos5250.dtsi:146: #interrups-cells = 2; I'll apply with above fix. Thanks, Kukjin interrupt-parent = mct_map; interrupts = 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11; -- 1.9.1 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [rtc-linux] Re: [PATCH v2 2/2] mfd: sec-core: Modify RTC compatible name of S2MPS13
2015-03-23 13:34 GMT+01:00 Lee Jones lee.jo...@linaro.org: On Tue, 17 Mar 2015, Krzysztof Kozlowski wrote: From: Chanwoo Choi cw00.c...@samsung.com This patch modify the RTC compatible name of S2MPS13 because S2MPS13's RTC is equal to S2MPS14's RTC. Cc: Lee Jones lee.jo...@linaro.org Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Changes since v1: 1. New patch. --- drivers/mfd/sec-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Hi, Sorry for the mess but we did this wrong. The S2MPS13 RTC is slightly different than S2MPS14 and that difference is important. It is embarrassing... but the difference was written small-print as a note in datasheet. Really. I found it after carefully comparing two PDFs. The impact of difference was not detected because of error in DTS for Exynos5433-based board. This patch should be dropped (or reverted) and s2mps13-rtc should be used for S2MPS13 RTC mfd_cell. The RTC driver (rtc/rtxc-s5m) should have its own support for RTC which I will add in separate patch. Lee, once again sorry for the mess. How would you like to proceed? Can you just drop this commit? Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
Bartlomiej Zolnierkiewicz wrote: Hi, Hi, On Monday, February 23, 2015 10:07:50 AM Viresh Kumar wrote: On 20 February 2015 at 21:50, Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com wrote: Allow driver build for !THERMAL or !CPU_THERMAL cases. The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()). Cc: Kukjin Kim kg...@kernel.org Looks OK to me, Acked-by: Kukjin Kim kg...@kernel.org Thanks, Kukjin Cc: Arnd Bergmann a...@arndb.de Cc: Eduardo Valentin edubez...@gmail.com Cc: Lukasz Majewski l.majew...@samsung.com Fixes: 8b2b4a4e5366 (cpufreq: exynos: allow modular build) Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/cpufreq/Kconfig.arm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 1b06fc4..f4df4af3 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ config ARM_EXYNOS_CPUFREQ tristate SAMSUNG EXYNOS CPUfreq Driver depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250 - depends on THERMAL + # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y: + depends on !CPU_THERMAL || THERMAL help This adds the CPUFreq driver for Samsung EXYNOS platforms. Supported SoC versions are: Acked-by: Viresh Kumar viresh.ku...@linaro.org Thank you for the ACK. Would you pick this patch up or should I resend it to Rafael? Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
Mark Brown wrote: On Sun, Mar 22, 2015 at 10:40:41AM +, Charles Keepax wrote: There are two PMICs on Cragganmore, currently one dynamically assign its IRQ base and the other uses a fixed base. It is possible for the statically assigned PMIC to fail if its IRQ is taken by the dynamically assigned one. Fix this by statically assigning both the IRQ bases. Signed-off-by: Charles Keepax ckee...@opensource.wolfsonmicro.com Reviwed-by: Mark Brown broo...@kernel.org Thanks for your review. This probably wants to go to stable as well. OK, I'll. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [alsa-devel] [PATCH RESEND] ARM: dts: Support audio on Exynos5422-odroidxu3 using simple-audio-card
Sylwester Nawrocki wrote: On 23/03/15 03:51, Inha Song wrote: Add MAX98090 audio codec, I2S interface and the sound nodes to support audio on Exynos5422 SoC Based Odroid-XU3 board. Now we can support audio in Odroid-XU3 board using simple-audio-card DT binding. Signed-off-by: Inha Song ideal.s...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 9 + arch/arm/boot/dts/exynos5422-odroidxu3.dts | 57 ++ 2 files changed, 66 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 4eaeabe..e459c1d 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -415,6 +415,9 @@ clock_audss EXYNOS_I2S_BUS, clock_audss EXYNOS_SCLK_I2S; clock-names = iis, i2s_opclk0, i2s_opclk1; + #clock-cells = 1; + clock-output-names = i2s_cdclk0; + #sound-dai-cells = 1; samsung,idma-addr = 0x0300; pinctrl-names = default; pinctrl-0 = i2s0_bus; @@ -429,6 +432,9 @@ dma-names = tx, rx; clocks = clock CLK_I2S1, clock CLK_SCLK_I2S1; clock-names = iis, i2s_opclk0; + #clock-cells = 1; + clock-output-names = i2s_cdclk1; + #sound-dai-cells = 1; pinctrl-names = default; pinctrl-0 = i2s1_bus; status = disabled; @@ -442,6 +448,9 @@ dma-names = tx, rx; clocks = clock CLK_I2S2, clock CLK_SCLK_I2S2; clock-names = iis, i2s_opclk0; + #clock-cells = 1; + clock-output-names = i2s_cdclk2; + #sound-dai-cells = 1; pinctrl-names = default; pinctrl-0 = i2s2_bus; status = disabled; diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts index edc25cf..9275ad6 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts @@ -11,6 +11,7 @@ */ /dts-v1/; +#include dt-bindings/sound/samsung-i2s.h #include exynos5800.dtsi / { @@ -285,6 +286,62 @@ rtc@101E { status = okay; }; + + sound: sound { + compatible = simple-audio-card; + assigned-clocks = clock_audss EXYNOS_MOUT_AUDSS, + clock_audss EXYNOS_MOUT_I2S, + clock_audss EXYNOS_DOUT_AUD_BUS; + assigned-clock-parents = clock CLK_FIN_PLL, + clock_audss EXYNOS_MOUT_AUDSS; + assigned-clock-rates = 0, + 0, + 1920; The patch looks good, except it would be more appropriate to move the above properties to clock_audss { }; node in this file. With that change feel free to add: Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com As a side note, this is a dts patch and of course Kukjin maintains that. You would likely get it applied sooner if you would have addressed it directly to Kukjin, rather than Mark or me. Yes, please. I'll apply this once you address comments per Sylwester's suggestion. Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7] ARM: dts: Add HS400 support for exynos5420 and exynos5800
Gentle Ping !! On Wed, Mar 18, 2015 at 4:50 PM, Alim Akhtar alim.akh...@samsung.com wrote: From: Seungwon Jeon tgih@samsung.com HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards. This also adds RCLK GPIO line, this gpio should be in pull-down state. This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Alim Akhtar alim.akh...@samsung.com [Alim: addressed review comments] Acked-by: Jaehoon Chung jh80.ch...@samsung.com --- Changes in V7: Add back bus1 pin, which was removed during rebase in v6 as rightly pointed out by Javier[1]. Changes in V6: Rebased on kukjin's for-next branch[0] (commit: 77105c8 Merge branch 'v4.0-samsung-fixes-2' into for-next) [0]: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git [1]: http://www.spinics.net/lists/arm-kernel/msg406618.html arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 - arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +-- 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 3f4e2fe..0788d08 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -699,8 +699,10 @@ samsung,dw-mshc-ciu-div = 3; samsung,dw-mshc-sdr-timing = 0 4; samsung,dw-mshc-ddr-timing = 0 2; + samsung,dw-mshc-hs400-timing = 0 2; + samsung,read-strobe-delay = 90; pinctrl-names = default; - pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8; + pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8 sd0_rclk; bus-width = 8; }; diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index ba686e4..8b15316 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi @@ -201,6 +201,13 @@ samsung,pin-drv = 3; }; + sd0_rclk: sd0-rclk { + samsung,pins = gpc0-7; + samsung,pin-function = 2; + samsung,pin-pud = 1; + samsung,pin-drv = 3; + }; + sd1_cmd: sd1-cmd { samsung,pins = gpc1-1; samsung,pin-function = 2; diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 7a56852..9103f23 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts @@ -80,8 +80,11 @@ samsung,dw-mshc-ciu-div = 3; samsung,dw-mshc-sdr-timing = 0 4; samsung,dw-mshc-ddr-timing = 0 2; + samsung,dw-mshc-hs400-timing = 0 2; + samsung,read-strobe-delay = 90; pinctrl-names = default; - pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8; + pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8 +sd0_rclk; bus-width = 8; cap-mmc-highspeed; }; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index c833bac..412f41d 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -654,15 +654,18 @@ num-slots = 1; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = 200; - clock-frequency = 4; + clock-frequency = 8; samsung,dw-mshc-ciu-div = 3; samsung,dw-mshc-sdr-timing = 0 4; samsung,dw-mshc-ddr-timing = 0 2; + samsung,dw-mshc-hs400-timing = 0 2; + samsung,read-strobe-delay = 90; pinctrl-names = default; - pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8; + pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8 sd0_rclk; bus-width = 8; }; -- 1.9.1 -- Regards, Alim -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] ARM: exynos_defconfig: Enable HDMI support
Javier Martinez Canilla wrote: Hello Kukjin, Hi, On Tue, Mar 17, 2015 at 7:54 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Fri, Feb 6, 2015 at 6:42 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Many Exynos boards have an HDMI port so enable Exynos DRM HDMI support. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Exynos DRM HDMI has some issues that were fixed by Andrzej's [0] series. So now is safe to HDMI support for Exynos boards. [0]: https://lkml.org/lkml/2015/2/5/265 arch/arm/configs/exynos_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 70e5d0bdb4e4..e44da52e5223 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -120,6 +120,7 @@ CONFIG_REGULATOR_S2MPS11=y CONFIG_REGULATOR_S5M8767=y CONFIG_REGULATOR_TPS65090=y CONFIG_DRM=y +CONFIG_DRM_EXYNOS_HDMI=y CONFIG_DRM_BRIDGE=y CONFIG_DRM_PTN3460=y CONFIG_DRM_PS8622=y -- It seems you missed this patch when picking the exynos_defconfig patches. Another gentle reminder about this patch. Thanks, will apply tonight ;-) - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
Allow driver build for !THERMAL or !CPU_THERMAL cases. The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()). Cc: Kukjin Kim kg...@kernel.org Cc: Arnd Bergmann a...@arndb.de Cc: Eduardo Valentin edubez...@gmail.com Cc: Lukasz Majewski l.majew...@samsung.com Fixes: 8b2b4a4e5366 (cpufreq: exynos: allow modular build) Acked-by: Viresh Kumar viresh.ku...@linaro.org Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- Hi Rafael, please apply this patch. It has been ACKed by Viresh already. drivers/cpufreq/Kconfig.arm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 1b06fc4..f4df4af3 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ config ARM_EXYNOS_CPUFREQ tristate SAMSUNG EXYNOS CPUfreq Driver depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250 - depends on THERMAL + # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y: + depends on !CPU_THERMAL || THERMAL help This adds the CPUFreq driver for Samsung EXYNOS platforms. Supported SoC versions are: -- 1.8.2.3 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7 0/9] arm64: Add the support for new Exynos5433 SoC
Dear Kukjin, On 03/24/2015 05:09 PM, Kukjin Kim wrote: Chanwoo Choi wrote: Dear Kukjin, Hi, Could you please pick or review this patch-set? Sorry for late response and honestly I was looking at the review in ml ;-) Anyway I have no objection on this series except using ARCH_EXYNOS for clock stuff in other series for exynos5433 but I agree we don't have other solution at this moment. I'll queue this series. Thanks for your apply. Best Regards, Chanwoo Choi Thanks, Kukjin Best Regards, Chanwoo Choi On Wed, Mar 18, 2015 at 9:17 AM, Chanwoo Choi cw00.c...@samsung.com wrote: This patchset adds new 64-bit Exynos5433 Samsung SoC which contains quad Cortex-A57 and quad Cortex-A53. It is desigend with the 20nm low power process. Depends on: - This patch-set has the dependency on Exynos5433 clock driver[1] and pinctrl driver[2]. The Exynos5433 clock controller patch-set[1] was merged by Michael Turquette. and Exynos5433's pinctrl patch[2] was merged by Linus Walleij. Exynos5433's TMU patch[3] will be refactoring without feature update. [1] http://git.linaro.org/people/mike.turquette/linux.git/commit/cc91909b9683c834485fd0627708c81d9398bf02 [2] https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=for- nextid=3c5ecc9ed3537846fd95e8f288d6d6968075879f [3] [PATCH 0/3] thermal: exynos: Add support for Exynos5433 TMU - https://lkml.org/lkml/2015/2/26/234 Changelog: Changes fromv v6: (https://lkml.org/lkml/2015/3/9/1036) - Fix wrong base address of CMU_MSCL dt node (0x105d - 0x150d) - Adjust the length of memory mapped region for all clock domains Changes from v5: (https://lkml.org/lkml/2015/3/5/27) - Move 'timer' dt node under root node by Mark Rutland's comment Changes from v4: (https://lkml.org/lkml/2015/2/24/2) - Rebased it on Linux 4.0-rc2 - Remove CONFIG_ARCH_EXYNOS5433 configuration by Arnd Bergmann's comment - Move 'aliases' dt node from SoC dtsi to board dts file by Arnd Bergmann's comment - Add Exynos5433 TMU patches which got the Lukasz Majewski's reviewed message Changes from v3: (https://lkml.org/lkml/2015/2/12/65) - Rebased it on Linux 4.0-rc1. - Remove ARM_GIC and ARM_AMBA dependency because CONFIG_ARM64 already included them. Changes from v2: (https://lkml.org/lkml/2014/12/2/134) : Fix the range of GICC memory map (0x1000 - 0x2000) : Fix address space of 'range' property under 'soc' node : Add ADMA / I2S dt node for sound playback/capture - Select ARM_AMBA/ARM_GIC/HAVE_S3C_RTC for Exynos5433 in arch/arm64/Kconfig - Send separate patch-set for Exynos5433 clock controller[1][2] and pinctrl[3] Changes from v1: (https://lkml.org/lkml/2014/11/27/92) - Merge two patches (patch2, patch3) to solve incomplete description - Exynos5433 Clock driver : Fix wrong register and code clean by using space instead of tab : Add CLK_IGNORE_UNUSED flag to pclk_sysreg_* clock for accessing system control register : Remove duplicate definition on the patch for CMU_BUS{0|1|2} domain - Exynos5433 SoC DTS : Remove un-supported properties of arch_timer : Remove 'clock-frequency' property from 'cpus' dt node : Fix interrupt type from edge rising triggering to level high triggering because Cortex-A53/A57 use level triggering. : Fix defult address-size/size-celss from 1 to 2 because Exynos5433 is 64-bit SoC : Modify 'fin_pll' dt node to remove un-needed and ugly code : Move 'chipid' dt node under 'soc' : Use lowercase on all case in exynos5433.dtsi : Add PSCI dt node for secondary cpu boot : Add 'samsung,exynos5433' compatible to MCT dt node - Divide pinctrl patch from this patchset - Add new following patches: : clocksource: exynos_mct: Add the support for Exynos 64bit SoC : arm64: Enable Exynos5433 SoC in the defconfig - Chanwoo Choi (6): arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC arm64: dts: exynos: Add SPI/PDMA dt node for Exynos5433 arm64: dts: exynos: Add PMU dt node for Exynos5433 arm64: dts: exynos: Add RTC and ADC dt node for Exynos5433 SoC arm64: dts: exynos: Add TMU sensor dt node for Exynos5433 SoC arm64: dts: exynos: Add thermal-zones dt node for Exynos5433 SoC Inha Song (2): arm64: dts: exynos: Add ADMA dt node for Exynos5433 SoC arm64: dts: exynos: Add I2S dt node for Exynos5433 SoC Jaehoon Chung (1): arm64: dts: exynos: Add MSHC dt node for Exynos5433 .../devicetree/bindings/arm/samsung/pmu.txt| 1 + arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 698 +++ .../dts/exynos/exynos5433-tmu-sensor-conf.dtsi | 22 + arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi | 231 + arch/arm64/boot/dts/exynos/exynos5433.dtsi | 931 + 5 files changed, 1883 insertions(+) create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi create mode 100644
Re: [PATCH] cpufreq: exynos: allow build for !THERMAL or !CPU_THERMAL cases
On Fri, Feb 20, 2015 at 05:20:22PM +0100, Bartlomiej Zolnierkiewicz wrote: Allow driver build for !THERMAL or !CPU_THERMAL cases. The new dependency rule is the same as the one that CPUFREQ_DT option has (for cpufreq-dt driver which has the same issue with using of_cpufreq_cooling_register()). Cc: Kukjin Kim kg...@kernel.org Cc: Arnd Bergmann a...@arndb.de Cc: Eduardo Valentin edubez...@gmail.com Cc: Lukasz Majewski l.majew...@samsung.com Fixes: 8b2b4a4e5366 (cpufreq: exynos: allow modular build) Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- drivers/cpufreq/Kconfig.arm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 1b06fc4..f4df4af3 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -28,7 +28,8 @@ config ARM_VEXPRESS_SPC_CPUFREQ config ARM_EXYNOS_CPUFREQ tristate SAMSUNG EXYNOS CPUfreq Driver depends on CPU_EXYNOS4210 || SOC_EXYNOS4212 || SOC_EXYNOS4412 || SOC_EXYNOS5250 - depends on THERMAL + # if CPU_THERMAL is on and THERMAL=m, ARM_EXYNOS_CPUFREQ cannot be =y: + depends on !CPU_THERMAL || THERMAL help This adds the CPUFreq driver for Samsung EXYNOS platforms. Supported SoC versions are: -- 1.8.2.3 signature.asc Description: Digital signature
RE: [PATCH v7] ARM: dts: Add HS400 support for exynos5420 and exynos5800
Alim Akhtar wrote: Gentle Ping !! Thanks ;-) On Wed, Mar 18, 2015 at 4:50 PM, Alim Akhtar alim.akh...@samsung.com wrote: From: Seungwon Jeon tgih@samsung.com HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards. This also adds RCLK GPIO line, this gpio should be in pull-down state. This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Alim Akhtar alim.akh...@samsung.com [Alim: addressed review comments] Acked-by: Jaehoon Chung jh80.ch...@samsung.com --- Changes in V7: Add back bus1 pin, which was removed during rebase in v6 as rightly pointed out by Javier[1]. Changes in V6: Rebased on kukjin's for-next branch[0] (commit: 77105c8 Merge branch 'v4.0-samsung-fixes-2' into for-next) [0]: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git [1]: http://www.spinics.net/lists/arm-kernel/msg406618.html arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 5 - arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +-- 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 3f4e2fe..0788d08 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -699,8 +699,10 @@ samsung,dw-mshc-ciu-div = 3; samsung,dw-mshc-sdr-timing = 0 4; samsung,dw-mshc-ddr-timing = 0 2; + samsung,dw-mshc-hs400-timing = 0 2; + samsung,read-strobe-delay = 90; pinctrl-names = default; - pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8; + pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8 sd0_rclk; bus-width = 8; }; diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index ba686e4..8b15316 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi @@ -201,6 +201,13 @@ samsung,pin-drv = 3; }; + sd0_rclk: sd0-rclk { + samsung,pins = gpc0-7; + samsung,pin-function = 2; + samsung,pin-pud = 1; + samsung,pin-drv = 3; + }; + sd1_cmd: sd1-cmd { samsung,pins = gpc1-1; samsung,pin-function = 2; diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 7a56852..9103f23 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts @@ -80,8 +80,11 @@ samsung,dw-mshc-ciu-div = 3; samsung,dw-mshc-sdr-timing = 0 4; samsung,dw-mshc-ddr-timing = 0 2; + samsung,dw-mshc-hs400-timing = 0 2; + samsung,read-strobe-delay = 90; pinctrl-names = default; - pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8; + pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8 +sd0_rclk; bus-width = 8; cap-mmc-highspeed; }; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index c833bac..412f41d 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -654,15 +654,18 @@ num-slots = 1; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = 200; - clock-frequency = 4; + clock-frequency = 8; samsung,dw-mshc-ciu-div = 3; samsung,dw-mshc-sdr-timing = 0 4; samsung,dw-mshc-ddr-timing = 0 2; + samsung,dw-mshc-hs400-timing = 0 2; + samsung,read-strobe-delay = 90; pinctrl-names = default; - pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8; + pinctrl-0 = sd0_clk sd0_cmd sd0_bus1 sd0_bus4 sd0_bus8 sd0_rclk; bus-width = 8; }; -- Applied. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ARM: exynos_defconfig: Enable HDMI support
Hello Kukjin, On Tue, Mar 17, 2015 at 7:54 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Fri, Feb 6, 2015 at 6:42 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Many Exynos boards have an HDMI port so enable Exynos DRM HDMI support. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Exynos DRM HDMI has some issues that were fixed by Andrzej's [0] series. So now is safe to HDMI support for Exynos boards. [0]: https://lkml.org/lkml/2015/2/5/265 arch/arm/configs/exynos_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 70e5d0bdb4e4..e44da52e5223 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -120,6 +120,7 @@ CONFIG_REGULATOR_S2MPS11=y CONFIG_REGULATOR_S5M8767=y CONFIG_REGULATOR_TPS65090=y CONFIG_DRM=y +CONFIG_DRM_EXYNOS_HDMI=y CONFIG_DRM_BRIDGE=y CONFIG_DRM_PTN3460=y CONFIG_DRM_PS8622=y -- It seems you missed this patch when picking the exynos_defconfig patches. Another gentle reminder about this patch. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer
Hello Inki, On Tue, Mar 17, 2015 at 2:24 PM, Daniel Stone dani...@collabora.com wrote: When performing a modeset, use the framebuffer pitch value to set FIMD IMG_SIZE and Mixer SPAN registers. These are both defined as pitch - the distance between contiguous lines (bytes for FIMD, pixels for mixer). Fixes display on Snow (1366x768). Signed-off-by: Daniel Stone dani...@collabora.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Any comments on this patch? It would be great to pick this sooner rather than later since it fixes (at least) display output on Snow and HDMI output on Peach Pit/Pi. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] exynos: pmu: use PS_HOLD based poweroff for all supported SoCs
Marek Szyprowski wrote: Hello, Hi, On 2015-02-09 11:58, Krzysztof Kozlowski wrote: 2015-02-09 10:06 GMT+01:00 Krzysztof Kozlowski k.kozlow...@samsung.com: 2015-02-09 8:25 GMT+01:00 Marek Szyprowski m.szyprow...@samsung.com: PS_HOLD based power off procedure is common for all Exynos SoCs, so use it for every Exynos SoC. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- arch/arm/mach-exynos/pmu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) I tried this on Trats2 board (Exynos 4412) and message Power down failed, please power off system manually. appears. Is it expected? Or am I missing some patches (I applied this on top of next-20150129)? It was my fault (I left attached JIG cable which prevents power off). Now it works fine. Tested on Trats2 (Exynos4412): Tested-by: Krzysztof Kozlowski k.kozlow...@samsung.com Patch also looks good, so: Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Gentle ping for merging this in v4.1-next... OK, I'll queue this into v4.1-next/mach-samsung. Just note, some newer SoC has different poweroff scheme not just using PS_HOLD based so maybe we need to revisit the poweroff later ;-) Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7 0/9] arm64: Add the support for new Exynos5433 SoC
Chanwoo Choi wrote: Dear Kukjin, Hi, Could you please pick or review this patch-set? Sorry for late response and honestly I was looking at the review in ml ;-) Anyway I have no objection on this series except using ARCH_EXYNOS for clock stuff in other series for exynos5433 but I agree we don't have other solution at this moment. I'll queue this series. Thanks, Kukjin Best Regards, Chanwoo Choi On Wed, Mar 18, 2015 at 9:17 AM, Chanwoo Choi cw00.c...@samsung.com wrote: This patchset adds new 64-bit Exynos5433 Samsung SoC which contains quad Cortex-A57 and quad Cortex-A53. It is desigend with the 20nm low power process. Depends on: - This patch-set has the dependency on Exynos5433 clock driver[1] and pinctrl driver[2]. The Exynos5433 clock controller patch-set[1] was merged by Michael Turquette. and Exynos5433's pinctrl patch[2] was merged by Linus Walleij. Exynos5433's TMU patch[3] will be refactoring without feature update. [1] http://git.linaro.org/people/mike.turquette/linux.git/commit/cc91909b9683c834485fd0627708c81d9398bf02 [2] https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=for- nextid=3c5ecc9ed3537846fd95e8f288d6d6968075879f [3] [PATCH 0/3] thermal: exynos: Add support for Exynos5433 TMU - https://lkml.org/lkml/2015/2/26/234 Changelog: Changes fromv v6: (https://lkml.org/lkml/2015/3/9/1036) - Fix wrong base address of CMU_MSCL dt node (0x105d - 0x150d) - Adjust the length of memory mapped region for all clock domains Changes from v5: (https://lkml.org/lkml/2015/3/5/27) - Move 'timer' dt node under root node by Mark Rutland's comment Changes from v4: (https://lkml.org/lkml/2015/2/24/2) - Rebased it on Linux 4.0-rc2 - Remove CONFIG_ARCH_EXYNOS5433 configuration by Arnd Bergmann's comment - Move 'aliases' dt node from SoC dtsi to board dts file by Arnd Bergmann's comment - Add Exynos5433 TMU patches which got the Lukasz Majewski's reviewed message Changes from v3: (https://lkml.org/lkml/2015/2/12/65) - Rebased it on Linux 4.0-rc1. - Remove ARM_GIC and ARM_AMBA dependency because CONFIG_ARM64 already included them. Changes from v2: (https://lkml.org/lkml/2014/12/2/134) : Fix the range of GICC memory map (0x1000 - 0x2000) : Fix address space of 'range' property under 'soc' node : Add ADMA / I2S dt node for sound playback/capture - Select ARM_AMBA/ARM_GIC/HAVE_S3C_RTC for Exynos5433 in arch/arm64/Kconfig - Send separate patch-set for Exynos5433 clock controller[1][2] and pinctrl[3] Changes from v1: (https://lkml.org/lkml/2014/11/27/92) - Merge two patches (patch2, patch3) to solve incomplete description - Exynos5433 Clock driver : Fix wrong register and code clean by using space instead of tab : Add CLK_IGNORE_UNUSED flag to pclk_sysreg_* clock for accessing system control register : Remove duplicate definition on the patch for CMU_BUS{0|1|2} domain - Exynos5433 SoC DTS : Remove un-supported properties of arch_timer : Remove 'clock-frequency' property from 'cpus' dt node : Fix interrupt type from edge rising triggering to level high triggering because Cortex-A53/A57 use level triggering. : Fix defult address-size/size-celss from 1 to 2 because Exynos5433 is 64-bit SoC : Modify 'fin_pll' dt node to remove un-needed and ugly code : Move 'chipid' dt node under 'soc' : Use lowercase on all case in exynos5433.dtsi : Add PSCI dt node for secondary cpu boot : Add 'samsung,exynos5433' compatible to MCT dt node - Divide pinctrl patch from this patchset - Add new following patches: : clocksource: exynos_mct: Add the support for Exynos 64bit SoC : arm64: Enable Exynos5433 SoC in the defconfig - Chanwoo Choi (6): arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC arm64: dts: exynos: Add SPI/PDMA dt node for Exynos5433 arm64: dts: exynos: Add PMU dt node for Exynos5433 arm64: dts: exynos: Add RTC and ADC dt node for Exynos5433 SoC arm64: dts: exynos: Add TMU sensor dt node for Exynos5433 SoC arm64: dts: exynos: Add thermal-zones dt node for Exynos5433 SoC Inha Song (2): arm64: dts: exynos: Add ADMA dt node for Exynos5433 SoC arm64: dts: exynos: Add I2S dt node for Exynos5433 SoC Jaehoon Chung (1): arm64: dts: exynos: Add MSHC dt node for Exynos5433 .../devicetree/bindings/arm/samsung/pmu.txt| 1 + arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi | 698 +++ .../dts/exynos/exynos5433-tmu-sensor-conf.dtsi | 22 + arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi | 231 + arch/arm64/boot/dts/exynos/exynos5433.dtsi | 931 + 5 files changed, 1883 insertions(+) create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-pinctrl.dtsi create mode 100644