Re: [PATCH 2/2] ARM: multi_v7_defconfig: Enable display on Trats2board
On Saturday 23 May 2015 11:18:58 Kukjin Kim wrote: On 05/22/15 18:11, Javier Martinez Canillas wrote: Hello Krzysztof, On 05/22/2015 02:48 AM, Krzysztof Kozlowski wrote: Enable the Exynos DSI and S6E8AA0 panel for full X11 display on Trats2. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 0848337a2a01..e9785020aab1 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -413,10 +413,12 @@ CONFIG_DRM=y CONFIG_DRM_PTN3460=m CONFIG_DRM_PS8622=m CONFIG_DRM_EXYNOS=m +CONFIG_DRM_EXYNOS_DSI=y CONFIG_DRM_EXYNOS_FIMD=y CONFIG_DRM_EXYNOS_HDMI=y CONFIG_DRM_RCAR_DU=m CONFIG_DRM_TEGRA=y +CONFIG_DRM_PANEL_S6E8AA0=m CONFIG_DRM_PANEL_SIMPLE=y CONFIG_FB_ARMCLCD=y CONFIG_FB_WM8505=y Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Looks good to me and this would be handled by arm-soc guys directly Acked-by: Kukjin Kim kg...@kernel.org I'd actually prefer if you could put this into the same branch as your other defconfig changes. We'll handle any conflicts when merging that in. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ARM: exynos_defconfig: savedefconfig
2015-05-23 12:34 GMT+09:00 Kukjin Kim kg...@kernel.org: This patch does 'savedefconfig' for exynos_defconfig to remove useless configs and check its dependencies. Sometimes some configs could be ignored because of the dependencies even they are enabled in defconfig file manually. So checking the dependencies would be better. Signed-off-by: Kukjin Kim kg...@kernel.org Generated autoconf.h is almost the same as previously, so: Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Best regards, Krzysztof -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base
On 21 May 2015 at 05:33, Krzysztof Kozlowski k.kozlow...@samsung.com wrote:
On 20.05.2015 23:59, Anand Moon wrote:
On 20 May 2015 at 08:57, Dongjin Kim tobet...@gmail.com wrote:
Hello Kryzsztof,
Are you able to check if TMU is under VDDI power domain from Exynos5422
datasheet?
If it is, XU3 use BUCK3 for TMU and more internal blocks.
Thank you,
Dongjin.
On Tue, May 19, 2015 at 4:42 PM, Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
2015-05-19 16:28 GMT+09:00 Anand Moon linux.am...@gmail.com:
On 15 May 2015 at 05:42, Krzysztof Kozlowski k.kozlow...@samsung.com
wrote:
2015-05-15 1:16 GMT+09:00 Anand Moon linux.am...@gmail.com:
On 13 May 2015 at 14:02, Krzysztof Kozlowski k.kozlow...@samsung.com
wrote:
2015-05-13 17:21 GMT+09:00 Anand Moon linux.am...@gmail.com:
On 13 May 2015 at 12:51, Krzysztof Kozlowski
k.kozlow...@samsung.com wrote:
2015-05-13 15:36 GMT+09:00 Anand Moon linux.am...@gmail.com:
This changes enables TMU IP block on the Exynos5422 Odroid-XU3
device.
Tested-by: Markus Reichl m.rei...@fivetechno.de
Acked-by: Lukasz Majewski l.majew...@samsung.com
Signed-off-by: Anand Moon linux.am...@gmail.com
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25
+
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 9446e28..cd78816 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -319,6 +319,31 @@
#cooling-cells = 2;
cooling-levels = 0 130 170 230;
};
+
+ tmu@1006 {
Here and for other overrides please use label notation, like:
tmu_cpu0 {
...
};
+ vtmu-supply = ldo10_reg;
I am curious, how did you find that LDO10 supplies TMU unit?
Best regards,
Krzysztof
Hi Krzysztof,
I have re-base my work on earlier Lukasz Majewski patches.
https://patchwork.kernel.org/patch/5693201/
NAK.
I am sorry, but this is not sufficient explanation. Actually such
explanation could mean that you did just blindly copied everything
instead of developing it.
You cannot use some regulator here just because some Exynos4 boards
use it. You have to be sure that this regulator supplies this part of
SoC or device.
Hi Krzysztof,
After going through the schematics, I came to understanding that their
is
missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
Below is the schematic of the board.
http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
ldo18_reg: LDO18 {
regulator-name = vdd_ldo18;
regulator-min-microvolt =
180;
regulator-max-microvolt =
180;
regulator-always-on;
};
The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for
TMU.
I think the schematics are missing some of details but it can be
deducted that:
1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to theL DO7 of
S2MPS11 PMIC.
3. I confirmed with the Exynos5422 datasheet that these
VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
So the LDO7 it is... but before using it there is a caveat. The LDO7
is also connected to VDD of MIPI, HDMI and few more. So when you use
this regulator in TMU it may be turned off by TMU driver (e.g. during
unbind). In such case these other blocks also should be tested and
checked whether they take this regulator and enable it.
hi Krzysztof,
I tried to use the LDO7 regulator for TMU but it failed to register.
[3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 1 uOhm)
[3.237691] thermal thermal_zone0: failed to read out thermal zone
(-22)
[3.243033] exynos-tmu 1006.tmu: Looking up vtmu-supply from
device tree
[3.243936] thermal thermal_zone1: failed to read out thermal zone
(-22)
[3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from
device tree
[3.250677] thermal thermal_zone2: failed to read out thermal zone
(-22)
[3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from
device tree
[3.257345] thermal thermal_zone3: failed to read out thermal zone
(-22)
[3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from
device tree
[3.263984] thermal thermal_zone4: failed to read out thermal zone
(-22)
[3.269769] exynos-tmu 100a.tmu: Looking up vtmu-supply from
device tree
[3.270363] usb 5-1: New USB device found, idVendor=0424,
idProduct=9514
[3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0,
SerialNumber=0
Indeed.
Hi Krzysztof/Dongjin
BUCK3 is option for TMU as suggested by Dongjin
What do you mean
Re: [PATCH v7 03/25] iommu: Init iommu-groups support earlier, in core_initcall
Hi Marek, Thank you for the patch. On Tuesday 19 May 2015 15:20:23 Marek Szyprowski wrote: iommu_group_alloc might be called very early in case of iommu controllers activated from of_iommu, so ensure that this part of subsystem is ready when devices are being populated from device-tree (core_initcall seems to be okay for this case). Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/iommu/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c index d4f527e56679..37a6aa8f318b 100644 --- a/drivers/iommu/iommu.c +++ b/drivers/iommu/iommu.c @@ -1207,7 +1207,7 @@ static int __init iommu_init(void) return 0; } -arch_initcall(iommu_init); +core_initcall(iommu_init); I'll let Joerg comment on this, but this initcall ordering dance always makes me feel that something isn't quite right. Have you had a chance to look at the patch series I posted about a week ago to implement IOMMU probe deferral support ? int iommu_domain_get_attr(struct iommu_domain *domain, enum iommu_attr attr, void *data) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base
On 24 May 2015 at 10:03, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: 2015-05-24 2:35 GMT+09:00 Anand Moon linux.am...@gmail.com: Hi Krzysztof, I did some debugging on the this using powerdebug utility. Using LDO7 to control TMU seams to me correct option compared to BUCK3. Setting LDO7 to control TMU I observed following output on powerdebug. I observed that the power drawn by the board on Odroid show is much less compare to BUCK3 on the same setup. I can see the HDMI output on Odroid-V2 display screen. I have done some stress testing on this configuration and It worked correctly. Powerdebug output using LDO7 --- PowerDebug 0.7.3 Clocks Regulators Sensors Gpio NameStatus State TypeUsers Microvolts Min u-volts Max u-volts phy 0 0 0 0 phy 0 0 0 0 vdd_ldo1enabled voltage 0 100 100 100 LDO10 0 0 0 LDO2enabled voltage 0 180 0 0 vdd_ldo3enabled voltage 0 180 180 180 LDO30 0 0 0 LDO4enabled voltage 0 180 0 0 vdd_ldo5enabled voltage 0 180 180 180 LDO50 0 0 0 vdd_ldo6enabled voltage 0 100 100 100 hdmiokay0 0 0 0 hdmiokay0 0 0 0 LDO60 0 0 0 vdd_ldo7enabled voltage 0 180 180 180 hdmiokay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 LDO70 0 0 0 vdd_ldo8enabled voltage 0 180 180 180 LDO80 0 0 0 vdd_ldo9enabled voltage 0 300 300 300 LDO90 0 0 0 Powerdebug output using BUCK3. -- PowerDebug 0.7.3 Clocks Regulators Sensors Gpio NameStatus State TypeUsers Microvolts Min u-volts Max u-volts LDO21 disabledvoltage 0 180 0 0 LDO22 disabledvoltage 0 120 0 0 LDO23 enabled voltage 0 110 0 0 tsp_io enabled voltage 0 280 280 280 LDO24 0 0 0 0 LDO25 disabledvoltage 0 180 0 0 vdd_ldo26 enabled voltage 0 300 300 300 LDO26 0 0 0 0 LDO27 enabled voltage 0 100 0 0 LDO28 disabledvoltage 0 330 0 0 LDO29 disabledvoltage 0 180 0 0 LDO30 disabledvoltage 0 180 0 0 LDO31 disabledvoltage 0 180 0 0 LDO32 disabledvoltage 0 180 0 0 LDO33 disabledvoltage 0 180 0 0 LDO34 disabledvoltage 0 300 0 0 LDO35 disabledvoltage 0 160 0 0 LDO36 disabledvoltage 0 180 0 0 LDO37 disabledvoltage 0 180 0 0 LDO38
Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base
2015-05-24 2:35 GMT+09:00 Anand Moon linux.am...@gmail.com: Hi Krzysztof, I did some debugging on the this using powerdebug utility. Using LDO7 to control TMU seams to me correct option compared to BUCK3. Setting LDO7 to control TMU I observed following output on powerdebug. I observed that the power drawn by the board on Odroid show is much less compare to BUCK3 on the same setup. I can see the HDMI output on Odroid-V2 display screen. I have done some stress testing on this configuration and It worked correctly. Powerdebug output using LDO7 --- PowerDebug 0.7.3 Clocks Regulators Sensors Gpio NameStatus State TypeUsers Microvolts Min u-volts Max u-volts phy 0 0 0 0 phy 0 0 0 0 vdd_ldo1enabled voltage 0 100 100 100 LDO10 0 0 0 LDO2enabled voltage 0 180 0 0 vdd_ldo3enabled voltage 0 180 180 180 LDO30 0 0 0 LDO4enabled voltage 0 180 0 0 vdd_ldo5enabled voltage 0 180 180 180 LDO50 0 0 0 vdd_ldo6enabled voltage 0 100 100 100 hdmiokay0 0 0 0 hdmiokay0 0 0 0 LDO60 0 0 0 vdd_ldo7enabled voltage 0 180 180 180 hdmiokay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 tmu okay0 0 0 0 LDO70 0 0 0 vdd_ldo8enabled voltage 0 180 180 180 LDO80 0 0 0 vdd_ldo9enabled voltage 0 300 300 300 LDO90 0 0 0 Powerdebug output using BUCK3. -- PowerDebug 0.7.3 Clocks Regulators Sensors Gpio NameStatus State TypeUsers Microvolts Min u-volts Max u-volts LDO21 disabledvoltage 0 180 0 0 LDO22 disabledvoltage 0 120 0 0 LDO23 enabled voltage 0 110 0 0 tsp_io enabled voltage 0 280 280 280 LDO24 0 0 0 0 LDO25 disabledvoltage 0 180 0 0 vdd_ldo26 enabled voltage 0 300 300 300 LDO26 0 0 0 0 LDO27 enabled voltage 0 100 0 0 LDO28 disabledvoltage 0 330 0 0 LDO29 disabledvoltage 0 180 0 0 LDO30 disabledvoltage 0 180 0 0 LDO31 disabledvoltage 0 180 0 0 LDO32 disabledvoltage 0 180 0 0 LDO33 disabledvoltage 0 180 0 0 LDO34 disabledvoltage 0 300 0 0 LDO35 disabledvoltage 0 160 0 0 LDO36 disabledvoltage 0 180 0 0 LDO37 disabledvoltage 0 180 0 0 LDO38 disabledvoltage 0 280 0 0 vdd_mif
