Re: [PATCH v3 5/5] cpufreq: remove no longer needed CPU_FREQ_BOOST_SW config option
On 31-07-15, 20:49, Bartlomiej Zolnierkiewicz wrote:
Remove no longer needed CPU_FREQ_BOOST_SW config option.
As a result scaling_boost_freqs sysfs attribute is available
when cpufreq-dt driver is used and boost support is enabled.
Cc: Viresh Kumar viresh.ku...@linaro.org
Cc: Thomas Abraham thomas...@samsung.com
Cc: Javier Martinez Canillas jav...@osg.samsung.com
Cc: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
---
drivers/cpufreq/Kconfig | 4
drivers/cpufreq/freq_table.c | 2 --
2 files changed, 6 deletions(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index bf6d596..de00a52 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -21,10 +21,6 @@ if CPU_FREQ
config CPU_FREQ_GOV_COMMON
bool
-config CPU_FREQ_BOOST_SW
- bool
- depends on THERMAL
-
config CPU_FREQ_STAT
tristate CPU frequency translation statistics
default y
diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
index a8f1daf..4c5de5b 100644
--- a/drivers/cpufreq/freq_table.c
+++ b/drivers/cpufreq/freq_table.c
@@ -293,9 +293,7 @@ EXPORT_SYMBOL_GPL(cpufreq_freq_attr_scaling_boost_freqs);
struct freq_attr *cpufreq_generic_attr[] = {
cpufreq_freq_attr_scaling_available_freqs,
-#ifdef CONFIG_CPU_FREQ_BOOST_SW
cpufreq_freq_attr_scaling_boost_freqs,
-#endif
NULL,
};
EXPORT_SYMBOL_GPL(cpufreq_generic_attr);
So, this will start appearing for all platforms that use cpufreq_generic_attr
and that may not be the right thing. We may only want to show boost frequencies
only if the driver supports it.
@Rafael: What do you say?
--
viresh
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 3/5] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12
On 31-07-15, 20:49, Bartlomiej Zolnierkiewicz wrote: diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index 659879a..bf6d596 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -191,6 +191,7 @@ config CPUFREQ_DT # if CPU_THERMAL is on and THERMAL=m, CPUFREQ_DT cannot be =y: depends on !CPU_THERMAL || THERMAL select PM_OPP + select EXYNOS_THERMAL if ARCH_EXYNOS help This adds a generic DT based cpufreq driver for frequency management. It supports both uniprocessor (UP) and symmetric multiprocessor (SMP) No, we shouldn't pollute generic Kconfig options with platform specific stuff. Why don't you enable thermal in your .config? -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 2/5] ARM: dts: Exynos4x12: add CPU OPP and regulator supply property
On 31-07-15, 20:49, Bartlomiej Zolnierkiewicz wrote:
For Exynos4x12 platforms, add CPU operating points (using
opp-v2 bindings) and CPU regulator supply properties for
migrating from Exynos specific cpufreq driver to using
generic cpufreq driver.
Based on the earlier work by Thomas Abraham.
Cc: Kukjin Kim kgene@samsung.com
Cc: Doug Anderson diand...@chromium.org
Cc: Andreas Faerber afaer...@suse.de
Cc: Thomas Abraham thomas...@samsung.com
Reviewed-by: Javier Martinez Canillas jav...@osg.samsung.com
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
---
arch/arm/boot/dts/exynos4212.dtsi | 81
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 ++
arch/arm/boot/dts/exynos4412-origen.dts | 4 ++
arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++
arch/arm/boot/dts/exynos4412.dtsi | 83
+
5 files changed, 176 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4212.dtsi
b/arch/arm/boot/dts/exynos4212.dtsi
index d9c8efee..5389011 100644
--- a/arch/arm/boot/dts/exynos4212.dtsi
+++ b/arch/arm/boot/dts/exynos4212.dtsi
@@ -30,6 +30,9 @@
device_type = cpu;
compatible = arm,cortex-a9;
reg = 0xA00;
+ clocks = clock CLK_ARM_CLK;
+ clock-names = cpu;
+ operating-points-v2 = cpu0_opp_table;
cooling-min-level = 13;
cooling-max-level = 7;
#cooling-cells = 2; /* min followed by max */
@@ -39,6 +42,84 @@
device_type = cpu;
compatible = arm,cortex-a9;
reg = 0xA01;
+ operating-points-v2 = cpu0_opp_table;
+ };
+ };
+
+ cpu0_opp_table: opp_table0 {
+ compatible = operating-points-v2;
+ opp-shared;
+
+ opp00 {
+ opp-hz = /bits/ 64 2;
+ opp-microvolt = 90;
+ clock-latency-ns = 20;
+ };
+ opp01 {
+ opp-hz = /bits/ 64 3;
+ opp-microvolt = 90;
+ clock-latency-ns = 20;
+ };
+ opp02 {
+ opp-hz = /bits/ 64 4;
+ opp-microvolt = 925000;
+ clock-latency-ns = 20;
+ };
+ opp03 {
+ opp-hz = /bits/ 64 5;
+ opp-microvolt = 95;
+ clock-latency-ns = 20;
+ };
+ opp04 {
+ opp-hz = /bits/ 64 6;
+ opp-microvolt = 975000;
+ clock-latency-ns = 20;
+ };
+ opp05 {
+ opp-hz = /bits/ 64 7;
+ opp-microvolt = 987500;
+ clock-latency-ns = 20;
+ };
+ opp06 {
+ opp-hz = /bits/ 64 8;
+ opp-microvolt = 100;
+ clock-latency-ns = 20;
+ };
+ opp07 {
+ opp-hz = /bits/ 64 9;
+ opp-microvolt = 1037500;
+ clock-latency-ns = 20;
+ };
+ opp08 {
+ opp-hz = /bits/ 64 10;
+ opp-microvolt = 1087500;
+ clock-latency-ns = 20;
+ };
+ opp09 {
+ opp-hz = /bits/ 64 11;
+ opp-microvolt = 1137500;
+ clock-latency-ns = 20;
+ };
+ opp10 {
+ opp-hz = /bits/ 64 12;
+ opp-microvolt = 1187500;
+ clock-latency-ns = 20;
+ };
+ opp11 {
+ opp-hz = /bits/ 64 13;
+ opp-microvolt = 125;
+ clock-latency-ns = 20;
+ };
+ opp12 {
+ opp-hz = /bits/ 64 14;
+ opp-microvolt = 1287500;
+ clock-latency-ns = 20;
+ };
+ opp13 {
+ opp-hz = /bits/ 64 15;
+ opp-microvolt = 135;
+ clock-latency-ns = 20;
+ turbo-mode;
};
};
};
I'm lovin' it :)
Acked-by: Viresh Kumar viresh.ku...@linaro.org
--
viresh
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
Re: [PATCH v3 4/5] cpufreq: exynos: remove Exynos4x12 specific cpufreq driver support
Cc'ing Rafael, please keep him in loop for such patches and better use get_maintainers to get the cc list automatically. On 31-07-15, 20:49, Bartlomiej Zolnierkiewicz wrote: Exynos4x12 based platforms have switched over to use generic cpufreq driver for cpufreq functionality. So the Exynos specific cpufreq support for these platforms can be removed. Also once Exynos4x12 based platforms support have been removed the shared exynos-cpufreq driver is no longer needed and can be deleted. Based on the earlier work by Thomas Abraham. Cc: Viresh Kumar viresh.ku...@linaro.org Cc: Thomas Abraham thomas...@samsung.com Reviewed-by: Javier Martinez Canillas jav...@osg.samsung.com Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/cpufreq/Kconfig.arm | 38 -- drivers/cpufreq/Makefile | 2 - drivers/cpufreq/exynos-cpufreq.c | 236 --- drivers/cpufreq/exynos-cpufreq.h | 72 --- drivers/cpufreq/exynos4x12-cpufreq.c | 236 --- 5 files changed, 584 deletions(-) delete mode 100644 drivers/cpufreq/exynos-cpufreq.c delete mode 100644 drivers/cpufreq/exynos-cpufreq.h delete mode 100644 drivers/cpufreq/exynos4x12-cpufreq.c Acked-by: Viresh Kumar viresh.ku...@linaro.org -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] i2c: s3c2410: remove unused variable
@@ -565,7 +564,7 @@ static int i2c_s3c_irq_nextbyte(struct s3c24xx_i2c *i2c, unsigned long iicstat) tmp = ~S3C2410_IICCON_IRQPEND; writel(tmp, i2c-regs + S3C2410_IICCON); out: - return ret; + return; What about removing out: and return as well? signature.asc Description: Digital signature
Re: [PATCH v3 3/5] ARM: Exynos: switch to using generic cpufreq driver for Exynos4x12
W dniu 01.08.2015 o 03:49, Bartlomiej Zolnierkiewicz pisze:
The new CPU clock type allows the use of generic CPUfreq driver.
Switch Exynos4x12 to using generic cpufreq driver.
Also make CPUFREQ_DT config option select Exynos thermal driver
if Exynos platform support is enabled.
Why? I think this wasn't in your previous patch.
Best regards,
Krzysztof
Please also note that the switch to use the generic cpufreq-dt
driver fixes the minor issue present with the old code (support
for 'boost' mode in the exynos-cpufreq driver was enabled for
all supported SoCs even though 'boost' frequency was provided
only for Exynos4x12 ones).
Cc: Tomasz Figa tomasz.f...@gmail.com
Cc: Kukjin Kim kgene@samsung.com
Cc: Thomas Abraham thomas...@samsung.com
Cc: Javier Martinez Canillas jav...@osg.samsung.com
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
---
arch/arm/mach-exynos/exynos.c | 2 ++
drivers/cpufreq/Kconfig | 1 +
2 files changed, 3 insertions(+)
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 77ac021..1c47aee 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -227,6 +227,8 @@ static void __init exynos_init_irq(void)
static const struct of_device_id exynos_cpufreq_matches[] = {
{ .compatible = samsung,exynos3250, .data = cpufreq-dt },
{ .compatible = samsung,exynos4210, .data = cpufreq-dt },
+ { .compatible = samsung,exynos4212, .data = cpufreq-dt },
+ { .compatible = samsung,exynos4412, .data = cpufreq-dt },
{ .compatible = samsung,exynos5250, .data = cpufreq-dt },
{ /* sentinel */ }
};
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 659879a..bf6d596 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -191,6 +191,7 @@ config CPUFREQ_DT
# if CPU_THERMAL is on and THERMAL=m, CPUFREQ_DT cannot be =y:
depends on !CPU_THERMAL || THERMAL
select PM_OPP
+ select EXYNOS_THERMAL if ARCH_EXYNOS
help
This adds a generic DT based cpufreq driver for frequency management.
It supports both uniprocessor (UP) and symmetric multiprocessor (SMP)
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
