RE: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

2012-11-21 Thread Kukjin Kim
Olof Johansson wrote:
 
 On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
  From: Olof Johansson o...@lixom.net
 
  UART3 is used for debugging on exynos5250-snow.
 
  [dianders: cleaned commit message.]
 
  Signed-off-by: Olof Johansson o...@lixom.net
  Signed-off-by: Doug Anderson diand...@chromium.org
 
 
  ---
   arch/arm/Kconfig.debug|   11 +++
   arch/arm/plat-samsung/Kconfig |1 +
   2 files changed, 12 insertions(+), 0 deletions(-)
 
  diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
  index 33a8930..35ba7dc 100644
  --- a/arch/arm/Kconfig.debug
  +++ b/arch/arm/Kconfig.debug
  @@ -355,6 +355,17 @@ choice
The uncompressor code port configuration is now handled
by CONFIG_S3C_LOWLEVEL_UART_PORT.
 
  +   config DEBUG_S3C_UART3
  +   depends on PLAT_SAMSUNG
 
 
 Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
 to protect users of = 3 UART platforms to select it. An added Depends
 on ARCH_EXYNOS4 || ARCH_EXYNOS5 should cover that. Can you add and
 repost, please?
 
Yes, please :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

2012-11-21 Thread Doug Anderson
On Tue, Nov 20, 2012 at 11:29 PM, Olof Johansson o...@lixom.net wrote:

 On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
  From: Olof Johansson o...@lixom.net
 
  UART3 is used for debugging on exynos5250-snow.
 
  [dianders: cleaned commit message.]
 
  Signed-off-by: Olof Johansson o...@lixom.net
  Signed-off-by: Doug Anderson diand...@chromium.org

 
  ---
   arch/arm/Kconfig.debug|   11 +++
   arch/arm/plat-samsung/Kconfig |1 +
   2 files changed, 12 insertions(+), 0 deletions(-)
 
  diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
  index 33a8930..35ba7dc 100644
  --- a/arch/arm/Kconfig.debug
  +++ b/arch/arm/Kconfig.debug
  @@ -355,6 +355,17 @@ choice
  The uncompressor code port configuration is now handled
  by CONFIG_S3C_LOWLEVEL_UART_PORT.
 
  + config DEBUG_S3C_UART3
  + depends on PLAT_SAMSUNG


 Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
 to protect users of = 3 UART platforms to select it. An added Depends
 on ARCH_EXYNOS4 || ARCH_EXYNOS5 should cover that. Can you add and
 repost, please?

Doh!  I hadn't even noticed that you'd already posted this--I got mine
from the Chrome OS tree directly.  Sorry about that...

I've added an  for ARCH_EXYNOS which seems reasonable.  I left
PLAT_SAMSUNG as a depend though technically ARCH_EXYNOS does select
PLAT_SAMSUNG through a convoluted series of other config options.

-Doug
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

2012-11-20 Thread Doug Anderson
From: Olof Johansson o...@lixom.net

UART3 is used for debugging on exynos5250-snow.

[dianders: cleaned commit message.]

Signed-off-by: Olof Johansson o...@lixom.net
Signed-off-by: Doug Anderson diand...@chromium.org

---
 arch/arm/Kconfig.debug|   11 +++
 arch/arm/plat-samsung/Kconfig |1 +
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 33a8930..35ba7dc 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -355,6 +355,17 @@ choice
  The uncompressor code port configuration is now handled
  by CONFIG_S3C_LOWLEVEL_UART_PORT.
 
+   config DEBUG_S3C_UART3
+   depends on PLAT_SAMSUNG
+   bool Use S3C UART 3 for low-level debug
+   help
+ Say Y here if you want the debug print routines to direct
+ their output to UART 3. The port must have been initialised
+ by the boot-loader before use.
+
+ The uncompressor code port configuration is now handled
+ by CONFIG_S3C_LOWLEVEL_UART_PORT.
+
config DEBUG_SOCFPGA_UART
depends on ARCH_SOCFPGA
bool Use SOCFPGA UART for low-level debug
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index 59401e1..d342ed0 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -502,5 +502,6 @@ config DEBUG_S3C_UART
default 0 if DEBUG_S3C_UART0
default 1 if DEBUG_S3C_UART1
default 2 if DEBUG_S3C_UART2
+   default 3 if DEBUG_S3C_UART3
 
 endif
-- 
1.7.7.3

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

2012-11-20 Thread Olof Johansson
On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
 From: Olof Johansson o...@lixom.net
 
 UART3 is used for debugging on exynos5250-snow.
 
 [dianders: cleaned commit message.]
 
 Signed-off-by: Olof Johansson o...@lixom.net
 Signed-off-by: Doug Anderson diand...@chromium.org

 
 ---
  arch/arm/Kconfig.debug|   11 +++
  arch/arm/plat-samsung/Kconfig |1 +
  2 files changed, 12 insertions(+), 0 deletions(-)
 
 diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
 index 33a8930..35ba7dc 100644
 --- a/arch/arm/Kconfig.debug
 +++ b/arch/arm/Kconfig.debug
 @@ -355,6 +355,17 @@ choice
 The uncompressor code port configuration is now handled
 by CONFIG_S3C_LOWLEVEL_UART_PORT.
  
 + config DEBUG_S3C_UART3
 + depends on PLAT_SAMSUNG


Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
to protect users of = 3 UART platforms to select it. An added Depends
on ARCH_EXYNOS4 || ARCH_EXYNOS5 should cover that. Can you add and
repost, please?


-Olof
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

2012-06-19 Thread Kukjin Kim
Olof Johansson wrote:
 
 Add support for using UART3 for DEBUG_LL on exynos.
 
 Signed-off-by: Olof Johansson o...@lixom.net
 ---
  arch/arm/Kconfig.debug| 11 +++
  arch/arm/plat-samsung/Kconfig |  1 +
  2 files changed, 12 insertions(+)
 
 diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
 index 01a1341..da84061 100644
 --- a/arch/arm/Kconfig.debug
 +++ b/arch/arm/Kconfig.debug
 @@ -310,6 +310,17 @@ choice
 The uncompressor code port configuration is now handled
 by CONFIG_S3C_LOWLEVEL_UART_PORT.
 
 + config DEBUG_S3C_UART3
 + depends on PLAT_SAMSUNG
 + bool Use S3C UART 3 for low-level debug
 + help
 +   Say Y here if you want the debug print routines to direct
 +   their output to UART 3. The port must have been
initialised
 +   by the boot-loader before use.
 +
 +   The uncompressor code port configuration is now handled
 +   by CONFIG_S3C_LOWLEVEL_UART_PORT.
 +
   config DEBUG_LL_UART_NONE
   bool No low-level debugging UART
   help
 diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
 index a2fae4e..ed0b695 100644
 --- a/arch/arm/plat-samsung/Kconfig
 +++ b/arch/arm/plat-samsung/Kconfig
 @@ -505,5 +505,6 @@ config DEBUG_S3C_UART
   default 0 if DEBUG_S3C_UART0
   default 1 if DEBUG_S3C_UART1
   default 2 if DEBUG_S3C_UART2
 + default 3 if DEBUG_S3C_UART3
 
  endif
 --
 1.7.10.1.488.g05fbf7a

Basically, looks ok to me, but don't we need to protect this config for 3
UARTs' Samsung SoC?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

2012-06-03 Thread Olof Johansson
Add support for using UART3 for DEBUG_LL on exynos.

Signed-off-by: Olof Johansson o...@lixom.net
---
 arch/arm/Kconfig.debug| 11 +++
 arch/arm/plat-samsung/Kconfig |  1 +
 2 files changed, 12 insertions(+)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index 01a1341..da84061 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -310,6 +310,17 @@ choice
  The uncompressor code port configuration is now handled
  by CONFIG_S3C_LOWLEVEL_UART_PORT.
 
+   config DEBUG_S3C_UART3
+   depends on PLAT_SAMSUNG
+   bool Use S3C UART 3 for low-level debug
+   help
+ Say Y here if you want the debug print routines to direct
+ their output to UART 3. The port must have been initialised
+ by the boot-loader before use.
+
+ The uncompressor code port configuration is now handled
+ by CONFIG_S3C_LOWLEVEL_UART_PORT.
+
config DEBUG_LL_UART_NONE
bool No low-level debugging UART
help
diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index a2fae4e..ed0b695 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -505,5 +505,6 @@ config DEBUG_S3C_UART
default 0 if DEBUG_S3C_UART0
default 1 if DEBUG_S3C_UART1
default 2 if DEBUG_S3C_UART2
+   default 3 if DEBUG_S3C_UART3
 
 endif
-- 
1.7.10.1.488.g05fbf7a

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html