[PATCH] ASoC: Samsung: Set RFS and BFS in slave mode

[Padmavathi Venna]

As per the User Manual, the RFS and BFS should be set in slave mode
for correct operation.

Signed-off-by: Padmavathi Venna padm...@samsung.com
Signed-off-by: Andrew Bresticker abres...@chromium.org
Reviewed-on: https://gerrit-int.chromium.org/37841
Reviewed-by: Simon Glass s...@google.com
---
 sound/soc/samsung/i2s.c |8 
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 82ebb1a..3fcf8d7 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -742,13 +742,13 @@ static int config_setup(struct i2s_dai *i2s)
return -EAGAIN;
}
 
-   /* Don't bother RFS, BFS  PSR in Slave mode */
-   if (is_slave(i2s))
-   return 0;
-
set_bfs(i2s, bfs);
set_rfs(i2s, rfs);
 
+   /* Don't bother with PSR in Slave mode */
+   if (is_slave(i2s))
+   return 0;
+
if (!(i2s-quirks  QUIRK_NO_MUXPSR)) {
psr = i2s-rclk_srcrate / i2s-frmclk / rfs;
writel(((psr - 1)  8) | PSR_PSREN, i2s-addr + I2SPSR);
-- 
1.7.4.4

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ASoC: Samsung: Set RFS and BFS in slave mode

[Mark Brown]

On Thu, Jul 11, 2013 at 12:38:25PM +0530, Padmavathi Venna wrote:
 As per the User Manual, the RFS and BFS should be set in slave mode
 for correct operation.

Applied, thanks.  Since this is a fix it should have been the first
patch in the series - this allows fixes to be sent to 

 Reviewed-on: https://gerrit-int.chromium.org/37841

Including things like this isn't terribly helpful - this is the Chromium
internal system and nobody in the community can view the review.  A link
to a public system might be useful but a private one should be omitted.


signature.asc
Description: Digital signature

Re: [PATCH] ASoC: Samsung: Set RFS and BFS in slave mode

[Padma Venkat]

Hi,

On Thu, Jul 11, 2013 at 4:41 PM, Mark Brown broo...@kernel.org wrote:
 On Thu, Jul 11, 2013 at 12:38:25PM +0530, Padmavathi Venna wrote:
 As per the User Manual, the RFS and BFS should be set in slave mode
 for correct operation.

 Applied, thanks.  Since this is a fix it should have been the first
 patch in the series - this allows fixes to be sent to

 Reviewed-on: https://gerrit-int.chromium.org/37841

 Including things like this isn't terribly helpful - this is the Chromium
 internal system and nobody in the community can view the review.  A link
 to a public system might be useful but a private one should be omitted.

I thought it was link to the public gerrit review system. Will remove next time.

Thanks
Padma
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html