RE: [PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare
Thomas Abraham wrote: > > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. > > Signed-off-by: Thomas Abraham (+ Alan Stern) Acked-by: Kukjin Kim Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > --- > drivers/usb/host/ohci-exynos.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci- > exynos.c > index 20a5008..7bca600 100644 > --- a/drivers/usb/host/ohci-exynos.c > +++ b/drivers/usb/host/ohci-exynos.c > @@ -123,7 +123,7 @@ static int __devinit exynos_ohci_probe(struct > platform_device *pdev) > goto fail_clk; > } > > - err = clk_enable(exynos_ohci->clk); > + err = clk_prepare_enable(exynos_ohci->clk); > if (err) > goto fail_clken; > > @@ -167,7 +167,7 @@ static int __devinit exynos_ohci_probe(struct > platform_device *pdev) > return 0; > > fail_io: > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > fail_clken: > clk_put(exynos_ohci->clk); > fail_clk: > @@ -186,7 +186,7 @@ static int __devexit exynos_ohci_remove(struct > platform_device *pdev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > clk_put(exynos_ohci->clk); > > usb_put_hcd(hcd); > @@ -232,7 +232,7 @@ static int exynos_ohci_suspend(struct device *dev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > > fail: > spin_unlock_irqrestore(&ohci->lock, flags); > @@ -247,7 +247,7 @@ static int exynos_ohci_resume(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct exynos4_ohci_platdata *pdata = pdev->dev.platform_data; > > - clk_enable(exynos_ohci->clk); > + clk_prepare_enable(exynos_ohci->clk); > > if (pdata && pdata->phy_init) > pdata->phy_init(pdev, S5P_USB_PHY_HOST); > -- > 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare
On Wednesday, October 03, 2012 8:42 AM Thomas Abraham wrote > > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. > > Signed-off-by: Thomas Abraham Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/usb/host/ohci-exynos.c | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c > index 20a5008..7bca600 100644 > --- a/drivers/usb/host/ohci-exynos.c > +++ b/drivers/usb/host/ohci-exynos.c > @@ -123,7 +123,7 @@ static int __devinit exynos_ohci_probe(struct > platform_device *pdev) > goto fail_clk; > } > > - err = clk_enable(exynos_ohci->clk); > + err = clk_prepare_enable(exynos_ohci->clk); > if (err) > goto fail_clken; > > @@ -167,7 +167,7 @@ static int __devinit exynos_ohci_probe(struct > platform_device *pdev) > return 0; > > fail_io: > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > fail_clken: > clk_put(exynos_ohci->clk); > fail_clk: > @@ -186,7 +186,7 @@ static int __devexit exynos_ohci_remove(struct > platform_device *pdev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > clk_put(exynos_ohci->clk); > > usb_put_hcd(hcd); > @@ -232,7 +232,7 @@ static int exynos_ohci_suspend(struct device *dev) > if (pdata && pdata->phy_exit) > pdata->phy_exit(pdev, S5P_USB_PHY_HOST); > > - clk_disable(exynos_ohci->clk); > + clk_disable_unprepare(exynos_ohci->clk); > > fail: > spin_unlock_irqrestore(&ohci->lock, flags); > @@ -247,7 +247,7 @@ static int exynos_ohci_resume(struct device *dev) > struct platform_device *pdev = to_platform_device(dev); > struct exynos4_ohci_platdata *pdata = pdev->dev.platform_data; > > - clk_enable(exynos_ohci->clk); > + clk_prepare_enable(exynos_ohci->clk); > > if (pdata && pdata->phy_init) > pdata->phy_init(pdev, S5P_USB_PHY_HOST); > -- > 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare
Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham --- drivers/usb/host/ohci-exynos.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 20a5008..7bca600 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -123,7 +123,7 @@ static int __devinit exynos_ohci_probe(struct platform_device *pdev) goto fail_clk; } - err = clk_enable(exynos_ohci->clk); + err = clk_prepare_enable(exynos_ohci->clk); if (err) goto fail_clken; @@ -167,7 +167,7 @@ static int __devinit exynos_ohci_probe(struct platform_device *pdev) return 0; fail_io: - clk_disable(exynos_ohci->clk); + clk_disable_unprepare(exynos_ohci->clk); fail_clken: clk_put(exynos_ohci->clk); fail_clk: @@ -186,7 +186,7 @@ static int __devexit exynos_ohci_remove(struct platform_device *pdev) if (pdata && pdata->phy_exit) pdata->phy_exit(pdev, S5P_USB_PHY_HOST); - clk_disable(exynos_ohci->clk); + clk_disable_unprepare(exynos_ohci->clk); clk_put(exynos_ohci->clk); usb_put_hcd(hcd); @@ -232,7 +232,7 @@ static int exynos_ohci_suspend(struct device *dev) if (pdata && pdata->phy_exit) pdata->phy_exit(pdev, S5P_USB_PHY_HOST); - clk_disable(exynos_ohci->clk); + clk_disable_unprepare(exynos_ohci->clk); fail: spin_unlock_irqrestore(&ohci->lock, flags); @@ -247,7 +247,7 @@ static int exynos_ohci_resume(struct device *dev) struct platform_device *pdev = to_platform_device(dev); struct exynos4_ohci_platdata *pdata = pdev->dev.platform_data; - clk_enable(exynos_ohci->clk); + clk_prepare_enable(exynos_ohci->clk); if (pdata && pdata->phy_init) pdata->phy_init(pdev, S5P_USB_PHY_HOST); -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
