Re: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work
Kukjin, On Tue, Apr 2, 2013 at 7:16 PM, Kukjin Kim kgene@samsung.com wrote: Applied with 1st one, BTW, do you want to send this for stable tree? I don't have any need for it to be in stable tree. The ARM Chromebook hasn't reached critical functionality on any released/upstram Linux versions so it doesn't make much sense to backport fixes. If someone else wants it in stable (and can confirm that it helps them) then I certainly wouldn't object! One more note, just now I discussed Jaecheol Lee about the bit, ENABLE_WAKEUP_SW, as the patch fixed, it should be cleared but used to be set s3c_irqwake_intmask. Let me check again, then if any updates I'll let you know. OK, thanks. If there is a reason that ENABLE_WAKEUP_SW needs to be set then it would be good to understand that case. :) -Doug -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work
Doug Anderson wrote: to make suspend/resume reliable on the ARM Chromebook (exynos5250-snow). A few more details: - The first patch is not strictly needed but was a nice cleanup. Our understanding was that EINT0 was originally turned on for exynos evt0 silicon and not needed for evt1. Looks good to me, applied, thanks. - The second patch is more important and (also) more obvious. The function was modifying the S5P_WAKEUP_MASK register and then clobbering its own modifications. Applied with 1st one, BTW, do you want to send this for stable tree? - Kukjin For some history, see: - https://gerrit.chromium.org/gerrit/31337 - https://gerrit.chromium.org/gerrit/31341 Jonathan Kliegman (2): arm: exynos: Remove hardcode wakeup unmask for EINT_0 arm: exynos: Clear ENABLE_WAKEUP_SW bit when entering suspend arch/arm/mach-exynos/include/mach/pm-core.h | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) -- 1.8.1.3 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work
Kukjin Kim wrote: Doug Anderson wrote: to make suspend/resume reliable on the ARM Chromebook (exynos5250-snow). A few more details: - The first patch is not strictly needed but was a nice cleanup. Our understanding was that EINT0 was originally turned on for exynos evt0 silicon and not needed for evt1. Looks good to me, applied, thanks. - The second patch is more important and (also) more obvious. The function was modifying the S5P_WAKEUP_MASK register and then clobbering its own modifications. Applied with 1st one, BTW, do you want to send this for stable tree? One more note, just now I discussed Jaecheol Lee about the bit, ENABLE_WAKEUP_SW, as the patch fixed, it should be cleared but used to be set s3c_irqwake_intmask. Let me check again, then if any updates I'll let you know. Thanks. - Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were part of the work
to make suspend/resume reliable on the ARM Chromebook (exynos5250-snow). A few more details: - The first patch is not strictly needed but was a nice cleanup. Our understanding was that EINT0 was originally turned on for exynos evt0 silicon and not needed for evt1. - The second patch is more important and (also) more obvious. The function was modifying the S5P_WAKEUP_MASK register and then clobbering its own modifications. For some history, see: - https://gerrit.chromium.org/gerrit/31337 - https://gerrit.chromium.org/gerrit/31341 Jonathan Kliegman (2): arm: exynos: Remove hardcode wakeup unmask for EINT_0 arm: exynos: Clear ENABLE_WAKEUP_SW bit when entering suspend arch/arm/mach-exynos/include/mach/pm-core.h | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) -- 1.8.1.3 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
