Re: [PATCH 0/2] Update uart irq handling for s3c64xx and later SoC's

2011-08-13 Thread Tomasz Figa
Hi Thomas,

On Wednesday 10 of August 2011 at 15:51:18, Thomas Abraham wrote:
 s3c64xx and later SoC's include the uart interrupt mask and pending 
registers
 in the uart controller, unlike their s3c24xx predecessor. This allows the
 uart irq handling to be moved from the platform code to the driver. This
 patchset does this change and removes all the macros that will not be
 required with this update.
 

Your patches should solve the issue of system hanging on wake up because of 
unacked (and unackable due to disabled UART bus clock) UART interrupts. So one 
more reason to merge them.

My earlier description of the issue:

 I am experiencing a strange issue with UART ports on a Tiny6410 board, based
 on the S3C6410 SoC (hardware wise same as the Mini6410 supported by Linux),
 after enabling CONFIG_PM and suspending the SoC.
 
 After triggering a wakeup event, it resumes till arch_suspend_enable_irqs()
 called by suspend_enter() and starts to get hammered by infinite amounts of
 UART interrupts.
 
 I have tracked this down to disabling UART PCLK clock on suspend and the
 bootloader/reset/power down/whatever leaving the UART in an undefined state
 with interrupt bits set (specifically Tx interrupt), with the masked clock
 making it impossible to ack them by plat-samsung/irq-uart.c. 

Best regards,
Tom

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/2] Update uart irq handling for s3c64xx and later SoC's

2011-08-10 Thread Thomas Abraham
s3c64xx and later SoC's include the uart interrupt mask and pending registers
in the uart controller, unlike their s3c24xx predecessor. This allows the
uart irq handling to be moved from the platform code to the driver. This
patchset does this change and removes all the macros that will not be
required with this update.

Thomas Abraham (2):
  serial: samsung: Add unified interrupt handler for s3c64xx and later SoC's
  ARM: SAMSUNG: Remove uart irq handling from plaform code

 arch/arm/Kconfig |1 -
 arch/arm/mach-s3c64xx/dev-uart.c |   60 ++---
 arch/arm/mach-s3c64xx/include/mach/irqs.h|   30 --
 arch/arm/mach-s3c64xx/irq.c  |   25 -
 arch/arm/plat-s5p/Kconfig|1 -
 arch/arm/plat-s5p/dev-uart.c |   84 +++---
 arch/arm/plat-s5p/include/plat/irqs.h|   35 ---
 arch/arm/plat-s5p/irq.c  |   34 ---
 arch/arm/plat-samsung/Kconfig|5 -
 arch/arm/plat-samsung/Makefile   |1 -
 arch/arm/plat-samsung/include/plat/regs-serial.h |5 +
 arch/arm/plat-samsung/irq-uart.c |   96 ---
 drivers/tty/serial/samsung.c |  107 +++---
 drivers/tty/serial/samsung.h |1 +
 14 files changed, 121 insertions(+), 364 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/irq-uart.c

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html