Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h

2014-07-04 Thread Kukjin Kim 

On 07/04/14 17:33, Tomasz Figa wrote:

Hi Sachin,

On 04.07.2014 10:29, Sachin Kamat wrote:

On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat  wrote:

PINCTRL_EXYNOS is always selected by Exynos platform in its
machine Kconfig. Thus the code in the else part is never used.
Remove it.

Signed-off-by: Sachin Kamat
---
  arch/arm/mach-exynos/common.h |4 
  1 file changed, 4 deletions(-)

diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index 1ee91763fa7c..3371669dabc6 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -125,11 +125,7 @@ void exynos_init_late(void);

  void exynos_firmware_init(void);

-#ifdef CONFIG_PINCTRL_EXYNOS
  extern u32 exynos_get_eint_wake_mask(void);
-#else
-static inline u32 exynos_get_eint_wake_mask(void) { return 0x; }
-#endif

  #ifdef CONFIG_PM_SLEEP
  extern void __init exynos_pm_init(void);
--
1.7.9.5



Ping..



For this change alone:

Reviewed-by: Tomasz Figa


Applied, thanks.

- Kukjin



However I can see much more unused code in that header, more
specifically prototypes of mct_init() (replaced with DT-based init) and
most of other *init*() functions (which are now all in one file). Do you
plan to remove them as well?

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h

2014-07-04 Thread Sachin Kamat 
Hi Tomasz,

On Fri, Jul 4, 2014 at 2:13 PM, Sachin Kamat  wrote:
> Hi Tomasz,
>
> On Fri, Jul 4, 2014 at 2:03 PM, Tomasz Figa  wrote:
>> Hi Sachin,
>>
>> On 04.07.2014 10:29, Sachin Kamat wrote:
>>> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat  
>>> wrote:
 PINCTRL_EXYNOS is always selected by Exynos platform in its
 machine Kconfig. Thus the code in the else part is never used.
 Remove it.

 Signed-off-by: Sachin Kamat 
 ---
  arch/arm/mach-exynos/common.h |4 
  1 file changed, 4 deletions(-)

 diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
 index 1ee91763fa7c..3371669dabc6 100644
 --- a/arch/arm/mach-exynos/common.h
 +++ b/arch/arm/mach-exynos/common.h
 @@ -125,11 +125,7 @@ void exynos_init_late(void);

  void exynos_firmware_init(void);

 -#ifdef CONFIG_PINCTRL_EXYNOS
  extern u32 exynos_get_eint_wake_mask(void);
 -#else
 -static inline u32 exynos_get_eint_wake_mask(void) { return 0x; }
 -#endif

  #ifdef CONFIG_PM_SLEEP
  extern void __init exynos_pm_init(void);
 --
 1.7.9.5

>>>
>>> Ping..
>>>
>>
>> For this change alone:
>>
>> Reviewed-by: Tomasz Figa 
>
> Thanks.
>
>>
>> However I can see much more unused code in that header, more
>> specifically prototypes of mct_init() (replaced with DT-based init) and
>> most of other *init*() functions (which are now all in one file). Do you
>> plan to remove them as well?
>
> Sure. I will remove those too.

Some of the things that you suggested are already taken care of in the
patch at [1].
So will keep my patch in the current format and later if something else is
needed will send separate patch to avoid merge conflicts. What say?

[1] https://lkml.org/lkml/2014/6/25/375

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h

2014-07-04 Thread Sachin Kamat 
Hi Tomasz,

On Fri, Jul 4, 2014 at 2:03 PM, Tomasz Figa  wrote:
> Hi Sachin,
>
> On 04.07.2014 10:29, Sachin Kamat wrote:
>> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat  
>> wrote:
>>> PINCTRL_EXYNOS is always selected by Exynos platform in its
>>> machine Kconfig. Thus the code in the else part is never used.
>>> Remove it.
>>>
>>> Signed-off-by: Sachin Kamat 
>>> ---
>>>  arch/arm/mach-exynos/common.h |4 
>>>  1 file changed, 4 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
>>> index 1ee91763fa7c..3371669dabc6 100644
>>> --- a/arch/arm/mach-exynos/common.h
>>> +++ b/arch/arm/mach-exynos/common.h
>>> @@ -125,11 +125,7 @@ void exynos_init_late(void);
>>>
>>>  void exynos_firmware_init(void);
>>>
>>> -#ifdef CONFIG_PINCTRL_EXYNOS
>>>  extern u32 exynos_get_eint_wake_mask(void);
>>> -#else
>>> -static inline u32 exynos_get_eint_wake_mask(void) { return 0x; }
>>> -#endif
>>>
>>>  #ifdef CONFIG_PM_SLEEP
>>>  extern void __init exynos_pm_init(void);
>>> --
>>> 1.7.9.5
>>>
>>
>> Ping..
>>
>
> For this change alone:
>
> Reviewed-by: Tomasz Figa 

Thanks.

>
> However I can see much more unused code in that header, more
> specifically prototypes of mct_init() (replaced with DT-based init) and
> most of other *init*() functions (which are now all in one file). Do you
> plan to remove them as well?

Sure. I will remove those too.

Regards,
Sachin.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h

2014-07-04 Thread Tomasz Figa 
Hi Sachin,

On 04.07.2014 10:29, Sachin Kamat wrote:
> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat  
> wrote:
>> PINCTRL_EXYNOS is always selected by Exynos platform in its
>> machine Kconfig. Thus the code in the else part is never used.
>> Remove it.
>>
>> Signed-off-by: Sachin Kamat 
>> ---
>>  arch/arm/mach-exynos/common.h |4 
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
>> index 1ee91763fa7c..3371669dabc6 100644
>> --- a/arch/arm/mach-exynos/common.h
>> +++ b/arch/arm/mach-exynos/common.h
>> @@ -125,11 +125,7 @@ void exynos_init_late(void);
>>
>>  void exynos_firmware_init(void);
>>
>> -#ifdef CONFIG_PINCTRL_EXYNOS
>>  extern u32 exynos_get_eint_wake_mask(void);
>> -#else
>> -static inline u32 exynos_get_eint_wake_mask(void) { return 0x; }
>> -#endif
>>
>>  #ifdef CONFIG_PM_SLEEP
>>  extern void __init exynos_pm_init(void);
>> --
>> 1.7.9.5
>>
> 
> Ping..
> 

For this change alone:

Reviewed-by: Tomasz Figa 

However I can see much more unused code in that header, more
specifically prototypes of mct_init() (replaced with DT-based init) and
most of other *init*() functions (which are now all in one file). Do you
plan to remove them as well?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h

2014-07-04 Thread Sachin Kamat 
On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat  wrote:
> PINCTRL_EXYNOS is always selected by Exynos platform in its
> machine Kconfig. Thus the code in the else part is never used.
> Remove it.
>
> Signed-off-by: Sachin Kamat 
> ---
>  arch/arm/mach-exynos/common.h |4 
>  1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index 1ee91763fa7c..3371669dabc6 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -125,11 +125,7 @@ void exynos_init_late(void);
>
>  void exynos_firmware_init(void);
>
> -#ifdef CONFIG_PINCTRL_EXYNOS
>  extern u32 exynos_get_eint_wake_mask(void);
> -#else
> -static inline u32 exynos_get_eint_wake_mask(void) { return 0x; }
> -#endif
>
>  #ifdef CONFIG_PM_SLEEP
>  extern void __init exynos_pm_init(void);
> --
> 1.7.9.5
>

Ping..
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h

2014-06-23 Thread Sachin Kamat 
PINCTRL_EXYNOS is always selected by Exynos platform in its
machine Kconfig. Thus the code in the else part is never used.
Remove it.

Signed-off-by: Sachin Kamat 
---
 arch/arm/mach-exynos/common.h |4 
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index 1ee91763fa7c..3371669dabc6 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -125,11 +125,7 @@ void exynos_init_late(void);
 
 void exynos_firmware_init(void);
 
-#ifdef CONFIG_PINCTRL_EXYNOS
 extern u32 exynos_get_eint_wake_mask(void);
-#else
-static inline u32 exynos_get_eint_wake_mask(void) { return 0x; }
-#endif
 
 #ifdef CONFIG_PM_SLEEP
 extern void __init exynos_pm_init(void);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html