Re: [PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

[Doug Anderson]

Andreas,

On Mon, Jun 23, 2014 at 4:06 PM, Andreas Färber  wrote:
> I was wondering which character to type, and found two undocumented
> s5m8767_pmic properties downstream (s5m-core,enable-low-jitter and
> s5m-core,device_type = <0x2>), which I then left out.

I don't know much about "s5m-core,device_type", but I doubt it's
needed.  You can see  for details.  I
haven't looked but I'd bet that we just get this from the compatible
string now.

I did do a (very!) quick look and I see that low-jitter was originally
implemented in the local 3.4 kernel at .
...and the local 3.8 kernel at .

NOTE: it's pretty important to make sure low-jitter is turned on for
Chromebooks if you actually want full functionality.  At least on
exynos5250-snow (with the max77686 PMIC) you'd get occasional (and
very strange and very hard to debug) TPM errors if you didn't have
low-jitter.  The TPM is part of the security model on Chromebooks and
you might have a hard time accessing the encrypted parts of the disk
without it.


-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

[Andreas Färber]

Am 23.06.2014 05:21, schrieb Sachin Kamat:
> On Mon, Jun 23, 2014 at 6:51 AM, Andreas Färber  wrote:
>> It's LDO2, not LD02.
>>
>> Signed-off-by: Andreas Färber 
>> ---
>>  Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +-
>>  Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt 
>> b/Documentation/devicetree/bindings/mfd/s2mps11.txt
>> index d81ba30..55ab4f4 100644
>> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
>> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
>> @@ -81,7 +81,7 @@ as per the datasheet of s2mps11.
>>   - valid values for n are:
>> - S2MPS11: 1 to 38
>> - S2MPS14: 1 to 25
>> - - Example: LDO1, LD02, LDO28
>> + - Example: LDO1, LDO2, LDO28
>> - BUCKn
>>   - valid values for n are:
>> - S2MPS11: 1 to 10
>> diff --git 
>> a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt 
>> b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
>> index d290988..2019131 100644
>> --- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
>> +++ b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
>> @@ -86,7 +86,7 @@ as per the datasheet of s5m8767.
>>
>> - LDOn
>>   - valid values for n are 1 to 28
>> - - Example: LDO1, LD02, LDO28
>> + - Example: LDO1, LDO2, LDO28
>> - BUCKn
>>   - valid values for n are 1 to 9.
>>   - Example: BUCK1, BUCK2, BUCK9
>> --
> 
> Very keen observation :)
> 
> Reviewed-by: Sachin Kamat 

A font that distinguishes the zero with a dot or dash helps! :)

I was wondering which character to type, and found two undocumented
s5m8767_pmic properties downstream (s5m-core,enable-low-jitter and
s5m-core,device_type = <0x2>), which I then left out.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

[Lee Jones]

On Mon, 23 Jun 2014, Andreas Färber wrote:

> It's LDO2, not LD02.
> 
> Signed-off-by: Andreas Färber 
> ---
>  Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +-
>  Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt 
> b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index d81ba30..55ab4f4 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -81,7 +81,7 @@ as per the datasheet of s2mps11.
> - valid values for n are:
>   - S2MPS11: 1 to 38
>   - S2MPS14: 1 to 25
> -   - Example: LDO1, LD02, LDO28
> +   - Example: LDO1, LDO2, LDO28
>   - BUCKn
> - valid values for n are:
>   - S2MPS11: 1 to 10
> diff --git 
> a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt 
> b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
> index d290988..2019131 100644
> --- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
> @@ -86,7 +86,7 @@ as per the datasheet of s5m8767.
>  
>   - LDOn
> - valid values for n are 1 to 28
> -   - Example: LDO1, LD02, LDO28
> +   - Example: LDO1, LDO2, LDO28
>   - BUCKn
> - valid values for n are 1 to 9.
> - Example: BUCK1, BUCK2, BUCK9

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

[Sachin Kamat]

On Mon, Jun 23, 2014 at 6:51 AM, Andreas Färber  wrote:
> It's LDO2, not LD02.
>
> Signed-off-by: Andreas Färber 
> ---
>  Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +-
>  Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt 
> b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index d81ba30..55ab4f4 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -81,7 +81,7 @@ as per the datasheet of s2mps11.
>   - valid values for n are:
> - S2MPS11: 1 to 38
> - S2MPS14: 1 to 25
> - - Example: LDO1, LD02, LDO28
> + - Example: LDO1, LDO2, LDO28
> - BUCKn
>   - valid values for n are:
> - S2MPS11: 1 to 10
> diff --git 
> a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt 
> b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
> index d290988..2019131 100644
> --- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
> @@ -86,7 +86,7 @@ as per the datasheet of s5m8767.
>
> - LDOn
>   - valid values for n are 1 to 28
> - - Example: LDO1, LD02, LDO28
> + - Example: LDO1, LDO2, LDO28
> - BUCKn
>   - valid values for n are 1 to 9.
>   - Example: BUCK1, BUCK2, BUCK9
> --

Very keen observation :)

Reviewed-by: Sachin Kamat 
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] Documentation: devicetree: Fix s2mps11 and s5m8767 typos

[Andreas Färber]

It's LDO2, not LD02.

Signed-off-by: Andreas Färber 
---
 Documentation/devicetree/bindings/mfd/s2mps11.txt | 2 +-
 Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt 
b/Documentation/devicetree/bindings/mfd/s2mps11.txt
index d81ba30..55ab4f4 100644
--- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
+++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
@@ -81,7 +81,7 @@ as per the datasheet of s2mps11.
  - valid values for n are:
- S2MPS11: 1 to 38
- S2MPS14: 1 to 25
- - Example: LDO1, LD02, LDO28
+ - Example: LDO1, LDO2, LDO28
- BUCKn
  - valid values for n are:
- S2MPS11: 1 to 10
diff --git a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt 
b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
index d290988..2019131 100644
--- a/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/s5m8767-regulator.txt
@@ -86,7 +86,7 @@ as per the datasheet of s5m8767.
 
- LDOn
  - valid values for n are 1 to 28
- - Example: LDO1, LD02, LDO28
+ - Example: LDO1, LDO2, LDO28
- BUCKn
  - valid values for n are 1 to 9.
  - Example: BUCK1, BUCK2, BUCK9
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html