Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time

2014-07-11 Thread Sachin Kamat
Hi Wolfram,

On Thu, Jul 10, 2014 at 5:16 PM, Wolfram Sang w...@the-dreams.de wrote:
 This driver has been flagged to drop class based instantiation. The removal
 improves boot-up time and is unneeded for embedded controllers. Users have 
 been
 warned to switch for some time now, so we can actually do the removal. Keep 
 the
 DEPRECATED flag, so the core can inform users that the behaviour finally
 changed now. After another transition period, this flag can go, too.
 While we are here, remove the indentation for the array setup because
 such things always break after some time.

 Signed-off-by: Wolfram Sang w...@the-dreams.de
 ---
  drivers/i2c/busses/i2c-s3c2410.c | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

 diff --git a/drivers/i2c/busses/i2c-s3c2410.c 
 b/drivers/i2c/busses/i2c-s3c2410.c
 index e828a1dba0e5..6252c051525a 100644
 --- a/drivers/i2c/busses/i2c-s3c2410.c
 +++ b/drivers/i2c/busses/i2c-s3c2410.c
 @@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device 
 *pdev)
 s3c24xx_i2c_parse_dt(pdev-dev.of_node, i2c);

 strlcpy(i2c-adap.name, s3c2410-i2c, sizeof(i2c-adap.name));
 -   i2c-adap.owner   = THIS_MODULE;
 -   i2c-adap.algo= s3c24xx_i2c_algorithm;
 +   i2c-adap.owner = THIS_MODULE;
 +   i2c-adap.algo = s3c24xx_i2c_algorithm;
 i2c-adap.retries = 2;
 -   i2c-adap.class   = I2C_CLASS_HWMON | I2C_CLASS_SPD | 
 I2C_CLASS_DEPRECATED;
 -   i2c-tx_setup = 50;
 +   i2c-adap.class = I2C_CLASS_DEPRECATED;
 +   i2c-tx_setup = 50;

 init_waitqueue_head(i2c-wait);

 --

Tested on Exynos 5250 boards.
Tested-by: Sachin Kamat sachin.ka...@samsung.com

-- 
Regards,
Sachin.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time

2014-07-10 Thread Wolfram Sang
This driver has been flagged to drop class based instantiation. The removal
improves boot-up time and is unneeded for embedded controllers. Users have been
warned to switch for some time now, so we can actually do the removal. Keep the
DEPRECATED flag, so the core can inform users that the behaviour finally
changed now. After another transition period, this flag can go, too.
While we are here, remove the indentation for the array setup because
such things always break after some time.

Signed-off-by: Wolfram Sang w...@the-dreams.de
---
 drivers/i2c/busses/i2c-s3c2410.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index e828a1dba0e5..6252c051525a 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device 
*pdev)
s3c24xx_i2c_parse_dt(pdev-dev.of_node, i2c);
 
strlcpy(i2c-adap.name, s3c2410-i2c, sizeof(i2c-adap.name));
-   i2c-adap.owner   = THIS_MODULE;
-   i2c-adap.algo= s3c24xx_i2c_algorithm;
+   i2c-adap.owner = THIS_MODULE;
+   i2c-adap.algo = s3c24xx_i2c_algorithm;
i2c-adap.retries = 2;
-   i2c-adap.class   = I2C_CLASS_HWMON | I2C_CLASS_SPD | 
I2C_CLASS_DEPRECATED;
-   i2c-tx_setup = 50;
+   i2c-adap.class = I2C_CLASS_DEPRECATED;
+   i2c-tx_setup = 50;
 
init_waitqueue_head(i2c-wait);
 
-- 
2.0.0

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html