RE: [PATCH 3/7] [media] s5p-fimc: Remove to support fimc for S5PC100
Sylwester Nawrocki wrote: On 05/16/2011 09:15 AM, Kukjin Kim wrote: Sylwester Nawrocki wrote: Shouldn't there be some deprecation period for whole s5pc100 support removal ? This is that. But I know, there is no time... It looks a bit rude to me that suddenly whole support for the SoC is vanished. Hmm...what did you think about my previous comments: 'removing some mach-s5ps'? I would expect one kernel release period of so notice for such a change. But it doesn't have to be true in this specific case. I know at least one active user of mainline FIMC driver @ s5pc100. Do you _really_ want to keep it in later mainline? I don't personally have interest in maintaining this driver for s5pc100. It just adds unnecessary complexity to my work and in fact I have limited possibilities now to test the driver on s5pc100. But if there are users and it really doesn't cost much to keep the support for s5pc100 why bother to remove it? Just to get rid of one mach-* directory ? I was not sure we should keep continually 6442 and C100 in mainline when I decided to removing 'mach-s5p'. I really don't care about 6442, but what's the problem with s5pc100 ? Is it being discontinued ? Or there is little users of it ? I would much more like to see attempts to consolidate the code rather than simply removing it. Hi Sylwester, Thanks for your opinion :) Please refer to my reply on this thread. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] [media] s5p-fimc: Remove to support fimc for S5PC100
Em 11-05-2011 22:11, Kukjin Kim escreveu:
According to removing ARCH_S5PC100, we don't need to support
fimc for S5PC100.
NACK
There's nothing mentioning the removal of ARCH_S5PC100 or the
corresponding bits at feature-removal-schedule.txt:
$ grep -i s5pc100 Documentation/feature-removal-schedule.txt
$
Mauro.
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Cc: Kyungmin Park kyungmin.p...@samsung.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
Signed-off-by: Kukjin Kim kgene@samsung.com
---
drivers/media/video/s5p-fimc/fimc-core.c | 14 --
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-core.c
b/drivers/media/video/s5p-fimc/fimc-core.c
index dc91a85..89d59d6 100644
--- a/drivers/media/video/s5p-fimc/fimc-core.c
+++ b/drivers/media/video/s5p-fimc/fimc-core.c
@@ -1871,17 +1871,6 @@ static struct samsung_fimc_variant
fimc2_variant_exynos4 = {
.pix_limit = s5p_pix_limit[3],
};
-/* S5PC100 */
-static struct samsung_fimc_driverdata fimc_drvdata_s5p = {
- .variant = {
- [0] = fimc0_variant_s5p,
- [1] = fimc0_variant_s5p,
- [2] = fimc2_variant_s5p,
- },
- .num_entities = 3,
- .lclk_frequency = 13300UL,
-};
-
/* S5PV210, S5PC110 */
static struct samsung_fimc_driverdata fimc_drvdata_s5pv210 = {
.variant = {
@@ -1907,9 +1896,6 @@ static struct samsung_fimc_driverdata
fimc_drvdata_exynos4 = {
static struct platform_device_id fimc_driver_ids[] = {
{
- .name = s5p-fimc,
- .driver_data= (unsigned long)fimc_drvdata_s5p,
- }, {
.name = s5pv210-fimc,
.driver_data= (unsigned long)fimc_drvdata_s5pv210,
}, {
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] [media] s5p-fimc: Remove to support fimc for S5PC100
On 05/16/2011 09:15 AM, Kukjin Kim wrote: Sylwester Nawrocki wrote: Shouldn't there be some deprecation period for whole s5pc100 support removal ? This is that. But I know, there is no time... It looks a bit rude to me that suddenly whole support for the SoC is vanished. Hmm...what did you think about my previous comments: 'removing some mach-s5ps'? I would expect one kernel release period of so notice for such a change. But it doesn't have to be true in this specific case. I know at least one active user of mainline FIMC driver @ s5pc100. Do you _really_ want to keep it in later mainline? I don't personally have interest in maintaining this driver for s5pc100. It just adds unnecessary complexity to my work and in fact I have limited possibilities now to test the driver on s5pc100. But if there are users and it really doesn't cost much to keep the support for s5pc100 why bother to remove it? Just to get rid of one mach-* directory ? I was not sure we should keep continually 6442 and C100 in mainline when I decided to removing 'mach-s5p'. I really don't care about 6442, but what's the problem with s5pc100 ? Is it being discontinued ? Or there is little users of it ? I would much more like to see attempts to consolidate the code rather than simply removing it. Regards, -- Sylwester Nawrocki Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 3/7] [media] s5p-fimc: Remove to support fimc for S5PC100
Sylwester Nawrocki wrote: Hi Kukjin, Hi, Shouldn't there be some deprecation period for whole s5pc100 support removal ? This is that. But I know, there is no time... It looks a bit rude to me that suddenly whole support for the SoC is vanished. Hmm...what did you think about my previous comments: 'removing some mach-s5ps'? I know at least one active user of mainline FIMC driver @ s5pc100. Do you _really_ want to keep it in later mainline? I was not sure we should keep continually 6442 and C100 in mainline when I decided to removing 'mach-s5p'. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/7] [media] s5p-fimc: Remove to support fimc for S5PC100
Hi Kukjin,
Shouldn't there be some deprecation period for whole s5pc100 support removal ?
It looks a bit rude to me that suddenly whole support for the SoC is vanished.
I know at least one active user of mainline FIMC driver @ s5pc100.
On 05/12/2011 03:11 AM, Kukjin Kim wrote:
According to removing ARCH_S5PC100, we don't need to support
fimc for S5PC100.
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Cc: Kyungmin Park kyungmin.p...@samsung.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
Signed-off-by: Kukjin Kim kgene@samsung.com
---
drivers/media/video/s5p-fimc/fimc-core.c | 14 --
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-core.c
b/drivers/media/video/s5p-fimc/fimc-core.c
index dc91a85..89d59d6 100644
--- a/drivers/media/video/s5p-fimc/fimc-core.c
+++ b/drivers/media/video/s5p-fimc/fimc-core.c
@@ -1871,17 +1871,6 @@ static struct samsung_fimc_variant
fimc2_variant_exynos4 = {
.pix_limit = s5p_pix_limit[3],
};
-/* S5PC100 */
-static struct samsung_fimc_driverdata fimc_drvdata_s5p = {
- .variant = {
- [0] = fimc0_variant_s5p,
- [1] = fimc0_variant_s5p,
- [2] = fimc2_variant_s5p,
- },
- .num_entities = 3,
- .lclk_frequency = 13300UL,
-};
-
/* S5PV210, S5PC110 */
static struct samsung_fimc_driverdata fimc_drvdata_s5pv210 = {
.variant = {
@@ -1907,9 +1896,6 @@ static struct samsung_fimc_driverdata
fimc_drvdata_exynos4 = {
static struct platform_device_id fimc_driver_ids[] = {
{
- .name = s5p-fimc,
- .driver_data= (unsigned long)fimc_drvdata_s5p,
- }, {
.name = s5pv210-fimc,
.driver_data= (unsigned long)fimc_drvdata_s5pv210,
}, {
--
Sylwester Nawrocki
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
