Re: [PATCH V5 4/5] ARM: dts: add clock provider information for i2s controllers in Exynos5250
Hi Doug, On Tue, Jun 4, 2013 at 10:49 PM, Doug Anderson diand...@chromium.org wrote: Padmavathi, On Tue, Jun 4, 2013 at 5:28 AM, Padmavathi Venna padm...@samsung.com wrote: @@ -471,6 +477,8 @@ dmas = pdma1 12 pdma1 11; dma-names = tx, rx; + clocks = clock 307; + clock-names = iis; ...actually, glancing at the driver I'm a little surprised that you don't need to list i2s_opclk0. Did you test i2s1? I didn't test i2s1 but i2s_opclk0 is also required. I will resubmit the patch. pinctrl-names = default; pinctrl-0 = i2s1_bus; }; @@ -481,6 +489,8 @@ dmas = pdma0 12 pdma0 11; dma-names = tx, rx; + clocks = clock 308; + clock-names = iis; ...and here. -Doug Thanks Padma -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V5 4/5] ARM: dts: add clock provider information for i2s controllers in Exynos5250
Add clock lookup information for i2s controllers on exynos5250 SoC.
Signed-off-by: Padmavathi Venna padm...@samsung.com
Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com
---
arch/arm/boot/dts/exynos5250.dtsi | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 388983e..1e62ca9 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -20,6 +20,8 @@
#include skeleton.dtsi
#include exynos5250-pinctrl.dtsi
+#include dt-bindings/clk/exynos-audss-clk.h
+
/ {
compatible = samsung,exynos5250;
interrupt-parent = gic;
@@ -457,6 +459,10 @@
pdma0 9
pdma0 8;
dma-names = tx, rx, tx-sec;
+ clocks = clock_audss EXYNOS_I2S_BUS,
+ clock_audss EXYNOS_I2S_BUS,
+ clock_audss EXYNOS_SCLK_I2S;
+ clock-names = iis, i2s_opclk0, i2s_opclk1;
samsung,supports-6ch;
samsung,supports-rstclr;
samsung,supports-secdai;
@@ -471,6 +477,8 @@
dmas = pdma1 12
pdma1 11;
dma-names = tx, rx;
+ clocks = clock 307;
+ clock-names = iis;
pinctrl-names = default;
pinctrl-0 = i2s1_bus;
};
@@ -481,6 +489,8 @@
dmas = pdma0 12
pdma0 11;
dma-names = tx, rx;
+ clocks = clock 308;
+ clock-names = iis;
pinctrl-names = default;
pinctrl-0 = i2s2_bus;
};
--
1.7.4.4
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V5 4/5] ARM: dts: add clock provider information for i2s controllers in Exynos5250
Padmavathi, On Tue, Jun 4, 2013 at 5:28 AM, Padmavathi Venna padm...@samsung.com wrote: Add clock lookup information for i2s controllers on exynos5250 SoC. Signed-off-by: Padmavathi Venna padm...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi | 10 ++ Would still like to see a separate patch documenting these clocks in Documentation/devicetree/bindings/sound/samsung-i2s.txt. ...but what's here looks good, thanks! Reviewed-by: Doug Anderson diand...@chromium.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V5 4/5] ARM: dts: add clock provider information for i2s controllers in Exynos5250
Padmavathi, On Tue, Jun 4, 2013 at 5:28 AM, Padmavathi Venna padm...@samsung.com wrote: @@ -471,6 +477,8 @@ dmas = pdma1 12 pdma1 11; dma-names = tx, rx; + clocks = clock 307; + clock-names = iis; ...actually, glancing at the driver I'm a little surprised that you don't need to list i2s_opclk0. Did you test i2s1? pinctrl-names = default; pinctrl-0 = i2s1_bus; }; @@ -481,6 +489,8 @@ dmas = pdma0 12 pdma0 11; dma-names = tx, rx; + clocks = clock 308; + clock-names = iis; ...and here. -Doug -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
