Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2014-02-23 Thread Kukjin Kim 

On 01/03/14 19:07, Sachin Kamat wrote:

On 21 December 2013 02:40, Tomasz Figatomasz.f...@gmail.com  wrote:

On Thursday 19 of December 2013 10:05:52 Sachin Kamat wrote:

Hi Tomasz,

On 18 December 2013 20:46, Tomasz Figat.f...@samsung.com  wrote:

Hi Sachin,

On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:

Added regulator entries to Exynos5420 SMDK board.

Signed-off-by: Sachin Kamatsachin.ka...@linaro.org
---
Changes since v1:
Changed node name
---
  arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 +
  1 file changed, 216 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index fb5a1e25c632..62e1ebe4e989 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -120,4 +120,220 @@
   reg =0x50;
   };
   };
+
+ hsi2c_4: i2c@12CA {
+ status = okay;
+
+ s2mps11_pmic@66 {


Just pmic@66 is enough.


Please see my comment below.




+ compatible = samsung,s2mps11-pmic;
+ reg =0x66;
+ s2mps11,buck2-ramp-delay =12;
+ s2mps11,buck34-ramp-delay =12;
+ s2mps11,buck16-ramp-delay =12;
+ s2mps11,buck6-ramp-enable =1;
+ s2mps11,buck2-ramp-enable =1;
+ s2mps11,buck3-ramp-enable =1;
+ s2mps11,buck4-ramp-enable =1;
+
+ s2mps11_osc: clocks {
+ #clock-cells =1;
+ clock-output-names = s2mps11_ap,
+ s2mps11_cp, s2mps11_bt;
+ };
+
+ regulators {
+ ldo1_reg: LDO1 {
+ regulator-name = vdd_ldo1;


Is this the name as written on the PCB or board schematics?
+ the same for all regulators below.


Yes, the schematic refers to these just as above (with no specific names).
Unless you have strong objections or a re-spin of this patch becomes
necessary, I
wouldn't want to change the name you pointed above. :)


OK.

Reviewed-by: Tomasz Figat.f...@samsung.com


Ping Kukjin.


Applied, thanks.

- Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2014-01-03 Thread Sachin Kamat 
On 21 December 2013 02:40, Tomasz Figa tomasz.f...@gmail.com wrote:
 On Thursday 19 of December 2013 10:05:52 Sachin Kamat wrote:
 Hi Tomasz,

 On 18 December 2013 20:46, Tomasz Figa t.f...@samsung.com wrote:
  Hi Sachin,
 
  On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:
  Added regulator entries to Exynos5420 SMDK board.
 
  Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
  ---
  Changes since v1:
  Changed node name
  ---
   arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 
  +
   1 file changed, 216 insertions(+)
 
  diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
  b/arch/arm/boot/dts/exynos5420-smdk5420.dts
  index fb5a1e25c632..62e1ebe4e989 100644
  --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
  +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
  @@ -120,4 +120,220 @@
reg = 0x50;
};
};
  +
  + hsi2c_4: i2c@12CA {
  + status = okay;
  +
  + s2mps11_pmic@66 {
 
  Just pmic@66 is enough.

 Please see my comment below.

 
  + compatible = samsung,s2mps11-pmic;
  + reg = 0x66;
  + s2mps11,buck2-ramp-delay = 12;
  + s2mps11,buck34-ramp-delay = 12;
  + s2mps11,buck16-ramp-delay = 12;
  + s2mps11,buck6-ramp-enable = 1;
  + s2mps11,buck2-ramp-enable = 1;
  + s2mps11,buck3-ramp-enable = 1;
  + s2mps11,buck4-ramp-enable = 1;
  +
  + s2mps11_osc: clocks {
  + #clock-cells = 1;
  + clock-output-names = s2mps11_ap,
  + s2mps11_cp, s2mps11_bt;
  + };
  +
  + regulators {
  + ldo1_reg: LDO1 {
  + regulator-name = vdd_ldo1;
 
  Is this the name as written on the PCB or board schematics?
  + the same for all regulators below.

 Yes, the schematic refers to these just as above (with no specific names).
 Unless you have strong objections or a re-spin of this patch becomes
 necessary, I
 wouldn't want to change the name you pointed above. :)

 OK.

 Reviewed-by: Tomasz Figa t.f...@samsung.com

Ping Kukjin.



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2013-12-20 Thread Tomasz Figa 
On Thursday 19 of December 2013 10:05:52 Sachin Kamat wrote:
 Hi Tomasz,
 
 On 18 December 2013 20:46, Tomasz Figa t.f...@samsung.com wrote:
  Hi Sachin,
 
  On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:
  Added regulator entries to Exynos5420 SMDK board.
 
  Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
  ---
  Changes since v1:
  Changed node name
  ---
   arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 
  +
   1 file changed, 216 insertions(+)
 
  diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
  b/arch/arm/boot/dts/exynos5420-smdk5420.dts
  index fb5a1e25c632..62e1ebe4e989 100644
  --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
  +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
  @@ -120,4 +120,220 @@
reg = 0x50;
};
};
  +
  + hsi2c_4: i2c@12CA {
  + status = okay;
  +
  + s2mps11_pmic@66 {
 
  Just pmic@66 is enough.
 
 Please see my comment below.
 
 
  + compatible = samsung,s2mps11-pmic;
  + reg = 0x66;
  + s2mps11,buck2-ramp-delay = 12;
  + s2mps11,buck34-ramp-delay = 12;
  + s2mps11,buck16-ramp-delay = 12;
  + s2mps11,buck6-ramp-enable = 1;
  + s2mps11,buck2-ramp-enable = 1;
  + s2mps11,buck3-ramp-enable = 1;
  + s2mps11,buck4-ramp-enable = 1;
  +
  + s2mps11_osc: clocks {
  + #clock-cells = 1;
  + clock-output-names = s2mps11_ap,
  + s2mps11_cp, s2mps11_bt;
  + };
  +
  + regulators {
  + ldo1_reg: LDO1 {
  + regulator-name = vdd_ldo1;
 
  Is this the name as written on the PCB or board schematics?
  + the same for all regulators below.
 
 Yes, the schematic refers to these just as above (with no specific names).
 Unless you have strong objections or a re-spin of this patch becomes
 necessary, I
 wouldn't want to change the name you pointed above. :)

OK.

Reviewed-by: Tomasz Figa t.f...@samsung.com

Best regards,
Tomasz

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2013-12-18 Thread Tomasz Figa 
Hi Sachin,

On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:
 Added regulator entries to Exynos5420 SMDK board.
 
 Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
 ---
 Changes since v1:
 Changed node name
 ---
  arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 
 +
  1 file changed, 216 insertions(+)
 
 diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
 b/arch/arm/boot/dts/exynos5420-smdk5420.dts
 index fb5a1e25c632..62e1ebe4e989 100644
 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
 +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
 @@ -120,4 +120,220 @@
   reg = 0x50;
   };
   };
 +
 + hsi2c_4: i2c@12CA {
 + status = okay;
 +
 + s2mps11_pmic@66 {

Just pmic@66 is enough.

 + compatible = samsung,s2mps11-pmic;
 + reg = 0x66;
 + s2mps11,buck2-ramp-delay = 12;
 + s2mps11,buck34-ramp-delay = 12;
 + s2mps11,buck16-ramp-delay = 12;
 + s2mps11,buck6-ramp-enable = 1;
 + s2mps11,buck2-ramp-enable = 1;
 + s2mps11,buck3-ramp-enable = 1;
 + s2mps11,buck4-ramp-enable = 1;
 +
 + s2mps11_osc: clocks {
 + #clock-cells = 1;
 + clock-output-names = s2mps11_ap,
 + s2mps11_cp, s2mps11_bt;
 + };
 +
 + regulators {
 + ldo1_reg: LDO1 {
 + regulator-name = vdd_ldo1;

Is this the name as written on the PCB or board schematics?
+ the same for all regulators below.

Best regards,
Tomasz
 
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2013-12-18 Thread Tomasz Figa 
Hi Kukjin,

On Tuesday 10 of December 2013 06:27:27 Kukjin Kim wrote:
 On 12/05/13 18:44, Sachin Kamat wrote:
  Added regulator entries to Exynos5420 SMDK board.
 
  Signed-off-by: Sachin Kamatsachin.ka...@linaro.org
  ---
  Changes since v1:
  Changed node name
  ---
arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 
  +
1 file changed, 216 insertions(+)
 
  diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
  b/arch/arm/boot/dts/exynos5420-smdk5420.dts
  index fb5a1e25c632..62e1ebe4e989 100644
  --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
  +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
  @@ -120,4 +120,220 @@
  reg =0x50;
  };
  };
  +
  +   hsi2c_4: i2c@12CA {
  +   status = okay;
  +
  +   s2mps11_pmic@66 {
  +   compatible = samsung,s2mps11-pmic;
  +   reg =0x66;
  +   s2mps11,buck2-ramp-delay =12;
  +   s2mps11,buck34-ramp-delay =12;
  +   s2mps11,buck16-ramp-delay =12;
  +   s2mps11,buck6-ramp-enable =1;
  +   s2mps11,buck2-ramp-enable =1;
  +   s2mps11,buck3-ramp-enable =1;
  +   s2mps11,buck4-ramp-enable =1;
  +
  +   s2mps11_osc: clocks {
  +   #clock-cells =1;
  +   clock-output-names = s2mps11_ap,
  +   s2mps11_cp, s2mps11_bt;
  +   };
  +
  +   regulators {
  +   ldo1_reg: LDO1 {
  +   regulator-name = vdd_ldo1;
  +   regulator-min-microvolt =100;
  +   regulator-max-microvolt =100;
  +   regulator-always-on;
  +   };
  +
  +   ldo3_reg: LDO3 {
  +   regulator-name = vdd_ldo3;
  +   regulator-min-microvolt =180;
  +   regulator-max-microvolt =180;
  +   regulator-always-on;
  +   };
  +
  +   ldo5_reg: LDO5 {
  +   regulator-name = vdd_ldo5;
  +   regulator-min-microvolt =180;
  +   regulator-max-microvolt =180;
  +   regulator-always-on;
  +   };
  +
  +   ldo6_reg: LDO6 {
  +   regulator-name = vdd_ldo6;
  +   regulator-min-microvolt =100;
  +   regulator-max-microvolt =100;
  +   regulator-always-on;
  +   };
  +
  +   ldo7_reg: LDO7 {
  +   regulator-name = vdd_ldo7;
  +   regulator-min-microvolt =180;
  +   regulator-max-microvolt =180;
  +   regulator-always-on;
  +   };
  +
  +   ldo8_reg: LDO8 {
  +   regulator-name = vdd_ldo8;
  +   regulator-min-microvolt =180;
  +   regulator-max-microvolt =180;
  +   regulator-always-on;
  +   };
  +
  +   ldo9_reg: LDO9 {
  +   regulator-name = vdd_ldo9;
  +   regulator-min-microvolt =300;
  +   regulator-max-microvolt =300;
  +   regulator-always-on;
  +   };
  +
  +   ldo10_reg: LDO10 {
  +   regulator-name = vdd_ldo10;
  +   regulator-min-microvolt =180;
  +   regulator-max-microvolt =180;
  +   regulator-always-on;
  +   };
  +
  +   ldo11_reg: LDO11 {
  +   regulator-name = vdd_ldo11;
  +   regulator-min-microvolt =100;
  +   regulator-max-microvolt =100;
  +   regulator-always-on;
  +   };
  +
  +   ldo12_reg: LDO12 {
  +   regulator-name = vdd_ldo12;
  +   regulator-min-microvolt =180;
  +   regulator-max-microvolt

Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2013-12-18 Thread Sachin Kamat 
Hi Tomasz,

On 18 December 2013 20:46, Tomasz Figa t.f...@samsung.com wrote:
 Hi Sachin,

 On Thursday 05 of December 2013 15:14:24 Sachin Kamat wrote:
 Added regulator entries to Exynos5420 SMDK board.

 Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
 ---
 Changes since v1:
 Changed node name
 ---
  arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 
 +
  1 file changed, 216 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
 b/arch/arm/boot/dts/exynos5420-smdk5420.dts
 index fb5a1e25c632..62e1ebe4e989 100644
 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
 +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
 @@ -120,4 +120,220 @@
   reg = 0x50;
   };
   };
 +
 + hsi2c_4: i2c@12CA {
 + status = okay;
 +
 + s2mps11_pmic@66 {

 Just pmic@66 is enough.

Please see my comment below.


 + compatible = samsung,s2mps11-pmic;
 + reg = 0x66;
 + s2mps11,buck2-ramp-delay = 12;
 + s2mps11,buck34-ramp-delay = 12;
 + s2mps11,buck16-ramp-delay = 12;
 + s2mps11,buck6-ramp-enable = 1;
 + s2mps11,buck2-ramp-enable = 1;
 + s2mps11,buck3-ramp-enable = 1;
 + s2mps11,buck4-ramp-enable = 1;
 +
 + s2mps11_osc: clocks {
 + #clock-cells = 1;
 + clock-output-names = s2mps11_ap,
 + s2mps11_cp, s2mps11_bt;
 + };
 +
 + regulators {
 + ldo1_reg: LDO1 {
 + regulator-name = vdd_ldo1;

 Is this the name as written on the PCB or board schematics?
 + the same for all regulators below.

Yes, the schematic refers to these just as above (with no specific names).
Unless you have strong objections or a re-spin of this patch becomes
necessary, I
wouldn't want to change the name you pointed above. :)

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2013-12-09 Thread Kukjin Kim 

On 12/05/13 18:44, Sachin Kamat wrote:

Added regulator entries to Exynos5420 SMDK board.

Signed-off-by: Sachin Kamatsachin.ka...@linaro.org
---
Changes since v1:
Changed node name
---
  arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 +
  1 file changed, 216 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index fb5a1e25c632..62e1ebe4e989 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -120,4 +120,220 @@
reg =0x50;
};
};
+
+   hsi2c_4: i2c@12CA {
+   status = okay;
+
+   s2mps11_pmic@66 {
+   compatible = samsung,s2mps11-pmic;
+   reg =0x66;
+   s2mps11,buck2-ramp-delay =12;
+   s2mps11,buck34-ramp-delay =12;
+   s2mps11,buck16-ramp-delay =12;
+   s2mps11,buck6-ramp-enable =1;
+   s2mps11,buck2-ramp-enable =1;
+   s2mps11,buck3-ramp-enable =1;
+   s2mps11,buck4-ramp-enable =1;
+
+   s2mps11_osc: clocks {
+   #clock-cells =1;
+   clock-output-names = s2mps11_ap,
+   s2mps11_cp, s2mps11_bt;
+   };
+
+   regulators {
+   ldo1_reg: LDO1 {
+   regulator-name = vdd_ldo1;
+   regulator-min-microvolt =100;
+   regulator-max-microvolt =100;
+   regulator-always-on;
+   };
+
+   ldo3_reg: LDO3 {
+   regulator-name = vdd_ldo3;
+   regulator-min-microvolt =180;
+   regulator-max-microvolt =180;
+   regulator-always-on;
+   };
+
+   ldo5_reg: LDO5 {
+   regulator-name = vdd_ldo5;
+   regulator-min-microvolt =180;
+   regulator-max-microvolt =180;
+   regulator-always-on;
+   };
+
+   ldo6_reg: LDO6 {
+   regulator-name = vdd_ldo6;
+   regulator-min-microvolt =100;
+   regulator-max-microvolt =100;
+   regulator-always-on;
+   };
+
+   ldo7_reg: LDO7 {
+   regulator-name = vdd_ldo7;
+   regulator-min-microvolt =180;
+   regulator-max-microvolt =180;
+   regulator-always-on;
+   };
+
+   ldo8_reg: LDO8 {
+   regulator-name = vdd_ldo8;
+   regulator-min-microvolt =180;
+   regulator-max-microvolt =180;
+   regulator-always-on;
+   };
+
+   ldo9_reg: LDO9 {
+   regulator-name = vdd_ldo9;
+   regulator-min-microvolt =300;
+   regulator-max-microvolt =300;
+   regulator-always-on;
+   };
+
+   ldo10_reg: LDO10 {
+   regulator-name = vdd_ldo10;
+   regulator-min-microvolt =180;
+   regulator-max-microvolt =180;
+   regulator-always-on;
+   };
+
+   ldo11_reg: LDO11 {
+   regulator-name = vdd_ldo11;
+   regulator-min-microvolt =100;
+   regulator-max-microvolt =100;
+   regulator-always-on;
+   };
+
+   ldo12_reg: LDO12 {
+   regulator-name = vdd_ldo12;
+   regulator-min-microvolt =180;
+

[PATCH v2] ARM: dts: Add regulator entries to Exynos5420 SMDK board

2013-12-05 Thread Sachin Kamat 
Added regulator entries to Exynos5420 SMDK board.

Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Changes since v1:
Changed node name
---
 arch/arm/boot/dts/exynos5420-smdk5420.dts |  216 +
 1 file changed, 216 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts 
b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index fb5a1e25c632..62e1ebe4e989 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -120,4 +120,220 @@
reg = 0x50;
};
};
+
+   hsi2c_4: i2c@12CA {
+   status = okay;
+
+   s2mps11_pmic@66 {
+   compatible = samsung,s2mps11-pmic;
+   reg = 0x66;
+   s2mps11,buck2-ramp-delay = 12;
+   s2mps11,buck34-ramp-delay = 12;
+   s2mps11,buck16-ramp-delay = 12;
+   s2mps11,buck6-ramp-enable = 1;
+   s2mps11,buck2-ramp-enable = 1;
+   s2mps11,buck3-ramp-enable = 1;
+   s2mps11,buck4-ramp-enable = 1;
+
+   s2mps11_osc: clocks {
+   #clock-cells = 1;
+   clock-output-names = s2mps11_ap,
+   s2mps11_cp, s2mps11_bt;
+   };
+
+   regulators {
+   ldo1_reg: LDO1 {
+   regulator-name = vdd_ldo1;
+   regulator-min-microvolt = 100;
+   regulator-max-microvolt = 100;
+   regulator-always-on;
+   };
+
+   ldo3_reg: LDO3 {
+   regulator-name = vdd_ldo3;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-always-on;
+   };
+
+   ldo5_reg: LDO5 {
+   regulator-name = vdd_ldo5;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-always-on;
+   };
+
+   ldo6_reg: LDO6 {
+   regulator-name = vdd_ldo6;
+   regulator-min-microvolt = 100;
+   regulator-max-microvolt = 100;
+   regulator-always-on;
+   };
+
+   ldo7_reg: LDO7 {
+   regulator-name = vdd_ldo7;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-always-on;
+   };
+
+   ldo8_reg: LDO8 {
+   regulator-name = vdd_ldo8;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-always-on;
+   };
+
+   ldo9_reg: LDO9 {
+   regulator-name = vdd_ldo9;
+   regulator-min-microvolt = 300;
+   regulator-max-microvolt = 300;
+   regulator-always-on;
+   };
+
+   ldo10_reg: LDO10 {
+   regulator-name = vdd_ldo10;
+   regulator-min-microvolt = 180;
+   regulator-max-microvolt = 180;
+   regulator-always-on;
+   };
+
+   ldo11_reg: LDO11 {
+   regulator-name = vdd_ldo11;
+   regulator-min-microvolt = 100;
+   regulator-max-microvolt = 100;
+   regulator-always-on;
+   };
+
+   ldo12_reg: LDO12 {
+   regulator-name = vdd_ldo12;
+   regulator-min-microvolt = 180;
+