Re: [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node
Thanks for pointing out this, Tomasz. I'll use those patches instead. Regards, Alex On Sat, Dec 14, 2013 at 9:24 PM, Tomasz Figa wrote: > Hi Alex, > > On Saturday 14 of December 2013 13:21:30 Alex Ling wrote: >> This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc >> node. Without this patch, dwmmc host driver will skip enabling the >> two clocks and it will break dwmmc host function on exynos4412. >> Tested on FriendlyARM TINY4412 board. >> >> Signed-off-by: Alex Ling >> --- >> Changes for v2: >>- Fix patch description as Mark Rutland suggested >> >> arch/arm/boot/dts/exynos4412.dtsi |2 ++ >> 1 file changed, 2 insertions(+) > > The patch is correct, but unfortunately it's not the only thing that > is wrong with MSHC device tree node for Exynos4x12. > > Please refer to my series fixing DW-MSHC support on Exynos4x12 (and > enabling it on TRATS2 board): > http://www.spinics.net/lists/arm-kernel/msg293652.html > > Best regards, > Tomasz > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node
Hi Alex, On Saturday 14 of December 2013 13:21:30 Alex Ling wrote: > This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc > node. Without this patch, dwmmc host driver will skip enabling the > two clocks and it will break dwmmc host function on exynos4412. > Tested on FriendlyARM TINY4412 board. > > Signed-off-by: Alex Ling > --- > Changes for v2: >- Fix patch description as Mark Rutland suggested > > arch/arm/boot/dts/exynos4412.dtsi |2 ++ > 1 file changed, 2 insertions(+) The patch is correct, but unfortunately it's not the only thing that is wrong with MSHC device tree node for Exynos4x12. Please refer to my series fixing DW-MSHC support on Exynos4x12 (and enabling it on TRATS2 board): http://www.spinics.net/lists/arm-kernel/msg293652.html Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node
This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc node. Without this patch, dwmmc host driver will skip enabling the two clocks and it will break dwmmc host function on exynos4412. Tested on FriendlyARM TINY4412 board. Signed-off-by: Alex Ling --- Changes for v2: - Fix patch description as Mark Rutland suggested arch/arm/boot/dts/exynos4412.dtsi |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi index e743e67..67bef99 100644 --- a/arch/arm/boot/dts/exynos4412.dtsi +++ b/arch/arm/boot/dts/exynos4412.dtsi @@ -67,5 +67,7 @@ interrupts = <0 77 0>; #address-cells = <1>; #size-cells = <0>; + clocks = <&clock 301>, <&clock 149>; + clock-names = "biu", "ciu"; }; }; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
