Re: [PATCH v3 09/16] dts: Documentation: Extending documentation entry for exynos-thermal

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:41:07PM +0100, Lukasz Majewski wrote:
 Properties necessary for providing Exynos thermal configuration via device
 tree.
 
 Signed-off-by: Lukasz Majewski l.majew...@samsung.com
 ---
 Changes for v3:
 - New patch
 
 ---
  .../devicetree/bindings/thermal/exynos-thermal.txt  | 17 
 +
  1 file changed, 17 insertions(+)
 
 diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt 
 b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
 index ae738f5..0f44932 100644
 --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
 +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
 @@ -39,6 +39,18 @@
  - vtmu-supply: This entry is optional and provides the regulator node 
 supplying
   voltage to TMU. If needed this entry can be placed inside
   board/platform specific dts file.
 +Following properties are mandatory (depending on SoC):
 +- samsung,tmu_gain: Gain value for internal TMU operation.
 +- samsung,tmu_reference_voltage: Value of TMU IP block's reference voltage
 +- samsung,tmu_noise_cancel_mode: Mode for noise cancellation
 +- samsung,tmu_efuse_value: Default level of temperature - it is needed when
 +in factory fusing produced wrong value
 +- samsung,tmu_min_efuse_value: Minimum temperature fused value
 +- samsung,tmu_max_efuse_value: Maximum temperature fused value
 +- samsung,tmu_first_point_trim: First point trimming value
 +- samsung,tmu_second_point_trim: Second point trimming value
 +- samsung,tmu_default_temp_offset: Default temperature offset
 +- samsung,tmu_cal_type: Callibration type
  
  Example 1):
  
 @@ -51,6 +63,7 @@ Example 1):
   clock-names = tmu_apbif;
   status = disabled;
   vtmu-supply = tmu_regulator_node;
 + #include exynos4412-tmu-sensor-conf.dtsi
   };
  
  Example 2):
 @@ -61,6 +74,7 @@ Example 2):
   interrupts = 0 58 0;
   clocks = clock 21;
   clock-names = tmu_apbif;
 + #include exynos5440-tmu-sensor-conf.dtsi

Did I miss something or at this point the above file does not exist yet?

Please make sure each commit / patch is in a compilable/usable/working
state.

   };
  
  Example 3): (In case of Exynos5420 with misplaced TRIMINFO register)
 @@ -70,6 +84,7 @@ Example 3): (In case of Exynos5420 with misplaced TRIMINFO 
 register)
   interrupts = 0 184 0;
   clocks = clock 318, clock 318;
   clock-names = tmu_apbif, tmu_triminfo_apbif;
 + #include exynos4412-tmu-sensor-conf.dtsi
   };
  
   tmu_cpu3: tmu@1006c000 {
 @@ -78,6 +93,7 @@ Example 3): (In case of Exynos5420 with misplaced TRIMINFO 
 register)
   interrupts = 0 185 0;
   clocks = clock 318, clock 319;
   clock-names = tmu_apbif, tmu_triminfo_apbif;
 + #include exynos4412-tmu-sensor-conf.dtsi
   };
  
   tmu_gpu: tmu@100a {
 @@ -86,6 +102,7 @@ Example 3): (In case of Exynos5420 with misplaced 
 TRIMINFO register)
   interrupts = 0 215 0;
   clocks = clock 319, clock 318;
   clock-names = tmu_apbif, tmu_triminfo_apbif;
 + #include exynos4412-tmu-sensor-conf.dtsi
   };
  
  Note: For multi-instance tmu each instance should have an alias correctly
 -- 
 2.0.0.rc2
 


signature.asc
Description: Digital signature


Re: [PATCH v3 09/16] dts: Documentation: Extending documentation entry for exynos-thermal

2015-01-14 Thread Eduardo Valentin
On Wed, Jan 14, 2015 at 02:52:25PM -0400, Eduardo Valentin wrote:
 On Wed, Jan 14, 2015 at 02:41:07PM +0100, Lukasz Majewski wrote:
  Properties necessary for providing Exynos thermal configuration via device
  tree.
  
  Signed-off-by: Lukasz Majewski l.majew...@samsung.com
  ---
  Changes for v3:
  - New patch
  
  ---
   .../devicetree/bindings/thermal/exynos-thermal.txt  | 17 
  +
   1 file changed, 17 insertions(+)
  
  diff --git a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt 
  b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
  index ae738f5..0f44932 100644
  --- a/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
  +++ b/Documentation/devicetree/bindings/thermal/exynos-thermal.txt
  @@ -39,6 +39,18 @@
   - vtmu-supply: This entry is optional and provides the regulator node 
  supplying
  voltage to TMU. If needed this entry can be placed inside
  board/platform specific dts file.
  +Following properties are mandatory (depending on SoC):
  +- samsung,tmu_gain: Gain value for internal TMU operation.
  +- samsung,tmu_reference_voltage: Value of TMU IP block's reference voltage
  +- samsung,tmu_noise_cancel_mode: Mode for noise cancellation
  +- samsung,tmu_efuse_value: Default level of temperature - it is needed when
  +  in factory fusing produced wrong value
  +- samsung,tmu_min_efuse_value: Minimum temperature fused value
  +- samsung,tmu_max_efuse_value: Maximum temperature fused value
  +- samsung,tmu_first_point_trim: First point trimming value
  +- samsung,tmu_second_point_trim: Second point trimming value
  +- samsung,tmu_default_temp_offset: Default temperature offset
  +- samsung,tmu_cal_type: Callibration type
   
   Example 1):
   
  @@ -51,6 +63,7 @@ Example 1):
  clock-names = tmu_apbif;
  status = disabled;
  vtmu-supply = tmu_regulator_node;
  +   #include exynos4412-tmu-sensor-conf.dtsi
  };
   
   Example 2):
  @@ -61,6 +74,7 @@ Example 2):
  interrupts = 0 58 0;
  clocks = clock 21;
  clock-names = tmu_apbif;
  +   #include exynos5440-tmu-sensor-conf.dtsi
 
 Did I miss something or at this point the above file does not exist yet?
 
 Please make sure each commit / patch is in a compilable/usable/working
 state.

I know this is a Documentation file, but the comment above still
applies.

 
  };
   
   Example 3): (In case of Exynos5420 with misplaced TRIMINFO register)
  @@ -70,6 +84,7 @@ Example 3): (In case of Exynos5420 with misplaced 
  TRIMINFO register)
  interrupts = 0 184 0;
  clocks = clock 318, clock 318;
  clock-names = tmu_apbif, tmu_triminfo_apbif;
  +   #include exynos4412-tmu-sensor-conf.dtsi
  };
   
  tmu_cpu3: tmu@1006c000 {
  @@ -78,6 +93,7 @@ Example 3): (In case of Exynos5420 with misplaced 
  TRIMINFO register)
  interrupts = 0 185 0;
  clocks = clock 318, clock 319;
  clock-names = tmu_apbif, tmu_triminfo_apbif;
  +   #include exynos4412-tmu-sensor-conf.dtsi
  };
   
  tmu_gpu: tmu@100a {
  @@ -86,6 +102,7 @@ Example 3): (In case of Exynos5420 with misplaced 
  TRIMINFO register)
  interrupts = 0 215 0;
  clocks = clock 319, clock 318;
  clock-names = tmu_apbif, tmu_triminfo_apbif;
  +   #include exynos4412-tmu-sensor-conf.dtsi
  };
   
   Note: For multi-instance tmu each instance should have an alias correctly
  -- 
  2.0.0.rc2
  




signature.asc
Description: Digital signature