RE: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Tushar Behera wrote: > > On 05/13/2014 03:37 PM, Paul Bolle wrote: > > Kukjin, > > > > On Tue, 2014-05-13 at 12:12 +0900, Kukjin Kim wrote: > >> Tomasz Figa wrote: > >>> You mean s/sram/sysram/ in compatible strings of Exynos-specific > >>> reserved areas? If yes, I'm fine, it might be even better. Just > remember > >>> to update documentation in patch 2/2 as well. > >>> > >> Done. If any problems in my tree, please let me know. > > > > It seems this one just hit linux-next (in next-20140513) as "ARM: > > EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains > > this hunk: > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -843,6 +843,7 @@ config ARCH_EXYNOS > > select HAVE_S3C_RTC if RTC_CLASS > > select NEED_MACH_MEMORY_H > > select SPARSE_IRQ > > + select SYSRAM > > select USE_OF > > help > > Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5) > > > > But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol > > SRAM. Did you perhaps do one s/sram/sysram/ too many on the original > > patch? > > > > Also the compatible string name should be 'mmio-sram' on the DTS files. > Paul and Tushar, Thanks for the pointing out. Let me fix them, config name and compatible string. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
On 05/13/2014 03:37 PM, Paul Bolle wrote: > Kukjin, > > On Tue, 2014-05-13 at 12:12 +0900, Kukjin Kim wrote: >> Tomasz Figa wrote: >>> You mean s/sram/sysram/ in compatible strings of Exynos-specific >>> reserved areas? If yes, I'm fine, it might be even better. Just remember >>> to update documentation in patch 2/2 as well. >>> >> Done. If any problems in my tree, please let me know. > > It seems this one just hit linux-next (in next-20140513) as "ARM: > EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains > this hunk: > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -843,6 +843,7 @@ config ARCH_EXYNOS > select HAVE_S3C_RTC if RTC_CLASS > select NEED_MACH_MEMORY_H > select SPARSE_IRQ > + select SYSRAM > select USE_OF > help > Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5) > > But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol > SRAM. Did you perhaps do one s/sram/sysram/ too many on the original > patch? > Also the compatible string name should be 'mmio-sram' on the DTS files. > > Paul Bolle > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" > in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Tushar Behera -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Kukjin, On Tue, 2014-05-13 at 12:12 +0900, Kukjin Kim wrote: > Tomasz Figa wrote: > > You mean s/sram/sysram/ in compatible strings of Exynos-specific > > reserved areas? If yes, I'm fine, it might be even better. Just remember > > to update documentation in patch 2/2 as well. > > > Done. If any problems in my tree, please let me know. It seems this one just hit linux-next (in next-20140513) as "ARM: EXYNOS: Map SYSRAM through generic DT bindings". Its commit now contains this hunk: --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -843,6 +843,7 @@ config ARCH_EXYNOS select HAVE_S3C_RTC if RTC_CLASS select NEED_MACH_MEMORY_H select SPARSE_IRQ + select SYSRAM select USE_OF help Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5) But there's no Kconfig symbol SYSRAM. However, there is a Kconfig symbol SRAM. Did you perhaps do one s/sram/sysram/ too many on the original patch? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Tomasz Figa wrote: > > Hi Kukjin, > Hi, > On 09.05.2014 04:14, Kukjin Kim wrote: > > Tomasz Figa wrote: > >> > >> Hi Sachin, > >> > >> On 08.05.2014 06:16, Sachin Kamat wrote: > >>> Instead of hardcoding the SYSRAM details for each SoC, > >>> pass this information through device tree (DT) and make > >>> the code SoC agnostic. Generic SRAM bindings are used > >>> for achieving this. > >>> > >>> Signed-off-by: Sachin Kamat > >>> Acked-by: Arnd Bergmann > >>> Acked-by: Heiko Stuebner > >>> --- > >>> Changes since v2. > >>> * Updated sysram node for Universal C210 board - Thanks to > >>> Tomasz Figa for testing and updating the same. > >>> * Added error handling code. > >>> * Break if matching node found. > >>> * Remove unnecessary error messages. > >>> > >>> This patch is based on linux next (next-20140501) on top of > >>> my Kconfig consolidation patch > >>> http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642 > >>> > >>> Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards. > >>> --- > >>> arch/arm/Kconfig|1 + > >>> arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++ > >>> arch/arm/boot/dts/exynos4210.dtsi | 18 +++ > >>> arch/arm/boot/dts/exynos4x12.dtsi | 18 +++ > >>> arch/arm/boot/dts/exynos5250.dtsi | 18 +++ > >>> arch/arm/boot/dts/exynos5420.dtsi | 18 +++ > >>> arch/arm/mach-exynos/common.h |1 + > >>> arch/arm/mach-exynos/exynos.c | 64 > > -- > >> - > >>> arch/arm/mach-exynos/firmware.c |8 ++- > >>> arch/arm/mach-exynos/include/mach/map.h |7 --- > >>> arch/arm/mach-exynos/platsmp.c | 56 > > ++-- > >>> 11 files changed, 148 insertions(+), 76 deletions(-) > >>> > >> > >> Looks good, thanks. > >> > >> Reviewed-by: Tomasz Figa > >> > > Looks good to me but I think, we need to change the name of 'sram' > because > > it can cause some confusing, actually it is not matching _real_ sram > area on > > the SoCs. When we upstreamed regarding patch, I decided the name to use > > 'SYSRAM', it was called another name in datasheet though. So, I'd like > to > > use 'sysram' instead of 'sram' as we used before. > > > > I will change the name when I apply this series in this weekend, if you > guys > > have no objection. > > You mean s/sram/sysram/ in compatible strings of Exynos-specific > reserved areas? If yes, I'm fine, it might be even better. Just remember > to update documentation in patch 2/2 as well. > Done. If any problems in my tree, please let me know. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
On 05/09/14 13:49, Tomasz Figa wrote: Hi Kukjin, Hi Tomasz, On 09.05.2014 04:14, Kukjin Kim wrote: Tomasz Figa wrote: Hi Sachin, On 08.05.2014 06:16, Sachin Kamat wrote: Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this. Signed-off-by: Sachin Kamat Acked-by: Arnd Bergmann Acked-by: Heiko Stuebner --- Changes since v2. * Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same. * Added error handling code. * Break if matching node found. * Remove unnecessary error messages. This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642 Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards. --- arch/arm/Kconfig | 1 + arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++ arch/arm/boot/dts/exynos4210.dtsi | 18 +++ arch/arm/boot/dts/exynos4x12.dtsi | 18 +++ arch/arm/boot/dts/exynos5250.dtsi | 18 +++ arch/arm/boot/dts/exynos5420.dtsi | 18 +++ arch/arm/mach-exynos/common.h | 1 + arch/arm/mach-exynos/exynos.c | 64 -- - arch/arm/mach-exynos/firmware.c | 8 ++- arch/arm/mach-exynos/include/mach/map.h | 7 --- arch/arm/mach-exynos/platsmp.c | 56 ++-- 11 files changed, 148 insertions(+), 76 deletions(-) Looks good, thanks. Reviewed-by: Tomasz Figa Looks good to me but I think, we need to change the name of 'sram' because it can cause some confusing, actually it is not matching _real_ sram area on the SoCs. When we upstreamed regarding patch, I decided the name to use 'SYSRAM', it was called another name in datasheet though. So, I'd like to use 'sysram' instead of 'sram' as we used before. I will change the name when I apply this series in this weekend, if you guys have no objection. You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just remember to update documentation in patch 2/2 as well. Yes, of course ;-) - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Hi Kukjin, On 09.05.2014 04:14, Kukjin Kim wrote: Tomasz Figa wrote: Hi Sachin, On 08.05.2014 06:16, Sachin Kamat wrote: Instead of hardcoding the SYSRAM details for each SoC, pass this information through device tree (DT) and make the code SoC agnostic. Generic SRAM bindings are used for achieving this. Signed-off-by: Sachin Kamat Acked-by: Arnd Bergmann Acked-by: Heiko Stuebner --- Changes since v2. * Updated sysram node for Universal C210 board - Thanks to Tomasz Figa for testing and updating the same. * Added error handling code. * Break if matching node found. * Remove unnecessary error messages. This patch is based on linux next (next-20140501) on top of my Kconfig consolidation patch http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642 Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards. --- arch/arm/Kconfig|1 + arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++ arch/arm/boot/dts/exynos4210.dtsi | 18 +++ arch/arm/boot/dts/exynos4x12.dtsi | 18 +++ arch/arm/boot/dts/exynos5250.dtsi | 18 +++ arch/arm/boot/dts/exynos5420.dtsi | 18 +++ arch/arm/mach-exynos/common.h |1 + arch/arm/mach-exynos/exynos.c | 64 -- - arch/arm/mach-exynos/firmware.c |8 ++- arch/arm/mach-exynos/include/mach/map.h |7 --- arch/arm/mach-exynos/platsmp.c | 56 ++-- 11 files changed, 148 insertions(+), 76 deletions(-) Looks good, thanks. Reviewed-by: Tomasz Figa Looks good to me but I think, we need to change the name of 'sram' because it can cause some confusing, actually it is not matching _real_ sram area on the SoCs. When we upstreamed regarding patch, I decided the name to use 'SYSRAM', it was called another name in datasheet though. So, I'd like to use 'sysram' instead of 'sram' as we used before. I will change the name when I apply this series in this weekend, if you guys have no objection. You mean s/sram/sysram/ in compatible strings of Exynos-specific reserved areas? If yes, I'm fine, it might be even better. Just remember to update documentation in patch 2/2 as well. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Tomasz Figa wrote: > > Hi Sachin, > > On 08.05.2014 06:16, Sachin Kamat wrote: > > Instead of hardcoding the SYSRAM details for each SoC, > > pass this information through device tree (DT) and make > > the code SoC agnostic. Generic SRAM bindings are used > > for achieving this. > > > > Signed-off-by: Sachin Kamat > > Acked-by: Arnd Bergmann > > Acked-by: Heiko Stuebner > > --- > > Changes since v2. > > * Updated sysram node for Universal C210 board - Thanks to > > Tomasz Figa for testing and updating the same. > > * Added error handling code. > > * Break if matching node found. > > * Remove unnecessary error messages. > > > > This patch is based on linux next (next-20140501) on top of > > my Kconfig consolidation patch > > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642 > > > > Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards. > > --- > > arch/arm/Kconfig|1 + > > arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++ > > arch/arm/boot/dts/exynos4210.dtsi | 18 +++ > > arch/arm/boot/dts/exynos4x12.dtsi | 18 +++ > > arch/arm/boot/dts/exynos5250.dtsi | 18 +++ > > arch/arm/boot/dts/exynos5420.dtsi | 18 +++ > > arch/arm/mach-exynos/common.h |1 + > > arch/arm/mach-exynos/exynos.c | 64 -- > - > > arch/arm/mach-exynos/firmware.c |8 ++- > > arch/arm/mach-exynos/include/mach/map.h |7 --- > > arch/arm/mach-exynos/platsmp.c | 56 ++-- > > 11 files changed, 148 insertions(+), 76 deletions(-) > > > > Looks good, thanks. > > Reviewed-by: Tomasz Figa > Looks good to me but I think, we need to change the name of 'sram' because it can cause some confusing, actually it is not matching _real_ sram area on the SoCs. When we upstreamed regarding patch, I decided the name to use 'SYSRAM', it was called another name in datasheet though. So, I'd like to use 'sysram' instead of 'sram' as we used before. I will change the name when I apply this series in this weekend, if you guys have no objection. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Hi Sachin, On 08.05.2014 06:16, Sachin Kamat wrote: > Instead of hardcoding the SYSRAM details for each SoC, > pass this information through device tree (DT) and make > the code SoC agnostic. Generic SRAM bindings are used > for achieving this. > > Signed-off-by: Sachin Kamat > Acked-by: Arnd Bergmann > Acked-by: Heiko Stuebner > --- > Changes since v2. > * Updated sysram node for Universal C210 board - Thanks to > Tomasz Figa for testing and updating the same. > * Added error handling code. > * Break if matching node found. > * Remove unnecessary error messages. > > This patch is based on linux next (next-20140501) on top of > my Kconfig consolidation patch > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642 > > Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards. > --- > arch/arm/Kconfig|1 + > arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++ > arch/arm/boot/dts/exynos4210.dtsi | 18 +++ > arch/arm/boot/dts/exynos4x12.dtsi | 18 +++ > arch/arm/boot/dts/exynos5250.dtsi | 18 +++ > arch/arm/boot/dts/exynos5420.dtsi | 18 +++ > arch/arm/mach-exynos/common.h |1 + > arch/arm/mach-exynos/exynos.c | 64 > --- > arch/arm/mach-exynos/firmware.c |8 ++- > arch/arm/mach-exynos/include/mach/map.h |7 --- > arch/arm/mach-exynos/platsmp.c | 56 ++-- > 11 files changed, 148 insertions(+), 76 deletions(-) > Looks good, thanks. Reviewed-by: Tomasz Figa -- Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Instead of hardcoding the SYSRAM details for each SoC,
pass this information through device tree (DT) and make
the code SoC agnostic. Generic SRAM bindings are used
for achieving this.
Signed-off-by: Sachin Kamat
Acked-by: Arnd Bergmann
Acked-by: Heiko Stuebner
---
Changes since v2.
* Updated sysram node for Universal C210 board - Thanks to
Tomasz Figa for testing and updating the same.
* Added error handling code.
* Break if matching node found.
* Remove unnecessary error messages.
This patch is based on linux next (next-20140501) on top of
my Kconfig consolidation patch
http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642
Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.
---
arch/arm/Kconfig|1 +
arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++
arch/arm/boot/dts/exynos4210.dtsi | 18 +++
arch/arm/boot/dts/exynos4x12.dtsi | 18 +++
arch/arm/boot/dts/exynos5250.dtsi | 18 +++
arch/arm/boot/dts/exynos5420.dtsi | 18 +++
arch/arm/mach-exynos/common.h |1 +
arch/arm/mach-exynos/exynos.c | 64 ---
arch/arm/mach-exynos/firmware.c |8 ++-
arch/arm/mach-exynos/include/mach/map.h |7 ---
arch/arm/mach-exynos/platsmp.c | 56 ++--
11 files changed, 148 insertions(+), 76 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index a6d19b1a..f66ea9453df9 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -855,6 +855,7 @@ config ARCH_EXYNOS
select S5P_DEV_MFC
select SAMSUNG_DMADEV
select SPARSE_IRQ
+ select SRAM
select USE_OF
help
Support for SAMSUNG's EXYNOS SoCs (EXYNOS4/5)
diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts
b/arch/arm/boot/dts/exynos4210-universal_c210.dts
index 63e34b24b04f..a62c0ff25917 100644
--- a/arch/arm/boot/dts/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/exynos4210-universal_c210.dts
@@ -28,6 +28,21 @@
bootargs = "console=ttySAC2,115200N8 root=/dev/mmcblk0p5 rw
rootwait earlyprintk panic=5 maxcpus=1";
};
+ sram@0202 {
+ smp-sram@0 {
+ status = "disabled";
+ };
+
+ smp-sram@5000 {
+ compatible = "samsung,exynos4210-sram";
+ reg = <0x5000 0x1000>;
+ };
+
+ smp-sram@1f000 {
+ status = "disabled";
+ };
+ };
+
mct@1005 {
compatible = "none";
};
diff --git a/arch/arm/boot/dts/exynos4210.dtsi
b/arch/arm/boot/dts/exynos4210.dtsi
index cacf6140dd2f..d3d727b0c263 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -31,6 +31,24 @@
pinctrl2 = &pinctrl_2;
};
+ sram@0202 {
+ compatible = "mmio-sram";
+ reg = <0x0202 0x2>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x0202 0x2>;
+
+ smp-sram@0 {
+ compatible = "samsung,exynos4210-sram";
+ reg = <0x0 0x1000>;
+ };
+
+ smp-sram@1f000 {
+ compatible = "samsung,exynos4210-sram-ns";
+ reg = <0x1f000 0x1000>;
+ };
+ };
+
pd_lcd1: lcd1-power-domain@10023CA0 {
compatible = "samsung,exynos4210-pd";
reg = <0x10023CA0 0x20>;
diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
b/arch/arm/boot/dts/exynos4x12.dtsi
index c4a9306f8529..75fb3e7e3999 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -37,6 +37,24 @@
interrupts = <2 2>, <3 2>, <18 2>, <19 2>;
};
+ sram@0202 {
+ compatible = "mmio-sram";
+ reg = <0x0202 0x4>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x0202 0x4>;
+
+ smp-sram@0 {
+ compatible = "samsung,exynos4210-sram";
+ reg = <0x0 0x1000>;
+ };
+
+ smp-sram@2f000 {
+ compatible = "samsung,exynos4210-sram-ns";
+ reg = <0x2f000 0x1000>;
+ };
+ };
+
pd_isp: isp-power-domain@10023CA0 {
compatible = "samsung,exynos4210-pd";
reg = <0x10023CA0 0x20>;
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 37423314a028..8d724d56a5c6 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -72,6 +72,24 @@
};
};
+ sram@0202
