Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
On 08-08-15, 00:21, Rafael J. Wysocki wrote: > > Acked-by: Viresh Kumar > > And what exactly am I supposed to do with this? > > Have a robot that will pick up all patches ACKed by you magically or what? :) That's why I have asked Bartlomiej specifically to send it separately to the pm list as a cpufreq patch. I wasn't expecting you to apply right from here. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
On Friday, August 07, 2015 05:07:39 PM Viresh Kumar wrote:
> On 07-08-15, 13:12, Bartlomiej Zolnierkiewicz wrote:
> > >From 993ebb6fc632ec7b61654c9610c90ff4dca4be34 Mon Sep 17 00:00:00 2001
> > From: Bartlomiej Zolnierkiewicz
> > Date: Fri, 7 Aug 2015 13:07:51 +0200
> > Subject: [PATCH] cpufreq-dt: make scaling_boost_freqs sysfs attr available
> > when boost is enabled
> >
> > Make scaling_boost_freqs sysfs attribute is available when
> > cpufreq-dt driver is used and boost support is enabled.
> >
> > Cc: Thomas Abraham
> > Cc: Javier Martinez Canillas
> > Cc: Krzysztof Kozlowski
> > Suggested-by: Viresh Kumar
> > Signed-off-by: Bartlomiej Zolnierkiewicz
> > ---
> > drivers/cpufreq/cpufreq-dt.c | 11 ++-
> > include/linux/cpufreq.h | 1 +
> > 2 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> > index b9259ab..c6a3b98 100644
> > --- a/drivers/cpufreq/cpufreq-dt.c
> > +++ b/drivers/cpufreq/cpufreq-dt.c
> > @@ -36,6 +36,12 @@ struct private_data {
> > unsigned int voltage_tolerance; /* in percentage */
> > };
> >
> > +static struct freq_attr *cpufreq_dt_attr[] = {
> > + &cpufreq_freq_attr_scaling_available_freqs,
> > + NULL, /* Extra space for boost-attr if required */
> > + NULL,
> > +};
> > +
> > static int set_target(struct cpufreq_policy *policy, unsigned int index)
> > {
> > struct dev_pm_opp *opp;
> > @@ -182,6 +188,8 @@ try_again:
> > return ret;
> > }
> >
> > +static struct cpufreq_driver dt_cpufreq_driver;
> > +
> > static int cpufreq_init(struct cpufreq_policy *policy)
> > {
> > struct cpufreq_frequency_table *freq_table;
> > @@ -336,6 +344,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> > ret = cpufreq_enable_boost_support();
> > if (ret)
> > goto out_free_cpufreq_table;
> > + cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs;
> > }
> >
> > policy->cpuinfo.transition_latency = transition_latency;
> > @@ -411,7 +420,7 @@ static struct cpufreq_driver dt_cpufreq_driver = {
> > .exit = cpufreq_exit,
> > .ready = cpufreq_ready,
> > .name = "cpufreq-dt",
> > - .attr = cpufreq_generic_attr,
> > + .attr = cpufreq_dt_attr,
> > };
> >
> > static int dt_cpufreq_probe(struct platform_device *pdev)
> > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > index 95f0186..657542d 100644
> > --- a/include/linux/cpufreq.h
> > +++ b/include/linux/cpufreq.h
> > @@ -609,6 +609,7 @@ struct cpufreq_frequency_table
> > *cpufreq_frequency_get_table(unsigned int cpu);
> >
> > /* the following are really really optional */
> > extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs;
> > +extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs;
> > extern struct freq_attr *cpufreq_generic_attr[];
> > int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,
> > struct cpufreq_frequency_table *table);
>
> Acked-by: Viresh Kumar
And what exactly am I supposed to do with this?
Have a robot that will pick up all patches ACKed by you magically or what?
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
On 07-08-15, 13:12, Bartlomiej Zolnierkiewicz wrote:
> >From 993ebb6fc632ec7b61654c9610c90ff4dca4be34 Mon Sep 17 00:00:00 2001
> From: Bartlomiej Zolnierkiewicz
> Date: Fri, 7 Aug 2015 13:07:51 +0200
> Subject: [PATCH] cpufreq-dt: make scaling_boost_freqs sysfs attr available
> when boost is enabled
>
> Make scaling_boost_freqs sysfs attribute is available when
> cpufreq-dt driver is used and boost support is enabled.
>
> Cc: Thomas Abraham
> Cc: Javier Martinez Canillas
> Cc: Krzysztof Kozlowski
> Suggested-by: Viresh Kumar
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/cpufreq/cpufreq-dt.c | 11 ++-
> include/linux/cpufreq.h | 1 +
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index b9259ab..c6a3b98 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -36,6 +36,12 @@ struct private_data {
> unsigned int voltage_tolerance; /* in percentage */
> };
>
> +static struct freq_attr *cpufreq_dt_attr[] = {
> + &cpufreq_freq_attr_scaling_available_freqs,
> + NULL, /* Extra space for boost-attr if required */
> + NULL,
> +};
> +
> static int set_target(struct cpufreq_policy *policy, unsigned int index)
> {
> struct dev_pm_opp *opp;
> @@ -182,6 +188,8 @@ try_again:
> return ret;
> }
>
> +static struct cpufreq_driver dt_cpufreq_driver;
> +
> static int cpufreq_init(struct cpufreq_policy *policy)
> {
> struct cpufreq_frequency_table *freq_table;
> @@ -336,6 +344,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> ret = cpufreq_enable_boost_support();
> if (ret)
> goto out_free_cpufreq_table;
> + cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs;
> }
>
> policy->cpuinfo.transition_latency = transition_latency;
> @@ -411,7 +420,7 @@ static struct cpufreq_driver dt_cpufreq_driver = {
> .exit = cpufreq_exit,
> .ready = cpufreq_ready,
> .name = "cpufreq-dt",
> - .attr = cpufreq_generic_attr,
> + .attr = cpufreq_dt_attr,
> };
>
> static int dt_cpufreq_probe(struct platform_device *pdev)
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index 95f0186..657542d 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -609,6 +609,7 @@ struct cpufreq_frequency_table
> *cpufreq_frequency_get_table(unsigned int cpu);
>
> /* the following are really really optional */
> extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs;
> +extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs;
> extern struct freq_attr *cpufreq_generic_attr[];
> int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,
> struct cpufreq_frequency_table *table);
Acked-by: Viresh Kumar
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
On Friday, August 07, 2015 04:11:56 PM Viresh Kumar wrote:
> On 07-08-15, 12:34, Bartlomiej Zolnierkiewicz wrote:
> > > I would suggest you sending such patches as reply to the earlier
> > > threads only, instead of a new chain. This will save your time.
> >
> > Please explain it more. This patch needs to be first for cpufreq-dt
> > switch to be complete. scaling_boost_freqs is available currently
> > for exynos-cpufreq users when boost is enabled and ideally we would
> > like it to be available immediately after the switch to cpufreq-dt.
>
> I wasn't talking about the ordering of the patches here, but when to
> send patches.
>
> So, you now sent these patches again, but what you could have done
> is: only send the first patch in reply to the earlier thread. And ask
> if it looks fine. If yes, resend the whole series properly or keep
> fixing there only..
>
> That makes things really fast. You don't have to resend the series and
> people wouldn't stay away from it. I stayed away from this series to
> find enough available time to see your 6 patches. Had it been just a
> reply, I would have replied immediately like now.
>
> Look at how updated versions in the same mail chain in case of OPP
> series..
Please find updated patch below. It can be moved just before
patch #6 and all patches in the series would still apply fine.
-8<---
>From 993ebb6fc632ec7b61654c9610c90ff4dca4be34 Mon Sep 17 00:00:00 2001
From: Bartlomiej Zolnierkiewicz
Date: Fri, 7 Aug 2015 13:07:51 +0200
Subject: [PATCH] cpufreq-dt: make scaling_boost_freqs sysfs attr available
when boost is enabled
Make scaling_boost_freqs sysfs attribute is available when
cpufreq-dt driver is used and boost support is enabled.
Cc: Thomas Abraham
Cc: Javier Martinez Canillas
Cc: Krzysztof Kozlowski
Suggested-by: Viresh Kumar
Signed-off-by: Bartlomiej Zolnierkiewicz
---
drivers/cpufreq/cpufreq-dt.c | 11 ++-
include/linux/cpufreq.h | 1 +
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index b9259ab..c6a3b98 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -36,6 +36,12 @@ struct private_data {
unsigned int voltage_tolerance; /* in percentage */
};
+static struct freq_attr *cpufreq_dt_attr[] = {
+ &cpufreq_freq_attr_scaling_available_freqs,
+ NULL, /* Extra space for boost-attr if required */
+ NULL,
+};
+
static int set_target(struct cpufreq_policy *policy, unsigned int index)
{
struct dev_pm_opp *opp;
@@ -182,6 +188,8 @@ try_again:
return ret;
}
+static struct cpufreq_driver dt_cpufreq_driver;
+
static int cpufreq_init(struct cpufreq_policy *policy)
{
struct cpufreq_frequency_table *freq_table;
@@ -336,6 +344,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
ret = cpufreq_enable_boost_support();
if (ret)
goto out_free_cpufreq_table;
+ cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs;
}
policy->cpuinfo.transition_latency = transition_latency;
@@ -411,7 +420,7 @@ static struct cpufreq_driver dt_cpufreq_driver = {
.exit = cpufreq_exit,
.ready = cpufreq_ready,
.name = "cpufreq-dt",
- .attr = cpufreq_generic_attr,
+ .attr = cpufreq_dt_attr,
};
static int dt_cpufreq_probe(struct platform_device *pdev)
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 95f0186..657542d 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -609,6 +609,7 @@ struct cpufreq_frequency_table
*cpufreq_frequency_get_table(unsigned int cpu);
/* the following are really really optional */
extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs;
+extern struct freq_attr cpufreq_freq_attr_scaling_boost_freqs;
extern struct freq_attr *cpufreq_generic_attr[];
int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,
struct cpufreq_frequency_table *table);
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
On 07-08-15, 12:34, Bartlomiej Zolnierkiewicz wrote: > > I would suggest you sending such patches as reply to the earlier > > threads only, instead of a new chain. This will save your time. > > Please explain it more. This patch needs to be first for cpufreq-dt > switch to be complete. scaling_boost_freqs is available currently > for exynos-cpufreq users when boost is enabled and ideally we would > like it to be available immediately after the switch to cpufreq-dt. I wasn't talking about the ordering of the patches here, but when to send patches. So, you now sent these patches again, but what you could have done is: only send the first patch in reply to the earlier thread. And ask if it looks fine. If yes, resend the whole series properly or keep fixing there only.. That makes things really fast. You don't have to resend the series and people wouldn't stay away from it. I stayed away from this series to find enough available time to see your 6 patches. Had it been just a reply, I would have replied immediately like now. Look at how updated versions in the same mail chain in case of OPP series.. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
Hi,
On Friday, August 07, 2015 09:11:28 AM Viresh Kumar wrote:
> Hi,
>
> I would suggest you sending such patches as reply to the earlier
> threads only, instead of a new chain. This will save your time.
Please explain it more. This patch needs to be first for cpufreq-dt
switch to be complete. scaling_boost_freqs is available currently
for exynos-cpufreq users when boost is enabled and ideally we would
like it to be available immediately after the switch to cpufreq-dt.
> For example, you will need to resend other patches unnecessarily if I
> NAK this patch :)
>
> On 06-08-15, 15:41, Bartlomiej Zolnierkiewicz wrote:
> > Add cpufreq_boost_enabled_generic_attr table and use it in
> > cpufreq-dt driver instead of cpufreq_generic_attr one when
> > boost support is enabled. As a result scaling_boost_freqs
> > sysfs attribute is available when cpufreq-dt driver is
> > used and boost support is enabled.
> >
> > Cc: Viresh Kumar
> > Cc: Thomas Abraham
> > Cc: Javier Martinez Canillas
> > Cc: Krzysztof Kozlowski
> > Signed-off-by: Bartlomiej Zolnierkiewicz
> > ---
> > drivers/cpufreq/cpufreq-dt.c | 3 +++
> > drivers/cpufreq/freq_table.c | 7 +++
> > include/linux/cpufreq.h | 1 +
> > 3 files changed, 11 insertions(+)
> >
> > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> > index b9259ab..7b091c0 100644
> > --- a/drivers/cpufreq/cpufreq-dt.c
> > +++ b/drivers/cpufreq/cpufreq-dt.c
> > @@ -182,6 +182,8 @@ try_again:
> > return ret;
> > }
> >
> > +static struct cpufreq_driver dt_cpufreq_driver;
> > +
> > static int cpufreq_init(struct cpufreq_policy *policy)
> > {
> > struct cpufreq_frequency_table *freq_table;
> > @@ -336,6 +338,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> > ret = cpufreq_enable_boost_support();
> > if (ret)
> > goto out_free_cpufreq_table;
> > + dt_cpufreq_driver.attr = cpufreq_boost_enabled_generic_attr;
> > }
> >
> > policy->cpuinfo.transition_latency = transition_latency;
> > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> > index a8f1daf..5a00a09 100644
> > --- a/drivers/cpufreq/freq_table.c
> > +++ b/drivers/cpufreq/freq_table.c
> > @@ -300,6 +300,13 @@ struct freq_attr *cpufreq_generic_attr[] = {
> > };
> > EXPORT_SYMBOL_GPL(cpufreq_generic_attr);
> >
> > +struct freq_attr *cpufreq_boost_enabled_generic_attr[] = {
> > + &cpufreq_freq_attr_scaling_available_freqs,
> > + &cpufreq_freq_attr_scaling_boost_freqs,
> > + NULL,
> > +};
> > +EXPORT_SYMBOL_GPL(cpufreq_boost_enabled_generic_attr);
>
> This isn't scalable. We can't create a new generic structure every time
> a entry comes in. Rather we should leave the generic attr for
boost entry is rather generic one so I imagine that other cpufreq
drivers that add support for boost would also like to use it.
Anyway since there are no such drivers currently I agree that
making a new generic structure may be premature and I will re-do
this patch according to your request.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> cpufreq-dt and do something like this in the cpufreq-dt driver (And
> that patch should rather go via cpufreq tree and not ARM SoC)..
>
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index a5b6a854661f..e229258ad791 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -36,6 +36,12 @@ struct private_data {
> unsigned int voltage_tolerance; /* in percentage */
> };
>
> +static struct freq_attr *cpufreq_dt_attr[] = {
> + &cpufreq_freq_attr_scaling_available_freqs,
> + NULL, /* Extra space for boost-attr if required */
> + NULL,
> +};
> +
> static int set_target(struct cpufreq_policy *policy, unsigned int index)
> {
> struct dev_pm_opp *opp;
> @@ -337,6 +343,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> ret = cpufreq_enable_boost_support();
> if (ret)
> goto out_free_cpufreq_table;
> + cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs;
> }
>
> policy->cpuinfo.transition_latency = transition_latency;
> @@ -412,7 +419,7 @@ static struct cpufreq_driver dt_cpufreq_driver = {
> .exit = cpufreq_exit,
> .ready = cpufreq_ready,
> .name = "cpufreq-dt",
> - .attr = cpufreq_generic_attr,
> + .attr = cpufreq_dt_attr,
> };
>
> static int dt_cpufreq_probe(struct platform_device *pdev)
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
Hi,
I would suggest you sending such patches as reply to the earlier
threads only, instead of a new chain. This will save your time.
For example, you will need to resend other patches unnecessarily if I
NAK this patch :)
On 06-08-15, 15:41, Bartlomiej Zolnierkiewicz wrote:
> Add cpufreq_boost_enabled_generic_attr table and use it in
> cpufreq-dt driver instead of cpufreq_generic_attr one when
> boost support is enabled. As a result scaling_boost_freqs
> sysfs attribute is available when cpufreq-dt driver is
> used and boost support is enabled.
>
> Cc: Viresh Kumar
> Cc: Thomas Abraham
> Cc: Javier Martinez Canillas
> Cc: Krzysztof Kozlowski
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/cpufreq/cpufreq-dt.c | 3 +++
> drivers/cpufreq/freq_table.c | 7 +++
> include/linux/cpufreq.h | 1 +
> 3 files changed, 11 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index b9259ab..7b091c0 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -182,6 +182,8 @@ try_again:
> return ret;
> }
>
> +static struct cpufreq_driver dt_cpufreq_driver;
> +
> static int cpufreq_init(struct cpufreq_policy *policy)
> {
> struct cpufreq_frequency_table *freq_table;
> @@ -336,6 +338,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
> ret = cpufreq_enable_boost_support();
> if (ret)
> goto out_free_cpufreq_table;
> + dt_cpufreq_driver.attr = cpufreq_boost_enabled_generic_attr;
> }
>
> policy->cpuinfo.transition_latency = transition_latency;
> diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
> index a8f1daf..5a00a09 100644
> --- a/drivers/cpufreq/freq_table.c
> +++ b/drivers/cpufreq/freq_table.c
> @@ -300,6 +300,13 @@ struct freq_attr *cpufreq_generic_attr[] = {
> };
> EXPORT_SYMBOL_GPL(cpufreq_generic_attr);
>
> +struct freq_attr *cpufreq_boost_enabled_generic_attr[] = {
> + &cpufreq_freq_attr_scaling_available_freqs,
> + &cpufreq_freq_attr_scaling_boost_freqs,
> + NULL,
> +};
> +EXPORT_SYMBOL_GPL(cpufreq_boost_enabled_generic_attr);
This isn't scalable. We can't create a new generic structure every time
a entry comes in. Rather we should leave the generic attr for
cpufreq-dt and do something like this in the cpufreq-dt driver (And
that patch should rather go via cpufreq tree and not ARM SoC)..
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index a5b6a854661f..e229258ad791 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -36,6 +36,12 @@ struct private_data {
unsigned int voltage_tolerance; /* in percentage */
};
+static struct freq_attr *cpufreq_dt_attr[] = {
+ &cpufreq_freq_attr_scaling_available_freqs,
+ NULL, /* Extra space for boost-attr if required */
+ NULL,
+};
+
static int set_target(struct cpufreq_policy *policy, unsigned int index)
{
struct dev_pm_opp *opp;
@@ -337,6 +343,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
ret = cpufreq_enable_boost_support();
if (ret)
goto out_free_cpufreq_table;
+ cpufreq_dt_attr[1] = &cpufreq_freq_attr_scaling_boost_freqs;
}
policy->cpuinfo.transition_latency = transition_latency;
@@ -412,7 +419,7 @@ static struct cpufreq_driver dt_cpufreq_driver = {
.exit = cpufreq_exit,
.ready = cpufreq_ready,
.name = "cpufreq-dt",
- .attr = cpufreq_generic_attr,
+ .attr = cpufreq_dt_attr,
};
static int dt_cpufreq_probe(struct platform_device *pdev)
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled
Add cpufreq_boost_enabled_generic_attr table and use it in
cpufreq-dt driver instead of cpufreq_generic_attr one when
boost support is enabled. As a result scaling_boost_freqs
sysfs attribute is available when cpufreq-dt driver is
used and boost support is enabled.
Cc: Viresh Kumar
Cc: Thomas Abraham
Cc: Javier Martinez Canillas
Cc: Krzysztof Kozlowski
Signed-off-by: Bartlomiej Zolnierkiewicz
---
drivers/cpufreq/cpufreq-dt.c | 3 +++
drivers/cpufreq/freq_table.c | 7 +++
include/linux/cpufreq.h | 1 +
3 files changed, 11 insertions(+)
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index b9259ab..7b091c0 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -182,6 +182,8 @@ try_again:
return ret;
}
+static struct cpufreq_driver dt_cpufreq_driver;
+
static int cpufreq_init(struct cpufreq_policy *policy)
{
struct cpufreq_frequency_table *freq_table;
@@ -336,6 +338,7 @@ static int cpufreq_init(struct cpufreq_policy *policy)
ret = cpufreq_enable_boost_support();
if (ret)
goto out_free_cpufreq_table;
+ dt_cpufreq_driver.attr = cpufreq_boost_enabled_generic_attr;
}
policy->cpuinfo.transition_latency = transition_latency;
diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
index a8f1daf..5a00a09 100644
--- a/drivers/cpufreq/freq_table.c
+++ b/drivers/cpufreq/freq_table.c
@@ -300,6 +300,13 @@ struct freq_attr *cpufreq_generic_attr[] = {
};
EXPORT_SYMBOL_GPL(cpufreq_generic_attr);
+struct freq_attr *cpufreq_boost_enabled_generic_attr[] = {
+ &cpufreq_freq_attr_scaling_available_freqs,
+ &cpufreq_freq_attr_scaling_boost_freqs,
+ NULL,
+};
+EXPORT_SYMBOL_GPL(cpufreq_boost_enabled_generic_attr);
+
int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,
struct cpufreq_frequency_table *table)
{
diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
index 95f0186..25937ff 100644
--- a/include/linux/cpufreq.h
+++ b/include/linux/cpufreq.h
@@ -610,6 +610,7 @@ struct cpufreq_frequency_table
*cpufreq_frequency_get_table(unsigned int cpu);
/* the following are really really optional */
extern struct freq_attr cpufreq_freq_attr_scaling_available_freqs;
extern struct freq_attr *cpufreq_generic_attr[];
+extern struct freq_attr *cpufreq_boost_enabled_generic_attr[];
int cpufreq_table_validate_and_show(struct cpufreq_policy *policy,
struct cpufreq_frequency_table *table);
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
