Re: [RESEND PATCH v5 0/8] Add support for Exynos SROM Controller driver
Hi Krzysztof, On Thursday 17 December 2015 10:44 AM, Krzysztof Kozlowski wrote: > On 12.12.2015 16:43, Pankaj Dubey wrote: >> THIS IS A RESEND OF ONCE MERGED INTO kgene/for-next AND LOST PATCHES >> >> Series v5 got merged in kgene/for-next but due to last moment change before >> pull >> these patches were not accepted during 4.3 merge window.After that >> kgene/for-next >> got rebased over 4.4-rc1 these patches got dropped into another branch and >> till >> date not included to for-next. >> >> Since then due to minor change in "drivers/soc/", patches are not getting >> applied >> cleanly so rebasing on current for-next and resending all these with fix in >> memory >> mapping included. >> >> >> This patch set adds support for Exynos SROM controller DT based driver. >> Currently SROM register sets are used only during S2R, so driver >> basically added for taking care of S2R. It will help us in removing >> static mapping from exynos.c and other extra code handline during S2R. >> >> This patch set also updated exynos4 and exynos5 dtsi files for with device >> node for srom, and added binding documentation for the same. >> >> First two patches are some minor cleanup in mach-exynos. >> >> Patchset v1 was posted here[1] >> [1]: https://lkml.org/lkml/2015/4/29/98 >> Patchset v2 was posted here[2] >> [2]: https://lkml.org/lkml/2015/8/24/125 >> Patchset v3 was posted here[3] >> [3]: https://lkml.org/lkml/2015/10/13/392 >> Patchset v3 was posted here[4] >> [4]: https://lkml.org/lkml/2015/10/19/278 >> >> This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for >> boot >> and S2R functionality. > > Let me share the plan/status: Thanks for sharing status on this. > 1. Currently Kukjin Kim is on out of office (he told me he will be back > on Christmas). > 2. I asked arm-soc people to pull my requests. > > 3. I applied this patchset to my branch: > next/stuff-late-not-split-per-branch > https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=next/stuff-late-not-split-per-branch > > 4. This branch is not pushed to linux-next. I will sort it out if my > previous pull requests get in. I will be out of office for Christmas so > depending on the timing of arm-soc/Christmas/Kukjin this may or may not > go into v4.5 (yay...). > I am fine in either way. But prefer if it goes in v4.5, just to save time in rebasing. > 5. If it does not get into v4.5, I will rebase it and proceed further > for v4.6. > > If you have any questions, please let me know. > > Best regards, > Krzysztof > > Thanks, Pankaj Dubey -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH v5 0/8] Add support for Exynos SROM Controller driver
On 12.12.2015 16:43, Pankaj Dubey wrote: > THIS IS A RESEND OF ONCE MERGED INTO kgene/for-next AND LOST PATCHES > > Series v5 got merged in kgene/for-next but due to last moment change before > pull > these patches were not accepted during 4.3 merge window.After that > kgene/for-next > got rebased over 4.4-rc1 these patches got dropped into another branch and > till > date not included to for-next. > > Since then due to minor change in "drivers/soc/", patches are not getting > applied > cleanly so rebasing on current for-next and resending all these with fix in > memory > mapping included. > > > This patch set adds support for Exynos SROM controller DT based driver. > Currently SROM register sets are used only during S2R, so driver > basically added for taking care of S2R. It will help us in removing > static mapping from exynos.c and other extra code handline during S2R. > > This patch set also updated exynos4 and exynos5 dtsi files for with device > node for srom, and added binding documentation for the same. > > First two patches are some minor cleanup in mach-exynos. > > Patchset v1 was posted here[1] > [1]: https://lkml.org/lkml/2015/4/29/98 > Patchset v2 was posted here[2] > [2]: https://lkml.org/lkml/2015/8/24/125 > Patchset v3 was posted here[3] > [3]: https://lkml.org/lkml/2015/10/13/392 > Patchset v3 was posted here[4] > [4]: https://lkml.org/lkml/2015/10/19/278 > > This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for > boot > and S2R functionality. Let me share the plan/status: 1. Currently Kukjin Kim is on out of office (he told me he will be back on Christmas). 2. I asked arm-soc people to pull my requests. 3. I applied this patchset to my branch: next/stuff-late-not-split-per-branch https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=next/stuff-late-not-split-per-branch 4. This branch is not pushed to linux-next. I will sort it out if my previous pull requests get in. I will be out of office for Christmas so depending on the timing of arm-soc/Christmas/Kukjin this may or may not go into v4.5 (yay...). 5. If it does not get into v4.5, I will rebase it and proceed further for v4.6. If you have any questions, please let me know. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RESEND PATCH v5 0/8] Add support for Exynos SROM Controller driver
Hello! > THIS IS A RESEND OF ONCE MERGED INTO kgene/for-next AND LOST PATCHES > > Series v5 got merged in kgene/for-next but due to last moment change before > pull > these patches were not accepted during 4.3 merge window.After that > kgene/for-next > got rebased over 4.4-rc1 these patches got dropped into another branch and > till > date not included to for-next. I will not strictly require it because i'd like to move on with this somehow, and if this gets merged, i'm fine with it, but if you happen to send v6, may be you should include this small bit: http://www.spinics.net/lists/linux-samsung-soc/msg49008.html ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RESEND PATCH v5 0/8] Add support for Exynos SROM Controller driver
THIS IS A RESEND OF ONCE MERGED INTO kgene/for-next AND LOST PATCHES Series v5 got merged in kgene/for-next but due to last moment change before pull these patches were not accepted during 4.3 merge window.After that kgene/for-next got rebased over 4.4-rc1 these patches got dropped into another branch and till date not included to for-next. Since then due to minor change in "drivers/soc/", patches are not getting applied cleanly so rebasing on current for-next and resending all these with fix in memory mapping included. This patch set adds support for Exynos SROM controller DT based driver. Currently SROM register sets are used only during S2R, so driver basically added for taking care of S2R. It will help us in removing static mapping from exynos.c and other extra code handline during S2R. This patch set also updated exynos4 and exynos5 dtsi files for with device node for srom, and added binding documentation for the same. First two patches are some minor cleanup in mach-exynos. Patchset v1 was posted here[1] [1]: https://lkml.org/lkml/2015/4/29/98 Patchset v2 was posted here[2] [2]: https://lkml.org/lkml/2015/8/24/125 Patchset v3 was posted here[3] [3]: https://lkml.org/lkml/2015/10/13/392 Patchset v3 was posted here[4] [4]: https://lkml.org/lkml/2015/10/19/278 This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for boot and S2R functionality. Changes since v5: - Rebased and resolved conflicts on lastest for-next. - Included fix in memory mapping size in exynos4/exynos5 dtsi files. Change since v4: - Removed unnedded NULL assignments from exynos_srom_remove function. - Added PM depency for selecting CONFIG_EXYNOS_SROM. Changes since v3: - Rebased to lastet kgene tree. - Added platform data support, instead of using global variables for srom base - Addressed review comments from LABBE Corentin Changes since v2: - Rebased to latest kgene tree. - Addressed review comments from Krzysztof Kozlowski. - Add new patch for MAINTAINER list update. - Reordered patch sequence for avoiding git bisect issues. Changes since v1: - Rebased to latest kgene tree. - Addressed review comments from Krzysztof Kozlowski. - Add two new patches for minor cleanup in exynos.c and map.h Pankaj Dubey (8): ARM: EXYNOS: remove unused static mapping of CMU for exynos5 ARM: EXYNOS: code cleanup in map.h dt-bindings: add exynos-srom device tree binding ARM: dts: add SROM device node for exynos4 ARM: dts: add SROM device node for exynos5 drivers: soc: add support for exynos SROM driver MAINTAINERS: add maintainers entry for drivers/soc/samsung ARM: EXYNOS: Remove SROM related register settings from mach-exynos .../bindings/arm/samsung/exynos-srom.txt | 12 ++ MAINTAINERS| 1 + arch/arm/boot/dts/exynos4.dtsi | 5 + arch/arm/boot/dts/exynos5.dtsi | 5 + arch/arm/mach-exynos/Kconfig | 2 + arch/arm/mach-exynos/exynos.c | 22 --- arch/arm/mach-exynos/include/mach/map.h| 8 - arch/arm/mach-exynos/regs-srom.h | 53 --- arch/arm/mach-exynos/suspend.c | 20 +-- arch/arm/plat-samsung/include/plat/map-s5p.h | 1 - drivers/soc/Kconfig| 1 + drivers/soc/Makefile | 1 + drivers/soc/samsung/Kconfig| 13 ++ drivers/soc/samsung/Makefile | 1 + drivers/soc/samsung/exynos-srom.c | 175 + drivers/soc/samsung/exynos-srom.h | 51 ++ 16 files changed, 269 insertions(+), 102 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt delete mode 100644 arch/arm/mach-exynos/regs-srom.h create mode 100644 drivers/soc/samsung/Kconfig create mode 100644 drivers/soc/samsung/Makefile create mode 100644 drivers/soc/samsung/exynos-srom.c create mode 100644 drivers/soc/samsung/exynos-srom.h -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
Hi Kukjin On Friday 23 October 2015 11:48 PM, Kukjin Kim wrote: > On 10/23/15 18:49, Pavel Fedin wrote: >> Hello! >> This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for boot and S2R functionality. >>> >>> Entire patchset tested on Trats2 (Exynos4412) board. Unless Kukjin picks >>> it also, I plan to take it for v4.5. >> >> Tested on SMDK5410. By the way, what is current status? If this is final >> revision, can i post my Ethernet support patchset on top >> of it? >> >> Tested-by: Pavel Fedin >> > Applied, this whole series. > I just pulled your tree, and I can't find these SROM patches in for-next (earlier they were present). Also I can see samsung for-next is pointing to linus/master branch. As this series not landed in linus tree due last moment changes, So do I need to rebase SROM patches on top of latest for-next, and send it once again? Thanks, Pankaj Dubey > Thanks, > Kukjin > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
Hello! > You may need to fetch again? > Anyway the branch is v4.4-next/driver-samsung or tags/samsung-driver... > Or just for-next should be fine I think. Thank you very much, already found it, and even posted my series, you should have already seen it. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
On 10/26/15 15:45, Pavel Fedin wrote: > Hello! > Hi, >> Applied, this whole series. > > Where can i find the recent code to base my series on? I looked at > linux-samsung.git but was unable to find it there. > You may need to fetch again? Anyway the branch is v4.4-next/driver-samsung or tags/samsung-driver... Or just for-next should be fine I think. See below: https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/log/?h=v4.4-next/driver-samsung Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
Hello! > Applied, this whole series. Where can i find the recent code to base my series on? I looked at linux-samsung.git but was unable to find it there. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
On 10/23/15 18:49, Pavel Fedin wrote: > Hello! > >>> This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for >>> boot >>> and S2R functionality. >>> >> >> Entire patchset tested on Trats2 (Exynos4412) board. Unless Kukjin picks >> it also, I plan to take it for v4.5. > > Tested on SMDK5410. By the way, what is current status? If this is final > revision, can i post my Ethernet support patchset on top > of it? > > Tested-by: Pavel Fedin > Applied, this whole series. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
Hello! > > This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for > > boot > > and S2R functionality. > > > > Entire patchset tested on Trats2 (Exynos4412) board. Unless Kukjin picks > it also, I plan to take it for v4.5. Tested on SMDK5410. By the way, what is current status? If this is final revision, can i post my Ethernet support patchset on top of it? Tested-by: Pavel Fedin Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/8] Add support for Exynos SROM Controller driver
On 20.10.2015 18:15, Pankaj Dubey wrote: > This patch set adds support for Exynos SROM controller DT based driver. > Currently SROM register sets are used only during S2R, so driver > basically added for taking care of S2R. It will help us in removing > static mapping from exynos.c and other extra code handline during S2R. > > This patch set also updated exynos4 and exynos5 dtsi files for with device > node for srom, and added binding documentation for the same. > > First two patches are some minor cleanup in mach-exynos. > > Patchset v1 was posted here[1] > [1]: https://lkml.org/lkml/2015/4/29/98 > Patchset v2 was posted here[2] > [2]: https://lkml.org/lkml/2015/8/24/125 > Patchset v3 was posted here[3] > [3]: https://lkml.org/lkml/2015/10/13/392 > Patchset v3 was posted here[4] > [4]: https://lkml.org/lkml/2015/10/19/278 > > This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for > boot > and S2R functionality. > Entire patchset tested on Trats2 (Exynos4412) board. Unless Kukjin picks it also, I plan to take it for v4.5. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v5 0/8] Add support for Exynos SROM Controller driver
This patch set adds support for Exynos SROM controller DT based driver. Currently SROM register sets are used only during S2R, so driver basically added for taking care of S2R. It will help us in removing static mapping from exynos.c and other extra code handline during S2R. This patch set also updated exynos4 and exynos5 dtsi files for with device node for srom, and added binding documentation for the same. First two patches are some minor cleanup in mach-exynos. Patchset v1 was posted here[1] [1]: https://lkml.org/lkml/2015/4/29/98 Patchset v2 was posted here[2] [2]: https://lkml.org/lkml/2015/8/24/125 Patchset v3 was posted here[3] [3]: https://lkml.org/lkml/2015/10/13/392 Patchset v3 was posted here[4] [4]: https://lkml.org/lkml/2015/10/19/278 This patchset, I have tested on Peach-Pi (Exynos5880) based chromebook for boot and S2R functionality. Change since v4: - Removed unnedded NULL assignments from exynos_srom_remove function. - Added PM depency for selecting CONFIG_EXYNOS_SROM. Changes since v3: - Rebased to lastet kgene tree. - Added platform data support, instead of using global variables for srom base - Addressed review comments from LABBE Corentin Changes since v2: - Rebased to latest kgene tree. - Addressed review comments from Krzysztof Kozlowski. - Add new patch for MAINTAINER list update. - Reordered patch sequence for avoiding git bisect issues. Changes since v1: - Rebased to latest kgene tree. - Addressed review comments from Krzysztof Kozlowski. - Add two new patches for minor cleanup in exynos.c and map.h Pankaj Dubey (8): ARM: EXYNOS: remove unused static mapping of CMU for exynos5 ARM: EXYNOS: code cleanup in map.h Documentation: dt-bindings: add exynos-srom binding information ARM: dts: add SROM device node for exynos4 ARM: dts: add SROM device node for exynos5 drivers: soc: add support for exynos SROM driver MAINTAINERS: add maintainers entry for drivers/soc/samsung ARM: EXYNOS: Remove SROM related register settings from mach-exynos .../bindings/arm/samsung/exynos-srom.txt | 12 ++ MAINTAINERS| 1 + arch/arm/boot/dts/exynos4.dtsi | 5 + arch/arm/boot/dts/exynos5.dtsi | 5 + arch/arm/mach-exynos/Kconfig | 2 + arch/arm/mach-exynos/exynos.c | 22 --- arch/arm/mach-exynos/include/mach/map.h| 8 - arch/arm/mach-exynos/regs-srom.h | 53 --- arch/arm/mach-exynos/suspend.c | 20 +-- arch/arm/plat-samsung/include/plat/map-s5p.h | 1 - drivers/soc/Kconfig| 1 + drivers/soc/Makefile | 1 + drivers/soc/samsung/Kconfig| 13 ++ drivers/soc/samsung/Makefile | 1 + drivers/soc/samsung/exynos-srom.c | 175 + drivers/soc/samsung/exynos-srom.h | 51 ++ 16 files changed, 269 insertions(+), 102 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt delete mode 100644 arch/arm/mach-exynos/regs-srom.h create mode 100644 drivers/soc/samsung/Kconfig create mode 100644 drivers/soc/samsung/Makefile create mode 100644 drivers/soc/samsung/exynos-srom.c create mode 100644 drivers/soc/samsung/exynos-srom.h -- 2.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html