Re: [PATCH v7] ARM: dts: Prepare node labels for exynos5250
Kukjin,
On Fri, Aug 22, 2014 at 3:49 AM, Kukjin Kim wrote:
> Andreas Färber wrote:
>>
>> Allows them to be extended by reference.
>>
>> Reviewed-by: Doug Anderson
>> Signed-off-by: Andreas Färber
>> ---
>> v6 -> v7:
>> * Dropped uart* labels (Tomasz Figa)
>>
>> v6: Split off from Snow/SMDK cleanups (Doug Anderson)
>>
>> arch/arm/boot/dts/exynos5250.dtsi | 16
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 492e1eff37bd..42eafd19cfb2 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -218,7 +218,7 @@
>> clock-names = "fimg2d";
>> };
>>
>> - codec@1100 {
>> + mfc: codec@1100 {
>> compatible = "samsung,mfc-v6";
>> reg = <0x1100 0x1>;
>> interrupts = <0 96 0>;
>> @@ -227,7 +227,7 @@
>> clock-names = "mfc";
>> };
>>
>> - rtc@101E {
>> + rtc: rtc@101E {
>> clocks = <&clock CLK_RTC>;
>> clock-names = "rtc";
>> status = "disabled";
>> @@ -261,7 +261,7 @@
>> clock-names = "uart", "clk_uart_baud0";
>> };
>>
>> - sata@122F {
>> + sata: sata@122F {
>> compatible = "snps,dwc-ahci";
>> samsung,sata-freq = <66>;
>> reg = <0x122F 0x1ff>;
>> @@ -573,7 +573,7 @@
>> #phy-cells = <1>;
>> };
>>
>> - usb@1211 {
>> + ehci: usb@1211 {
>
> I'm not sure which one is recommended between above and "ehci: ehci@1211
> {"
My understanding is that more generic names should be used for node
names. AKA: "usb" and not "ehci". "mmc" and not "dwmmc".
In another thread I was pointed at ePAPR
:
The name of a node should be somewhat generic, reflecting the function
of the device and not its precise programming model.
>> - hdmi {
>> + hdmi: hdmi {
>
> Should be
>
> + hdmi: hdmi@1453 { ?
Seems like that should be a followon patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7] ARM: dts: Prepare node labels for exynos5250
Am 22.08.2014 12:49, schrieb Kukjin Kim:
> Andreas Färber wrote:
>>
>> Allows them to be extended by reference.
>>
>> Reviewed-by: Doug Anderson
>> Signed-off-by: Andreas Färber
>> ---
>> v6 -> v7:
>> * Dropped uart* labels (Tomasz Figa)
>>
>> v6: Split off from Snow/SMDK cleanups (Doug Anderson)
>>
>> arch/arm/boot/dts/exynos5250.dtsi | 16
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>> b/arch/arm/boot/dts/exynos5250.dtsi
>> index 492e1eff37bd..42eafd19cfb2 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -218,7 +218,7 @@
>> clock-names = "fimg2d";
>> };
>>
>> -codec@1100 {
>> +mfc: codec@1100 {
>> compatible = "samsung,mfc-v6";
>> reg = <0x1100 0x1>;
>> interrupts = <0 96 0>;
>> @@ -227,7 +227,7 @@
>> clock-names = "mfc";
>> };
>>
>> -rtc@101E {
>> +rtc: rtc@101E {
>> clocks = <&clock CLK_RTC>;
>> clock-names = "rtc";
>> status = "disabled";
>> @@ -261,7 +261,7 @@
>> clock-names = "uart", "clk_uart_baud0";
>> };
>>
>> -sata@122F {
>> +sata: sata@122F {
>> compatible = "snps,dwc-ahci";
>> samsung,sata-freq = <66>;
>> reg = <0x122F 0x1ff>;
>> @@ -573,7 +573,7 @@
>> #phy-cells = <1>;
>> };
>>
>> -usb@1211 {
>> +ehci: usb@1211 {
>
> I'm not sure which one is recommended between above and "ehci: ehci@1211
> {"
>
>> compatible = "samsung,exynos4210-ehci";
>> reg = <0x1211 0x100>;
>> interrupts = <0 71 0>;
>> @@ -588,7 +588,7 @@
>> };
>> };
>>
>> -usb@1212 {
>> +ohci: usb@1212 {
>
> Same as above...
A quick git-grep in v3.16.1 shows both ways used in arch/arm/boot/dts/:
usb@: 232
xhci@: 0
ehci@: 41
ohci@: 60
uhci@: 7
>> compatible = "samsung,exynos4210-ohci";
>> reg = <0x1212 0x100>;
>> interrupts = <0 71 0>;
>> @@ -725,7 +725,7 @@
>> clock-names = "gscl";
>> };
>>
>> -hdmi {
>> +hdmi: hdmi {
>
> Should be
>
> + hdmi: hdmi@1453 { ?
Actually, without applying this patch and my follow-up cleanups strictly
using these new labels, we can't rename any of the nodes here, since it
would break the derived .dts files. It was specifically requested in v5
to make this patch here separate from subsequent uses of the new labels
for the benefit of cherry-picking.
So since you don't seem to disagree with the label names that I add
here, I consider renaming nodes outside the scope of this patch.
+1 for reflecting the reg address in the unit address of the hdmi node
as a follow-up to the refactorings, if that does not break any driver
assumptions.
Regards,
Andreas
>> compatible = "samsung,exynos4212-hdmi";
>> reg = <0x1453 0x7>;
>> interrupts = <0 95 0>;
>> @@ -751,14 +751,14 @@
>> #phy-cells = <0>;
>> };
>>
>> -dp-controller@145B {
>> +dp: dp-controller@145B {
>> clocks = <&clock CLK_DP>;
>> clock-names = "dp";
>> phys = <&dp_phy>;
>> phy-names = "dp";
>> };
>>
>> -fimd@1440 {
>> +fimd: fimd@1440 {
>> clocks = <&clock CLK_SCLK_FIMD1>, <&clock CLK_FIMD1>;
>> clock-names = "sclk_fimd", "fimd";
>> };
>> --
>> 2.0.4
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7] ARM: dts: Prepare node labels for exynos5250
Andreas Färber wrote:
>
> Allows them to be extended by reference.
>
> Reviewed-by: Doug Anderson
> Signed-off-by: Andreas Färber
> ---
> v6 -> v7:
> * Dropped uart* labels (Tomasz Figa)
>
> v6: Split off from Snow/SMDK cleanups (Doug Anderson)
>
> arch/arm/boot/dts/exynos5250.dtsi | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 492e1eff37bd..42eafd19cfb2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -218,7 +218,7 @@
> clock-names = "fimg2d";
> };
>
> - codec@1100 {
> + mfc: codec@1100 {
> compatible = "samsung,mfc-v6";
> reg = <0x1100 0x1>;
> interrupts = <0 96 0>;
> @@ -227,7 +227,7 @@
> clock-names = "mfc";
> };
>
> - rtc@101E {
> + rtc: rtc@101E {
> clocks = <&clock CLK_RTC>;
> clock-names = "rtc";
> status = "disabled";
> @@ -261,7 +261,7 @@
> clock-names = "uart", "clk_uart_baud0";
> };
>
> - sata@122F {
> + sata: sata@122F {
> compatible = "snps,dwc-ahci";
> samsung,sata-freq = <66>;
> reg = <0x122F 0x1ff>;
> @@ -573,7 +573,7 @@
> #phy-cells = <1>;
> };
>
> - usb@1211 {
> + ehci: usb@1211 {
I'm not sure which one is recommended between above and "ehci: ehci@1211 {"
> compatible = "samsung,exynos4210-ehci";
> reg = <0x1211 0x100>;
> interrupts = <0 71 0>;
> @@ -588,7 +588,7 @@
> };
> };
>
> - usb@1212 {
> + ohci: usb@1212 {
Same as above...
> compatible = "samsung,exynos4210-ohci";
> reg = <0x1212 0x100>;
> interrupts = <0 71 0>;
> @@ -725,7 +725,7 @@
> clock-names = "gscl";
> };
>
> - hdmi {
> + hdmi: hdmi {
Should be
+ hdmi: hdmi@1453 { ?
> compatible = "samsung,exynos4212-hdmi";
> reg = <0x1453 0x7>;
> interrupts = <0 95 0>;
> @@ -751,14 +751,14 @@
> #phy-cells = <0>;
> };
>
> - dp-controller@145B {
> + dp: dp-controller@145B {
> clocks = <&clock CLK_DP>;
> clock-names = "dp";
> phys = <&dp_phy>;
> phy-names = "dp";
> };
>
> - fimd@1440 {
> + fimd: fimd@1440 {
> clocks = <&clock CLK_SCLK_FIMD1>, <&clock CLK_FIMD1>;
> clock-names = "sclk_fimd", "fimd";
> };
> --
> 2.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v7] ARM: dts: Prepare node labels for exynos5250
Allows them to be extended by reference.
Reviewed-by: Doug Anderson
Signed-off-by: Andreas Färber
---
v6 -> v7:
* Dropped uart* labels (Tomasz Figa)
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
arch/arm/boot/dts/exynos5250.dtsi | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5250.dtsi
b/arch/arm/boot/dts/exynos5250.dtsi
index 492e1eff37bd..42eafd19cfb2 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -218,7 +218,7 @@
clock-names = "fimg2d";
};
- codec@1100 {
+ mfc: codec@1100 {
compatible = "samsung,mfc-v6";
reg = <0x1100 0x1>;
interrupts = <0 96 0>;
@@ -227,7 +227,7 @@
clock-names = "mfc";
};
- rtc@101E {
+ rtc: rtc@101E {
clocks = <&clock CLK_RTC>;
clock-names = "rtc";
status = "disabled";
@@ -261,7 +261,7 @@
clock-names = "uart", "clk_uart_baud0";
};
- sata@122F {
+ sata: sata@122F {
compatible = "snps,dwc-ahci";
samsung,sata-freq = <66>;
reg = <0x122F 0x1ff>;
@@ -573,7 +573,7 @@
#phy-cells = <1>;
};
- usb@1211 {
+ ehci: usb@1211 {
compatible = "samsung,exynos4210-ehci";
reg = <0x1211 0x100>;
interrupts = <0 71 0>;
@@ -588,7 +588,7 @@
};
};
- usb@1212 {
+ ohci: usb@1212 {
compatible = "samsung,exynos4210-ohci";
reg = <0x1212 0x100>;
interrupts = <0 71 0>;
@@ -725,7 +725,7 @@
clock-names = "gscl";
};
- hdmi {
+ hdmi: hdmi {
compatible = "samsung,exynos4212-hdmi";
reg = <0x1453 0x7>;
interrupts = <0 95 0>;
@@ -751,14 +751,14 @@
#phy-cells = <0>;
};
- dp-controller@145B {
+ dp: dp-controller@145B {
clocks = <&clock CLK_DP>;
clock-names = "dp";
phys = <&dp_phy>;
phy-names = "dp";
};
- fimd@1440 {
+ fimd: fimd@1440 {
clocks = <&clock CLK_SCLK_FIMD1>, <&clock CLK_FIMD1>;
clock-names = "sclk_fimd", "fimd";
};
--
2.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
